From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id E045774003D for ; Mon, 18 Dec 2023 09:08:17 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=AQjuu8pmcDHzrDosppy0Cz8ogc61aq2zA7YLnKwoR4w=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1702890496; v=1; b=keA/N7tC1ZoR1V9hjNUwYtJAyCS+oPlqvRUB0vwpmI4b1fBoDmlNXHFD2IrHBeW4UT5MU19E Cge94ymooG+SOFmb+43YQTs0hk/Ko/pZkJj5dzy/3hxGqLvh7DpEyzkV/UlOoEM4qS7BLmnLKuf xJNUSthYlREyGqhWHruzZ43g= X-Received: by 127.0.0.2 with SMTP id vknVYY7687511xUMRDb0VNjF; Mon, 18 Dec 2023 01:08:16 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.88]) by mx.groups.io with SMTP id smtpd.web11.40518.1702890495574501642 for ; Mon, 18 Dec 2023 01:08:15 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10927"; a="426611594" X-IronPort-AV: E=Sophos;i="6.04,285,1695711600"; d="scan'208";a="426611594" X-Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Dec 2023 01:08:14 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10927"; a="768777999" X-IronPort-AV: E=Sophos;i="6.04,285,1695711600"; d="scan'208";a="768777999" X-Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga007.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 18 Dec 2023 01:08:14 -0800 X-Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Mon, 18 Dec 2023 01:08:13 -0800 X-Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Mon, 18 Dec 2023 01:08:13 -0800 X-Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.168) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Mon, 18 Dec 2023 01:08:13 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CSJIVGFmx9uwb12slzutzUPbTfwjg7HQiePqSc3orJ79/f/kn/y3kIEFNQe8rhN25rVjKqmIwE8ovNBZXbCYQbAo05wT2/AG16rUWDwwofoJkcVzUIG9qxpayBgEdEfchpy8B/p+wditvQesqILbg2YF76cWLDTVnHcKg6uwLc/HQT3pRSOOBlaFsDhSxUvDAKwjscn7mRnU0R6Aaa2t5tS/ljCavFLdWMfJ09ybVUN27kIokFpOVAmOBdJHoqbG9+eVVJ46cAsc0KjyqdD8XJbl8O77BSI6RMoMfCU8WERq8Wf8lbGHmniG3DwoUruyyJVOYw2OGlT6dRJBCDCQZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=l0SGhC+TmnOSGScQrwZjiPFieXBxfuNL/q4eTV0cYi0=; b=dTDjfwIwDinaebdNVqLuHxZw4ZCg2sU6ltWzFX1vipp5Sxp6oKPY5A91F9+FwAmd+8+fYYhcZ/lzyY/yCum1hv1GmC8rTCz5BomZSrojY9vKpDpMfk8y9Zt0ulAs8F0ZX+Dc6h55n27+faMAaQMzu3Oz7ouBeEayEwCQOEAFbbzmc6+z+zxHfqjGhhpysGobPhtVomJMyPtlyrs0g6M8diqANSnumzgBT63/uxkg94sc8sPdljNfoUItuiichoQ4IQwfA/+Ai8r1xrYUtHmGcHGmVjogS4TZTKDGICcsgY7hDsnRDRTndzhjjDY/c/N5Il1sVMuFOQC1lhJRCI7Usw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from BYAPR11MB2712.namprd11.prod.outlook.com (2603:10b6:a02:bf::13) by SN7PR11MB7993.namprd11.prod.outlook.com (2603:10b6:806:2e5::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7091.37; Mon, 18 Dec 2023 09:08:06 +0000 X-Received: from BYAPR11MB2712.namprd11.prod.outlook.com ([fe80::a0b4:833f:7b54:adf1]) by BYAPR11MB2712.namprd11.prod.outlook.com ([fe80::a0b4:833f:7b54:adf1%7]) with mapi id 15.20.7091.034; Mon, 18 Dec 2023 09:08:06 +0000 From: "Xu, Wei6" To: "Ni, Ray" , "devel@edk2.groups.io" CC: Laszlo Ersek , Ard Biesheuvel , Sami Mujawar Subject: Re: [edk2-devel] [PATCH v4 0/4] StandaloneMmCore finds drivers in uncompressed inner fv. Thread-Topic: [edk2-devel] [PATCH v4 0/4] StandaloneMmCore finds drivers in uncompressed inner fv. Thread-Index: AQHaEIbAQ+ydnPBFckqS3kgqJ1W9b7Cugv9AgAA6TyCAAESlQA== Date: Mon, 18 Dec 2023 09:08:05 +0000 Message-ID: References: <1794F968339CC3DE.12603@groups.io> In-Reply-To: Accept-Language: en-US, en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR11MB2712:EE_|SN7PR11MB7993:EE_ x-ms-office365-filtering-correlation-id: a66eefb4-d43f-4abd-d2cc-08dbffa8d8d5 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: 3nspSTszHz0U//hJUoKWY14F2NYEfEvinpxXl+Zrje2yCm6gkrUExkvGKM2myUWPN2cmZCA0pgNX2fuqS+EoJRG+jkd+atjvqUxhX1ogunqH1RcHCrUXmYjI3nHvJ19qwQcK9qV6xrv+KQvnTsJ/l6Vy1zBt1/4wIi4ngOQrhK0jG5AuXXJSMHRDpE3r485KzsbBKd2M5mwF8zVsCaknMwbbe1nhAwJbqLgo/fDdIM1+uPvbrt/io8KYi5M1iw0kr3I2bL4fem+EL/AVuCZJbevXNZDNAmQBBOZyooa1xJ/Aba4A1UpWCa6AbTBvSlJc5MBAzkIQNkf10n/P9iNcprCnlgfgpTka1KE/Jxp5ASQLccNwnwxOVaDI5WL2T8DLlJCG/AHe4DF+TjHJWuOOUwfl5Bcm5/ox4ccaBEtOQA5jnjxVf9cxfXCf8B42oTacvuvvb1FXzZpC3t5EJrtNyhx8GxUpiuTcQ/3Ul+BiRNNowqLvdp14z7DSjV9VbF7PvCmKSx/6aw2OHr5YNpfLKQB2xYkKvk0CJ7hmtOaSZIGwiLnwe8RtdTqaFf6pdRulzluIobiqIGU3/Nn0eM/syjFXdB9PNrjlaI1gVWwwKlQ2fzjzfd/+jt5eES2veVOjVUHOnKklhulnG50riuEiaQ== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Q35PDiiHhQDmvvkFGhY3807nI0mAHITEcS8XoHZXRmokNiZKM/CtNf3Zvpxa?= =?us-ascii?Q?yurPLin33Z/vqGhgKEzthDxr/Mwq144dtcoGj0Dpi3E1vaTA6v5RP4FAubQx?= =?us-ascii?Q?ybVUozPhxKxlCsLKZrU94Wj/Fk0iSB9YjcLgqvyKrtJCen0YUFUaq4h5ZbkK?= =?us-ascii?Q?ZDCtQDbCulk4SuiW044PP7jzPRbiBNBbOtIRuNzBehfD6xfBVzQVI6yUFCl0?= =?us-ascii?Q?ADMGtwF5UoHX+kjFRFDF/RGffYwWbeyr4liV+/6rxIl8X02PHmAAaIj67NWg?= =?us-ascii?Q?HnSuoaADSvL46AHgfz9RwXW9AcnDtsvLaGGNdm1s7uMsu4HEQpT0CizcLc5L?= =?us-ascii?Q?nX4+QPyA0CvjoXjjSqU2xSWuxjTP3lDAANngZHHxDRF3p4dHlLf8GSLnC2vO?= =?us-ascii?Q?HsSDfGGwZ/46d1lO6AVpUIkawmS+3uCYden6H1mqoFZdQpzadNzgrgfdt+5l?= =?us-ascii?Q?D02+ZoZXQxy+zasz+VI3yvTmErwF5fWOotZuaDXp3B6DLaIQGvrrSKqI6gho?= =?us-ascii?Q?bRFe+ZK80/7Mr4vu4ZYaOjY+6zv2KzDgq1nT1n5IiU22vyQJjonQSUXh4+dS?= =?us-ascii?Q?olDZ0hS4o94bhC1A/nVJKEYRJJi1MtYJKBdi02SdM9DYBzNJiJnXwied0eZD?= =?us-ascii?Q?/i44V0PAcW6Tle43a4AdGJe8FzZhprNmyS08yZ6BwIu+OodnGRVfotsovyuw?= =?us-ascii?Q?u5NdNETiu3qqGbZD88D+gUqQsuOy+RkS2DRrr9b9AqV0Ku/SWC2z3Nx/0Rtf?= =?us-ascii?Q?QcK5arq70rSZTDnHYU3Iph5lQO/aAXIdqghwxm2Ch6FlYuIj+UyspjNpYCsf?= =?us-ascii?Q?oo6e+K/lkx1AgFvFWLcduRLQUUacGH6kFw5L9Xks6O5PrtOw2JgIoRW3tCEI?= =?us-ascii?Q?7YzZaLmI/VuWDP6tW7hlBd9yPlhRpAlQ7r1jRzFJWs7767ETXkinuKWyj6pH?= =?us-ascii?Q?Hqs/xizIZc1ADsMu3VvUL1IOJZWJEmA26I+u4RkWqP1gUpzu6tEBji3iE8JO?= =?us-ascii?Q?KUk4NLnq39qo7UmfuYkPtMMKfRD7K6axDLTyg5ujE3h5/cjFQpubp4yaidsP?= =?us-ascii?Q?T+JjheUAmqbl+1C0gp4gjnHRRs+Pt7u4R8nfGBdKyyPd+ARp1SMJaXdGCGiu?= =?us-ascii?Q?fZePGplX+leE8DKF4YPS1yYAPtGUFyASu1zm3fmQxhsLN4D4QcrT2zhsj0PJ?= =?us-ascii?Q?67u5Ad4xhlXMnXesDiHFCK7A7k6+fz+v0oi84BwirxOEMGBMKWxG/Hr5PQQe?= =?us-ascii?Q?V/hzBECc1wVjBilLxjomXwuZzml+xywQ9wH1FUxQRuaHD/XAAsgeaauiDqup?= =?us-ascii?Q?oEm0MVe/IF0ip1qD5CpflSsVAtsmnduECE92nSZbJtlZ6QRvnCmdQYEYXTdF?= =?us-ascii?Q?B9Bbgu4s/9NLyPbMtAU8G3iVQB19pVT3z8bDE8rSlBtM6fDmAbYigc8Glja7?= =?us-ascii?Q?92/U9xMgXtl6jjakI+/VFr+sQ22/Ay3FX6MMqhDMEAOkJIR+dgfDoCLbEQVc?= =?us-ascii?Q?UpU/KEGSRPpKJa9csIWtaty8vyx0JKH++pkdrvRm52/595sJWX3QjZV3rKXX?= =?us-ascii?Q?U8QmcW00GDj/xsfpcc4=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB2712.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a66eefb4-d43f-4abd-d2cc-08dbffa8d8d5 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Dec 2023 09:08:06.0031 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: tu1S2dK7d5dj3pVAqc2Y5MQsEP/d9VbvOpGk1sKqj1YCrzHMcS5uGf4gi0efYiS/6Gp+mvx3KJZVdcypYstVCg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB7993 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,wei6.xu@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 2uQyomein71skCTb0A3n0tEIx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b="keA/N7tC"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") Thanks Ray, The PR is updated with "Reviewed-by" added.=20 https://github.com/tianocore/edk2/pull/5004 BR, Wei -----Original Message----- From: Ni, Ray =20 Sent: Monday, December 18, 2023 1:02 PM To: Xu, Wei6 ; devel@edk2.groups.io Cc: Laszlo Ersek ; Ard Biesheuvel ; Sami Mujawar Subject: RE: [edk2-devel] [PATCH v4 0/4] StandaloneMmCore finds drivers in = uncompressed inner fv. Reviewed-by: Ray Ni Can you kindly update the PR to add the Reviewed-by? I can help to set "pus= h" label after that. Thanks, Ray > -----Original Message----- > From: Xu, Wei6 > Sent: Monday, December 18, 2023 9:37 AM > To: devel@edk2.groups.io; Xu, Wei6 > Cc: Laszlo Ersek ; Ard Biesheuvel=20 > ; Sami Mujawar ; Ni,=20 > Ray > Subject: RE: [edk2-devel] [PATCH v4 0/4] StandaloneMmCore finds=20 > drivers in uncompressed inner fv. >=20 > This patch series already got "reviewed-by" from Laszlo. Could anyone=20 > help to merge the changes? Thanks a lot. >=20 > Thanks Laszlo for reviewing the patches. >=20 > BR, > Wei >=20 > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Xu,=20 > Wei6 > Sent: Monday, November 6, 2023 3:53 PM > To: devel@edk2.groups.io > Cc: Xu, Wei6 ; Laszlo Ersek ;=20 > Ard Biesheuvel ; Sami Mujawar=20 > ; Ni, Ray > Subject: [edk2-devel] [PATCH v4 0/4] StandaloneMmCore finds drivers in=20 > uncompressed inner fv. >=20 > V1: > This patch is to fix the issue that StandaloneMmCore fails to detect=20 > uncompressed inner FV. > PR: https://github.com/tianocore/edk2/pull/4943 >=20 > V2: > Based on V1, fix some other issues > 1. Add Missing object size checks before casting pointers to header types > a. InnerFvHeader =3D (EFI_FIRMWARE_VOLUME_HEADER *)SectionData; > This is introduced in V1, add the size check on SectionDataSize=20 > against EFI_FIRMWARE_VOLUME_HEADER > b. Section =3D (EFI_COMMON_SECTION_HEADER *)(FileHeader + 1); > Use FfsFindSection instead of FfsFindSectionData to avoid pointer=20 > casting. > 2. Fix potential memory leak issue that ScratchBuffer is not freed=20 > when page allocation for DstBuffer fails. > PR: https://github.com/tianocore/edk2/pull/4965 >=20 > V3: > 1. Separate patch per individual issue fix on patch V2. > 2. Fix one more issue: Limit FwVol encapsulation section recursion in=20 > MmCoreFfsFindMmDriver(). > PR: https://github.com/tianocore/edk2/pull/4975 >=20 > V4: > Patch (1/4): Move the declaration of MmCoreFfsFindMmDriver() from=20 > source file to the header file "StandaloneMmCore.h" > Patch (2/4): Handle the case that ExtractGuidedSectionDecode()'s=20 > decoded buffer is identical to the data in InputSection Patch (3/4):=20 > Fix the issue 'Section > + 1' migth be a wrong address for InnerFvHeader if Section is > EFI_COMMON_SECTION_HEADER2. > Patch (4/4): 'Continue' if an EFI_SECTION_FIRMWARE_VOLUME_IMAGE is=20 > found, do not look for an EFI_SECTION_GUID_DEFINED again. > PR: https://github.com/tianocore/edk2/pull/5004 >=20 > For the recursion logic improvement, Let's do it in other patch set in=20 > future after this patch is committed. >=20 > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Cc: Sami Mujawar > Cc: Ray Ni >=20 > Wei6 Xu (4): > StandaloneMmPkg/Core: Limit FwVol encapsulation section recursion > StandaloneMmPkg/Core: Fix potential memory leak issue > StandaloneMmPkg/Core: Fix issue that offset calculation might be wrong > StandaloneMmPkg/Core: Fix the failure to find uncompressed inner FV >=20 > StandaloneMmPkg/Core/Dispatcher.c | 5 -- > StandaloneMmPkg/Core/FwVol.c | 88 > +++++++++++++++++------ > StandaloneMmPkg/Core/StandaloneMmCore.c | 7 +- > StandaloneMmPkg/Core/StandaloneMmCore.h | 26 +++++++ > StandaloneMmPkg/Core/StandaloneMmCore.inf | 3 + > StandaloneMmPkg/StandaloneMmPkg.dec | 5 ++ > 6 files changed, 103 insertions(+), 31 deletions(-) >=20 > -- > 2.29.2.windows.2 >=20 >=20 >=20 >=20 >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112637): https://edk2.groups.io/g/devel/message/112637 Mute This Topic: https://groups.io/mt/103235459/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-