Submit a new BZ https://bugzilla.tianocore.org/show_bug.cgi?id=3268 for this change. Patch set V2 has been sent out for review. Thanks! Qi Zhang From: Bret Barkelew Sent: Thursday, March 18, 2021 4:45 AM To: devel@edk2.groups.io; lersek@redhat.com; Yao, Jiewen ; Zhang, Qi1 Cc: Wang, Jian J ; Kumar, Rahul1 Subject: RE: [EXTERNAL] Re: [edk2-devel] [PATCH] SecurityPkg/Tcg2Config: hide PCR Bank SHA1 checkbox +1 - Bret ________________________________ From: devel@edk2.groups.io > on behalf of Laszlo Ersek via groups.io > Sent: Wednesday, March 17, 2021 11:28:07 AM To: devel@edk2.groups.io >; Yao, Jiewen >; Zhang, Qi1 > Cc: Wang, Jian J >; Kumar, Rahul1 > Subject: [EXTERNAL] Re: [edk2-devel] [PATCH] SecurityPkg/Tcg2Config: hide PCR Bank SHA1 checkbox On 03/17/21 05:19, Yao, Jiewen wrote: > Thank you Qi. > > i recommend we file a bugzilla on the scope of the problem I agree. We already have a number of BZs related to the disablement of SHA1 and MD5: https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D1682&data=04%7C01%7Cbret.barkelew%40microsoft.com%7Ca9f46449e57d4642ab4608d8e9727545%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637516025103613890%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=Bxq4fGkZUA91NNncp%2F68zbcXSYBQcIfGbgcT4CYktKs%3D&reserved=0 https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D2943&data=04%7C01%7Cbret.barkelew%40microsoft.com%7Ca9f46449e57d4642ab4608d8e9727545%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637516025103613890%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=eh9ef1WSF1DuepEkiXg1x%2BmmWs77eNrkSObOS5SVB94%3D&reserved=0 https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D3003&data=04%7C01%7Cbret.barkelew%40microsoft.com%7Ca9f46449e57d4642ab4608d8e9727545%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637516025103613890%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=YJTXNb2GnPkkc9Y6GI%2BI9WYy8MdeujtSvpah5mWhrp0%3D&reserved=0 https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D3021&data=04%7C01%7Cbret.barkelew%40microsoft.com%7Ca9f46449e57d4642ab4608d8e9727545%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637516025103613890%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=pcAqk46YRGn9jS0ra5sl7Gg7i8PvqZbdewsH6hMq5YM%3D&reserved=0 https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D3027&data=04%7C01%7Cbret.barkelew%40microsoft.com%7Ca9f46449e57d4642ab4608d8e9727545%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637516025103613890%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=4sOMDQitxKwFfXmYFJ9ooF7hovK4vfMww0ppsHz5vjk%3D&reserved=0 https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D3079&data=04%7C01%7Cbret.barkelew%40microsoft.com%7Ca9f46449e57d4642ab4608d8e9727545%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637516025103613890%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=8is%2FUsgRy71E%2F9ui%2BkMwoTmp4jiw0vKlsUwJ%2BxEqfO0%3D&reserved=0 We should certainly track the change for Tcg2Config too, in a new BZ. Thanks Laszlo > > After the scope is agreed, then you can send the patch. > > For example, I can ask why not remove the sha1supported field at all? > > I hope the community can reach consensus on the problem statement at first. > > > thank you! > Yao, Jiewen > > >> 在 2021年3月17日，上午10:56，Zhang, Qi1 > 写道： >> >> wrap SHA1 related by DISABLE_SHA1_DEPRECATED_INTERFACES. >> >> Cc: Jiewen Yao > >> Cc: Jian J Wang > >> Cc: Qi Zhang > >> Cc: Rahul Kumar > >> Signed-off-by: Qi Zhang > >> --- >> SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigImpl.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigImpl.c b/SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigImpl.c >> index 2946f95db0..81a4d3fa6a 100644 >> --- a/SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigImpl.c >> +++ b/SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigImpl.c >> @@ -710,9 +710,11 @@ SetConfigInfo ( >> ) >> { >> switch (TpmAlgHash) { >> +#ifndef DISABLE_SHA1_DEPRECATED_INTERFACES >> case TPM_ALG_SHA1: >> Tcg2ConfigInfo->Sha1Supported = TRUE; >> break; >> +#endif >> case TPM_ALG_SHA256: >> Tcg2ConfigInfo->Sha256Supported = TRUE; >> break; >> -- >> 2.26.2.windows.1 >> > > > > >