From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web08.405.1635269588674029165 for ; Tue, 26 Oct 2021 10:33:09 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=Q0GxdNKC; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: maciej.czajkowski@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10149"; a="227425094" X-IronPort-AV: E=Sophos;i="5.87,184,1631602800"; d="scan'208";a="227425094" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Oct 2021 10:33:00 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,184,1631602800"; d="scan'208";a="578821436" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmsmga002.fm.intel.com with ESMTP; 26 Oct 2021 10:32:59 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 26 Oct 2021 10:32:58 -0700 Received: from orsmsx605.amr.corp.intel.com (10.22.229.18) by ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 26 Oct 2021 10:32:58 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Tue, 26 Oct 2021 10:32:58 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.168) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Tue, 26 Oct 2021 10:32:57 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PIU/8t6kmZhdTSMoQCGGolzcu6XT7tP2VQN3C00X5qbWE7aanynBFgh+eR6CqeeB8hu71zeeskEN7hHc+/J+3oupf3q8DsqfZix/04G7Ma1pIFKIjwMqXJuM9ducNlzudeSa/ZUhyQMrdTKbYOL/f4ruJAYXw8zsGm4FyByofwz5aTDGVrQUX04Q96isJ6cYVMiDlH81CPlVBZQcpvoJ1D0eoRfWR9PyH6UqNpd1Z7Gaqzq2M+i5a9GujgqDUS+B5J2yVfxMQwFmtoAWt5k4G3671m2ZuF5YN6tFFmoASKomIEYQgMzrHx+S0QzVIwlv0OXoY9jzDMBuzPB5fT28KQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HKJimYtEwe2Jb8UUbgpJWceNwv90VaelCMvf6TvQeM4=; b=cX3hjHmZpHR9Gb1O/a5l/uL7MeC4L6tpZerxqfnUIoWHkRqCwpMC0I5NVjyMox07PP5psOH5X6315WFTazQ31sGVMZq5wNxZDuuNHJnXpCPdqvi9/cg5BLR/7c2Y0vmmTdIdTwWJsBvTbBT1duHMTO3Vs838wpSSt48wMpk/JbHMTEoIdJ2AkJL0yOkeqkfqV7yeU16NAspBAX/yvWYKacO+ggrkdQIjhRe+HiVsctbD/sGbPy6loW6PqbMXQzfcN4lWuKMmTHqpbSOCoV3gSxW5DanuQNglco/MQ+9qoYSHOhBLg2KRvDUA5W60BCQCSKKTcS5U83zZLWqsSn0Cqw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HKJimYtEwe2Jb8UUbgpJWceNwv90VaelCMvf6TvQeM4=; b=Q0GxdNKCYxdTt/mRGpHLQXaUin5rh4o/CRDqAOi1ErBkp7IAwlXG/MBpYEz2RU9e2JTwqWytAZEqwFidmIdfcnyAMIM9xNPGJlNEHn0vYgOgOXnGFoLeH99xllbIFQTVahqdrYdocEe0OyApGemA5FWpCjRvyn8beHc0ejyAWaM= Received: from BYAPR11MB3047.namprd11.prod.outlook.com (2603:10b6:a03:8b::32) by BYAPR11MB3783.namprd11.prod.outlook.com (2603:10b6:a03:f5::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.14; Tue, 26 Oct 2021 17:32:56 +0000 Received: from BYAPR11MB3047.namprd11.prod.outlook.com ([fe80::6cf9:ebb2:dc7f:8b03]) by BYAPR11MB3047.namprd11.prod.outlook.com ([fe80::6cf9:ebb2:dc7f:8b03%5]) with mapi id 15.20.4628.020; Tue, 26 Oct 2021 17:32:56 +0000 From: "Maciej Czajkowski" To: "devel@edk2.groups.io" , "Czajkowski, Maciej" , "Chaganty, Rangasai V" , "Ni, Ray" Subject: Re: [edk2-devel] [edk2platforms][PATCH v2 1/1] IntelSiliconPkg: Add IntelDieInfoProtocol Thread-Topic: [edk2-devel] [edk2platforms][PATCH v2 1/1] IntelSiliconPkg: Add IntelDieInfoProtocol Thread-Index: AQHXxCghxnTaAPlUDEuFyETclMmYlqvllL7Q Date: Tue, 26 Oct 2021 17:32:56 +0000 Message-ID: References: <20211018135719.689-1-maciej.czajkowski@intel.com> <16AF249FA7D41B9C.11150@groups.io> In-Reply-To: <16AF249FA7D41B9C.11150@groups.io> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.200.16 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 532b7f89-f52f-414a-d5dd-08d998a6a5fd x-ms-traffictypediagnostic: BYAPR11MB3783: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: NxXB+Y58GFBC8g3wU4b6DTmTQdakGBQ+gN3913tvnhKpRFWyUT+Oyn4Uy27axBkilzbAWWMNs6C9K2afJUe8er83BmF7CHAKIbyRaEN7NBCY2T+qHLuHX2a6ZOER1J9x+LBv06a6UycjYPTfZ8Aj4H8IF3QjtzMiUAgtz3IhU35akM5T9qwxCTv1mSvlb79FmBemmw+r6cG7zNyxYq/BkUib5FdJaWzc2bsC1GIexbdF+v1V1ZPCE6aQim+oEZsUUGQ2UpYnGKcM2p9vkBd5jD7WYttekoBi6E+JxxzQoyzsSPd8IeDEbYzRLl3nuvWtuaPzl8pSUEhPxUDex4pZyqqv/bIKKDz9iJ5io5xBhkyzNxzExV0VFr7bvghOb2iklqZW97RDDFJV2pTqL0/lz5O4qhvna9FWwBtRMje5k4Ack1gFllijkQ9Fiv9wODEVH4K37kMjvQHAqTL28r5eLOdYt3untQ6r4aGuE1I/DRKXi+4VuSfINN79JcrAERJ7cVPAlb/OnByRBWOWnPsBjU+YaMRR722tr2QbJnCEyeZ6aKEg8vTA+FHi34DCaUIlB8kvolZWv/jo0tHKHnO26L3gBS8ITN9Ce88FUmZD3QDp5tfhSjQDLhdiOQOlKW/wF5nE4SwEPNxuTh4Rkd8qtKpqH9+i6oKPsfKtGXzAj3XkGg3RhgegOErj6TteLyk0I6X1eHXuSEZ/fJi0bnoQGA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR11MB3047.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(186003)(316002)(9686003)(26005)(6636002)(33656002)(82960400001)(7696005)(6506007)(55016002)(8936002)(8676002)(71200400001)(110136005)(83380400001)(122000001)(86362001)(508600001)(38100700002)(66556008)(64756008)(66476007)(66446008)(76116006)(66946007)(38070700005)(5660300002)(2906002)(52536014);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?dQypU/mNN1FJ/94X3LYHlJuw0qxEYMSNqfbAKz6cq4d7DlbUSOyz6EK94fxM?= =?us-ascii?Q?h68Cdc2VwAXvGwr30SalbFL3AIVqE7jsw2yZlfR8A3nvRP+iyNo7ScwWgC9m?= =?us-ascii?Q?9jKFkQDHz1a2B8uUQUcLRcaCOOJAq3kAVdp/v3sY7U//9WsIGtOC9uZIpE40?= =?us-ascii?Q?uC9J4DpvJqdnnEBYwB34Hbxg0Un9PO/AtMwUvz8xlTJ0BD8l7eiaQ0Vt2pJP?= =?us-ascii?Q?zBi2XhIGwwd+M8MZINbaOaMDevvJeqLoSmIGLkMJuhqXPXjow3xrsHZ37Aif?= =?us-ascii?Q?X5KaDl5YXk9Y2eFXTCczOCcQVwQxf4clmNFkjszxaqQ3q6i3fKHO1gemHP5f?= =?us-ascii?Q?MZU0WOZs9CuGviQgH+2+NvrDIFMMHWZL/rQD5VYyqSX2Bh1+UurjWEDPZJvf?= =?us-ascii?Q?8xYbrXuv1DHCd+wFI9xV3f+02xiJ5ZCB/+uBOqHstMiQjB6uz7ydV5UMgYds?= =?us-ascii?Q?BDiz/09qt1R0ltt7MMs0G4GrV497lLSGOd6IBqCzjIg2pj0GhRULAbF2SlgP?= =?us-ascii?Q?enM5APsdqEOWLgHfuMgFt/wpEvflpmKEuGWgSQvCSlLkeDa8tUzwG0apiq1A?= =?us-ascii?Q?r4oEXvQwMndWxDD84lhwQ4DnTq+v0psVWs28eMMYuNbbpwaFM+RvlwkA9/ot?= =?us-ascii?Q?1gz7XK1OFn5OmbwBgvyXZIZIWMllElRFo7mlsWpWwtDBOqDjyccom1gTAqbo?= =?us-ascii?Q?xhpZJvurWQnAAc2l7b6sZUALnKhlCk4MSNEGMrWEqGarey0bAE3L1+T+qQ+w?= =?us-ascii?Q?lNWpWsI0gp5VnBHFjRnSGah0CIoVlHtoJdFqfEtTsB/hauQNiFz6GFh/rjcH?= =?us-ascii?Q?BdUJCqHVD08BJOfNBJ/3addDE8ddDGOIIjX4VJttmmo1HteORu7SeApSxaSf?= =?us-ascii?Q?8eO5bN9mlUCMECg6dYWsYHfvO7vlGnTBYzu4HN6jlnPFDJThc/TcUj1Ih2XS?= =?us-ascii?Q?uMnixoQaoEh1lohJY7naFhju+yziL1r4rpNnvLIHHqidEBb9TAnv4vZ3cGsv?= =?us-ascii?Q?89otoHzM/yG7cqwmUIucbRR2/YD13QE5Nyz6WMPWROjXwjNqOmMrDa0ozd/S?= =?us-ascii?Q?ZUJuYteAr9zFbnEdHB/WXpiixJISd/DZvOH/bNDmhTXDE8Y9UwNs2xBn8Rgk?= =?us-ascii?Q?Bf4I9vOQjPJgmBRJyEFxFDqT1GkDoqUZQXJHSTxcWtzGOa+K7c/L0VmLqGGL?= =?us-ascii?Q?MfRk/xqaRwVEF8xRkNrVMwMUrAmywNEZbczI2mKiyaA0CEGwrju+jrm8iXbd?= =?us-ascii?Q?ZERZbR5pInIpo74/s4rdq9uaXUn+NZEiifv5PQm8AW3CR1NdBrJXB47IzDln?= =?us-ascii?Q?mhitp5D7NtKIOx/m1PrMfonhLVqWZUtNYLg7s29aio0cLQ0rRF3rMxFBYFk9?= =?us-ascii?Q?H9sZjuSaFnSYFFywkn94Z/VQAH39p9p1WIHDi7EKDCnHwqCgYFovxXdGoDVH?= =?us-ascii?Q?pagj30wk3SZHymXREFJAO+uiCfr6GGergjkgingmO6eirRr8NoAfJnMVtDwR?= =?us-ascii?Q?Pq3pJbhgbJya1ftkz1WTxs20udONzT0wBfsyAwpjuILIPakG7y7b59EAxm8a?= =?us-ascii?Q?Q8M3SkWDiWKb9ShnPn1q7jjoWtrUUWvkFHJsTWWHPAqjX2dXTFjSfla9Zoi9?= =?us-ascii?Q?CmZ+BXorq615N+Cu1BP2R+fXM9AsT/E8sBHR+lDD1KP2EVSBL3W3F9jfIBVL?= =?us-ascii?Q?svGPbA=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3047.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 532b7f89-f52f-414a-d5dd-08d998a6a5fd X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Oct 2021 17:32:56.5245 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: UuL+P3UCU6RyC9H76aP/RHldu4Zvgii9po1/9eQ783HzGUhD9KBLqCXrUXoP0qTrgkjD8JNAtAoxWY/jLZF8vjuooK59KTkFpRhJbEsQDuY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3783 Return-Path: maciej.czajkowski@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Ray, Sai, Could you take a look on this patch? Pasting below questions and answers from previous patch for a reference. What's the difference between SOC and CPU? SOC die differs from typical CPU die in Intel's chiplet design. = What the purpose of "DieIndex"? We want to have an indication to which exactly die given protocol instance = is referring to (in example in multi socket/multi PCH designs). = Have you considered to use data fields such as "CONST CHAR8 * DieName, Step= ping, Sku" instead of the methods? Yes, but there might be a configuration where chipset id is going to be cha= nged during the boot. By using methods, we ensure that returned value is co= rrect in every call. Can you add some details on how a producer of this interface would know the= values to be assigned here? Does this contain any sort of encoding of gene= ration and Die specific ID in a single UINT64? Yes, in order to have a generic field regardless of the die type and per-ge= neration changes it will be packed into a single UINT64. Protocol will be i= nstalled by silicon code, and consumer will need to be aware of the encodin= g and decode it. Same applies for stepping id. = Any reason the die specific GUIDs are not declared in the .dec file? I can't see any problems with that, they will be added in v2 changes. --------------------------------------------------------------------- Intel Technology Poland sp. z o.o. ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc | VII Wydz= ial Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 | NIP 957-07-52-31= 6 | Kapital zakladowy 200.000 PLN. Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego adresata= i moze zawierac informacje poufne. W razie przypadkowego otrzymania tej wi= adomosci, prosimy o powiadomienie nadawcy oraz trwale jej usuniecie; jakiek= olwiek przegladanie lub rozpowszechnianie jest zabronione. This e-mail and any attachments may contain confidential material for the s= ole use of the intended recipient(s). If you are not the intended recipient= , please contact the sender and delete all copies; any review or distributi= on by others is strictly prohibited.