public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Hot Tian" <hot.tian@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"leif@nuviainc.com" <leif@nuviainc.com>,
	"Desimone, Nathaniel L" <nathaniel.l.desimone@intel.com>
Cc: "rfc@edk2.groups.io" <rfc@edk2.groups.io>,
	Laszlo Ersek <lersek@redhat.com>,
	Ard Biesheuvel <ard.biesheuvel@arm.com>,
	"Kirkendall, Garrett" <garrett.kirkendall@amd.com>,
	"Lendacky, Thomas" <thomas.lendacky@amd.com>,
	"thomas.abraham@arm.com" <thomas.abraham@arm.com>,
	"Frank.Orr@dell.com" <Frank.Orr@dell.com>,
	Jim Dailey <jim.dailey@dell.com>,
	Abner Chang <abner.chang@hpe.com>,
	"Wang, Sunny (HPS SW)" <sunnywang@hpe.com>,
	Daniel Schaefer <daniel.schaefer@hpe.com>,
	Liming Gao <gaoliming@byosoft.com.cn>,
	Tim Lewis <tim.lewis@insyde.com>,
	"Kevin@Insyde" <kevin.davis@insyde.com>,
	Felix Polyudov <felixp@ami.com>,
	"Kinney, Michael D" <michael.d.kinney@intel.com>,
	"Oram, Isaac W" <isaac.w.oram@intel.com>,
	"Ni, Ray" <ray.ni@intel.com>
Subject: Re: [edk2-devel] [edk2-rfc] [RFC] Request to move MinPlatformPkg out of the Intel folder
Date: Fri, 2 Oct 2020 04:19:49 +0000	[thread overview]
Message-ID: <BYAPR11MB32064FD4A62901CF050271DB80310@BYAPR11MB3206.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20201001232621.GL5623@vanye>

Why not move to edk2 repo?

Thanks,
Hot

-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Leif Lindholm
Sent: Friday, October 02, 2020 7:26
To: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>
Cc: rfc@edk2.groups.io; devel@edk2.groups.io; Laszlo Ersek <lersek@redhat.com>; Ard Biesheuvel <ard.biesheuvel@arm.com>; Kirkendall, Garrett <garrett.kirkendall@amd.com>; Lendacky, Thomas <thomas.lendacky@amd.com>; thomas.abraham@arm.com; Frank.Orr@dell.com; Jim Dailey <jim.dailey@dell.com>; Abner Chang <abner.chang@hpe.com>; Wang, Sunny (HPS SW) <sunnywang@hpe.com>; Daniel Schaefer <daniel.schaefer@hpe.com>; Liming Gao <gaoliming@byosoft.com.cn>; Tim Lewis <tim.lewis@insyde.com>; Kevin@Insyde <kevin.davis@insyde.com>; Felix Polyudov <felixp@ami.com>; Kinney, Michael D <michael.d.kinney@intel.com>; Oram, Isaac W <isaac.w.oram@intel.com>; Ni, Ray <ray.ni@intel.com>
Subject: Re: [edk2-devel] [edk2-rfc] [RFC] Request to move MinPlatformPkg out of the Intel folder

On Thu, Oct 01, 2020 at 23:20:01 +0000, Desimone, Nathaniel L wrote:
> > One thing I think is needed for this to move out of Platform/Intel 
> > would be a ReadMe.rst describing the intended real-world use.
> > Some of this lives in Platform/Intel/Readme.md today.
> > Could we start with a set moving this text into a separate file 
> > under MinPlatformPkg and rework that into something that stands on its own?
> 
> Yeah agreed, given that the feedback on this RFC has been pretty 
> positive thus far, I'm planning on making a patch series for this. 
> I'll make these changes part of said patch series.

Sounds good.

> > If I was to bikeshed, I'd probably suggest 
> > Platform/TianoCore/MinPlatformPkg. Oops, guess I did.
> 
> Seems a little superfluous to me... isn't edk2-platforms part of 
> TianoCore by definition? 😊

It is. It's just the pattern for everything else in edk2-platforms (apart from OptionRomPkg, which was just transplanted from edk2) exists in the form of <section>/$VENDOR/. Platform/MinPlatformPkg would be the only bare package in Platform/.

> > I think we should see this as a separate step, regardless.
> > 
> > I do think we should be able to do better on sharing some of this 
> > platform image tooling cross-architecture (even moreso now Risc-V is 
> > involved), but I would prefer for us to spend the effort of 
> > identifying the intersections upfront before we start uploading 
> > tools to places where they look generic and may confuse people.
> > 
> > Maybe we should raise this part as a BZ?
> 
> Yup, sounds like good next steps to me. I've filed the BZ: 
> https://bugzilla.tianocore.org/show_bug.cgi?id=2992

Top man.

Best Regards,

Leif






  reply	other threads:[~2020-10-02  4:20 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-30 23:17 [RFC] Request to move MinPlatformPkg out of the Intel folder Nate DeSimone
2020-10-01  4:04 ` Abner Chang
2020-10-01  6:54 ` Laszlo Ersek
2020-10-01 23:27   ` [edk2-devel] " Nate DeSimone
2020-10-01  7:43 ` Wim Vervoorn
2020-10-01  8:00   ` [edk2-devel] " christian.walter
2020-10-01 11:24 ` Kirkendall, Garrett
2020-10-01 11:52 ` Leif Lindholm
2020-10-01 23:20   ` [edk2-rfc] " Nate DeSimone
2020-10-01 23:26     ` Leif Lindholm
2020-10-02  4:19       ` Hot Tian [this message]
2020-10-04 20:46         ` [edk2-devel] " Nate DeSimone
2020-10-04 22:00           ` Leif Lindholm
2020-10-05 20:11             ` Nate DeSimone
2020-10-03  3:36 ` [edk2-devel] " Sean
2020-10-04 21:02   ` Nate DeSimone
2020-10-05 19:35     ` Bret Barkelew
2020-10-05 20:18       ` [edk2-rfc] " Nate DeSimone

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BYAPR11MB32064FD4A62901CF050271DB80310@BYAPR11MB3206.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox