From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mx.groups.io with SMTP id smtpd.web12.22329.1595433943446984380 for ; Wed, 22 Jul 2020 09:05:43 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=x6KjqaLw; spf=pass (domain: intel.com, ip: 192.55.52.88, mailfrom: jian.j.wang@intel.com) IronPort-SDR: K66AfnVovl8iIu244oUxd1NUmtdx3dGOpE7omRiuJMm314VKO26MLVT0ikD8cvJu0Md82XyUdz DlWLUiDyp+vw== X-IronPort-AV: E=McAfee;i="6000,8403,9690"; a="168504847" X-IronPort-AV: E=Sophos;i="5.75,383,1589266800"; d="scan'208";a="168504847" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jul 2020 09:05:39 -0700 IronPort-SDR: 24EuqAYAbUMElCiD+2UJDvPAvG8Aj5GyGMvA8BMSEWfBS5WB+nXrMRkR4a7kU/UoPcm7uMLE4p mqL8643qzs8A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,383,1589266800"; d="scan'208";a="392722730" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga001.fm.intel.com with ESMTP; 22 Jul 2020 09:05:37 -0700 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 22 Jul 2020 09:05:34 -0700 Received: from ORSEDG001.ED.cps.intel.com (10.7.248.4) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Wed, 22 Jul 2020 09:05:34 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.46) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 22 Jul 2020 09:05:33 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nyOsWIXijv4vNzM/s5CZtQ5hvtEEjRSifSPeG9MMwMSSH0AynRH2k0Ki3kfS16Y6qKYHK/XUrgTt7vFvldCuPxZ8EqxkVI2MU/V2R4LFBqD4EFcdAgWuWSMN6c9QIFpYPY0+zzmcXj/TX8xrI/IGa793ZGLBGaCnTSuNmfcPUYU8mwROx9L/UeHIu/JpUvyzCoH4pPGvC/xTTsulTo1BhkZZlR907zqCLUTv85/JUBaTWf6ltsui+M4rkmf27waA9MV3fAdXMkdvJoyQBjxiKsR3lLSOVi5H3W8ZZoZXqELIVh9egdXNAMBKYbvJjkWQbC5RFTVjwgDpT5sk7+0lHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BNEbBX5tnXBE/+YYLQVSLYya7+9Zf+VxJyPcIj+8zLw=; b=jOqJq2S4JcPtfNnczIHfCQQ7HQ48IzlldBkoGj7+kwR2YfV8wrmc8lgHsfdGTklsPol0L3LlSwUdedfKaF2NVjrSzhEbiPk2yMVuU/6afxxQaAoedGyIiz7l4V4SrJib3OVMkV8OwCUq59a1N1nHm0Mc9JprcCUUyPadifbsA0TSN3ssD7pQoMrmoq1roVce/GD+b7/MLLFj75ztv2Qn+9yh35euKrBSLKIa0OzbSSAdyuhFmFA/VSwBvQMoa1QkwYaCsIr4x2ynOz4tlgBJgGX42Xou99dohvzGcZHwZjVT0FPcpiyru1fgyYZ9DNGQ3SchOq1J1/XuDdByMYSORA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BNEbBX5tnXBE/+YYLQVSLYya7+9Zf+VxJyPcIj+8zLw=; b=x6KjqaLwZ5/K3dtfCiHXdMUW39duZ5acCTHED0GywRTCJxPc2414kWr9GmiNoIcfEAnLhOQCrw1a8JOvr0O2X19o/MIo1Bti9nXsMu385XDn1L1+QC/zr+ZF2IQIsSWsNNZcDtTaT3Qboj+ZLDYFqUeJLdAUcxCjfSits/rubUY= Received: from BYAPR11MB3303.namprd11.prod.outlook.com (2603:10b6:a03:18::15) by BYAPR11MB3558.namprd11.prod.outlook.com (2603:10b6:a03:b3::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3195.17; Wed, 22 Jul 2020 16:05:32 +0000 Received: from BYAPR11MB3303.namprd11.prod.outlook.com ([fe80::fc2a:d66e:8c79:6ecd]) by BYAPR11MB3303.namprd11.prod.outlook.com ([fe80::fc2a:d66e:8c79:6ecd%7]) with mapi id 15.20.3195.025; Wed, 22 Jul 2020 16:05:32 +0000 From: "Wang, Jian J" To: "Zhang, Qi1" , "devel@edk2.groups.io" CC: "Yao, Jiewen" , "Kumar, Rahul1" Subject: Re: [PATCH v7 0/6] Add capability to let PEIM extend TcgEvent Thread-Topic: [PATCH v7 0/6] Add capability to let PEIM extend TcgEvent Thread-Index: AQHWYAEYVAeDKCV9XUuFroKh0ugmIKkTw74g Date: Wed, 22 Jul 2020 16:05:32 +0000 Message-ID: References: <20200722082107.12601-1-qi1.zhang@intel.com> In-Reply-To: <20200722082107.12601-1-qi1.zhang@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNTQyNjg4ZDAtMzRhMS00YTgyLWJmODEtZWRiYjE3NGM1Y2Q5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiTDdseTBwaEZkR2QxbFNTWTRTN3dBMUhYdnJ6aFoybkc1WDEzUVhaMmJDRnhyQWNNMDlBaU5kWWc4blJGUE50SSJ9 dlp-reaction: no-action dlp-version: 11.2.0.6 dlp-product: dlpe-windows x-ctpclassification: CTP_NT authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.201] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 5f6d9e8c-c363-485b-95e5-08d82e590fca x-ms-traffictypediagnostic: BYAPR11MB3558: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5516; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: dsLjgaSHfz6WkWZ+w2pAwlARJgjpmkxnnDQrsKeJIHst7HfRkmf7l3wWUqCREA4w+vOObuos1YAuF8O44EcZbsvqLLSxsvQaBGCAURGoZ64jU7k6iiRy0GmCMgnicaNAaE7gDK9WFbjnyIA1A2twhciZltaaJbgSxUVm9FmClxWSqCJ1KWUtmWe7+zh6binp31zKzbUcY+BFtdfF8K4agTFg3KYYEwAxwVYFHeW3Y9kP4pvh4c/PI/cDMW2uYbGeuNd1GRZiV4d6C2+ALsATtrpcKoJ/9fTTQlFA1Ex8Au4eD77jc9SWXW7ildA1YdetEige48JAgp6faD24jx1WgcYAvIyidB8a+os2dXNDBqvupO2OKSJA/h2d58pPvDQkBBp4kTdmilgGBzICbr+l6Q== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR11MB3303.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(346002)(136003)(376002)(39860400002)(396003)(366004)(5660300002)(71200400001)(33656002)(8936002)(52536014)(316002)(86362001)(83380400001)(55016002)(4326008)(8676002)(6506007)(66946007)(76116006)(7696005)(966005)(66446008)(66556008)(66476007)(53546011)(64756008)(19627235002)(186003)(26005)(2906002)(107886003)(54906003)(110136005)(478600001)(9686003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: Gpmx2YMh5VSMKzhA79ZStZ44+Y7jUvOHb88z+xTDm0sj+OCwuclsnoz0Ro48r6nJh4FeYFm+tm+AJ7b9gFCkvlpFnUGzmB7whkh/ojob8r7a1pUpTw964absitFntC7pb3N23aIFuUFrbIWTDxYFaZPNP8sgIBkc9Ha3QBJk+2kG896ogsId5seztNkMwSRlBTq3lDcxfHLyVs1lk1TOuBx+GUKi1Yj5xS3lajd0CPH3c5okru5fJRkxHm13sexuXIpS8TMKcGWU574yFtmI9sQ7myRAxky/HIpFHpuw5AVlDhEvPzpn3gDGYBnmH4PuaFwoftPO3myuVdn8b2C6wyNAYgBKbhbFFU5H2ZTI3lCmdfa/4KWaehFPYqoBkGfkipQUPwF8F0BF/+0DynN/11T+avza8b59qyP6qsYrjZRwOBV8LEQMp80T9/iuJ5nJqeXpHhefh1yu6jSMNueFlYQDTWc0GQ0oY+uoK3+hsN5QOkJ7zPPqzmbqRihniI8N MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3303.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5f6d9e8c-c363-485b-95e5-08d82e590fca X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Jul 2020 16:05:32.2438 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: dHehX2rtYTk6W/d0xtyqTaVWCnZ5vRn/Y2/lhy+xlUhmz74aez6XrIKQe2iFQKnuepQVVC6dw05oDyMieFlDMQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3558 Return-Path: jian.j.wang@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable For this patch series, Reviewed-by: Jian J Wang Regards, Jian > -----Original Message----- > From: Zhang, Qi1 > Sent: Wednesday, July 22, 2020 4:21 PM > To: devel@edk2.groups.io > Cc: Zhang, Qi1 ; Yao, Jiewen ; > Wang, Jian J ; Kumar, Rahul1 > Subject: [PATCH v7 0/6] Add capability to let PEIM extend TcgEvent >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2841 >=20 > Currently, we have TCG/TCG2 protocol and DxeTpmMeasurementLib to let DXE > module extend the TCG event. > There is more and more use case in PEI phase that a PEIM need extend TCG > event, such as BootGuard, FSP, Microcode measurement. Currently, we dont > have API to do that so that each module need create TCG/TCG2 event log, > which is a burden. >=20 > This bugzilla requests to add PeiTpmMeasurementLib instance. >=20 > The implementation includes: > 1) A EDKII_TCG_PPI which abstracts the HashLogExtendEvent service. > 2) A PeiTpmMeasurementLib instance, so that a PEIM can call this API to > add TCG event. >=20 > Cc: Jiewen Yao > Cc: Jian J Wang > Cc: Qi Zhang > Cc: Rahul Kumar >=20 > Jiewen Yao (6): > SecurityPkg/TcgPpi: Add TcgPpi header file. > SecurityPkg/dec: Add TcgPpi. > SecurityPkg/Tcg: Add TcgPpi > SecurityPkg/Tcg2: Add TcgPpi > SecurityPkg/PeiTpmMeasurementLib: Add PEI instance. > SecurityPkg/dsc: Add PeiTpmMeasurementLib. >=20 > SecurityPkg/Include/Ppi/Tcg.h | 60 ++++++++++ > .../PeiTpmMeasurementLib.c | 74 ++++++++++++ > .../PeiTpmMeasurementLib.inf | 50 ++++++++ > .../PeiTpmMeasurementLib.uni | 17 +++ > SecurityPkg/SecurityPkg.dec | 3 + > SecurityPkg/SecurityPkg.dsc | 4 +- > SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c | 110 +++++++++++++----- > SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.inf | 3 +- > SecurityPkg/Tcg/TcgPei/TcgPei.c | 61 +++++++++- > SecurityPkg/Tcg/TcgPei/TcgPei.inf | 3 +- > 10 files changed, 351 insertions(+), 34 deletions(-) > create mode 100644 SecurityPkg/Include/Ppi/Tcg.h > create mode 100644 > SecurityPkg/Library/PeiTpmMeasurementLib/PeiTpmMeasurementLib.c > create mode 100644 > SecurityPkg/Library/PeiTpmMeasurementLib/PeiTpmMeasurementLib.inf > create mode 100644 > SecurityPkg/Library/PeiTpmMeasurementLib/PeiTpmMeasurementLib.uni >=20 > -- > 2.26.2.windows.1