From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web11.34757.1589766838487289589 for ; Sun, 17 May 2020 18:53:58 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=Fi+diAd/; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: nathaniel.l.desimone@intel.com) IronPort-SDR: HRdrsKUzpKRKRpZxvt/36MxK3Q671Jw8Tml28QtLd8IqIrsFtlQ2DuXHNlSNGFCq2HN36yd1Ue p0FWwvZMv1eg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 May 2020 18:53:58 -0700 IronPort-SDR: HcxI6tHWuC+Ggjw3tBk8hdkFQbbjOlwX/sYdXzeCBjor2+CsFlFa7Nhd2PstPS9npsSPw7711x Oo7a8v8iVXOQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,405,1583222400"; d="scan'208";a="439044326" Received: from orsmsx108.amr.corp.intel.com ([10.22.240.6]) by orsmga005.jf.intel.com with ESMTP; 17 May 2020 18:53:58 -0700 Received: from orsmsx162.amr.corp.intel.com (10.22.240.85) by ORSMSX108.amr.corp.intel.com (10.22.240.6) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 17 May 2020 18:53:57 -0700 Received: from ORSEDG002.ED.cps.intel.com (10.7.248.5) by ORSMSX162.amr.corp.intel.com (10.22.240.85) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 17 May 2020 18:53:57 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.171) by edgegateway.intel.com (134.134.137.101) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 17 May 2020 18:53:57 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aHFm9nh1XLdQ6GhU+Qx6W1LrtmvyVyoPzHwW8ytm5rAjqR/Ls2NIImq0lyX9E6EnjDdCXzHNXYAq4GKSdeAP1pOkGp4Q/MmGWJPxMLdPwvUvZiRUo5WaKr/67XjviOCRTDKayByTE02Y68rBL8wSM5idRRQsX8l8FHQtcBNWO12YqTao/Ayhvvkpt0sE+9UyV4rHetS/5oV6Y4eqwHM/9VVNRh+kIcutLGDCzd3Uo+rEx0XrhNLeqdU+/mdnSv1G+Wg206jY+MhheQCmeb3sG1htj/vkmUnplZi4TAizfr1IofxAZJMdkFShHOvhVfhh5LKCMUq6xZLdunu95mzcGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xtSe2om41MW667FkJrJ/lcisBUrjAIpYa4uKg8OL5bU=; b=ID4wdIJt8+dFxWq4HKbOfxZxS+mDJiy0440/oUKWxbWm+Hb0SY4GW+8uewucEs7Y6GyHMel+jtYUM1HPB71ziu/c74tIFhsd9LIEodYw6pnHZArj5cdGAAK16u/foYb8Y18+AY76gesRHd3MRyAlpFmtT3wr0HTShNeL+Jl++sbS6Axbozu+fdIa+BxDFV5d1HjW/rhh+QgM4B5FO3daO+QphYWFRaHjXl9ehWq43a5Z++SwCL7Ogh4ZAgL6xCOxbeWyQhgDj67aZ/dkbghpepKQOj9YJlGN/sUUQeLSgj5HWxKoN0k9CZQ+R78Kir0MyfwUoFqj8qW4sOq2RCDkBg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xtSe2om41MW667FkJrJ/lcisBUrjAIpYa4uKg8OL5bU=; b=Fi+diAd/jlWDL9JnuTIm91Bv0F0OHh3ba5k3Vw7lujZvW55yI4JNyBxMeQiAFFGje7fJATdNKQTD7XsuZipDnIn2A75HazPWKr1YHgqc+RCcudPY9zkU5LQXTMH7KiYVlc79vz5t4A7n3svYPw9Rc26B+7ifiW0JHXZF43iYep8= Received: from BYAPR11MB3496.namprd11.prod.outlook.com (2603:10b6:a03:8b::16) by BYAPR11MB2982.namprd11.prod.outlook.com (2603:10b6:a03:84::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3000.20; Mon, 18 May 2020 01:53:56 +0000 Received: from BYAPR11MB3496.namprd11.prod.outlook.com ([fe80::114a:dfed:5bd3:bc00]) by BYAPR11MB3496.namprd11.prod.outlook.com ([fe80::114a:dfed:5bd3:bc00%7]) with mapi id 15.20.3000.034; Mon, 18 May 2020 01:53:56 +0000 From: "Nate DeSimone" To: "Desimone, Ashley E" , "devel@edk2.groups.io" CC: "Pandya, Puja" , "Bjorge, Erik C" , Bret Barkelew , "Agyeman, Prince" Subject: Re: [edk2-staging/EdkRepo] [PATCH] EdkRepo: Improve clone error handling. Thread-Topic: [edk2-staging/EdkRepo] [PATCH] EdkRepo: Improve clone error handling. Thread-Index: AQHWKxLL0H8q9Czgr06DTrnp+3OzLqitF/Fw Date: Mon, 18 May 2020 01:53:56 +0000 Message-ID: References: <20200515234412.18064-1-ashley.e.desimone@intel.com> In-Reply-To: <20200515234412.18064-1-ashley.e.desimone@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiN2QwNjc0NDktZmRhZi00NjA4LWJlZmItYTU2MTMxMTVjZmNiIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiM2Fkakd2WnFMV05SWXdyc1dcL0RKNGRLVVwvMEJ4MVZSczkzNEZiVnhIXC9MRTZhVTV1RGU0Rk84WWg5ZTllZmhuUyJ9 dlp-reaction: no-action dlp-version: 11.2.0.6 dlp-product: dlpe-windows x-ctpclassification: CTP_NT authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [134.134.136.208] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 55838aed-1527-41f2-5eb2-08d7face5359 x-ms-traffictypediagnostic: BYAPR11MB2982: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5516; x-forefront-prvs: 04073E895A x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 34ZSnaOZmYCtFmChB0HzO1S/NYZtqx/yxyt8GR97nXJw+pP60YZT/XSLmIwn4A/4FFfRj5/ATYHElLSsnwhpwgf2H9CKlBcX28FRyE3oo8umdkHLY5RxJQsPFu6EgO1L/P5keKEfAHw7hL8HkyzG8SIPH4YIf9lIARBwYu6kGFK4xjdqPB6lCEBf0lo2XYv9pMvD5oZJVW0IH6eq6WJXHZCJjoS4/mghAVrYJN3eo/8lm2wXdttTFYz3oWxNnelz+L3xJA31mF3hz6gt6etWAjAHfMtcpzqrgevTwzWF44NafNLpqXcb4w4oLuefGWIlnrJe2G3tF/JzTOKpy06GSwNetJT0r62oV7teKfcA6hPcjEjWQuH2CYlRdngR3vH0BthtdJ5rCUL46jan3AICf3xX/zjC4Vn87B26WAOhbd1+A8jrQW8j8j9Bb2r2eKh0 x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR11MB3496.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(346002)(136003)(39860400002)(396003)(366004)(376002)(110136005)(54906003)(478600001)(316002)(8676002)(33656002)(8936002)(186003)(107886003)(71200400001)(52536014)(4326008)(7696005)(26005)(76116006)(2906002)(66556008)(66476007)(64756008)(86362001)(66946007)(55016002)(66446008)(9686003)(53546011)(6506007)(5660300002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: Z2Sl8QKvKH5p89OKL4JjaH3egf7xNNv2oTUZ0e9Yu8FVNv2jkjFnxR9ad6s3q/FF5daMRqZHR1BhPjtaKEP+lc0LiBg5aZVlqk0GvAhst9WrZVfZ5YCOOO1sj7/jvJr/nV9Cnvqb3RpU4fHKbyFUutmZx9mdC8L9IvMozUJ+Q0FhC3rF0wmPXp/HETq/+nNVmgse1vqRb1def6i86JKWiz9iF1CCTzicYDd5p5VE+fKKqOi4bGMjIvaTGnWeOD4QFDSw+gPUJSHf7Jl03mzjadhKWkpqgd/Jo45eQeE3L5Jal/3PnpIA40sBTpfGHsDeLZmPaRZgcB5yQNI2UZ1psu+Q3lo7wdhldv/K+pl5HQNA8SOUPPjBMPQ1A4MdTQD95GR6LF/FvzIQ5/qAZ+r4RX6dqrzgPILnvf6quzA70K2wobhegBNIzIybLwi89fd/rpbcAIH1/MiCmbBF9Ksiae7mrrCYY1NJTf3LzWaiYUrfcL/qSzuqRPiC4VYqN6zX MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 55838aed-1527-41f2-5eb2-08d7face5359 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 May 2020 01:53:56.3548 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: RpruI/8Q2rNjD44NSbdnF+93O8b1xhWZCuiYU7Yk0JVhVE38sblP6IECn9rYltDvpp+gb1CDtASHBlYN6GFmYHOoBUzBi//IvvlbrUZu7Hc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB2982 Return-Path: nathaniel.l.desimone@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Pushed: f8ded3c3 > -----Original Message----- > From: Desimone, Ashley E > Sent: Friday, May 15, 2020 4:44 PM > To: devel@edk2.groups.io > Cc: Desimone, Nathaniel L ; Pandya, Puja > ; Bjorge, Erik C ; Bret > Barkelew ; Agyeman, Prince > > Subject: [edk2-staging/EdkRepo] [PATCH] EdkRepo: Improve clone error > handling. >=20 > Raise an invalid parameters exception when a project is not found. >=20 > Signed-off-by: Ashley E Desimone > Cc: Nate DeSimone > Cc: Puja Pandya > Cc: Erik Bjorge > Cc: Bret Barkelew > Cc: Prince Agyeman > --- > edkrepo/commands/clone_command.py | 16 ++++++++++------ > 1 file changed, 10 insertions(+), 6 deletions(-) >=20 > diff --git a/edkrepo/commands/clone_command.py > b/edkrepo/commands/clone_command.py > index 179aaf7..3f2e6e1 100644 > --- a/edkrepo/commands/clone_command.py > +++ b/edkrepo/commands/clone_command.py > @@ -17,6 +17,7 @@ from edkrepo.common.common_repo_functions > import clone_repos, sparse_checkout, v from > edkrepo.common.common_repo_functions import update_editor_config, > combinations_in_manifest from > edkrepo.common.common_repo_functions import write_included_config, > write_conditional_include from edkrepo.common.edkrepo_exception > import EdkrepoInvalidParametersException, > EdkrepoManifestInvalidException > +from edkrepo.common.edkrepo_exception import > +EdkrepoManifestNotFoundException > from edkrepo.common.humble import CLONE_INVALID_WORKSPACE, > CLONE_INVALID_PROJECT_ARG, CLONE_INVALID_COMBO_ARG from > edkrepo.common.humble import SPARSE_CHECKOUT, > CLONE_INVALID_LOCAL_ROOTS from > edkrepo.common.workspace_maintenance.workspace_maintenance import > case_insensitive_single_match @@ -81,12 +82,15 @@ class > CloneCommand(EdkrepoCommand): > os.makedirs(workspace_dir) >=20 > cfg, user_cfg, conflicts =3D list_available_manifest_repos(confi= g['cfg_file'], > config['user_cfg_file']) > - manifest_repo, source_cfg, global_manifest_path =3D > find_project_in_all_indices(args.ProjectNameOrManifestFile, > - config= ['cfg_file'], > - config= ['user_cfg_file'], > - > PROJ_NOT_IN_REPO.format(args.ProjectNameOrManifestFile), > - > SOURCE_MANIFEST_REPO_NOT_FOUND.format(args.ProjectNameOrManif > estFile), > - args.s= ource_manifest_repo) > + try: > + manifest_repo, source_cfg, global_manifest_path =3D > find_project_in_all_indices(args.ProjectNameOrManifestFile, > + conf= ig['cfg_file'], > + conf= ig['user_cfg_file'], > + > PROJ_NOT_IN_REPO.format(args.ProjectNameOrManifestFile), > + > SOURCE_MANIFEST_REPO_NOT_FOUND.format(args.ProjectNameOrManif > estFile), > + args= .source_manifest_repo) > + except EdkrepoManifestNotFoundException: > + raise > + EdkrepoInvalidParametersException(CLONE_INVALID_PROJECT_ARG) >=20 > # If this manifest is in a defined manifest repository validate = the > manifest within the manifest repo > if manifest_repo in cfg: > -- > 2.16.2.windows.1