From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web10.34672.1589766800618642987 for ; Sun, 17 May 2020 18:53:20 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=oohYtCDl; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: nathaniel.l.desimone@intel.com) IronPort-SDR: cQCY2jV775DsmTtW+/OILHtDuxN5apsT0C3GRreDBzQzoWZhI8PEm6ymzdyDcFhh/MMrMUKake 07k03Kp7pLmw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 May 2020 18:53:19 -0700 IronPort-SDR: SMpyOvogSZatCRVRoFAamuZeDv3I6dlj9kvMwopDPEefLq1MyMU9CdwIFquDVX/fg7Amg8s8Vy DNJdtdiB2jrw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,405,1583222400"; d="scan'208";a="254317460" Received: from orsmsx109.amr.corp.intel.com ([10.22.240.7]) by fmsmga008.fm.intel.com with ESMTP; 17 May 2020 18:53:19 -0700 Received: from ORSEDG002.ED.cps.intel.com (10.7.248.5) by ORSMSX109.amr.corp.intel.com (10.22.240.7) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 17 May 2020 18:53:19 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.173) by edgegateway.intel.com (134.134.137.101) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 17 May 2020 18:53:19 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EnxaXUgoppH73orOKUjvB+q1mOlS5MXngRkboSaoD3l6+Iu/GKL2Aq/KvrPTWQc9fcEZiGqzHg1OuvgX5U92MBvG87VLsfXN7rZywl5k4dzwFcKn7htJZW7S4/6tz2HIkMu7+8qYxjK0pdR8q9uF22XJeDJjcUZEzPWwvrxRa8VELdab0oj4ZEnp2hg8PUwMdV9xKjZ9+0TpOmGqwSQv4gb+HsTzth79AIUKErGti6Ikc2rMM51o8PQYJjiZRdfBHh16bksLnNFJyHG9JdOAwHBs++FBvVXzqN9z4bkJ5lodNdKLIoa1cQYatDybrqpagcnPZrSkvpg4WfnN+4rR5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AwnawqsG4J8THxIg+VR9VWLktpFHU+yF80eanKw40cs=; b=Ur3EcvzxV6NKN1SaFsRv9GLJMA1BXt3facGd+XXSDeTqCHP815Qss4svhGGq6VIXEK23xv9nXBp8S1HZHiFX739gI97OEqpPuh+jOYDPe9WRY8efKAAGo/8Ooy6IBJJVS/RnyfLSRN2xeA+4bPRMnD7sJNdUkLHTgOUhxGMg/jXcCNADrY/MCbYWbEKFQT66Vz75ULOcEhsr94H5GDcgWJq3BFFlu5lXlg+B1A1droh3sVQP1gaaF9qJy3saf7knTNV1vLNBUi5qxJJW6G6d7sMQS3YWuJnL0Ug3vJ8o++YXn6gvDvgz4gM7eGNXj33O2h/MYK+P1Fn6ZDSVlVBIOg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AwnawqsG4J8THxIg+VR9VWLktpFHU+yF80eanKw40cs=; b=oohYtCDlzTblV3h8S2BXZKkthkIhGvrCqvKRKzqjuEOh8Xz0saycrlwBiHcy6kPk5yfuH/kX/8uVX3kjA6gmjj7kJ52FQjH/xXrkegF+3R2egt1rP5gKlygDNdIXemnXsccF/rBR/3l5am0231D8Mt/htJgaGUIs7elyW5xaIE4= Received: from BYAPR11MB3496.namprd11.prod.outlook.com (2603:10b6:a03:8b::16) by BYAPR11MB2982.namprd11.prod.outlook.com (2603:10b6:a03:84::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3000.20; Mon, 18 May 2020 01:53:17 +0000 Received: from BYAPR11MB3496.namprd11.prod.outlook.com ([fe80::114a:dfed:5bd3:bc00]) by BYAPR11MB3496.namprd11.prod.outlook.com ([fe80::114a:dfed:5bd3:bc00%7]) with mapi id 15.20.3000.034; Mon, 18 May 2020 01:53:17 +0000 From: "Nate DeSimone" To: "Desimone, Ashley E" , "devel@edk2.groups.io" CC: "Pandya, Puja" , "Bjorge, Erik C" , Bret Barkelew , "Agyeman, Prince" Subject: Re: [edk2-staging/EdkRepo] [PATCH] EdkRepo: Improve clone error handling. Thread-Topic: [edk2-staging/EdkRepo] [PATCH] EdkRepo: Improve clone error handling. Thread-Index: AQHWKxLL0H8q9Czgr06DTrnp+3OzLqitF6yQ Date: Mon, 18 May 2020 01:53:17 +0000 Message-ID: References: <20200515234412.18064-1-ashley.e.desimone@intel.com> In-Reply-To: <20200515234412.18064-1-ashley.e.desimone@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMWQyMjQ2MzgtOTkzNy00M2IzLWE2YWUtZjc4MmM0ODc1MzFkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiNHJcL1dsUWU3Tlc5ckdpNjFkSFh5TWw2VzJJRG9ncEZnSjdPenhGOXBDVlB4dVRyNnVna1B6S3YzRkg2aFR5cDkifQ== dlp-reaction: no-action dlp-version: 11.2.0.6 dlp-product: dlpe-windows x-ctpclassification: CTP_NT authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [134.134.136.208] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ffd2f1a6-2cad-4d78-1f66-08d7face3c5b x-ms-traffictypediagnostic: BYAPR11MB2982: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5516; x-forefront-prvs: 04073E895A x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: a9k0pFKYP9Qx9nq3pl7X6UKlGVnuH0KXa/3UmfI64KiRWbouWehtPXfhKBT9tuUrP84GnJn5Hq31gshGVCcwz+YmYvbXLQF/6O+4tK5i9uRhrZFU0LBlIn2p+YIjk8UZli5d4QMEh3hY6SIrvDyW8MR7ZXuyGNV+HgWhcolvFd6Bn+tDviuCtqmg0v2vZww2H2J+b27AyUklkdBquqhHtCTB83NzvimIT5E1CQDPmtTMBIwdpOpgQdzy/EEmfMDTMo6KOXpxL/iwy72zOyR8eD7Ee0sEmTSX/u8EJzWHP1XMuXMGYNOxOOlxT6u9evewFauTE3GGhx6mMFKGtn8HM2TQE98JiRqUi5lxGdxblLEgg509B7FMWhgBZPi/xxepzwGuEr31TK77PPOBWUegPXNvGHgYTukxfxSh+6kGQaEcvgjRsOvzyyOLozM6n9LR x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR11MB3496.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(376002)(366004)(396003)(39860400002)(136003)(346002)(55016002)(66446008)(9686003)(26005)(64756008)(86362001)(66946007)(66476007)(76116006)(2906002)(66556008)(5660300002)(6506007)(53546011)(478600001)(54906003)(110136005)(52536014)(4326008)(7696005)(8936002)(33656002)(316002)(8676002)(186003)(107886003)(71200400001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: hcO05RBsnIoZwMR2gq8/gjKG4LOpVM9Q8IoA/F8dIErHlH5HHjQNp1245NoLO4N/udec58ekb8oSPQB29BO7kFv0W9iTAfT80h1TDBlTHS79PW98DVwn5DxQIss7XwTRjue3ZxxMbFg9YOOmjV//SpOwH33ssCHWKpGSI2rWXJv03e4vLZMWujhkdvMm2CENHpae+WRcxWrJ+KXEOXc+ZMDQaxOjslY/EpC9n+rZH0RNJKdlSq1m/a9wql/mLbmz30YNmsO+84vmetvE2ArBKWWAjT6WYCtpjRN0J8xXASTn/+DKYpQ4DyJoAKbJl1sLcAjho6WoLkxbZ8r0hqGhVmSBmtrEz4WKPnmiiy38RnqZm6m19tN2aQYLCdtjnOgxCOlrRMG9l05caAylWpsYCf+Hp/AAPuOVipgah3fc+07zZvVZe2am/FL5WNwIL24Yryufq4HoCIwunNzH693LfwbvVmnLKjfPi++YaytcNh/PCUyoe/rgAdbFoLQ9U/sK MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: ffd2f1a6-2cad-4d78-1f66-08d7face3c5b X-MS-Exchange-CrossTenant-originalarrivaltime: 18 May 2020 01:53:17.7896 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: xF8O9eJOeSaeeWknwBhtIPmiNwXsFyIUssC7ieXDpADxwgmLgM3dnraq8JxzMl2zAVR24LxR9er0+X9NFgIGIc+7n+E3mNwOb76kgzJARh0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB2982 Return-Path: nathaniel.l.desimone@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Nate DeSimone > -----Original Message----- > From: Desimone, Ashley E > Sent: Friday, May 15, 2020 4:44 PM > To: devel@edk2.groups.io > Cc: Desimone, Nathaniel L ; Pandya, Puja > ; Bjorge, Erik C ; Bret > Barkelew ; Agyeman, Prince > > Subject: [edk2-staging/EdkRepo] [PATCH] EdkRepo: Improve clone error > handling. >=20 > Raise an invalid parameters exception when a project is not found. >=20 > Signed-off-by: Ashley E Desimone > Cc: Nate DeSimone > Cc: Puja Pandya > Cc: Erik Bjorge > Cc: Bret Barkelew > Cc: Prince Agyeman > --- > edkrepo/commands/clone_command.py | 16 ++++++++++------ > 1 file changed, 10 insertions(+), 6 deletions(-) >=20 > diff --git a/edkrepo/commands/clone_command.py > b/edkrepo/commands/clone_command.py > index 179aaf7..3f2e6e1 100644 > --- a/edkrepo/commands/clone_command.py > +++ b/edkrepo/commands/clone_command.py > @@ -17,6 +17,7 @@ from edkrepo.common.common_repo_functions > import clone_repos, sparse_checkout, v from > edkrepo.common.common_repo_functions import update_editor_config, > combinations_in_manifest from > edkrepo.common.common_repo_functions import write_included_config, > write_conditional_include from edkrepo.common.edkrepo_exception > import EdkrepoInvalidParametersException, > EdkrepoManifestInvalidException > +from edkrepo.common.edkrepo_exception import > +EdkrepoManifestNotFoundException > from edkrepo.common.humble import CLONE_INVALID_WORKSPACE, > CLONE_INVALID_PROJECT_ARG, CLONE_INVALID_COMBO_ARG from > edkrepo.common.humble import SPARSE_CHECKOUT, > CLONE_INVALID_LOCAL_ROOTS from > edkrepo.common.workspace_maintenance.workspace_maintenance import > case_insensitive_single_match @@ -81,12 +82,15 @@ class > CloneCommand(EdkrepoCommand): > os.makedirs(workspace_dir) >=20 > cfg, user_cfg, conflicts =3D list_available_manifest_repos(confi= g['cfg_file'], > config['user_cfg_file']) > - manifest_repo, source_cfg, global_manifest_path =3D > find_project_in_all_indices(args.ProjectNameOrManifestFile, > - config= ['cfg_file'], > - config= ['user_cfg_file'], > - > PROJ_NOT_IN_REPO.format(args.ProjectNameOrManifestFile), > - > SOURCE_MANIFEST_REPO_NOT_FOUND.format(args.ProjectNameOrManif > estFile), > - args.s= ource_manifest_repo) > + try: > + manifest_repo, source_cfg, global_manifest_path =3D > find_project_in_all_indices(args.ProjectNameOrManifestFile, > + conf= ig['cfg_file'], > + conf= ig['user_cfg_file'], > + > PROJ_NOT_IN_REPO.format(args.ProjectNameOrManifestFile), > + > SOURCE_MANIFEST_REPO_NOT_FOUND.format(args.ProjectNameOrManif > estFile), > + args= .source_manifest_repo) > + except EdkrepoManifestNotFoundException: > + raise > + EdkrepoInvalidParametersException(CLONE_INVALID_PROJECT_ARG) >=20 > # If this manifest is in a defined manifest repository validate = the > manifest within the manifest repo > if manifest_repo in cfg: > -- > 2.16.2.windows.1