From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web08.4228.1666077676261477004 for ; Tue, 18 Oct 2022 00:21:16 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=geFrneUV; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: robert.kowalewski@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1666077676; x=1697613676; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version:content-transfer-encoding; bh=lIkoZYHDNzXasQMMkrmPBdXwcusbsIWRiZTeGOVvRs0=; b=geFrneUVvJL4IsoBBNB45x1EhOItIp8Ti9PaVYUOktw9acVoUCv9oReb r9LnXA5MjvKfNFWgAR5ZGHWdl7CMFkQT8iJ23OprfL7NVBaAlUcUO7q+q 44NXAlEgpvEXlb9/HDr4Mqm6ekb0NyrfVw2SFzOq3gLeS1CxBEczpgQHZ IoiBVA4Ze5jQH7F1eFumYAKN2RAtwBJq6jU/P9U1h8+1X0HlQJIga+oHZ Icl2OyUbjcmslnlUL+OO8qKXtMepr1CK7EbrZ0v7CnxZQHmssSmzIpPn5 3JkQOjorFMIzjJcvnXYIwRkY6/MV6EY/MYIyunoHQZ2jJz2wsFvvRK1CT A==; X-IronPort-AV: E=McAfee;i="6500,9779,10503"; a="306005775" X-IronPort-AV: E=Sophos;i="5.95,193,1661842800"; d="scan'208";a="306005775" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Oct 2022 00:21:15 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10503"; a="628600061" X-IronPort-AV: E=Sophos;i="5.95,193,1661842800"; d="scan'208";a="628600061" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga002.jf.intel.com with ESMTP; 18 Oct 2022 00:21:15 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 18 Oct 2022 00:21:14 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 18 Oct 2022 00:21:13 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Tue, 18 Oct 2022 00:21:13 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.169) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Tue, 18 Oct 2022 00:21:13 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=L0CGsWHrtiz9pjgYTMk6fi/N1DgQSd+W4RiQUVr0+zkKgpk8zGDlW8WDwBID28rxAHbHnHjuKAy3Jrjbsurc4SR60B93nhKHLNAxRVZrUyd1B+Sb1OuQkBVjrKxFaLTkq+yXYe/cgqQlKQcBlr01SCB3nboo5c0M2cFPU+GyIaXuu4szlaUwOcxwvMvwzAciGO+KABaxGaBi5KtOkFgMZSMmDrc6oWa5KssDklqmkG3/cuwVxFmtE4CAcOm/ouCnITd/GkB8/02rrAeoq595BeYG9FLT3uIOT+jkT5MhBkOHrYPGIasuXoxWCOSQGTnH3nE6PieTzs6shodq07n2Og== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uXUVGkZ+6mZUkaB7ydkAWEP+iqBONd+eRk66TlwBNv4=; b=V37lT7xc/tk5aLZnfG0DjSLxmc8+bdfeVYL5dzHxlMafebbJ0a1KziOzh8yz+CCu329daVHtuZsxTjgK1KB8UrqFV4vZ7arMZnTBCPI0fM2O16gl1aGmxEX3QbP7chyeJh6LjJtKGevdAEc5tkxWDAg61aexxY45Qxfs4k1qcGU86qIBDIKDrdCew6xblQ79HaK3KSyDlyBFHwUJnJCk/AUwDmwzQgvlHx5BR6gC3y012i7EvxhRGm8HN0ZEpKE+hZksEnRVjScBxPnxLCj8QOdrqor9gxdfhBSHbZvDNQ5+NbFGQ5CE5uY5yZh00Gu8OAR1qs4T8D0CEBJz65Qrbw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BYAPR11MB3509.namprd11.prod.outlook.com (2603:10b6:a03:8e::25) by DM4PR11MB6336.namprd11.prod.outlook.com (2603:10b6:8:b9::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.30; Tue, 18 Oct 2022 07:21:11 +0000 Received: from BYAPR11MB3509.namprd11.prod.outlook.com ([fe80::eea3:8ac6:c81f:6a57]) by BYAPR11MB3509.namprd11.prod.outlook.com ([fe80::eea3:8ac6:c81f:6a57%5]) with mapi id 15.20.5723.032; Tue, 18 Oct 2022 07:21:11 +0000 From: "Robert Kowalewski" To: "Sheng, W" , "devel@edk2.groups.io" CC: "Ni, Ray" , "Chaganty, Rangasai V" , "Huang, Jenny" Subject: Re: [PATCH] IntelSiliconPkg/VTd: Refine VTd core driver Thread-Topic: [PATCH] IntelSiliconPkg/VTd: Refine VTd core driver Thread-Index: AQHY4rzpXIZfVzCr50Kx4rY42Q2XOa4TvtIg Date: Tue, 18 Oct 2022 07:21:11 +0000 Message-ID: References: <20221018064311.186-1-w.sheng@intel.com> In-Reply-To: <20221018064311.186-1-w.sheng@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR11MB3509:EE_|DM4PR11MB6336:EE_ x-ms-office365-filtering-correlation-id: 833cb855-c5e9-4c07-3c5e-08dab0d9557c x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: BSklOhL/XKR7bShailfI8Z2zVKHFh+xasXGMoPwQu7mi/JPJt0edtXOOX2mLz4GImUsoDC+umKS9EO/KPBCLQxesfvmEFeD+d4zbvME4MTER+Q5ZmrIGGgrmJhjSJGzeTKCIlZohWMqupe8bNmhoaODnmyBgrekej8r5D0O8qzdU+Py4gfHSPAIitm58vyDgmcOqIt5hlIV1XRQF0HHM/PbHJG8xO+nHckf8gmW9QmqGNed/+PSNv3FvujPTX0pGY0+COpOdVDI4lQM10FJkaTUudTrN6EYbx2JJdyt75Hn2iwbCoYrquuD/m/oC7vGYmjDUSEnbRuJr6ePjJPIOTEk+sDyzgGtII+MytY1cInjNlMgAxgOQPnUjT8wHhe3M5DzPudZrJduWVGzX4xnzKY7ht7FVlfSXoTu05GgYSm+F251uI9feKsMNmcaWtYXiUBX3Snyt9ju3tlAvH/kVKSyDGw7u0VRT5Fxu7w3+uI0ydBeATSUaWFF+uoN9PTD87CN08ncGMVNy/VPfzSeFaMNz62Akms8zpGjTHfDGW9dkKSrzINneMaOKAt0Gj1FJtcDQGIspKUJIZv6mzA+4G8Dk3jBfQj0wzsWvCDWNMhxyLaALDGQDLJ+qhPymrk2YDaKxmFThBSgeTT4Q8eCYx5KyC21Xkaj5g7wnMJIC8fp/701AVFyhQk4jJScop8Y1BSJPj1cx24CHnzjZol/3WUk1aZk1oS6ZErVuDeNdIfoG//Zv69VlkBnWqCfX0o1eZpoLH+ajwbasW9S1uJc+aA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR11MB3509.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(39860400002)(396003)(376002)(136003)(346002)(451199015)(38100700002)(86362001)(82960400001)(41300700001)(107886003)(110136005)(7696005)(6506007)(316002)(53546011)(26005)(5660300002)(54906003)(8936002)(52536014)(55016003)(38070700005)(122000001)(9686003)(4326008)(71200400001)(478600001)(33656002)(76116006)(66476007)(66446008)(66946007)(66556008)(8676002)(64756008)(83380400001)(186003)(2906002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?5VsB35eHtfhfPeH+tBMDvvaVwSa95x219ZTE9iJKsRmmg7YjcHeQrrX1z5xc?= =?us-ascii?Q?6TL45PJGRn07Dw+HZT8ClfAWkweVziIQKtniRAekbQJrA2/qITkMaAjRdvF3?= =?us-ascii?Q?hiHGxre0cS5GyBHlYCr6/IPuhxMGP/kS+U/OeGJx84nR3qplKNfE9nAc2y/h?= =?us-ascii?Q?MLlpUwF9dKaXHyYQHKWDVpQ/cDdbRVwTFAaL21dyDagx3G6kfBzHmqfSc4jQ?= =?us-ascii?Q?vktCcGfKHci9oK6GBzK1R8SUbdQLI5VtOn6ayJ159Oq564GndJFNa2xmCRpD?= =?us-ascii?Q?B8CrAxLIU3tXulrjqO8zndET+thTRdQJt5ohLoRA9fYiEyGdF/7uKV6PXNBg?= =?us-ascii?Q?p7V1iY7g/cVFjOFnxtGiTxx0q7yJA65I2VAoMeOCqV3Ip2DIF2pZECBEm0Ht?= =?us-ascii?Q?6YjhzJATeAiVJk2ahRQbcGNJKeCt5W27PVcd3BU2/8qtrbs676M5qkL/YO0b?= =?us-ascii?Q?fsSUZkvOSv+sV2CTEWnJNwDY5sVSHdze53/yJPpo2Zpbu5sj5JzgbIuhqZo5?= =?us-ascii?Q?r2Eka8Ai4Y5pui4ZNmd5CAhhVMH8zWx0911YLnGLzftQcpDg9kSfadml4XMU?= =?us-ascii?Q?sEA+i80RqY0efoQDsrOTTiEbhpzTV1snV2D3lgoApJ/64uYy3EewHEsAW9GN?= =?us-ascii?Q?4nkDGNaZpQ04+tmcxdwEXD8stfDAJwlC+nE4wr6AZi3Ft5jw387X5VLx/Bu1?= =?us-ascii?Q?+xabNxJoniH70o8KM8ak4bZNzM7/Dqqn3LzoM3If0RwpNnRilua+X+UTqv0/?= =?us-ascii?Q?QQZXgLbuleEGC1jStzs9Py9XvP5Xj1juP+YPUSx2XuKTi9P9LtFOPKqF2iRw?= =?us-ascii?Q?DxNBj7pTJC7/qQwfoiw9lY2fjzFvhqO8vaGMho3T4VyZO73nbEMYOsgKJI0F?= =?us-ascii?Q?RAAw326SJolfeBQvI18psg2I4yuVzgS75Edttl6yinIJEVV82wMlIps1EYs8?= =?us-ascii?Q?T96rA4b8PxYdOpK2g9iDicy6cmXPumZ84kw0SlT9f5tUvlkh4TIfE++d5tD4?= =?us-ascii?Q?mOG9BQqI96cyrZQf1ndDMRCX+CRT44lgNt+Ee9KIPSfEGe71BJ/YAyKRbBxH?= =?us-ascii?Q?bt4YfYmP6AmADysgkH0lh6emNUI1Ao+Xd7SlhEs7gV67KZ03LQP3hBrS+Ku6?= =?us-ascii?Q?ysRP/z+gAY7NyxLnw3Y2sqtpKFsXvDTuOlqNDPlINL1Vxi3xCNnngvRKoHAV?= =?us-ascii?Q?nckI7WAcWKGZJ+KW3GwUoiIUmLseR5qVbal6MllPIErmft36l8W8AmI/VUPf?= =?us-ascii?Q?hR22T0OmFP0InITMu6bfOpyPcBIbtqZdC7fa6xjtQ0Hs8CwEL3pVIFkwrzkJ?= =?us-ascii?Q?Sv3IaaKd3J8X4PBYH6t4YH9eL27vZT/QaXPRf5c4EvromgBLuwqUiZOfGbI+?= =?us-ascii?Q?ARiAaEuHkVFopfC6qUW3+KJcrwCoGa9IoMCy0aBMsLFRNEiCA7DbfOKG1X8P?= =?us-ascii?Q?fPwx5eVyrCNbE9nImaimsbmVdlOW/MulnR0hTzNMo32yKCjhwsXZOV8Mhk5g?= =?us-ascii?Q?rJxIOlpjuOX/dS+yn7FpZfCWG5qWA7hhbMlMQVk8E1pUO/p2a+Lk2CxH8WyY?= =?us-ascii?Q?oEsvQIxk2KMrF58pvicrmMBmAPP+izikofrn95xYWvPS0lHUps3mzYxQz3CU?= =?us-ascii?Q?Gg=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3509.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 833cb855-c5e9-4c07-3c5e-08dab0d9557c X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Oct 2022 07:21:11.4631 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Gp/8+ERHbvc4hPuhJUrcjrF3Kg5OOVUINcB88j1tpJM/f29qKQuRSB3TT2whhXpeJ1/+cqYKL9/kNBanTU6H2wslpQiiUA5Rw9dhd0+GKRI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB6336 Return-Path: robert.kowalewski@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Robert Kowalewski -----Original Message----- From: Sheng, W = Sent: Tuesday, October 18, 2022 8:43 AM To: devel@edk2.groups.io Cc: Ni, Ray ; Chaganty, Rangasai V ; Huang, Jenny ; Kowalewski, Robert Subject: [PATCH] IntelSiliconPkg/VTd: Refine VTd core driver Refine the DRHD table print message. Remove unused variable. Hsd-es-id: 15012152545 Signed-off-by: Sheng Wei Cc: Ray Ni Cc: Rangasai V Chaganty Cc: Jenny Huang Cc: Robert Kowalewski --- .../Feature/VTd/IntelVTdDmarPei/IntelVTdDmar.c | 3 +-- .../Feature/VTd/IntelVTdDxe/DmarAcpiTable.c | 8 ++++---- .../IntelSiliconPkg/Feature/VTd/IntelVTdDxe/VtdReg.c | 3 +-- 3 files changed, 6 insertions(+), 8 deletions(-) diff --git a/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDmarPei/Inte= lVTdDmar.c b/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDmarPei/Inte= lVTdDmar.c index 24beccd26..af85a3d8e 100644 --- a/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDmarPei/IntelVTdDma= r.c +++ b/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDmarPei/IntelVTdDma= r.c @@ -486,7 +486,6 @@ EnableDmar ( IN UINTN RootEntryTable ) { - UINT32 Reg32; UINTN VtdUnitBaseAddress; BOOLEAN TEWasEnabled; = @@ -529,7 +528,7 @@ EnableDmar ( // // Init DMAr Fault Event and Data registers // - Reg32 =3D MmioRead32 (VtdUnitBaseAddress + R_FEDATA_REG); + MmioRead32 (VtdUnitBaseAddress + R_FEDATA_REG); = // // Write Buffer Flush before invalidation diff --git a/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/DmarAcpi= Table.c b/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/DmarAcpiTab= le.c index 42e1b1449..a485f4d9a 100644 --- a/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/DmarAcpiTable.c +++ b/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/DmarAcpiTable.c @@ -536,14 +536,14 @@ DumpDmarDrhd ( " Flags ................................................ 0x%02x\n", Drhd->Flags )); - DEBUG ((DEBUG_INFO, - " Size ................................................. 0x%02x\n", - Drhd->Size - )); DEBUG ((DEBUG_INFO, " INCLUDE_PCI_ALL .................................... 0x%02x\n", Drhd->Flags & EFI_ACPI_DMAR_DRHD_FLAGS_INCLUDE_PCI_ALL )); + DEBUG ((DEBUG_INFO, + " Size ................................................. 0x%02x\n", + Drhd->Size + )); DEBUG ((DEBUG_INFO, " Segment Number ....................................... 0x%04x\n", Drhd->SegmentNumber diff --git a/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/VtdReg.c= b/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/VtdReg.c index 1b354e850..8e834f4c4 100644 --- a/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/VtdReg.c +++ b/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/VtdReg.c @@ -573,7 +573,6 @@ EnableDmar ( ) { UINTN Index; - UINT32 Reg32; UINTN VtdUnitBaseAddress; BOOLEAN TEWasEnabled; = @@ -615,7 +614,7 @@ EnableDmar ( // // Init DMAr Fault Event and Data registers // - Reg32 =3D MmioRead32 (mVtdUnitInformation[Index].VtdUnitBaseAddress + = R_FEDATA_REG); + MmioRead32 (mVtdUnitInformation[Index].VtdUnitBaseAddress + R_FEDATA_R= EG); = // // Write Buffer Flush before invalidation -- = 2.26.2.windows.1 --------------------------------------------------------------------- Intel Technology Poland sp. z o.o. ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc | VII Wydz= ial Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 | NIP 957-07-52-31= 6 | Kapital zakladowy 200.000 PLN. Spolka oswiadcza, ze posiada status duzego przedsiebiorcy w rozumieniu usta= wy z dnia 8 marca 2013 r. o przeciwdzialaniu nadmiernym opoznieniom w trans= akcjach handlowych. Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego adresata= i moze zawierac informacje poufne. W razie przypadkowego otrzymania tej wi= adomosci, prosimy o powiadomienie nadawcy oraz trwale jej usuniecie; jakiek= olwiek przegladanie lub rozpowszechnianie jest zabronione. This e-mail and any attachments may contain confidential material for the s= ole use of the intended recipient(s). If you are not the intended recipient= , please contact the sender and delete all copies; any review or distributi= on by others is strictly prohibited.