From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mx.groups.io with SMTP id smtpd.web10.3587.1689236400523779871 for ; Thu, 13 Jul 2023 01:20:00 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=dF0FafXH; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: robert.kowalewski@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1689236400; x=1720772400; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version:content-transfer-encoding; bh=kk8Kb6LqINga7GZgvPX23kLL7q17Aij6FRLz9zy71CI=; b=dF0FafXHnTrL0a6B7IsmiUtcbAXP7iNvP2aA0hEgvGQS0ZwdpGxoHXCP 1T6rzDxape2lq+ZBcQhIZGGQEpXXKMVRDue9ugOzwf8zMZ6ZPpKfKle5/ E11v/Lz1TcDxNQucPnWtUlGE+PWU3UJketBOZBrvwIuga2thV4aoDCpO+ aBEJsx8zCCIs+3CaY39qFk9/KHABdNHj2zTLcJqo5e6VIrneSLM98VDSA deFh5jl6I3FSCma+gOtameq8j2HpTcRQW8pibiGMb98LTE8530aIakOhQ JEmFIchHWIYc4L4prnK8wGFdIASbFjVQvIiG6OYNXEF+w80NJOSgK2atw w==; X-IronPort-AV: E=McAfee;i="6600,9927,10769"; a="368659596" X-IronPort-AV: E=Sophos;i="6.01,202,1684825200"; d="scan'208";a="368659596" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jul 2023 01:19:59 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10769"; a="845970523" X-IronPort-AV: E=Sophos;i="6.01,202,1684825200"; d="scan'208";a="845970523" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga004.jf.intel.com with ESMTP; 13 Jul 2023 01:19:59 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Thu, 13 Jul 2023 01:19:59 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Thu, 13 Jul 2023 01:19:59 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.109) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Thu, 13 Jul 2023 01:19:58 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MLoHRZRRwtonxKYOvhEgnj5sbGycrR4lZT2QzqeNmULzA4QSwpenzzjsjx7v0nNFNN1Y2M9HKo0tmSqKsw9pqUSreRSfWQlSPFqx24WvEXjS0IE7I9ncUAzBeJNvEpNEMC0/ZpPstOLTiRcvNtC7RSc8/hQuq3CgmN5xroQJzPoO0gIBvAUwARUJYmJM9OFa+MRvFEgUXL0N9bD5dIPUvJGT5r1yl7G9xrfXd7v9HaxN17Qnc2pXQLUuMxpMe2WNezIaqfPRqz4SOttWwvU/r/1/+cfhbe+cG9XnPiHUGgAWCx4z1roWFscRofIHFRDGPHSW2w3PBoA2D160dhCKBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=a8GbrP4CPcOW2VtKVIgNxvhPHcU9VFYRN92tQWP2MlQ=; b=J6TWbQGvyRBDc83HFKbGui/6456/MNPKItAW/9meqCUqUhpzptiJnG8PKjDZZ3qhKQrKB9cTCuwB/1JXgcvLdFsEgPzZZ58iR/fnAJBYTQUuFjVrhvQbfxB6AVa2TJvAJLFtzbxHgaboDFiQdQhaEcBEdUeQ809fS9fWGv22vayszXwtytuBoqmrpjP0YtC2NCat7GeCXIfGaO7zfLzCPS2Rt8shPZN3zB7RZeAgfWhCFf3tLxIaKCRQhz3tMP4ePWtgjS7In16qB7NfM3xABuZ+E3t5mpWB+iNy4jHOzWjC3YTsasDPgCkO6pX0oAEx7pduKSSxYFDMiWC3nDM4IQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BYAPR11MB3509.namprd11.prod.outlook.com (2603:10b6:a03:8e::25) by SJ0PR11MB5814.namprd11.prod.outlook.com (2603:10b6:a03:423::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6588.24; Thu, 13 Jul 2023 08:19:57 +0000 Received: from BYAPR11MB3509.namprd11.prod.outlook.com ([fe80::6f28:ebf4:56:fad4]) by BYAPR11MB3509.namprd11.prod.outlook.com ([fe80::6f28:ebf4:56:fad4%5]) with mapi id 15.20.6588.022; Thu, 13 Jul 2023 08:19:57 +0000 From: "Robert Kowalewski" To: "Huang, Jenny" , "Sheng, W" , "devel@edk2.groups.io" CC: "Ni, Ray" , "Chaganty, Rangasai V" Subject: Re: [PATCH] IntelSiliconPkg/Vtd: Resolve parameter transfer errors Thread-Topic: [PATCH] IntelSiliconPkg/Vtd: Resolve parameter transfer errors Thread-Index: AQHZtU4gndmAkI5F8U6H0iQUqFInG6+3NC0AgAAmsHA= Date: Thu, 13 Jul 2023 08:19:57 +0000 Message-ID: References: <20230713055133.794-1-w.sheng@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR11MB3509:EE_|SJ0PR11MB5814:EE_ x-ms-office365-filtering-correlation-id: c18a72da-aabc-4783-5acc-08db8379f19a x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 7vmTAvsLRgwLZ4eUy8hGHI7VR3ep2IFvSZs9BLPVgC3tP6eUY6zTKCnMtHGWP+ujxuuwXW6PuT04FSO1uvW9y9zxpz9L61ziEySWzDdf6W8l3KBJDKityetuQrZSJtZ/qjuJI1EDNklqgPHCbT1B7UMlKgMoe4uHclUlQ5K/9eDxHZ2ViI0kLpvNMVJuRQLZYGnBRYpbvkUtD1AHw1suw/dbaNcqjEF+x2QQ3l98VDQLhP9tLR6g9U0RyfDVXHNFe8elQNoxKogbYH7qNcnI64RrGcNq7ISNnW/8x2TAyJ/Xs5BHVRc/VDyksp+8MGB3bqP6vpywzWTjCed65fAHt5R3tkDZcq5pk8faVisaaQ5cwVaDtPAhtW3rUAwFx8tDfnzibTpnGe1ybdx0WxpZ0RnsuGIBGvjRnhVmUHFh5FP/uLJHmDy2GuDMXOQGSyvWG6N3jIfzbflhGJT6PaB9Uv0ce4A2DdL+G19Xzy+4qKdeAxQgwdnml2H/rjbT9Gscaguj3qKdo9gxlPMJ+0EQAo9VdY0f/bpN9ymYCd0303oTgnXGtSJnE/Hp8S+SjVy9SuUf+BTZYsknHwZ9E5RJ/neULrol3yTBTuyOK9s+dBKC2Ea6kceZeERENHJ58xUr x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR11MB3509.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(376002)(136003)(346002)(39860400002)(366004)(396003)(451199021)(38100700002)(122000001)(82960400001)(86362001)(33656002)(38070700005)(55016003)(8936002)(52536014)(26005)(5660300002)(6506007)(107886003)(110136005)(54906003)(53546011)(8676002)(41300700001)(186003)(2906002)(83380400001)(316002)(66556008)(66946007)(76116006)(71200400001)(4326008)(9686003)(478600001)(7696005)(66476007)(66446008)(64756008);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?26yl4v1xLk3Ap4QAqwZf+CikeOdo0H50ry8I28X6P8X0U2Gpo/N2MTGgtUjp?= =?us-ascii?Q?0r7ApDquHhhUWG7XRGb1ZxyQN3OlUZ1TsE1mbpghHnEqmf8pFfoviw35Ij7e?= =?us-ascii?Q?O0fMlwU7MWny6lEWp7QAU+Va9HDnat53dYrA6sIUKIBHMvoER09OzZDhX1w6?= =?us-ascii?Q?c6h6pjayucfq3Fq37cHB7tda145FeqHGw7cG5r2x6RjZppGLeSXA2twZsdfT?= =?us-ascii?Q?tcxKB0315Al/yxvaG2AwuNO/na8jz+BTrVw4hYJNCaRXOg7d2mJfOB0DsAO7?= =?us-ascii?Q?QM0gkgJcrRCMmnSUHWOClZ/S9GSCNmqfce+m4/96etu8TCyfhKoR/tl1it6O?= =?us-ascii?Q?boxHa6FuODN/nYPW5G5t5HhbUNYZATt5xk8rDA/tubmHClvMWJVTC/tv25Qn?= =?us-ascii?Q?Yl9D3wLbapIblHWskNHVt+rcBb5vXGcxq2Yup9N1I1s6b824P8sdzcEGn7Dn?= =?us-ascii?Q?UC6KRKc5xSGm6akG4oqtp5XlA2d4EPMQTBXyfJZVDpao9tbiH5PbZaKBco9j?= =?us-ascii?Q?Gf6Ms6Yl1RAeX70gkEBAgG/CA1WumzqI2OZp8p3XVNEwQqKMcFYvdq5CTlSn?= =?us-ascii?Q?L83H4lKK4xzrPIXWgzvBj0LiiSAL4aIPDz0P3C2cT0Pq926Upgd2gBZaKfKG?= =?us-ascii?Q?HKsh2+y191vtv4HNBg7NnWFutz1DqqBCrPk32yYK0SCf3o4sQf5cO8b+f1rm?= =?us-ascii?Q?UfLEbm7UWZOAXbRt7vsay9+qBdYKaUQNBPVZHOodf8GWbdJlcYHG4xtxabez?= =?us-ascii?Q?1H/2oEzLhZhRDv1CD/1ruKy54J9Wgc32xVvgNbl70Gn0LtPMKDPUVGDSkAF4?= =?us-ascii?Q?o7Q4wC1Y9AchHkwEx1XL4mrsTyrwincsRb3NoiLLlUs8NMQn5ShY3DFYezgS?= =?us-ascii?Q?bmzdLglklNnYd09Qg1viKIpcV0/d4lK/UXYVCFOSVHmbcNsLhz4rqOFxBKjH?= =?us-ascii?Q?kUGTvMZj6d5inIXZAmqGale3OtS9GOum8n/DDX3ZpY5cUErSnJYE6lf2BPRS?= =?us-ascii?Q?I+fG3JRIQR/wQt36/7SIPdU3nZ9PU8idrB3rU/f5I9lfrDAw108JfVLjm4pg?= =?us-ascii?Q?n+nyMd+aX4CkIgV/5FFmhMWkRcanwlXNowZSLK8lvIED5qhZLuYHHq4WtVI7?= =?us-ascii?Q?fcSAqJ+5U4cxZvwhP93zQdQ8Yy6Buh8rgo0bIDFozkIvJXXZ241fP80Fpjqy?= =?us-ascii?Q?i7IZH0QzsZhXUdzyR5Jm1mA/akINcpA4oe8M2gd1TnUDyrjymAwOCPw18p18?= =?us-ascii?Q?0Yt0THq2WqHyH3WbMNRfhkk3cTqXn5AUB8vVVlfMnm0qF6HTituHMO2WHk7E?= =?us-ascii?Q?/5Tb/BALn1uWhfrTK1iWwcvBxLAzH0Uz0lM8SrEOVAEjA36us6gbxWWGjyt1?= =?us-ascii?Q?ebeoZ2vW9pRPiFMtQy3jgY+sJyhbQk3kfebiFeNQsIGKrF8bX6e63o/cwqkf?= =?us-ascii?Q?X6dQuXzvW2nGbjS5pBk1ZOL0JtVyYmk8dCVd052bl9AtriTxHwD0ssB65SbW?= =?us-ascii?Q?j/8nDlXCdIUMIIyp1SyCFFk6ztsGgeJeJLBEIhQxfWE3uiZIxS23pQybLLkK?= =?us-ascii?Q?LoW9IsopHTcTd2A0O6yz9BSqRAtRl1BYqrFUAtnzsrgNyLaDNy23ceaDGY9U?= =?us-ascii?Q?bw=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3509.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c18a72da-aabc-4783-5acc-08db8379f19a X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jul 2023 08:19:57.0424 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: rwtpTr1ve1mnNWczTV52Tt6SU3UMhz/oSvnPJ4Ok2zol6iCIGkSP9jRFA0p6qnmAq4+TRMpfkSVJkvmIsVsYPs4OkykxGzb1b5tka7R6dIU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5814 Return-Path: robert.kowalewski@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed by Robert Kowalewski -----Original Message----- From: Huang, Jenny = Sent: Thursday, July 13, 2023 8:01 AM To: Sheng, W ; devel@edk2.groups.io Cc: Ni, Ray ; Chaganty, Rangasai V ; Kowalewski, Robert Subject: RE: [PATCH] IntelSiliconPkg/Vtd: Resolve parameter transfer errors Reviewed by Jenny Huang -----Original Message----- From: Sheng, W = Sent: Wednesday, July 12, 2023 10:52 PM To: devel@edk2.groups.io Cc: Ni, Ray ; Chaganty, Rangasai V ; Huang, Jenny ; Kowalewski, Robert Subject: [PATCH] IntelSiliconPkg/Vtd: Resolve parameter transfer errors Fix the capsule update assert caused by function call errors. Cc: Ray Ni Cc: Rangasai V Chaganty Cc: Jenny Huang Cc: Robert Kowalewski Signed-off-by: Sheng Wei --- .../Intel/IntelSiliconPkg/Feature/VTd/IntelVTdCoreDxe/VtdReg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdCoreDxe/VtdR= eg.c b/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdCoreDxe/VtdReg.c index dd0c49698..f05ca6ae5 100644 --- a/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdCoreDxe/VtdReg.c +++ b/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdCoreDxe/VtdReg.c @@ -737,7 +737,7 @@ DumpVtdIfError ( if (HasError) { REPORT_STATUS_CODE (EFI_ERROR_CODE, PcdGet32 (PcdErrorCodeVTdError)); DEBUG((DEBUG_INFO, "\n#### ERROR ####\n")); - DumpVtdRegs (Num); + DumpVtdRegs (mVtdUnitInformation[Num].VtdUnitBaseAddress); DEBUG((DEBUG_INFO, "#### ERROR ####\n\n")); // // Clear -- = 2.26.2.windows.1 --------------------------------------------------------------------- Intel Technology Poland sp. z o.o. ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc | VII Wydz= ial Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 | NIP 957-07-52-31= 6 | Kapital zakladowy 200.000 PLN. Spolka oswiadcza, ze posiada status duzego przedsiebiorcy w rozumieniu usta= wy z dnia 8 marca 2013 r. o przeciwdzialaniu nadmiernym opoznieniom w trans= akcjach handlowych. Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego adresata= i moze zawierac informacje poufne. W razie przypadkowego otrzymania tej wi= adomosci, prosimy o powiadomienie nadawcy oraz trwale jej usuniecie; jakiek= olwiek przegladanie lub rozpowszechnianie jest zabronione. This e-mail and any attachments may contain confidential material for the s= ole use of the intended recipient(s). If you are not the intended recipient= , please contact the sender and delete all copies; any review or distributi= on by others is strictly prohibited.