Re: [edk2-devel] [PATCH] Maintainers.txt: Update reviewer email address

["Rabeda, Maciej" <maciej.rabeda@intel.com>]

Laszlo,

Thanks for a thorough explanation of the process :)
It looks like one extra step for maintainership transition seems is identified: 
"However (AIUI), the mergify bot will reject and close any PR with the "push" label set if the PR was not submitted by a maintainer in the first place"

For maintainer identification process, where does the mergify bot get the maintainer list from?
Do you know who should I ask to be added to that list?

Thanks!
Maciej

-----Original Message-----
From: Laszlo Ersek <lersek@redhat.com> 
Sent: Tuesday, December 10, 2019 13:37
To: Rabeda, Maciej <maciej.rabeda@intel.com>; devel@edk2.groups.io; Wu, Jiaxin <jiaxin.wu@intel.com>; Maciej Rabeda <maciej.rabeda@linux.intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming <liming.gao@intel.com>
Cc: Fu, Siyuan <siyuan.fu@intel.com>
Subject: Re: [edk2-devel] [PATCH] Maintainers.txt: Update reviewer email address

On 12/10/19 10:32, Rabeda, Maciej wrote:
> Laszlo,
> 
> Understood, Jiaxin and I have successfully went with one patch via PR flow already.
> I was wondering whether any extra actions are required so that I will be able to apply 'push' label to my/other contributor's pull requests to tianocore/edk2.

Important detail: at this stage, we are not dealing with github.com pull requests from *others*. Only following use cases are in scope:

(1) maintainer submits a PR, or reopen a PR they submitted earlier, for the purposes of a personal CI build (no "push" label)

(2) same as (1), except with the "push" label set, for the purposes of an actual fast-forward merge (not just personal CI build); with the topic branch that's subject to the merge consisting purely of patches that have been posted *and reviewed* earlier on the list.

(3) same as (1), except with "non-maintainer contributor" replacing "maintainer"

A PR, submitted by anyone for the edk2 project on github.com, such that it does not fall in any of the above categories, should be rejected, just like before. Patch submission and review continues on the mailing list.

To put differently, you should *only* set the push label on a PR that:
- you have submitted / reopened yourself; and
- the topic branch subject to the merge consists only of patches that you authored, or applied from others from the list, *and* have been reviewed on the list; and
- the topic branch subject to the merge carries all the feedback tags given on the list (such as Tested-by, Acked-by, Reviewed-by).

Basically, as a maintainer, you need to:
- follow the list,
- once there are approved patches for NetworkPkg, pick them up with "git-am" in a local topic branch,
- rebase the local topic branch with "git-rebase", so you can apply the R-b / T-b / A-b tags from the list to the commit messages,
- push the above topic branch to your own github repo,
- submit a PR for the topic branch,
- set the "push" label on the PR.

"pick up patches from the list" and "pick up feedback tags from the list" are *not* optional.

> I assume that the list of people that can apply that label is limited to EDK II Maintainers or is my assumption wrong?

Technically, anyone can create a pull request, and my understanding is that anyone can set the "push" label on their pull request.

However (AIUI), the mergify bot will reject and close any PR with the "push" label set if the PR was not submitted by a maintainer in the first place.

Thanks
Laszlo

--------------------------------------------------------------------

Intel Technology Poland sp. z o.o.
ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc | VII Wydzial Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 | NIP 957-07-52-316 | Kapital zakladowy 200.000 PLN.

Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego adresata i moze zawierac informacje poufne. W razie przypadkowego otrzymania tej wiadomosci, prosimy o powiadomienie nadawcy oraz trwale jej usuniecie; jakiekolwiek
przegladanie lub rozpowszechnianie jest zabronione.
This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). If you are not the intended recipient, please contact the sender and delete all copies; any review or distribution by
others is strictly prohibited.