From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mx.groups.io with SMTP id smtpd.web11.10847.1575990115295315505 for ; Tue, 10 Dec 2019 07:01:55 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=dM5YYszt; spf=pass (domain: intel.com, ip: 192.55.52.88, mailfrom: maciej.rabeda@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Dec 2019 07:01:31 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,300,1571727600"; d="scan'208";a="295914043" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga001.jf.intel.com with ESMTP; 10 Dec 2019 07:01:30 -0800 Received: from fmsmsx126.amr.corp.intel.com (10.18.125.43) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 10 Dec 2019 07:01:30 -0800 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by FMSMSX126.amr.corp.intel.com (10.18.125.43) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 10 Dec 2019 07:01:30 -0800 Received: from NAM04-BN3-obe.outbound.protection.outlook.com (104.47.46.55) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 10 Dec 2019 07:01:30 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=l7NvkOgD8oMnhcNz9acBkQ36M7guxJXK4vwa9bkHcqD82jcA0D5H/WIS2qe8ejtnA2kxLjt6NRD/hutMXZ35qv6cyaHZ3uUICM4rb7gai+y5Qh6XWyZel7SLojCdhibEs/7ZOJSIJP2Dq+7n675EZGzPHZRzsbOVeudG4oZ+BCihusNKqRF+94DhGDvNvVLUEBAJCpGZd+Yv4JPUzEaUmcg5sYn6PbFUeq4jVA/6KK36QpH2zomnEMF18xVShfhXM5PkS3Y//Gk36R6T4QKL/pnf8DHF1+ZXEPCtJwQnQM/9U65c7u7IGr0zl4JGIrz2vcIwglm+gctKmp07sDdTEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RQFT0OUiwM67lVku5Yi/y2RWJe5uFdrBEkRfC7jg8hg=; b=HLFP3sjStMgnMUfV7ObBV6GoskB7Z13ePoGnhpSQ7Rg3ngDENAHkN4oz8ezjzUmc5O5xksy2radsVjXP6cBuKByc868M1bemooRra2sxzeILxJPvJ/jlDliVI7V9uE9VJ5+gvRPn/pooQavXVbFUr34nwSaguFtrmG/sHhmLPSkKs/rY2rqnMjiseQqeE+p9Z/8hLWSIbLjFi+TuaSJ3Lupd6jQD/s7XbvHtTB0oRcNA0orFL7+vdpkq20lg0oT6t8+/pyr/pDS1Hg57WuukCpW/is4CpUS2VmIrq+zYYaRAzDEFmqNUcA35A+hOAH52Er6Bf6DBtvaENlurFscsew== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RQFT0OUiwM67lVku5Yi/y2RWJe5uFdrBEkRfC7jg8hg=; b=dM5YYsztSplZIGhAS/rWUSdA8F51jz7fFzvCV/lT1e2tseh2boECMG2KEemSp5878Z0W0BeEIFj+PP2TYup10NmObu0caBORYHHd1OjShN7Z9mRjdm5zkGVe5PlRxIBCGGOpgt0D3Qfk1GJQ4AnpeJ+G2VoshKYQ7z0aYldbpRM= Received: from BYAPR11MB3527.namprd11.prod.outlook.com (20.177.226.90) by BYAPR11MB2631.namprd11.prod.outlook.com (52.135.223.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2538.14; Tue, 10 Dec 2019 15:01:14 +0000 Received: from BYAPR11MB3527.namprd11.prod.outlook.com ([fe80::710d:6e83:7ce:6f3c]) by BYAPR11MB3527.namprd11.prod.outlook.com ([fe80::710d:6e83:7ce:6f3c%6]) with mapi id 15.20.2516.017; Tue, 10 Dec 2019 15:01:14 +0000 From: "Rabeda, Maciej" To: Laszlo Ersek , "devel@edk2.groups.io" , "Wu, Jiaxin" , Maciej Rabeda , "Kinney, Michael D" , "Gao, Liming" CC: "Fu, Siyuan" Subject: Re: [edk2-devel] [PATCH] Maintainers.txt: Update reviewer email address Thread-Topic: [edk2-devel] [PATCH] Maintainers.txt: Update reviewer email address Thread-Index: AQHVrFJuxG2GIZdga0mj8hME+xvvEqey30WAgAAwaYCAAAsbAIAABKoggAA03oCAACcDwA== Date: Tue, 10 Dec 2019 15:01:13 +0000 Message-ID: References: <20191206162855.2155-1-maciej.rabeda@linux.intel.com> <895558F6EA4E3B41AC93A00D163B727416FBF2B4@SHSMSX107.ccr.corp.intel.com> <077c152f-22f8-ce29-ccaa-10874d5e8381@redhat.com> In-Reply-To: <077c152f-22f8-ce29-ccaa-10874d5e8381@redhat.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNDEwMjk2MTgtNDlhOC00ODNlLTkzOTUtYzlhNjQ0NDhiOGU0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiM3JsbERLQW1TVXNLUkI0VE5wN20zRVRwV0pwRVNkdysyUG9vQ2F6WHJVVUw5OUNHOGV1RE9TWE1YMGdkakF4NSJ9 dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: spf=none (sender IP is ) smtp.mailfrom=maciej.rabeda@intel.com; x-originating-ip: [134.191.221.96] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 76c03f42-e4b8-4386-9b68-08d77d81cd0a x-ms-traffictypediagnostic: BYAPR11MB2631: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-forefront-prvs: 02475B2A01 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(366004)(13464003)(199004)(189003)(7696005)(2906002)(55016002)(52536014)(6506007)(15650500001)(71200400001)(26005)(5660300002)(6636002)(86362001)(53546011)(110136005)(66556008)(66446008)(66476007)(64756008)(33656002)(81166006)(81156014)(8936002)(8676002)(76116006)(66946007)(186003)(4326008)(498600001)(9686003);DIR:OUT;SFP:1102;SCL:1;SRVR:BYAPR11MB2631;H:BYAPR11MB3527.namprd11.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: RK9I/W8CIjyD1RPQOLrRH+w0Vh3FTtfm1r6gSuH1ApG+xgSNmSVnZTY7Y3DTuqd4atjrv5Z72e6ktTKj/+mAUsTAHw9U+viEpkbe0sz0xfrXU7KjvzdSpH7S6UaLyeQ9NcgRf5dmkmvUvZlDxKfr1QVZomBYomDeVXX5FbouZVdOq0hJS1VE6rAXcWK8Aq/mMExcvr8UYuHItdRqau7U246tyNS/SWiIE5THpiFvpkUEdG32E9DWCcZ0NiLb9fbWr8UDih2C0M6DU1IHoXr88MrVWYKdO/LGWmLP4fSrmnx+JJlL01KJD2OGK7gdAd55IqubIRi6YbVWItjDoXiurnoK7PgxTuOFc283GI/ckaxwx7JxZ8swQ0duLIMGKIaTgz/Uq3DBEy1pMgL/qpBPSu6/9Ht2Mf/cpLCoZNSRv9OYifOV8P3dNSVPsFkqFnKIjzNzXxHvJqsPPWd8DEbwOyjtp4e9JI/z+WKPaF0ET20zPXDsplXbLPxkRV4bwQbH MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 76c03f42-e4b8-4386-9b68-08d77d81cd0a X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Dec 2019 15:01:13.8733 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: vatE+cV/FQpgx6JTDRPLAShLQ9uFGCzBFs0zravlfpzaNinqt7T1YGm6lqhqJWo57uI/yCw9VlNi17yDnOS9+Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB2631 Return-Path: maciej.rabeda@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Laszlo, Thanks for a thorough explanation of the process :) It looks like one extra step for maintainership transition seems is identif= ied: = "However (AIUI), the mergify bot will reject and close any PR with the "pus= h" label set if the PR was not submitted by a maintainer in the first place" For maintainer identification process, where does the mergify bot get the m= aintainer list from? Do you know who should I ask to be added to that list? Thanks! Maciej -----Original Message----- From: Laszlo Ersek = Sent: Tuesday, December 10, 2019 13:37 To: Rabeda, Maciej ; devel@edk2.groups.io; Wu, Jia= xin ; Maciej Rabeda ; K= inney, Michael D ; Gao, Liming Cc: Fu, Siyuan Subject: Re: [edk2-devel] [PATCH] Maintainers.txt: Update reviewer email ad= dress On 12/10/19 10:32, Rabeda, Maciej wrote: > Laszlo, > = > Understood, Jiaxin and I have successfully went with one patch via PR flo= w already. > I was wondering whether any extra actions are required so that I will be = able to apply 'push' label to my/other contributor's pull requests to tiano= core/edk2. Important detail: at this stage, we are not dealing with github.com pull re= quests from *others*. Only following use cases are in scope: (1) maintainer submits a PR, or reopen a PR they submitted earlier, for the= purposes of a personal CI build (no "push" label) (2) same as (1), except with the "push" label set, for the purposes of an a= ctual fast-forward merge (not just personal CI build); with the topic branc= h that's subject to the merge consisting purely of patches that have been p= osted *and reviewed* earlier on the list. (3) same as (1), except with "non-maintainer contributor" replacing "mainta= iner" A PR, submitted by anyone for the edk2 project on github.com, such that it = does not fall in any of the above categories, should be rejected, just like= before. Patch submission and review continues on the mailing list. To put differently, you should *only* set the push label on a PR that: - you have submitted / reopened yourself; and - the topic branch subject to the merge consists only of patches that you a= uthored, or applied from others from the list, *and* have been reviewed on = the list; and - the topic branch subject to the merge carries all the feedback tags given= on the list (such as Tested-by, Acked-by, Reviewed-by). Basically, as a maintainer, you need to: - follow the list, - once there are approved patches for NetworkPkg, pick them up with "git-am= " in a local topic branch, - rebase the local topic branch with "git-rebase", so you can apply the R-b= / T-b / A-b tags from the list to the commit messages, - push the above topic branch to your own github repo, - submit a PR for the topic branch, - set the "push" label on the PR. "pick up patches from the list" and "pick up feedback tags from the list" a= re *not* optional. > I assume that the list of people that can apply that label is limited to = EDK II Maintainers or is my assumption wrong? Technically, anyone can create a pull request, and my understanding is that= anyone can set the "push" label on their pull request. However (AIUI), the mergify bot will reject and close any PR with the "push= " label set if the PR was not submitted by a maintainer in the first place. Thanks Laszlo -------------------------------------------------------------------- Intel Technology Poland sp. z o.o. ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc | VII Wydz= ial Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 | NIP 957-07-52-31= 6 | Kapital zakladowy 200.000 PLN. Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego adresata= i moze zawierac informacje poufne. W razie przypadkowego otrzymania tej wi= adomosci, prosimy o powiadomienie nadawcy oraz trwale jej usuniecie; jakiek= olwiek przegladanie lub rozpowszechnianie jest zabronione. This e-mail and any attachments may contain confidential material for the s= ole use of the intended recipient(s). If you are not the intended recipient= , please contact the sender and delete all copies; any review or distributi= on by others is strictly prohibited.