From: "Guo Dong" <guo.dong@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"marcello.bauer@9elements.com" <marcello.bauer@9elements.com>
Cc: Patrick Rudolph <patrick.rudolph@9elements.com>,
Christian Walter <christian.walter@9elements.com>,
"Ma, Maurice" <maurice.ma@intel.com>,
"Desimone, Nathaniel L" <nathaniel.l.desimone@intel.com>,
"Zeng, Star" <star.zeng@intel.com>
Subject: Re: [edk2-devel] [PATCH v2 1/1] UefiPayloadPkg: Remove x86 legacy UART defaults
Date: Mon, 13 Jul 2020 16:07:01 +0000 [thread overview]
Message-ID: <BYAPR11MB36220C840C0FE821284BC5859E600@BYAPR11MB3622.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20200713082522.5168-2-marcello.bauer@9elements.com>
Reviewed-by: Guo Dong <guo.dong@intel.com>
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Marcello
> Sylvester Bauer
> Sent: Monday, July 13, 2020 1:25 AM
> To: devel@edk2.groups.io
> Cc: Patrick Rudolph <patrick.rudolph@9elements.com>; Christian Walter
> <christian.walter@9elements.com>; Ma, Maurice <maurice.ma@intel.com>;
> Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Zeng, Star
> <star.zeng@intel.com>
> Subject: [edk2-devel] [PATCH v2 1/1] UefiPayloadPkg: Remove x86 legacy UART
> defaults
>
> From: Patrick Rudolph <patrick.rudolph@9elements.com>
>
> The BaseSerialPortLib16550 does fallback to a fixed address UART defined
> by PcdSerialRegisterBase and does not initialize if it is zero. Do not
> assume a serial port at 0x3F8, otherwise it could cause errors during
> initialisation of a non-existent serial port on non legacy platforms.
>
> Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>
> Signed-off-by: Marcello Sylvester Bauer <marcello.bauer@9elements.com>
> Cc: Patrick Rudolph <patrick.rudolph@9elements.com>
> Cc: Christian Walter <christian.walter@9elements.com>
> Cc: Maurice Ma <maurice.ma@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> ---
> UefiPayloadPkg/UefiPayloadPkgIa32.dsc | 2 +-
> UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/UefiPayloadPkg/UefiPayloadPkgIa32.dsc
> b/UefiPayloadPkg/UefiPayloadPkgIa32.dsc
> index 0efcfa8fb2f4..0d8854810700 100644
> --- a/UefiPayloadPkg/UefiPayloadPkgIa32.dsc
> +++ b/UefiPayloadPkg/UefiPayloadPkgIa32.dsc
> @@ -306,7 +306,7 @@ [PcdsPatchableInModule.common]
> # The following parameters are set by Library/PlatformHookLib
>
> #
>
> gEfiMdeModulePkgTokenSpaceGuid.PcdSerialUseMmio|FALSE
>
> - gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterBase|0x3f8
>
> + gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterBase|0
>
> gEfiMdeModulePkgTokenSpaceGuid.PcdSerialBaudRate|$(BAUD_RATE)
>
> gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterStride|1
>
>
>
> diff --git a/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc
> b/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc
> index d645d233cd08..34640b1fc1da 100644
> --- a/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc
> +++ b/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc
> @@ -307,7 +307,7 @@ [PcdsPatchableInModule.common]
> # The following parameters are set by Library/PlatformHookLib
>
> #
>
> gEfiMdeModulePkgTokenSpaceGuid.PcdSerialUseMmio|FALSE
>
> - gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterBase|0x3f8
>
> + gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterBase|0
>
> gEfiMdeModulePkgTokenSpaceGuid.PcdSerialBaudRate|$(BAUD_RATE)
>
> gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterStride|1
>
>
>
> --
> 2.27.0
>
>
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
>
> View/Reply Online (#62410): https://edk2.groups.io/g/devel/message/62410
> Mute This Topic: https://groups.io/mt/75472935/1781375
> Group Owner: devel+owner@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub [guo.dong@intel.com]
> -=-=-=-=-=-=
prev parent reply other threads:[~2020-07-13 16:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-13 8:25 [PATCH v2 0/1] Remove x86 legacy UART defaults Marcello Sylvester Bauer
2020-07-13 8:25 ` [PATCH v2 1/1] UefiPayloadPkg: " Marcello Sylvester Bauer
2020-07-13 15:27 ` Ma, Maurice
2020-07-13 16:07 ` Guo Dong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR11MB36220C840C0FE821284BC5859E600@BYAPR11MB3622.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox