From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mx.groups.io with SMTP id smtpd.web11.16.1594656429060438160 for ; Mon, 13 Jul 2020 09:07:09 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=Fu7t2F2T; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: guo.dong@intel.com) IronPort-SDR: ci4IHpfp9wi01g3B2DQjiT7CJzCEjl9fWtdwqULPLqXgkmweq+9PRHRswa9ZMLXa86xMgwOOiy kNeuskTg85iQ== X-IronPort-AV: E=McAfee;i="6000,8403,9681"; a="146126575" X-IronPort-AV: E=Sophos;i="5.75,348,1589266800"; d="scan'208";a="146126575" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jul 2020 09:07:04 -0700 IronPort-SDR: Rxlp7x7xCwCkpKX/8f+vC1BGbACvIj2HJv/bFl1wVweFqHakLcn0KOhmgI7LSh5z5BeizW3oPo AHkaGEnTQ3Tw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,348,1589266800"; d="scan'208";a="429438694" Received: from orsmsx108.amr.corp.intel.com ([10.22.240.6]) by orsmga004.jf.intel.com with ESMTP; 13 Jul 2020 09:07:03 -0700 Received: from ORSEDG001.ED.cps.intel.com (10.7.248.4) by ORSMSX108.amr.corp.intel.com (10.22.240.6) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 13 Jul 2020 09:07:02 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.43) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 13 Jul 2020 09:07:02 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IyNRXiJKQPZ+RVh4oHtgNoy09KeyA5faIcVwBb4KjnC0NCuE7QqNbr5o8/oAVjUAWVnG0UE427CP4nbqPmjG75JZbfxknQYQWdIC6gTtnFxk2SDG+QvAi3+onwNhk3L1Zbud2TSQNtNadTg4b8Y4vCGSeXc/yY5FaSMVaiXKRe1qCTDmMyb8H5hdzA44B346qnrpAnBddIb+Y6Y9+C3NPgywcImbEBM/C+MxUCL8jpSfKYcDbMJHOgu2emsWrwGdKif1UcJEoQp2+klVydtNIS8DC6P/y0ADLJcIY8WohAiDbXxuk3zbKLZ4Yh+PwZiYR5j/u//52Y8Z+RlC+3YuPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ks7mZwiPy0fslLExkcxgOvukdwE3bbfrjjjunNshjxc=; b=a/qH21SZgj/pGYqhm0LZzuatvq0Dym3xuSRiXm7HIH9hvD/j5ndPWPcAKMkttE/w2o8zuZyn2dyKrJZALdf/7BE8jEPBQs58l2AoDYM3YFNVRkAeumM+MAfaRB76JRa7RDdZ1n5FN1EV9Z5PDpyTu/rw1gLpe8umD2MJPf44HYV8vfbzjf0EHFZ1xo/pe67rtNS2GYeHJ7ORh6e9iSBYdP4VHAo0EeMYg66fMP4KrFNFcqtce00pmLYfPm6G2z9ks6z+oF/vQhjOpmgLNSxk1xjqDpWgFR6gxxnSH2019RPubcd4T5AcmgXIB5LvH0+Cg7LGIDLiL1fSpKXPzMo/DA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ks7mZwiPy0fslLExkcxgOvukdwE3bbfrjjjunNshjxc=; b=Fu7t2F2ToGNS5lxFh/rPP94Q5cfMancKyXiJMetrxmXQK5XTtkHzY9IGdLmn4dkRhtQ6NGgiMeXi8hNuANPrCNdhjzjr74Qs2b/AeYW1KxKhuSMHWrlyr3bVxHwGB78i1ck5ivBwqs2twG9NIYaAoRWK7rC9o6h1gaq23QMLwuo= Received: from BYAPR11MB3622.namprd11.prod.outlook.com (2603:10b6:a03:fe::30) by BYAPR11MB2728.namprd11.prod.outlook.com (2603:10b6:a02:ca::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3174.23; Mon, 13 Jul 2020 16:07:01 +0000 Received: from BYAPR11MB3622.namprd11.prod.outlook.com ([fe80::edcc:d9ab:61a6:bd13]) by BYAPR11MB3622.namprd11.prod.outlook.com ([fe80::edcc:d9ab:61a6:bd13%3]) with mapi id 15.20.3174.025; Mon, 13 Jul 2020 16:07:01 +0000 From: "Guo Dong" To: "devel@edk2.groups.io" , "marcello.bauer@9elements.com" CC: Patrick Rudolph , Christian Walter , "Ma, Maurice" , "Desimone, Nathaniel L" , "Zeng, Star" Subject: Re: [edk2-devel] [PATCH v2 1/1] UefiPayloadPkg: Remove x86 legacy UART defaults Thread-Topic: [edk2-devel] [PATCH v2 1/1] UefiPayloadPkg: Remove x86 legacy UART defaults Thread-Index: AQHWWO8wrwDHLNUx90Gsq8c2IFxPuKkFrTAg Date: Mon, 13 Jul 2020 16:07:01 +0000 Message-ID: References: <20200713082522.5168-1-marcello.bauer@9elements.com> <20200713082522.5168-2-marcello.bauer@9elements.com> In-Reply-To: <20200713082522.5168-2-marcello.bauer@9elements.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-originating-ip: [68.2.51.172] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 02c7dc78-f31a-42be-b971-08d82746c739 x-ms-traffictypediagnostic: BYAPR11MB2728: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:483; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: xia7buP8m5ilIf/DKuqM5pbk6sGjR0xzkOei1GW1ckDO047AoQQIoOEu2XsUtc357Q+2dHO30rCXjaAvvC63jRUmA+VaZkB+qr8+1/LPpRpaoIF44iVy/ibON6DyRON6Qi50Ljx1NYd93ICwfsE++eM6hT0kpSdq2/6uj87rABttcdLgMLs8+BXNfUEl7v+/f3XAuyaI1iUv9+gKyxhH07whdwBbD0/4l55rCCVZ26+Qjj/0ZbR2um5LmCdaY+Xh7w5Lu5+Lda2B3MY4z+l6PFh1MS4MsuakcER0KF4teFyDtgDKZ/G4xI2OmGKUzbFcmaK1J1dai352YYIhN8KkQVJWhiTu9hicLHCj37msxMsp8lPKVze0CpoQ0846bLPQyYFBmRDj3ucitRdnSLukwQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR11MB3622.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(136003)(396003)(366004)(39860400002)(376002)(346002)(7696005)(8676002)(55016002)(6506007)(53546011)(107886003)(26005)(54906003)(83380400001)(33656002)(9686003)(19627235002)(186003)(4326008)(966005)(8936002)(66946007)(71200400001)(76116006)(66476007)(66446008)(66556008)(64756008)(110136005)(316002)(478600001)(2906002)(5660300002)(86362001)(52536014);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: ozwMZflNPHWBnBzxZiIJKITKsR8Lep68KCjyQfMZfNxz1NVzLK2/GTh1L15OtagXpCyXu43dvWzCG+QHCM7o2YnrIXkkRSLZQdxVWtX0i2d0KY+NFOCmlRBC+OC9jng8B1FrIFNWonDMTi/jp6qdX7/qapBy2d+ob/lQ5hSijkelHsT/xURy0HFkUdJwdpqhD/TzCGO+8JAL38UKbpMBXAJQRYsbTDXIF+Rt4Hqve4rgz02SM0y6PemkqytEmWpGUjCMKCgdMnmUxJuuxCu03Aw9TvkOFI1v+WNdfpztaF6FR5DCPa/U7+XCGhq+b/YdFvBG8fWhCtBhhlSF0TZ4DLa1ZGewr2DYZYmnUFiKFiSyR9PTndWtiFIV8N89c/guLxdOQOQll9pHPW6sCWCT86PnJqPLrL6AunXqlM5niFhSg7UEzBahy3uQsb0s3Oa76wIwnaY3FcF6ozfqlaDLWLcV8vvGpALPOY/YJRx4NyI= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3622.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 02c7dc78-f31a-42be-b971-08d82746c739 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jul 2020 16:07:01.4719 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ZDjLEmglM9Uk9FAdDZ8iP9dWiOId7jjT75n/5jkrb9u7rR06DosVcCtRzupgW/NCPsTaqwW5y+q4uAgc8AHpSg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB2728 Return-Path: guo.dong@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Guo Dong > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Marcello > Sylvester Bauer > Sent: Monday, July 13, 2020 1:25 AM > To: devel@edk2.groups.io > Cc: Patrick Rudolph ; Christian Walter > ; Ma, Maurice ; > Desimone, Nathaniel L ; Zeng, Star > > Subject: [edk2-devel] [PATCH v2 1/1] UefiPayloadPkg: Remove x86 legacy UA= RT > defaults >=20 > From: Patrick Rudolph >=20 > The BaseSerialPortLib16550 does fallback to a fixed address UART defined > by PcdSerialRegisterBase and does not initialize if it is zero. Do not > assume a serial port at 0x3F8, otherwise it could cause errors during > initialisation of a non-existent serial port on non legacy platforms. >=20 > Signed-off-by: Patrick Rudolph > Signed-off-by: Marcello Sylvester Bauer > Cc: Patrick Rudolph > Cc: Christian Walter > Cc: Maurice Ma > Cc: Nate DeSimone > Cc: Star Zeng > --- > UefiPayloadPkg/UefiPayloadPkgIa32.dsc | 2 +- > UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/UefiPayloadPkg/UefiPayloadPkgIa32.dsc > b/UefiPayloadPkg/UefiPayloadPkgIa32.dsc > index 0efcfa8fb2f4..0d8854810700 100644 > --- a/UefiPayloadPkg/UefiPayloadPkgIa32.dsc > +++ b/UefiPayloadPkg/UefiPayloadPkgIa32.dsc > @@ -306,7 +306,7 @@ [PcdsPatchableInModule.common] > # The following parameters are set by Library/PlatformHookLib >=20 > # >=20 > gEfiMdeModulePkgTokenSpaceGuid.PcdSerialUseMmio|FALSE >=20 > - gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterBase|0x3f8 >=20 > + gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterBase|0 >=20 > gEfiMdeModulePkgTokenSpaceGuid.PcdSerialBaudRate|$(BAUD_RATE) >=20 > gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterStride|1 >=20 >=20 >=20 > diff --git a/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc > b/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc > index d645d233cd08..34640b1fc1da 100644 > --- a/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc > +++ b/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc > @@ -307,7 +307,7 @@ [PcdsPatchableInModule.common] > # The following parameters are set by Library/PlatformHookLib >=20 > # >=20 > gEfiMdeModulePkgTokenSpaceGuid.PcdSerialUseMmio|FALSE >=20 > - gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterBase|0x3f8 >=20 > + gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterBase|0 >=20 > gEfiMdeModulePkgTokenSpaceGuid.PcdSerialBaudRate|$(BAUD_RATE) >=20 > gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterStride|1 >=20 >=20 >=20 > -- > 2.27.0 >=20 >=20 > -=3D-=3D-=3D-=3D-=3D-=3D > Groups.io Links: You receive all messages sent to this group. >=20 > View/Reply Online (#62410): https://edk2.groups.io/g/devel/message/62410 > Mute This Topic: https://groups.io/mt/75472935/1781375 > Group Owner: devel+owner@edk2.groups.io > Unsubscribe: https://edk2.groups.io/g/devel/unsub [guo.dong@intel.com] > -=3D-=3D-=3D-=3D-=3D-=3D