From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web10.28372.1647275503998468255 for ; Mon, 14 Mar 2022 09:31:44 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=Q8WkGqZs; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: guo.dong@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1647275504; x=1678811504; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=se0rp7XaQB2G3gHi/hgS/TYlT0z9DCtaoH7cu1xiH+4=; b=Q8WkGqZs7C79R5wurUOxbR7QRtzzCxaJhkkdXu5mXuQWlxIp8NmJVOqP Ob/7eONv2AXg34mg/ecoUBMFP0GSE4c4TPcxW70snTI4TGSH5asi/lZ0K C20UaAgTm5wXdhPjxClDz0E3tpHOi7bElCAHCwV3p8qtr6U2Q65fdYnXA M++8VzNTgkL/lLKQj63y25YS40ZKnUlFUrrWkVe/096Jhgu9GkM8o3fvB tdF33kosaCDs9UR+8nPDmFsYpMDne80DbgBHKQt0kTGMs7mX35294+WnB RDSklj/LhNjYD1BNoFLwcUS7n768GIp9c4kgRwZf16cZk4L8evr3HDIX5 A==; X-IronPort-AV: E=McAfee;i="6200,9189,10285"; a="342505287" X-IronPort-AV: E=Sophos;i="5.90,181,1643702400"; d="scan'208";a="342505287" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Mar 2022 09:31:43 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,181,1643702400"; d="scan'208";a="643902793" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga002.fm.intel.com with ESMTP; 14 Mar 2022 09:31:43 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Mon, 14 Mar 2022 09:31:42 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Mon, 14 Mar 2022 09:31:42 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21 via Frontend Transport; Mon, 14 Mar 2022 09:31:42 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.172) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.21; Mon, 14 Mar 2022 09:31:40 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=i8HpgySdc+RPxnGQPhlWrJ7hZvY2PrWGUwHIElUt0oQdCCDURqCXPxulHmwMiZ61qxUhRuMDb6zCA0w1BJZhdcOq45nDpJ2Tm3MdDVDgYHusTud3lln483c2evxF96o976p80s774AT9pS8Cnx1vDcwW4NeEYp6vzoFEWuAE8GRz2al9oI5p9jvtvv6YK+f/wP/3hrF8KOkOoA24SvFCdGWekGpY/lfehq8zHIO9QARdZ9fBwMbd2jvmh4nf3bxncKowNlyODdSujQw91aZdBoo0RnfgE9T6m/nBxLV731mxy2EiDV5hvcye+kSm04y9xce3blTC0hyZO6l9zd4vJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=i7DXl4SMnpUe1AMUcwu4fI/BtUDJRkAMx7mWIzCC28E=; b=O1ADPAOCCzg4u3UsJrqN24ec43F+/0MlsMLCDtNAC5qJVgQW4rsde+i2VC5+OqcvHcj0MEH9wexfsZZ32FLoqhaRsKsA5RHmP82KV5kSHHRdcvsGYEJ5+47aQCaTcyFACr3glU/UGSmqFdGmJ/UrrbMtoPKCorxdMSdlkDd7HzEbipA8rgvuhuOs/HFBEKUyY2VUaAptABclCs83hD8Y5EzTpnZk7mKXeYnBR95H6AtXeLgASQ4h4YBJS7aQNkx+2aBB/hyrLKSi+BhKaTgKUqS2mtpAW3nS2wFwM9p1BDcrsFZegYtPsrvbT0JHD30YWEPFzW4jiveXuIVYh82PAQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BYAPR11MB3622.namprd11.prod.outlook.com (2603:10b6:a03:fe::30) by DM6PR11MB3274.namprd11.prod.outlook.com (2603:10b6:5:b::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5061.26; Mon, 14 Mar 2022 16:31:35 +0000 Received: from BYAPR11MB3622.namprd11.prod.outlook.com ([fe80::b4d1:1ea2:e9c:f4ec]) by BYAPR11MB3622.namprd11.prod.outlook.com ([fe80::b4d1:1ea2:e9c:f4ec%7]) with mapi id 15.20.5061.028; Mon, 14 Mar 2022 16:31:35 +0000 From: "Guo Dong" To: "Ni, Ray" , "devel@edk2.groups.io" , "Rhodes, Sean" CC: "Ma, Maurice" , "You, Benjamin" Subject: Re: [edk2-devel] [PATCH] UefiPayloadPkg: Fix build error Thread-Topic: [edk2-devel] [PATCH] UefiPayloadPkg: Fix build error Thread-Index: AQHYNU27a1QDzUlnqEOgzlwzOmPkaay+OBiAgADeSBA= Date: Mon, 14 Mar 2022 16:31:35 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.401.20 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: be498b8b-5505-48b1-19aa-08da05d81b63 x-ms-traffictypediagnostic: DM6PR11MB3274:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: zfps8S6oyr/MOfRceDbwBJIiGxQHfFjzd20D+6OYHAGYxBWCncRceeJiP/N3XopESqwx57ybPtecpbWhGLD5K2UZIzujGaGxNxAHGlbBhiqUnlZ23T13xQ0SYcwYbosWvYySHW4GAGaGSDbg1s4HoqIUxz8MkwhTCa7nJO3OOlScnxCrc5TU0+vEmZ79zVDTkQVSQ6sM68PLErVY9nDf6CBFZMTCi4udQNx15RXfoNbHCPF/hbnNLWd+YhM+fOgL+yxlGBi5K5YLVUKUfHvCHI0Vkt+mEfpvB7nNyc57p1l8ZLNBgMkhcU0JjhUu5HRdbgIT0HPpYLu9E0XJkcI1AdspD0HBTIidUH4e8RxRMXbf9zgRMcllpwNKn7XY8PBEOYDYyyw4EJ+JI7nslSKubbjTJNn1AqcyDgnYvz2ZfKA4h+Vg14PSP+5BGRabsy3qa6EoInUdD1TnW7IbcADECEv2A428EDhogJ7bOMz+BX2DcIF13yFpi3zIAENq6vnNpIibKZjLM/Xr0huzdAwOxnlgX0M7vbmd+EmPFDiuDDNAuOtc99ZdQHUkQ62ZXnGF3nU6HfTvGC4f8v1qd43rTFGhrAKTbP7X0RUMVIjmMCiHFWmyjedvQZ/LEOy5yT4yOcwSUk4ee8ydf7GMsRTcOBNK4XQdyh5W7SEeKohK/rMsxo92o/ZECAMu1XytNDp1DCmZcygCLdDaDB7O2Bv8u2j3X8EDFwQyQQWz/jkOVcje7GV6pVmYoH02eK+aFb4zLwHnbTtfN95Ueo4Skjim+SfqYonh+Lx25KB/83s7tGgF7SVLyprZWbS9oc11WH0DBr+5qUqbZ8iC0YI6d0nZfw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR11MB3622.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(53546011)(38070700005)(66946007)(7696005)(6506007)(316002)(107886003)(2906002)(9686003)(110136005)(76116006)(82960400001)(55016003)(54906003)(8676002)(5660300002)(26005)(122000001)(186003)(4326008)(64756008)(66446008)(66476007)(66556008)(71200400001)(508600001)(8936002)(966005)(52536014)(33656002)(86362001)(38100700002)(83380400001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?/NW7td0t3OSIs/sq0y7kgMdAfVcBdzBqiuyv7Q5s4PCStTBQG0sWFoDLssbE?= =?us-ascii?Q?N6XbN6/PZXWT29o2b1I2JUNQBIuBsnh45gILe8DhwizhCYZKyWAV3B+5+J1z?= =?us-ascii?Q?QlxiehEeBvqhFhlfTYsDBFbdQd9QgRSwgJQT52MPr5TSJtdBQxPKUj9CwBke?= =?us-ascii?Q?w7bgStsO+m0rQmT/P2CQRcd/CWE32vGbeoXp6/iqnCWHIUxP9676jhtlsnI3?= =?us-ascii?Q?Fiaa4OPvxRtyMZZeWY2L4Nl1DRFVwJQ6gPSld52m9NAkeFMfUdZxLfT5f69g?= =?us-ascii?Q?4dyqkzHvF+YNd5DrN0TvHl/mpnnzkhwHr5FMhibVUmbErYZO0D+Y8uQl+9fR?= =?us-ascii?Q?2cj9+R59Y1sOomD2HHPTHW1GNqwHvSp0aPTJaZH5EGNu1LYI9nHwaM1iaYkx?= =?us-ascii?Q?asOy7Vprz8jgRLpf1nMycDphy9sEkaEUuwlmvhfD+zBp+4cC4OvXIHUyODrE?= =?us-ascii?Q?WalQH6kxQWTF7i5rdvEZrO3YEbX18PXDwMVq6HKGCwvHx/LSOanrIsH34d/D?= =?us-ascii?Q?zgmZ/FRlONF7/mWZEWikiGajTmtDMq5xJkUpW1ep2nJpgFk3OEfMrFNkQdp0?= =?us-ascii?Q?c0EYuCnTmtbVjCXFkN7XmoIzeH3jdo5rFwRC3S78IQo9cGrFDtny4BTM1NIF?= =?us-ascii?Q?hIHLdxEVWWbyL4+rf6vrr3DtASl/I7Xch/l/vvaETLXcZF8x6rZYI6aoKSKQ?= =?us-ascii?Q?U8vl9+VlU72ueiZFedAy/JzIIway/ck1ir7XRmCapsTBMj7Jw4iQl0yJ+NMf?= =?us-ascii?Q?IApcpAoyisq2nlITuQ63hrOU84LyPbxDBQYgRujBdbir4c2EFhKcdLcTn6hL?= =?us-ascii?Q?MQFN7U6H9xQiL/k04h3Xx+ov2Fb0AaQJN5/rnvAa31Tl56Ak+Srk6x8VKjNy?= =?us-ascii?Q?PsaHy0lNIuVSy1fKcw/fG6e2ButP//8HWNQxjaNoyfvxQGJ+ckSOhxQLAslX?= =?us-ascii?Q?uKKRSAi0GWpHMs9VICSTElZpjgMIvnYNe8HV5Uid+jTHFw538ZjBJxtlZTJH?= =?us-ascii?Q?wocgOFXunUl9wlhQFdApNCPohlFLZm/EJIV4OtIJmrkGX8l0/O+X9IcIKqhN?= =?us-ascii?Q?97QYXMu7qGYeRhWKuXSSeOQmwwr5udtLel4TNKqjstbQFMe2KAYuqa8Aj/+N?= =?us-ascii?Q?pDEkFLO5Sc4Ykv2clWkuQxkG8MPEgjnUXn6F8fGL5s581A1Tktn9Ot36LbSF?= =?us-ascii?Q?0Mn1y4Eto71niYhjjVyzQhvNwMuQHY/x9KtSPP5QOKTZpqVt9r8+ktlMs+4U?= =?us-ascii?Q?lyElL77ajs8TOjk+TA3XaLXmqRhaUA5oYKhdhUG6cOOOph1PC/SpNQYQbVzc?= =?us-ascii?Q?nVVJQvp53lw4/l8BpJGB6zx/2XV+0UbkeCQ/WYuj1lVwpZ8h9HUgqVwim/kW?= =?us-ascii?Q?PCvnBVe1ZXup6hHjRgH0fVOEhFioqvJ2Y5eGzcGk5TvlTGg3NvjXS+qLte7I?= =?us-ascii?Q?fIwWasSPD2qWgddLQV6iuFnjGExONrpm?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3622.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: be498b8b-5505-48b1-19aa-08da05d81b63 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Mar 2022 16:31:35.5338 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: L4XMzkQKMvlunejRmQSw1xbtC4qA5TcXTEDygEy40B+bF76CAGKoGW81pFleWJpHbIjpvwgKUs1TbQGeB7E/4w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3274 Return-Path: guo.dong@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable You would understand it when you look at the NetworkPkg/Network.dsc.inc In that DSC file, network components could be built as X64 or IA32 dependin= g on PLATFORMX64_ENABLE. -----Original Message----- From: Ni, Ray =20 Sent: Sunday, March 13, 2022 8:13 PM To: devel@edk2.groups.io; Rhodes, Sean Cc: Dong, Guo ; Ma, Maurice ; You= , Benjamin Subject: RE: [edk2-devel] [PATCH] UefiPayloadPkg: Fix build error I don't understand the need of "+ DEFINE PLATFORMX64_ENABLE =3D TRUE". -----Original Message----- From: devel@edk2.groups.io On Behalf Of Sean Rhodes Sent: Friday, March 11, 2022 9:41 PM To: devel@edk2.groups.io Cc: Dong, Guo ; Ni, Ray ; Ma, Maurice= ; You, Benjamin Subject: [edk2-devel] [PATCH] UefiPayloadPkg: Fix build error From: Guo Dong On windows build, need add -DPLATFORMX64_ENABLE=3DTRUE in the build command= line beside -DNETWORK_DRIVER_ENABLE=3DTRUE in order build network features= . So set PLATFORMX64_ENABLE to TRUE when need build network feature. On Linux build, DSC file should not have PcdAllowHttpConnections when netwo= rk feature is not built, else would cause build error. Cc: Guo Dong Cc: Ray Ni Cc: Maurice Ma Cc: Benjamin You Signed-off-by: Guo Dong --- UefiPayloadPkg/UefiPayloadPkg.dsc | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/UefiPayloadPkg/UefiPayloadPkg.dsc b/UefiPayloadPkg/UefiPayload= Pkg.dsc index 558513baf1..f3806a8ebc 100644 --- a/UefiPayloadPkg/UefiPayloadPkg.dsc +++ b/UefiPayloadPkg/UefiPayloadPkg.dsc @@ -407,7 +407,9 @@ [PcdsPatchableInModule.X64] gPcAtChipsetPkgTokenSpaceGuid.PcdRtcIndexRegister|$(RTC_INDEX_REGISTER) gPcAtChipsetPkgTokenSpaceGuid.PcdRtcTargetRegister|$(RTC_TARGET_REGISTER= ) +!if $(NETWORK_DRIVER_ENABLE) =3D=3D TRUE gEfiNetworkPkgTokenSpaceGuid.PcdAllowHttpConnections|TRUE +!endif =20 [PcdsPatchableInModule.common] gEfiMdeModulePkgTokenSpaceGuid.PcdBootManagerMenuFile|{ 0x21, 0xaa, 0x2c= , 0x46, 0x14, 0x76, 0x03, 0x45, 0x83, 0x6e, 0x8a, 0xb6, 0xf4, 0x66, 0x23, 0= x31 } @@ -530,6 +532,8 @@ # UEFI network modules # !if $(NETWORK_DRIVER_ENABLE) =3D=3D TRUE +[Defines] + DEFINE PLATFORMX64_ENABLE =3D TRUE !include NetworkPkg/Network.dsc.inc !endif =20 -- 2.32.0 -=3D-=3D-=3D-=3D-=3D-=3D Groups.io Links: You receive all messages sent to this group. View/Reply Online (#87463): https://edk2.groups.io/g/devel/message/87463 Mute This Topic: https://groups.io/mt/89710183/1712937 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [ray.ni@intel.com] -=3D-=3D-=3D-=3D-=3D-=3D