From: "Guo Dong" <guo.dong@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"lersek@redhat.com" <lersek@redhat.com>
Cc: "marcello.bauer@9elements.com" <marcello.bauer@9elements.com>,
"Kinney, Michael D" <michael.d.kinney@intel.com>,
"Leif Lindholm (Nuvia address)" <leif@nuviainc.com>,
"Doran, Mark" <mark.doran@intel.com>,
Andrew Fish <afish@apple.com>,
"Guptha, Soumya K" <soumya.k.guptha@intel.com>
Subject: Re: [edk2-devel] more development process failure [was: UefiPayloadPkg: Runtime MMCONF]
Date: Wed, 16 Sep 2020 17:30:23 +0000 [thread overview]
Message-ID: <BYAPR11MB36222A8141F58F8ED225DA039E210@BYAPR11MB3622.namprd11.prod.outlook.com> (raw)
In-Reply-To: <11b4d671-7c5e-0ef3-0d2f-13ef605f1eaf@redhat.com>
Hi Laszlo,
The patchset includes 3 patches, and all of them had been reviewed by package owners.
The patch submitter has a pull request https://github.com/tianocore/edk2/pull/885, I rebased the patch to latest master, and merged it by adding reviewed-by found from emails.
I also make sure it passed all the checks before I put "push" button there. then retrigger a new build with "push" button.
I am not sure what is missing. If there is any other requirements, should they be captured during code review or tool check?
Thanks,
Guo
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Laszlo
> Ersek
> Sent: Wednesday, September 16, 2020 1:57 AM
> To: Dong, Guo <guo.dong@intel.com>
> Cc: devel@edk2.groups.io; marcello.bauer@9elements.com; Kinney, Michael D
> <michael.d.kinney@intel.com>; Leif Lindholm (Nuvia address)
> <leif@nuviainc.com>; Doran, Mark <mark.doran@intel.com>; Andrew Fish
> <afish@apple.com>; Guptha, Soumya K <soumya.k.guptha@intel.com>
> Subject: [edk2-devel] more development process failure [was: UefiPayloadPkg:
> Runtime MMCONF]
>
> Guo,
>
> On 08/18/20 10:24, Marcello Sylvester Bauer wrote:
> > Support arbitrary platforms with different or even no MMCONF space.
> > Fixes crash on platforms not exposing 256 buses.
> >
> > Tested on:
> > * AMD Stoney Ridge
> >
> > Branch: https://github.com/9elements/edk2-1/tree/UefiPayloadPkg-
> MMCONF
> > PR: https://github.com/tianocore/edk2/pull/885
> >
> > v5:
> > * MdePkg
> > - support variable size MMCONF in all PciExpressLibs
> > - use (UINTX)-1 as return values for invalid Pci addresses
>
> Okay, so we got more of the same development process violations here, as
> I've just reported at <https://edk2.groups.io/g/devel/message/65313>.
>
> See this new pull request:
>
> https://github.com/tianocore/edk2/pull/932/
>
> "No description provided."
>
> You should be embarrassed.
>
> Laszlo
>
>
>
>
>
next prev parent reply other threads:[~2020-09-16 17:30 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-18 8:24 [PATCH v5 0/3] UefiPayloadPkg: Runtime MMCONF Marcello Sylvester Bauer
2020-08-18 8:24 ` [PATCH v5 1/3] UefiPayloadPkg: Store the size of the MMCONF window Marcello Sylvester Bauer
2020-08-18 8:24 ` [PATCH v5 2/3] MdePkg: PciExpressLib support variable size MMCONF Marcello Sylvester Bauer
2020-08-20 10:55 ` Liming Gao
2020-08-18 8:24 ` [PATCH v5 3/3] UefiPayloadPkg: Support variable size MMCONF space Marcello Sylvester Bauer
2020-09-08 22:35 ` [edk2-devel] " Guo Dong
2020-09-16 8:56 ` more development process failure [was: UefiPayloadPkg: Runtime MMCONF] Laszlo Ersek
2020-09-16 17:30 ` Guo Dong [this message]
2020-09-16 18:14 ` [edk2-devel] " Laszlo Ersek
2020-09-16 21:51 ` Guo Dong
2020-09-17 5:59 ` Laszlo Ersek
2020-09-17 1:49 ` 回复: " gaoliming
2020-09-17 2:31 ` Yao, Jiewen
2020-09-17 6:31 ` Laszlo Ersek
2020-09-17 7:31 ` Yao, Jiewen
2020-09-17 10:26 ` Laszlo Ersek
2020-09-18 4:39 ` Ni, Ray
2020-09-18 7:37 ` Andrew Fish
2020-09-26 0:34 ` Guo Dong
2020-09-27 1:44 ` 回复: " gaoliming
2020-09-27 17:29 ` Guo Dong
2020-09-28 17:55 ` Laszlo Ersek
2020-09-29 4:13 ` Guo Dong
2020-09-29 11:59 ` Laszlo Ersek
2020-09-17 5:56 ` 回复: " Laszlo Ersek
2020-09-21 9:57 ` Marcello Sylvester Bauer
2020-09-22 6:45 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR11MB36222A8141F58F8ED225DA039E210@BYAPR11MB3622.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox