* [PATCH v2 0/1] UefiPayloadPkg: Set default PciBaseSize on Ia32
@ 2020-10-13 13:33 Marcello Sylvester Bauer
2020-10-13 13:33 ` [PATCH v2 1/1] " Marcello Sylvester Bauer
2020-10-13 19:02 ` [PATCH v2 0/1] " Ma, Maurice
0 siblings, 2 replies; 12+ messages in thread
From: Marcello Sylvester Bauer @ 2020-10-13 13:33 UTC (permalink / raw)
To: devel
Cc: Marcello Sylvester Bauer, patrick.rudolph, maurice.ma, guo.dong,
benjamin.you
This commit fix UefiPayloadPkgIa32 build in master.
In commit 8028b2907e20b21cd7d69639a36ac82a77c81dc1 I did forget to set the
default value for PcdPciExpressBaseSize on Ia32 Targets. This patch does insert
it afterwards. It would be great if it could be merged asap.
PS: I added the Ia32 target to our CI to avoid this issue in future. Sorry for
the misfortune.
v2:
* Remove no longer required build-time PcdPciExpressBaseAddress
Branch: https://github.com/9elements/edk2/tree/fix/UefiPayloadPkgIa32_V2
PR: https://github.com/tianocore/edk2/pull/1008
Marcello Sylvester Bauer (1):
UefiPayloadPkg: Set default PciBaseSize on Ia32
UefiPayloadPkg/UefiPayloadPkgIa32.dsc | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
--
2.28.0
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH v2 1/1] UefiPayloadPkg: Set default PciBaseSize on Ia32
2020-10-13 13:33 [PATCH v2 0/1] UefiPayloadPkg: Set default PciBaseSize on Ia32 Marcello Sylvester Bauer
@ 2020-10-13 13:33 ` Marcello Sylvester Bauer
2020-10-13 19:00 ` Ma, Maurice
2020-10-13 19:02 ` [PATCH v2 0/1] " Ma, Maurice
1 sibling, 1 reply; 12+ messages in thread
From: Marcello Sylvester Bauer @ 2020-10-13 13:33 UTC (permalink / raw)
To: devel
Cc: Marcello Sylvester Bauer, patrick.rudolph, maurice.ma, guo.dong,
benjamin.you
* Add needed PcdPciExpressBaseSize default on Ia32 targets analog to X64 in:
8028b2907e20b21cd7d69639a36ac82a77c81dc1
* Remove no longer required build-time PcdPciExpressBaseAddress with regards to:
3900a63e3a1b9ba9a4105bedead7b986188cec2c
Signed-off-by: Marcello Sylvester Bauer <marcello.bauer@9elements.com>
Cc: Patrick Rudolph <patrick.rudolph@9elements.com>
Cc: Maurice Ma <maurice.ma@intel.com>
Cc: Guo Dong <guo.dong@intel.com>
Cc: Benjamin You <benjamin.you@intel.com>
---
UefiPayloadPkg/UefiPayloadPkgIa32.dsc | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/UefiPayloadPkg/UefiPayloadPkgIa32.dsc b/UefiPayloadPkg/UefiPayloadPkgIa32.dsc
index 12d7ffe81416..d1fcbbb50207 100644
--- a/UefiPayloadPkg/UefiPayloadPkgIa32.dsc
+++ b/UefiPayloadPkg/UefiPayloadPkgIa32.dsc
@@ -292,8 +292,6 @@ [PcdsFixedAtBuild]
gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseMemory|FALSE
gEfiMdeModulePkgTokenSpaceGuid.PcdBootManagerMenuFile|{ 0x21, 0xaa, 0x2c, 0x46, 0x14, 0x76, 0x03, 0x45, 0x83, 0x6e, 0x8a, 0xb6, 0xf4, 0x66, 0x23, 0x31 }
- gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress|$(PCIE_BASE)
-
!if $(SOURCE_DEBUG_ENABLE)
gEfiSourceLevelDebugPkgTokenSpaceGuid.PcdDebugLoadImageMethod|0x2
!endif
@@ -364,6 +362,7 @@ [PcdsDynamicDefault]
gEfiMdeModulePkgTokenSpaceGuid.PcdConOutRow|31
gEfiMdeModulePkgTokenSpaceGuid.PcdConOutColumn|100
gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress|0
+ gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseSize|0
################################################################################
#
--
2.28.0
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH v2 1/1] UefiPayloadPkg: Set default PciBaseSize on Ia32
2020-10-13 13:33 ` [PATCH v2 1/1] " Marcello Sylvester Bauer
@ 2020-10-13 19:00 ` Ma, Maurice
0 siblings, 0 replies; 12+ messages in thread
From: Ma, Maurice @ 2020-10-13 19:00 UTC (permalink / raw)
To: Marcello Sylvester Bauer, devel@edk2.groups.io
Cc: patrick.rudolph@9elements.com, Dong, Guo, You, Benjamin
Reviewed-by:
Maurice Ma <maurice.ma@intel.com>
> -----Original Message-----
> From: Marcello Sylvester Bauer <marcello.bauer@9elements.com>
> Sent: Tuesday, October 13, 2020 6:34
> To: devel@edk2.groups.io
> Cc: Marcello Sylvester Bauer <marcello.bauer@9elements.com>;
> patrick.rudolph@9elements.com; Ma, Maurice <maurice.ma@intel.com>; Dong,
> Guo <guo.dong@intel.com>; You, Benjamin <benjamin.you@intel.com>
> Subject: [PATCH v2 1/1] UefiPayloadPkg: Set default PciBaseSize on Ia32
>
> * Add needed PcdPciExpressBaseSize default on Ia32 targets analog to X64 in:
> 8028b2907e20b21cd7d69639a36ac82a77c81dc1
> * Remove no longer required build-time PcdPciExpressBaseAddress with regards
> to:
> 3900a63e3a1b9ba9a4105bedead7b986188cec2c
>
> Signed-off-by: Marcello Sylvester Bauer <marcello.bauer@9elements.com>
> Cc: Patrick Rudolph <patrick.rudolph@9elements.com>
> Cc: Maurice Ma <maurice.ma@intel.com>
> Cc: Guo Dong <guo.dong@intel.com>
> Cc: Benjamin You <benjamin.you@intel.com>
> ---
> UefiPayloadPkg/UefiPayloadPkgIa32.dsc | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/UefiPayloadPkg/UefiPayloadPkgIa32.dsc
> b/UefiPayloadPkg/UefiPayloadPkgIa32.dsc
> index 12d7ffe81416..d1fcbbb50207 100644
> --- a/UefiPayloadPkg/UefiPayloadPkgIa32.dsc
> +++ b/UefiPayloadPkg/UefiPayloadPkgIa32.dsc
> @@ -292,8 +292,6 @@ [PcdsFixedAtBuild]
> gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseMemory|FALSE
>
> gEfiMdeModulePkgTokenSpaceGuid.PcdBootManagerMenuFile|{ 0x21, 0xaa,
> 0x2c, 0x46, 0x14, 0x76, 0x03, 0x45, 0x83, 0x6e, 0x8a, 0xb6, 0xf4, 0x66, 0x23,
> 0x31 }
>
>
>
> - gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress|$(PCIE_BASE)
>
> -
>
> !if $(SOURCE_DEBUG_ENABLE)
>
> gEfiSourceLevelDebugPkgTokenSpaceGuid.PcdDebugLoadImageMethod|0x2
>
> !endif
>
> @@ -364,6 +362,7 @@ [PcdsDynamicDefault]
> gEfiMdeModulePkgTokenSpaceGuid.PcdConOutRow|31
>
> gEfiMdeModulePkgTokenSpaceGuid.PcdConOutColumn|100
>
> gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress|0
>
> + gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseSize|0
>
>
>
>
> #############################################################
> ###################
>
> #
>
> --
> 2.28.0
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v2 0/1] UefiPayloadPkg: Set default PciBaseSize on Ia32
2020-10-13 13:33 [PATCH v2 0/1] UefiPayloadPkg: Set default PciBaseSize on Ia32 Marcello Sylvester Bauer
2020-10-13 13:33 ` [PATCH v2 1/1] " Marcello Sylvester Bauer
@ 2020-10-13 19:02 ` Ma, Maurice
2020-10-22 8:25 ` Marcello Sylvester Bauer
1 sibling, 1 reply; 12+ messages in thread
From: Ma, Maurice @ 2020-10-13 19:02 UTC (permalink / raw)
To: Marcello Sylvester Bauer, devel@edk2.groups.io
Cc: patrick.rudolph@9elements.com, Dong, Guo, You, Benjamin
Reviewed-by:
Maurice Ma <maurice.ma@intel.com>
> -----Original Message-----
> From: Marcello Sylvester Bauer <marcello.bauer@9elements.com>
> Sent: Tuesday, October 13, 2020 6:34
> To: devel@edk2.groups.io
> Cc: Marcello Sylvester Bauer <marcello.bauer@9elements.com>;
> patrick.rudolph@9elements.com; Ma, Maurice <maurice.ma@intel.com>; Dong,
> Guo <guo.dong@intel.com>; You, Benjamin <benjamin.you@intel.com>
> Subject: [PATCH v2 0/1] UefiPayloadPkg: Set default PciBaseSize on Ia32
>
> This commit fix UefiPayloadPkgIa32 build in master.
>
> In commit 8028b2907e20b21cd7d69639a36ac82a77c81dc1 I did forget to set
> the default value for PcdPciExpressBaseSize on Ia32 Targets. This patch does
> insert it afterwards. It would be great if it could be merged asap.
>
> PS: I added the Ia32 target to our CI to avoid this issue in future. Sorry for the
> misfortune.
>
> v2:
> * Remove no longer required build-time PcdPciExpressBaseAddress
>
> Branch: https://github.com/9elements/edk2/tree/fix/UefiPayloadPkgIa32_V2
> PR: https://github.com/tianocore/edk2/pull/1008
>
> Marcello Sylvester Bauer (1):
> UefiPayloadPkg: Set default PciBaseSize on Ia32
>
> UefiPayloadPkg/UefiPayloadPkgIa32.dsc | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> --
> 2.28.0
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v2 0/1] UefiPayloadPkg: Set default PciBaseSize on Ia32
2020-10-13 19:02 ` [PATCH v2 0/1] " Ma, Maurice
@ 2020-10-22 8:25 ` Marcello Sylvester Bauer
2020-10-23 2:49 ` Guo Dong
[not found] ` <16407F3C2F4AEB24.28553@groups.io>
0 siblings, 2 replies; 12+ messages in thread
From: Marcello Sylvester Bauer @ 2020-10-22 8:25 UTC (permalink / raw)
To: Ma, Maurice
Cc: devel@edk2.groups.io, patrick.rudolph@9elements.com, Dong, Guo,
You, Benjamin
[-- Attachment #1: Type: text/plain, Size: 2165 bytes --]
Hi,
As already mentioned, this patch fixes the current master build for the
UefiPayloadPkgIa32 platform.
Is it possible to merge this change soon?
Sorry for the circumstances.
thanks,
Marcello
On Tue, Oct 13, 2020 at 9:02 PM Ma, Maurice <maurice.ma@intel.com> wrote:
> Reviewed-by:
> Maurice Ma <maurice.ma@intel.com>
>
> > -----Original Message-----
> > From: Marcello Sylvester Bauer <marcello.bauer@9elements.com>
> > Sent: Tuesday, October 13, 2020 6:34
> > To: devel@edk2.groups.io
> > Cc: Marcello Sylvester Bauer <marcello.bauer@9elements.com>;
> > patrick.rudolph@9elements.com; Ma, Maurice <maurice.ma@intel.com>; Dong,
> > Guo <guo.dong@intel.com>; You, Benjamin <benjamin.you@intel.com>
> > Subject: [PATCH v2 0/1] UefiPayloadPkg: Set default PciBaseSize on Ia32
> >
> > This commit fix UefiPayloadPkgIa32 build in master.
> >
> > In commit 8028b2907e20b21cd7d69639a36ac82a77c81dc1 I did forget to set
> > the default value for PcdPciExpressBaseSize on Ia32 Targets. This patch
> does
> > insert it afterwards. It would be great if it could be merged asap.
> >
> > PS: I added the Ia32 target to our CI to avoid this issue in future.
> Sorry for the
> > misfortune.
> >
> > v2:
> > * Remove no longer required build-time PcdPciExpressBaseAddress
> >
> > Branch: https://github.com/9elements/edk2/tree/fix/UefiPayloadPkgIa32_V2
> > PR: https://github.com/tianocore/edk2/pull/1008
> >
> > Marcello Sylvester Bauer (1):
> > UefiPayloadPkg: Set default PciBaseSize on Ia32
> >
> > UefiPayloadPkg/UefiPayloadPkgIa32.dsc | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > --
> > 2.28.0
>
--
*[Marcello Sylvester Bauer]*
9elements Agency GmbH, Kortumstraße 19-21, 44787 Bochum, Germany
Email: [DEINE EMAIL ADDRESSE]
<https://static.9elements.com/email_signatur.html>
Phone: *+49 234 68 94 188 <+492346894188>*
Mobile: *+49 1722847618 <+491722847618>*
Sitz der Gesellschaft: Bochum
Handelsregister: Amtsgericht Bochum, HRB 17519
Geschäftsführung: Sebastian Deutsch, Eray Basar
Datenschutzhinweise nach Art. 13 DSGVO <https://9elements.com/privacy>
[-- Attachment #2: Type: text/html, Size: 5335 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v2 0/1] UefiPayloadPkg: Set default PciBaseSize on Ia32
2020-10-22 8:25 ` Marcello Sylvester Bauer
@ 2020-10-23 2:49 ` Guo Dong
[not found] ` <16407F3C2F4AEB24.28553@groups.io>
1 sibling, 0 replies; 12+ messages in thread
From: Guo Dong @ 2020-10-23 2:49 UTC (permalink / raw)
To: Marcello Sylvester Bauer, Ma, Maurice
Cc: devel@edk2.groups.io, patrick.rudolph@9elements.com,
You, Benjamin
[-- Attachment #1: Type: text/plain, Size: 2984 bytes --]
Hi Marcello,
Sorry for late response. I created a pull request https://github.com/tianocore/edk2/pull/1044 to merge this patch 2 hours ago.
Hopefully it could be merged soon after all the checks.
Thanks,
Guo
From: Marcello Sylvester Bauer <marcello.bauer@9elements.com>
Sent: Thursday, October 22, 2020 1:25 AM
To: Ma, Maurice <maurice.ma@intel.com>
Cc: devel@edk2.groups.io; patrick.rudolph@9elements.com; Dong, Guo <guo.dong@intel.com>; You, Benjamin <benjamin.you@intel.com>
Subject: Re: [PATCH v2 0/1] UefiPayloadPkg: Set default PciBaseSize on Ia32
Hi,
As already mentioned, this patch fixes the current master build for the UefiPayloadPkgIa32 platform.
Is it possible to merge this change soon?
Sorry for the circumstances.
thanks,
Marcello
On Tue, Oct 13, 2020 at 9:02 PM Ma, Maurice <maurice.ma@intel.com<mailto:maurice.ma@intel.com>> wrote:
Reviewed-by:
Maurice Ma <maurice.ma@intel.com<mailto:maurice.ma@intel.com>>
> -----Original Message-----
> From: Marcello Sylvester Bauer <marcello.bauer@9elements.com<mailto:marcello.bauer@9elements.com>>
> Sent: Tuesday, October 13, 2020 6:34
> To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>
> Cc: Marcello Sylvester Bauer <marcello.bauer@9elements.com<mailto:marcello.bauer@9elements.com>>;
> patrick.rudolph@9elements.com<mailto:patrick.rudolph@9elements.com>; Ma, Maurice <maurice.ma@intel.com<mailto:maurice.ma@intel.com>>; Dong,
> Guo <guo.dong@intel.com<mailto:guo.dong@intel.com>>; You, Benjamin <benjamin.you@intel.com<mailto:benjamin.you@intel.com>>
> Subject: [PATCH v2 0/1] UefiPayloadPkg: Set default PciBaseSize on Ia32
>
> This commit fix UefiPayloadPkgIa32 build in master.
>
> In commit 8028b2907e20b21cd7d69639a36ac82a77c81dc1 I did forget to set
> the default value for PcdPciExpressBaseSize on Ia32 Targets. This patch does
> insert it afterwards. It would be great if it could be merged asap.
>
> PS: I added the Ia32 target to our CI to avoid this issue in future. Sorry for the
> misfortune.
>
> v2:
> * Remove no longer required build-time PcdPciExpressBaseAddress
>
> Branch: https://github.com/9elements/edk2/tree/fix/UefiPayloadPkgIa32_V2
> PR: https://github.com/tianocore/edk2/pull/1008
>
> Marcello Sylvester Bauer (1):
> UefiPayloadPkg: Set default PciBaseSize on Ia32
>
> UefiPayloadPkg/UefiPayloadPkgIa32.dsc | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> --
> 2.28.0
--
[Marcello Sylvester Bauer]
[http://static.9elements.com/logo-signature.png]
9elements Agency GmbH, Kortumstraße 19-21, 44787 Bochum, Germany
Email: [DEINE EMAIL ADDRESSE]<https://static.9elements.com/email_signatur.html>
Phone: +49 234 68 94 188<tel:+492346894188>
Mobile: +49 1722847618<tel:+491722847618>
Sitz der Gesellschaft: Bochum
Handelsregister: Amtsgericht Bochum, HRB 17519
Geschäftsführung: Sebastian Deutsch, Eray Basar
Datenschutzhinweise nach Art. 13 DSGVO<https://9elements.com/privacy>
[-- Attachment #2: Type: text/html, Size: 10753 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [edk2-devel] [PATCH v2 0/1] UefiPayloadPkg: Set default PciBaseSize on Ia32
[not found] ` <16407F3C2F4AEB24.28553@groups.io>
@ 2020-10-23 22:36 ` Guo Dong
2020-11-09 10:47 ` Marcello Sylvester Bauer
0 siblings, 1 reply; 12+ messages in thread
From: Guo Dong @ 2020-10-23 22:36 UTC (permalink / raw)
To: devel@edk2.groups.io, Dong, Guo, Marcello Sylvester Bauer,
Ma, Maurice
Cc: patrick.rudolph@9elements.com, You, Benjamin
[-- Attachment #1: Type: text/plain, Size: 4085 bytes --]
Hi Marcello,
It looks there is issue for the CI tool to complete all the checks. So I just closed this PR.
And I just created another PR https://github.com/tianocore/edk2/pull/1046 to remove PEI phase from UEFI payload.
If the new patch is approved, we don’t need this patch to update DSC file.
In the new patch, UEFI payload would use a single DSC file to support X64, IA32X64 and possibly IA32 build.
Please have a look at that PR and let me know if you have any comments.
Thanks,
Guo
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Guo Dong
Sent: Thursday, October 22, 2020 7:49 PM
To: Marcello Sylvester Bauer <marcello.bauer@9elements.com>; Ma, Maurice <maurice.ma@intel.com>
Cc: devel@edk2.groups.io; patrick.rudolph@9elements.com; You, Benjamin <benjamin.you@intel.com>
Subject: Re: [edk2-devel] [PATCH v2 0/1] UefiPayloadPkg: Set default PciBaseSize on Ia32
Hi Marcello,
Sorry for late response. I created a pull request https://github.com/tianocore/edk2/pull/1044 to merge this patch 2 hours ago.
Hopefully it could be merged soon after all the checks.
Thanks,
Guo
From: Marcello Sylvester Bauer <marcello.bauer@9elements.com<mailto:marcello.bauer@9elements.com>>
Sent: Thursday, October 22, 2020 1:25 AM
To: Ma, Maurice <maurice.ma@intel.com<mailto:maurice.ma@intel.com>>
Cc: devel@edk2.groups.io<mailto:devel@edk2.groups.io>; patrick.rudolph@9elements.com<mailto:patrick.rudolph@9elements.com>; Dong, Guo <guo.dong@intel.com<mailto:guo.dong@intel.com>>; You, Benjamin <benjamin.you@intel.com<mailto:benjamin.you@intel.com>>
Subject: Re: [PATCH v2 0/1] UefiPayloadPkg: Set default PciBaseSize on Ia32
Hi,
As already mentioned, this patch fixes the current master build for the UefiPayloadPkgIa32 platform.
Is it possible to merge this change soon?
Sorry for the circumstances.
thanks,
Marcello
On Tue, Oct 13, 2020 at 9:02 PM Ma, Maurice <maurice.ma@intel.com<mailto:maurice.ma@intel.com>> wrote:
Reviewed-by:
Maurice Ma <maurice.ma@intel.com<mailto:maurice.ma@intel.com>>
> -----Original Message-----
> From: Marcello Sylvester Bauer <marcello.bauer@9elements.com<mailto:marcello.bauer@9elements.com>>
> Sent: Tuesday, October 13, 2020 6:34
> To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>
> Cc: Marcello Sylvester Bauer <marcello.bauer@9elements.com<mailto:marcello.bauer@9elements.com>>;
> patrick.rudolph@9elements.com<mailto:patrick.rudolph@9elements.com>; Ma, Maurice <maurice.ma@intel.com<mailto:maurice.ma@intel.com>>; Dong,
> Guo <guo.dong@intel.com<mailto:guo.dong@intel.com>>; You, Benjamin <benjamin.you@intel.com<mailto:benjamin.you@intel.com>>
> Subject: [PATCH v2 0/1] UefiPayloadPkg: Set default PciBaseSize on Ia32
>
> This commit fix UefiPayloadPkgIa32 build in master.
>
> In commit 8028b2907e20b21cd7d69639a36ac82a77c81dc1 I did forget to set
> the default value for PcdPciExpressBaseSize on Ia32 Targets. This patch does
> insert it afterwards. It would be great if it could be merged asap.
>
> PS: I added the Ia32 target to our CI to avoid this issue in future. Sorry for the
> misfortune.
>
> v2:
> * Remove no longer required build-time PcdPciExpressBaseAddress
>
> Branch: https://github.com/9elements/edk2/tree/fix/UefiPayloadPkgIa32_V2
> PR: https://github.com/tianocore/edk2/pull/1008
>
> Marcello Sylvester Bauer (1):
> UefiPayloadPkg: Set default PciBaseSize on Ia32
>
> UefiPayloadPkg/UefiPayloadPkgIa32.dsc | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> --
> 2.28.0
--
[Marcello Sylvester Bauer]
[http://static.9elements.com/logo-signature.png]
9elements Agency GmbH, Kortumstraße 19-21, 44787 Bochum, Germany
Email: [DEINE EMAIL ADDRESSE]<https://static.9elements.com/email_signatur.html>
Phone: +49 234 68 94 188<tel:+492346894188>
Mobile: +49 1722847618<tel:+491722847618>
Sitz der Gesellschaft: Bochum
Handelsregister: Amtsgericht Bochum, HRB 17519
Geschäftsführung: Sebastian Deutsch, Eray Basar
Datenschutzhinweise nach Art. 13 DSGVO<https://9elements.com/privacy>
[-- Attachment #2: Type: text/html, Size: 13392 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [edk2-devel] [PATCH v2 0/1] UefiPayloadPkg: Set default PciBaseSize on Ia32
2020-10-23 22:36 ` [edk2-devel] " Guo Dong
@ 2020-11-09 10:47 ` Marcello Sylvester Bauer
2020-11-10 4:13 ` Guo Dong
0 siblings, 1 reply; 12+ messages in thread
From: Marcello Sylvester Bauer @ 2020-11-09 10:47 UTC (permalink / raw)
To: Dong, Guo
Cc: devel@edk2.groups.io, Ma, Maurice, patrick.rudolph@9elements.com,
You, Benjamin
[-- Attachment #1: Type: text/plain, Size: 4897 bytes --]
Hi Guo,
Sounds good to remove the IA32 target and stick to a single DSC file.
However, Is there an advantage to remove the PEI phase? It breaks many of
our upcoming patches, which currently rely on the PEI phase (e.g.
SecureBoot support).
In addition to the failed PatchCheck, it does not build on Linux gcc:
https://github.com/9elements/edk2/runs/1373473040
thanks,
Marcello
On Sat, Oct 24, 2020 at 12:36 AM Dong, Guo <guo.dong@intel.com> wrote:
>
>
> Hi Marcello,
>
>
>
> It looks there is issue for the CI tool to complete all the checks. So I
> just closed this PR.
>
>
>
> And I just created another PR https://github.com/tianocore/edk2/pull/1046
> to remove PEI phase from UEFI payload.
>
> If the new patch is approved, we don’t need this patch to update DSC file.
>
> In the new patch, UEFI payload would use a single DSC file to support X64,
> IA32X64 and possibly IA32 build.
>
> Please have a look at that PR and let me know if you have any comments.
>
>
>
> Thanks,
>
> Guo
>
>
>
> *From:* devel@edk2.groups.io <devel@edk2.groups.io> * On Behalf Of *Guo
> Dong
> *Sent:* Thursday, October 22, 2020 7:49 PM
> *To:* Marcello Sylvester Bauer <marcello.bauer@9elements.com>; Ma,
> Maurice <maurice.ma@intel.com>
> *Cc:* devel@edk2.groups.io; patrick.rudolph@9elements.com; You, Benjamin <
> benjamin.you@intel.com>
> *Subject:* Re: [edk2-devel] [PATCH v2 0/1] UefiPayloadPkg: Set default
> PciBaseSize on Ia32
>
>
>
>
>
> Hi Marcello,
>
>
>
> Sorry for late response. I created a pull request
> https://github.com/tianocore/edk2/pull/1044 to merge this patch 2 hours
> ago.
>
> Hopefully it could be merged soon after all the checks.
>
>
>
> Thanks,
>
> Guo
>
>
>
> *From:* Marcello Sylvester Bauer <marcello.bauer@9elements.com>
> *Sent:* Thursday, October 22, 2020 1:25 AM
> *To:* Ma, Maurice <maurice.ma@intel.com>
> *Cc:* devel@edk2.groups.io; patrick.rudolph@9elements.com; Dong, Guo <
> guo.dong@intel.com>; You, Benjamin <benjamin.you@intel.com>
> *Subject:* Re: [PATCH v2 0/1] UefiPayloadPkg: Set default PciBaseSize on
> Ia32
>
>
>
> Hi,
>
> As already mentioned, this patch fixes the current master build for the
> UefiPayloadPkgIa32 platform.
> Is it possible to merge this change soon?
>
>
>
> Sorry for the circumstances.
>
>
> thanks,
> Marcello
>
> On Tue, Oct 13, 2020 at 9:02 PM Ma, Maurice <maurice.ma@intel.com> wrote:
>
> Reviewed-by:
> Maurice Ma <maurice.ma@intel.com>
>
> > -----Original Message-----
> > From: Marcello Sylvester Bauer <marcello.bauer@9elements.com>
> > Sent: Tuesday, October 13, 2020 6:34
> > To: devel@edk2.groups.io
> > Cc: Marcello Sylvester Bauer <marcello.bauer@9elements.com>;
> > patrick.rudolph@9elements.com; Ma, Maurice <maurice.ma@intel.com>; Dong,
> > Guo <guo.dong@intel.com>; You, Benjamin <benjamin.you@intel.com>
> > Subject: [PATCH v2 0/1] UefiPayloadPkg: Set default PciBaseSize on Ia32
> >
> > This commit fix UefiPayloadPkgIa32 build in master.
> >
> > In commit 8028b2907e20b21cd7d69639a36ac82a77c81dc1 I did forget to set
> > the default value for PcdPciExpressBaseSize on Ia32 Targets. This patch
> does
> > insert it afterwards. It would be great if it could be merged asap.
> >
> > PS: I added the Ia32 target to our CI to avoid this issue in future.
> Sorry for the
> > misfortune.
> >
> > v2:
> > * Remove no longer required build-time PcdPciExpressBaseAddress
> >
> > Branch: https://github.com/9elements/edk2/tree/fix/UefiPayloadPkgIa32_V2
> > PR: https://github.com/tianocore/edk2/pull/1008
> >
> > Marcello Sylvester Bauer (1):
> > UefiPayloadPkg: Set default PciBaseSize on Ia32
> >
> > UefiPayloadPkg/UefiPayloadPkgIa32.dsc | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > --
> > 2.28.0
>
>
>
>
> --
>
> *[Marcello Sylvester Bauer]*
>
>
>
> 9elements Agency GmbH, Kortumstraße 19-21, 44787 Bochum, Germany
>
> Email: [DEINE EMAIL ADDRESSE]
> <https://static.9elements.com/email_signatur.html>
>
> Phone: *+49 234 68 94 188 <+492346894188>*
>
> Mobile: *+49 1722847618 <+491722847618>*
>
>
>
> Sitz der Gesellschaft: Bochum
>
> Handelsregister: Amtsgericht Bochum, HRB 17519
>
> Geschäftsführung: Sebastian Deutsch, Eray Basar
>
>
> Datenschutzhinweise nach Art. 13 DSGVO <https://9elements.com/privacy>
>
>
>
--
*[Marcello Sylvester Bauer]*
9elements Agency GmbH, Kortumstraße 19-21, 44787 Bochum, Germany
Email: [DEINE EMAIL ADDRESSE]
<https://static.9elements.com/email_signatur.html>
Phone: *+49 234 68 94 188 <+492346894188>*
Mobile: *+49 1722847618 <+491722847618>*
Sitz der Gesellschaft: Bochum
Handelsregister: Amtsgericht Bochum, HRB 17519
Geschäftsführung: Sebastian Deutsch, Eray Basar
Datenschutzhinweise nach Art. 13 DSGVO <https://9elements.com/privacy>
[-- Attachment #2: Type: text/html, Size: 14812 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [edk2-devel] [PATCH v2 0/1] UefiPayloadPkg: Set default PciBaseSize on Ia32
2020-11-09 10:47 ` Marcello Sylvester Bauer
@ 2020-11-10 4:13 ` Guo Dong
2020-11-10 13:23 ` Marcello Sylvester Bauer
0 siblings, 1 reply; 12+ messages in thread
From: Guo Dong @ 2020-11-10 4:13 UTC (permalink / raw)
To: Marcello Sylvester Bauer
Cc: devel@edk2.groups.io, Ma, Maurice, patrick.rudolph@9elements.com,
You, Benjamin
[-- Attachment #1: Type: text/plain, Size: 6284 bytes --]
Hi Marcello,
Removing the PEI phase could simplify the UEFI payload, the PEI FV will be replaced by a single UefiPayloadEntry module which only does minimal work and passes control to DXE core. So we don’t need have a PEI core and other PEI modules in UEFI payload. It would reduce payload size and improve the boot performance.
I don’t know how your upcoming patches and your secureboot works in UEFI payload PEI. I could take a look and give comments if you have the change list.
Thank you to point out the failure. I will update the patch and create a PR.
Thanks,
Guo
From: Marcello Sylvester Bauer <marcello.bauer@9elements.com>
Sent: Monday, November 9, 2020 3:47 AM
To: Dong, Guo <guo.dong@intel.com>
Cc: devel@edk2.groups.io; Ma, Maurice <maurice.ma@intel.com>; patrick.rudolph@9elements.com; You, Benjamin <benjamin.you@intel.com>
Subject: Re: [edk2-devel] [PATCH v2 0/1] UefiPayloadPkg: Set default PciBaseSize on Ia32
Hi Guo,
Sounds good to remove the IA32 target and stick to a single DSC file. However, Is there an advantage to remove the PEI phase? It breaks many of our upcoming patches, which currently rely on the PEI phase (e.g. SecureBoot support).
In addition to the failed PatchCheck, it does not build on Linux gcc: https://github.com/9elements/edk2/runs/1373473040
thanks,
Marcello
On Sat, Oct 24, 2020 at 12:36 AM Dong, Guo <guo.dong@intel.com<mailto:guo.dong@intel.com>> wrote:
Hi Marcello,
It looks there is issue for the CI tool to complete all the checks. So I just closed this PR.
And I just created another PR https://github.com/tianocore/edk2/pull/1046 to remove PEI phase from UEFI payload.
If the new patch is approved, we don’t need this patch to update DSC file.
In the new patch, UEFI payload would use a single DSC file to support X64, IA32X64 and possibly IA32 build.
Please have a look at that PR and let me know if you have any comments.
Thanks,
Guo
From: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>> On Behalf Of Guo Dong
Sent: Thursday, October 22, 2020 7:49 PM
To: Marcello Sylvester Bauer <marcello.bauer@9elements.com<mailto:marcello.bauer@9elements.com>>; Ma, Maurice <maurice.ma@intel.com<mailto:maurice.ma@intel.com>>
Cc: devel@edk2.groups.io<mailto:devel@edk2.groups.io>; patrick.rudolph@9elements.com<mailto:patrick.rudolph@9elements.com>; You, Benjamin <benjamin.you@intel.com<mailto:benjamin.you@intel.com>>
Subject: Re: [edk2-devel] [PATCH v2 0/1] UefiPayloadPkg: Set default PciBaseSize on Ia32
Hi Marcello,
Sorry for late response. I created a pull request https://github.com/tianocore/edk2/pull/1044 to merge this patch 2 hours ago.
Hopefully it could be merged soon after all the checks.
Thanks,
Guo
From: Marcello Sylvester Bauer <marcello.bauer@9elements.com<mailto:marcello.bauer@9elements.com>>
Sent: Thursday, October 22, 2020 1:25 AM
To: Ma, Maurice <maurice.ma@intel.com<mailto:maurice.ma@intel.com>>
Cc: devel@edk2.groups.io<mailto:devel@edk2.groups.io>; patrick.rudolph@9elements.com<mailto:patrick.rudolph@9elements.com>; Dong, Guo <guo.dong@intel.com<mailto:guo.dong@intel.com>>; You, Benjamin <benjamin.you@intel.com<mailto:benjamin.you@intel.com>>
Subject: Re: [PATCH v2 0/1] UefiPayloadPkg: Set default PciBaseSize on Ia32
Hi,
As already mentioned, this patch fixes the current master build for the UefiPayloadPkgIa32 platform.
Is it possible to merge this change soon?
Sorry for the circumstances.
thanks,
Marcello
On Tue, Oct 13, 2020 at 9:02 PM Ma, Maurice <maurice.ma@intel.com<mailto:maurice.ma@intel.com>> wrote:
Reviewed-by:
Maurice Ma <maurice.ma@intel.com<mailto:maurice.ma@intel.com>>
> -----Original Message-----
> From: Marcello Sylvester Bauer <marcello.bauer@9elements.com<mailto:marcello.bauer@9elements.com>>
> Sent: Tuesday, October 13, 2020 6:34
> To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>
> Cc: Marcello Sylvester Bauer <marcello.bauer@9elements.com<mailto:marcello.bauer@9elements.com>>;
> patrick.rudolph@9elements.com<mailto:patrick.rudolph@9elements.com>; Ma, Maurice <maurice.ma@intel.com<mailto:maurice.ma@intel.com>>; Dong,
> Guo <guo.dong@intel.com<mailto:guo.dong@intel.com>>; You, Benjamin <benjamin.you@intel.com<mailto:benjamin.you@intel.com>>
> Subject: [PATCH v2 0/1] UefiPayloadPkg: Set default PciBaseSize on Ia32
>
> This commit fix UefiPayloadPkgIa32 build in master.
>
> In commit 8028b2907e20b21cd7d69639a36ac82a77c81dc1 I did forget to set
> the default value for PcdPciExpressBaseSize on Ia32 Targets. This patch does
> insert it afterwards. It would be great if it could be merged asap.
>
> PS: I added the Ia32 target to our CI to avoid this issue in future. Sorry for the
> misfortune.
>
> v2:
> * Remove no longer required build-time PcdPciExpressBaseAddress
>
> Branch: https://github.com/9elements/edk2/tree/fix/UefiPayloadPkgIa32_V2
> PR: https://github.com/tianocore/edk2/pull/1008
>
> Marcello Sylvester Bauer (1):
> UefiPayloadPkg: Set default PciBaseSize on Ia32
>
> UefiPayloadPkg/UefiPayloadPkgIa32.dsc | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> --
> 2.28.0
--
[Marcello Sylvester Bauer]
[http://static.9elements.com/logo-signature.png]
9elements Agency GmbH, Kortumstraße 19-21, 44787 Bochum, Germany
Email: [DEINE EMAIL ADDRESSE]<https://static.9elements.com/email_signatur.html>
Phone: +49 234 68 94 188<tel:+492346894188>
Mobile: +49 1722847618<tel:+491722847618>
Sitz der Gesellschaft: Bochum
Handelsregister: Amtsgericht Bochum, HRB 17519
Geschäftsführung: Sebastian Deutsch, Eray Basar
Datenschutzhinweise nach Art. 13 DSGVO<https://9elements.com/privacy>
--
[Marcello Sylvester Bauer]
[http://static.9elements.com/logo-signature.png]
9elements Agency GmbH, Kortumstraße 19-21, 44787 Bochum, Germany
Email: [DEINE EMAIL ADDRESSE]<https://static.9elements.com/email_signatur.html>
Phone: +49 234 68 94 188<tel:+492346894188>
Mobile: +49 1722847618<tel:+491722847618>
Sitz der Gesellschaft: Bochum
Handelsregister: Amtsgericht Bochum, HRB 17519
Geschäftsführung: Sebastian Deutsch, Eray Basar
Datenschutzhinweise nach Art. 13 DSGVO<https://9elements.com/privacy>
[-- Attachment #2: Type: text/html, Size: 22536 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [edk2-devel] [PATCH v2 0/1] UefiPayloadPkg: Set default PciBaseSize on Ia32
2020-11-10 4:13 ` Guo Dong
@ 2020-11-10 13:23 ` Marcello Sylvester Bauer
2020-11-10 19:28 ` Guo Dong
0 siblings, 1 reply; 12+ messages in thread
From: Marcello Sylvester Bauer @ 2020-11-10 13:23 UTC (permalink / raw)
To: Dong, Guo
Cc: devel@edk2.groups.io, Ma, Maurice, patrick.rudolph@9elements.com,
You, Benjamin
[-- Attachment #1: Type: text/plain, Size: 7419 bytes --]
Hi Guo,
> Removing the PEI phase could simplify the UEFI payload, the PEI FV will
be replaced by a single UefiPayloadEntry module which only does minimal
work and passes control to DXE core. So we don’t need have a PEI core and
other PEI modules in UEFI payload. It would reduce payload size and improve
the boot performance.
Okay, this makes very much sense. Is there an approximate estimate of when
it will be finished? It would be great if we could still merge this patch
anyway somehow.
> I don’t know how your upcoming patches and your secureboot works in UEFI
payload PEI. I could take a look and give comments if you have the change
list.
It is still WIP but could be adapted:
https://github.com/9elements/edk2/tree/feature/secureboot
Thanks,
Marcello
On Tue, Nov 10, 2020 at 5:14 AM Dong, Guo <guo.dong@intel.com> wrote:
>
>
> Hi Marcello,
>
>
>
> Removing the PEI phase could simplify the UEFI payload, the PEI FV will be
> replaced by a single UefiPayloadEntry module which only does minimal work
> and passes control to DXE core. So we don’t need have a PEI core and other
> PEI modules in UEFI payload. It would reduce payload size and improve the
> boot performance.
>
>
>
> I don’t know how your upcoming patches and your secureboot works in UEFI
> payload PEI. I could take a look and give comments if you have the change
> list.
>
>
>
> Thank you to point out the failure. I will update the patch and create a
> PR.
>
>
>
> Thanks,
>
> Guo
>
>
>
> *From:* Marcello Sylvester Bauer <marcello.bauer@9elements.com>
> *Sent:* Monday, November 9, 2020 3:47 AM
> *To:* Dong, Guo <guo.dong@intel.com>
> *Cc:* devel@edk2.groups.io; Ma, Maurice <maurice.ma@intel.com>;
> patrick.rudolph@9elements.com; You, Benjamin <benjamin.you@intel.com>
> *Subject:* Re: [edk2-devel] [PATCH v2 0/1] UefiPayloadPkg: Set default
> PciBaseSize on Ia32
>
>
>
> Hi Guo,
>
>
>
> Sounds good to remove the IA32 target and stick to a single DSC file.
> However, Is there an advantage to remove the PEI phase? It breaks many of
> our upcoming patches, which currently rely on the PEI phase (e.g.
> SecureBoot support).
>
> In addition to the failed PatchCheck, it does not build on Linux gcc:
> https://github.com/9elements/edk2/runs/1373473040
>
> thanks,
> Marcello
>
>
>
> On Sat, Oct 24, 2020 at 12:36 AM Dong, Guo <guo.dong@intel.com> wrote:
>
>
>
> Hi Marcello,
>
>
>
> It looks there is issue for the CI tool to complete all the checks. So I
> just closed this PR.
>
>
>
> And I just created another PR https://github.com/tianocore/edk2/pull/1046
> to remove PEI phase from UEFI payload.
>
> If the new patch is approved, we don’t need this patch to update DSC file.
>
> In the new patch, UEFI payload would use a single DSC file to support X64,
> IA32X64 and possibly IA32 build.
>
> Please have a look at that PR and let me know if you have any comments.
>
>
>
> Thanks,
>
> Guo
>
>
>
> *From:* devel@edk2.groups.io <devel@edk2.groups.io> *On Behalf Of *Guo
> Dong
> *Sent:* Thursday, October 22, 2020 7:49 PM
> *To:* Marcello Sylvester Bauer <marcello.bauer@9elements.com>; Ma,
> Maurice <maurice.ma@intel.com>
> *Cc:* devel@edk2.groups.io; patrick.rudolph@9elements.com; You, Benjamin <
> benjamin.you@intel.com>
> *Subject:* Re: [edk2-devel] [PATCH v2 0/1] UefiPayloadPkg: Set default
> PciBaseSize on Ia32
>
>
>
>
>
> Hi Marcello,
>
>
>
> Sorry for late response. I created a pull request
> https://github.com/tianocore/edk2/pull/1044 to merge this patch 2 hours
> ago.
>
> Hopefully it could be merged soon after all the checks.
>
>
>
> Thanks,
>
> Guo
>
>
>
> *From:* Marcello Sylvester Bauer <marcello.bauer@9elements.com>
> *Sent:* Thursday, October 22, 2020 1:25 AM
> *To:* Ma, Maurice <maurice.ma@intel.com>
> *Cc:* devel@edk2.groups.io; patrick.rudolph@9elements.com; Dong, Guo <
> guo.dong@intel.com>; You, Benjamin <benjamin.you@intel.com>
> *Subject:* Re: [PATCH v2 0/1] UefiPayloadPkg: Set default PciBaseSize on
> Ia32
>
>
>
> Hi,
>
> As already mentioned, this patch fixes the current master build for the
> UefiPayloadPkgIa32 platform.
> Is it possible to merge this change soon?
>
>
>
> Sorry for the circumstances.
>
>
> thanks,
> Marcello
>
> On Tue, Oct 13, 2020 at 9:02 PM Ma, Maurice <maurice.ma@intel.com> wrote:
>
> Reviewed-by:
> Maurice Ma <maurice.ma@intel.com>
>
> > -----Original Message-----
> > From: Marcello Sylvester Bauer <marcello.bauer@9elements.com>
> > Sent: Tuesday, October 13, 2020 6:34
> > To: devel@edk2.groups.io
> > Cc: Marcello Sylvester Bauer <marcello.bauer@9elements.com>;
> > patrick.rudolph@9elements.com; Ma, Maurice <maurice.ma@intel.com>; Dong,
> > Guo <guo.dong@intel.com>; You, Benjamin <benjamin.you@intel.com>
> > Subject: [PATCH v2 0/1] UefiPayloadPkg: Set default PciBaseSize on Ia32
> >
> > This commit fix UefiPayloadPkgIa32 build in master.
> >
> > In commit 8028b2907e20b21cd7d69639a36ac82a77c81dc1 I did forget to set
> > the default value for PcdPciExpressBaseSize on Ia32 Targets. This patch
> does
> > insert it afterwards. It would be great if it could be merged asap.
> >
> > PS: I added the Ia32 target to our CI to avoid this issue in future.
> Sorry for the
> > misfortune.
> >
> > v2:
> > * Remove no longer required build-time PcdPciExpressBaseAddress
> >
> > Branch: https://github.com/9elements/edk2/tree/fix/UefiPayloadPkgIa32_V2
> > PR: https://github.com/tianocore/edk2/pull/1008
> >
> > Marcello Sylvester Bauer (1):
> > UefiPayloadPkg: Set default PciBaseSize on Ia32
> >
> > UefiPayloadPkg/UefiPayloadPkgIa32.dsc | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > --
> > 2.28.0
>
>
>
>
> --
>
> *[Marcello Sylvester Bauer]*
>
>
>
> 9elements Agency GmbH, Kortumstraße 19-21, 44787 Bochum, Germany
>
> Email: [DEINE EMAIL ADDRESSE]
> <https://static.9elements.com/email_signatur.html>
>
> Phone: *+49 234 68 94 188 <+492346894188>*
>
> Mobile: *+49 1722847618 <+491722847618>*
>
>
>
> Sitz der Gesellschaft: Bochum
>
> Handelsregister: Amtsgericht Bochum, HRB 17519
>
> Geschäftsführung: Sebastian Deutsch, Eray Basar
>
>
> Datenschutzhinweise nach Art. 13 DSGVO <https://9elements.com/privacy>
>
>
>
>
>
>
> --
>
> *[Marcello Sylvester Bauer]*
>
>
>
> 9elements Agency GmbH, Kortumstraße 19-21, 44787 Bochum, Germany
>
> Email: [DEINE EMAIL ADDRESSE]
> <https://static.9elements.com/email_signatur.html>
>
> Phone: *+49 234 68 94 188 <+492346894188>*
>
> Mobile: *+49 1722847618 <+491722847618>*
>
>
>
> Sitz der Gesellschaft: Bochum
>
> Handelsregister: Amtsgericht Bochum, HRB 17519
>
> Geschäftsführung: Sebastian Deutsch, Eray Basar
>
>
> Datenschutzhinweise nach Art. 13 DSGVO <https://9elements.com/privacy>
>
--
*[Marcello Sylvester Bauer]*
9elements Agency GmbH, Kortumstraße 19-21, 44787 Bochum, Germany
Email: [DEINE EMAIL ADDRESSE]
<https://static.9elements.com/email_signatur.html>
Phone: *+49 234 68 94 188 <+492346894188>*
Mobile: *+49 1722847618 <+491722847618>*
Sitz der Gesellschaft: Bochum
Handelsregister: Amtsgericht Bochum, HRB 17519
Geschäftsführung: Sebastian Deutsch, Eray Basar
Datenschutzhinweise nach Art. 13 DSGVO <https://9elements.com/privacy>
[-- Attachment #2: Type: text/html, Size: 21871 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [edk2-devel] [PATCH v2 0/1] UefiPayloadPkg: Set default PciBaseSize on Ia32
2020-11-10 13:23 ` Marcello Sylvester Bauer
@ 2020-11-10 19:28 ` Guo Dong
2020-11-11 17:51 ` Patrick Rudolph
0 siblings, 1 reply; 12+ messages in thread
From: Guo Dong @ 2020-11-10 19:28 UTC (permalink / raw)
To: devel@edk2.groups.io, marcello.bauer@9elements.com
Cc: Ma, Maurice, patrick.rudolph@9elements.com, You, Benjamin
[-- Attachment #1: Type: text/plain, Size: 9525 bytes --]
Hi Marcello,
The patch passed all checks now .https://github.com/tianocore/edk2/pull/1109
And I just send the patch out for code review. Please comments if you have question.
I briefly reviewed your secureboot work, both BlSMMStoreDxe.inf and SecureBootEnrollDefaultKeys are DXE driver, I don’t see any dependency to PEI.
And here is my though for the overall flow for the default key enrollment:
1. Bootloader pass the NVS variable region to UEFI payload via HOB
* Bootloader might provision the default keys in variable region.
2. UEFI payload retrieve the variable region from HOB.
* This could be done via a PlatformSupportLib instance, or add to ParseLib.
3. UEFI payload BlSupportDxe modules could set variable related PCDs if the variable HOB found.
4. UEFI payload FVB driver or a new driver (SecureBootEnrollDefaultKeys in your case) could check if variable region is initialized. UEFI payload could setup the default Keys only when the variable region is not initialized. This should only happens once if the bootloader doesn’t provision default keys.
5. Use the EDKII variable driver should work.
Feel free to contact me if you want to discuss it further.
Thanks,
Guo
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Marcello Sylvester Bauer
Sent: Tuesday, November 10, 2020 6:24 AM
To: Dong, Guo <guo.dong@intel.com>
Cc: devel@edk2.groups.io; Ma, Maurice <maurice.ma@intel.com>; patrick.rudolph@9elements.com; You, Benjamin <benjamin.you@intel.com>
Subject: Re: [edk2-devel] [PATCH v2 0/1] UefiPayloadPkg: Set default PciBaseSize on Ia32
Hi Guo,
> Removing the PEI phase could simplify the UEFI payload, the PEI FV will be replaced by a single UefiPayloadEntry module which only does minimal work and passes control to DXE core. So we don’t need have a PEI core and other PEI modules in UEFI payload. It would reduce payload size and improve the boot performance.
Okay, this makes very much sense. Is there an approximate estimate of when it will be finished? It would be great if we could still merge this patch anyway somehow.
> I don’t know how your upcoming patches and your secureboot works in UEFI payload PEI. I could take a look and give comments if you have the change list.
It is still WIP but could be adapted: https://github.com/9elements/edk2/tree/feature/secureboot
Thanks,
Marcello
On Tue, Nov 10, 2020 at 5:14 AM Dong, Guo <guo.dong@intel.com<mailto:guo.dong@intel.com>> wrote:
Hi Marcello,
Removing the PEI phase could simplify the UEFI payload, the PEI FV will be replaced by a single UefiPayloadEntry module which only does minimal work and passes control to DXE core. So we don’t need have a PEI core and other PEI modules in UEFI payload. It would reduce payload size and improve the boot performance.
I don’t know how your upcoming patches and your secureboot works in UEFI payload PEI. I could take a look and give comments if you have the change list.
Thank you to point out the failure. I will update the patch and create a PR.
Thanks,
Guo
From: Marcello Sylvester Bauer <marcello.bauer@9elements.com<mailto:marcello.bauer@9elements.com>>
Sent: Monday, November 9, 2020 3:47 AM
To: Dong, Guo <guo.dong@intel.com<mailto:guo.dong@intel.com>>
Cc: devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Ma, Maurice <maurice.ma@intel.com<mailto:maurice.ma@intel.com>>; patrick.rudolph@9elements.com<mailto:patrick.rudolph@9elements.com>; You, Benjamin <benjamin.you@intel.com<mailto:benjamin.you@intel.com>>
Subject: Re: [edk2-devel] [PATCH v2 0/1] UefiPayloadPkg: Set default PciBaseSize on Ia32
Hi Guo,
Sounds good to remove the IA32 target and stick to a single DSC file. However, Is there an advantage to remove the PEI phase? It breaks many of our upcoming patches, which currently rely on the PEI phase (e.g. SecureBoot support).
In addition to the failed PatchCheck, it does not build on Linux gcc: https://github.com/9elements/edk2/runs/1373473040
thanks,
Marcello
On Sat, Oct 24, 2020 at 12:36 AM Dong, Guo <guo.dong@intel.com<mailto:guo.dong@intel.com>> wrote:
Hi Marcello,
It looks there is issue for the CI tool to complete all the checks. So I just closed this PR.
And I just created another PR https://github.com/tianocore/edk2/pull/1046 to remove PEI phase from UEFI payload.
If the new patch is approved, we don’t need this patch to update DSC file.
In the new patch, UEFI payload would use a single DSC file to support X64, IA32X64 and possibly IA32 build.
Please have a look at that PR and let me know if you have any comments.
Thanks,
Guo
From: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>> On Behalf Of Guo Dong
Sent: Thursday, October 22, 2020 7:49 PM
To: Marcello Sylvester Bauer <marcello.bauer@9elements.com<mailto:marcello.bauer@9elements.com>>; Ma, Maurice <maurice.ma@intel.com<mailto:maurice.ma@intel.com>>
Cc: devel@edk2.groups.io<mailto:devel@edk2.groups.io>; patrick.rudolph@9elements.com<mailto:patrick.rudolph@9elements.com>; You, Benjamin <benjamin.you@intel.com<mailto:benjamin.you@intel.com>>
Subject: Re: [edk2-devel] [PATCH v2 0/1] UefiPayloadPkg: Set default PciBaseSize on Ia32
Hi Marcello,
Sorry for late response. I created a pull request https://github.com/tianocore/edk2/pull/1044 to merge this patch 2 hours ago.
Hopefully it could be merged soon after all the checks.
Thanks,
Guo
From: Marcello Sylvester Bauer <marcello.bauer@9elements.com<mailto:marcello.bauer@9elements.com>>
Sent: Thursday, October 22, 2020 1:25 AM
To: Ma, Maurice <maurice.ma@intel.com<mailto:maurice.ma@intel.com>>
Cc: devel@edk2.groups.io<mailto:devel@edk2.groups.io>; patrick.rudolph@9elements.com<mailto:patrick.rudolph@9elements.com>; Dong, Guo <guo.dong@intel.com<mailto:guo.dong@intel.com>>; You, Benjamin <benjamin.you@intel.com<mailto:benjamin.you@intel.com>>
Subject: Re: [PATCH v2 0/1] UefiPayloadPkg: Set default PciBaseSize on Ia32
Hi,
As already mentioned, this patch fixes the current master build for the UefiPayloadPkgIa32 platform.
Is it possible to merge this change soon?
Sorry for the circumstances.
thanks,
Marcello
On Tue, Oct 13, 2020 at 9:02 PM Ma, Maurice <maurice.ma@intel.com<mailto:maurice.ma@intel.com>> wrote:
Reviewed-by:
Maurice Ma <maurice.ma@intel.com<mailto:maurice.ma@intel.com>>
> -----Original Message-----
> From: Marcello Sylvester Bauer <marcello.bauer@9elements.com<mailto:marcello.bauer@9elements.com>>
> Sent: Tuesday, October 13, 2020 6:34
> To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>
> Cc: Marcello Sylvester Bauer <marcello.bauer@9elements.com<mailto:marcello.bauer@9elements.com>>;
> patrick.rudolph@9elements.com<mailto:patrick.rudolph@9elements.com>; Ma, Maurice <maurice.ma@intel.com<mailto:maurice.ma@intel.com>>; Dong,
> Guo <guo.dong@intel.com<mailto:guo.dong@intel.com>>; You, Benjamin <benjamin.you@intel.com<mailto:benjamin.you@intel.com>>
> Subject: [PATCH v2 0/1] UefiPayloadPkg: Set default PciBaseSize on Ia32
>
> This commit fix UefiPayloadPkgIa32 build in master.
>
> In commit 8028b2907e20b21cd7d69639a36ac82a77c81dc1 I did forget to set
> the default value for PcdPciExpressBaseSize on Ia32 Targets. This patch does
> insert it afterwards. It would be great if it could be merged asap.
>
> PS: I added the Ia32 target to our CI to avoid this issue in future. Sorry for the
> misfortune.
>
> v2:
> * Remove no longer required build-time PcdPciExpressBaseAddress
>
> Branch: https://github.com/9elements/edk2/tree/fix/UefiPayloadPkgIa32_V2
> PR: https://github.com/tianocore/edk2/pull/1008
>
> Marcello Sylvester Bauer (1):
> UefiPayloadPkg: Set default PciBaseSize on Ia32
>
> UefiPayloadPkg/UefiPayloadPkgIa32.dsc | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> --
> 2.28.0
--
[Marcello Sylvester Bauer]
[http://static.9elements.com/logo-signature.png]
9elements Agency GmbH, Kortumstraße 19-21, 44787 Bochum, Germany
Email: [DEINE EMAIL ADDRESSE]<https://static.9elements.com/email_signatur.html>
Phone: +49 234 68 94 188<tel:+492346894188>
Mobile: +49 1722847618<tel:+491722847618>
Sitz der Gesellschaft: Bochum
Handelsregister: Amtsgericht Bochum, HRB 17519
Geschäftsführung: Sebastian Deutsch, Eray Basar
Datenschutzhinweise nach Art. 13 DSGVO<https://9elements.com/privacy>
--
[Marcello Sylvester Bauer]
[http://static.9elements.com/logo-signature.png]
9elements Agency GmbH, Kortumstraße 19-21, 44787 Bochum, Germany
Email: [DEINE EMAIL ADDRESSE]<https://static.9elements.com/email_signatur.html>
Phone: +49 234 68 94 188<tel:+492346894188>
Mobile: +49 1722847618<tel:+491722847618>
Sitz der Gesellschaft: Bochum
Handelsregister: Amtsgericht Bochum, HRB 17519
Geschäftsführung: Sebastian Deutsch, Eray Basar
Datenschutzhinweise nach Art. 13 DSGVO<https://9elements.com/privacy>
--
[Marcello Sylvester Bauer]
[http://static.9elements.com/logo-signature.png]
9elements Agency GmbH, Kortumstraße 19-21, 44787 Bochum, Germany
Email: [DEINE EMAIL ADDRESSE]<https://static.9elements.com/email_signatur.html>
Phone: +49 234 68 94 188<tel:+492346894188>
Mobile: +49 1722847618<tel:+491722847618>
Sitz der Gesellschaft: Bochum
Handelsregister: Amtsgericht Bochum, HRB 17519
Geschäftsführung: Sebastian Deutsch, Eray Basar
Datenschutzhinweise nach Art. 13 DSGVO<https://9elements.com/privacy>
[-- Attachment #2: Type: text/html, Size: 35761 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [edk2-devel] [PATCH v2 0/1] UefiPayloadPkg: Set default PciBaseSize on Ia32
2020-11-10 19:28 ` Guo Dong
@ 2020-11-11 17:51 ` Patrick Rudolph
0 siblings, 0 replies; 12+ messages in thread
From: Patrick Rudolph @ 2020-11-11 17:51 UTC (permalink / raw)
To: Dong, Guo
Cc: devel@edk2.groups.io, marcello.bauer@9elements.com, Ma, Maurice,
You, Benjamin
[-- Attachment #1: Type: text/plain, Size: 10076 bytes --]
Hi Guo,
Thanks for the review! I have no objections against your plan. We'll rebase
our patches once it has landed in master.
Having the CI building UefiPayloadPkg would be great to prevent
regressions in the future.
Kind Regards,
Patrick Rudolph
B.Sc. Electrical Engineering
System Firmware Developer
9elements GmbH, Kortumstraße 19-21, 44787 Bochum, Germany
Email: patrick.rudolph@9elements.com
Phone: *+49 234 68 94 188 <+492346894188>*
Sitz der Gesellschaft: Bochum
Handelsregister: Amtsgericht Bochum, HRB 17519
Geschäftsführung: Sebastian Deutsch, Eray Basar
Datenschutzhinweise nach Art. 13 DSGVO <https://9elements.com/privacy>
Am Di., 10. Nov. 2020 um 20:28 Uhr schrieb Dong, Guo <guo.dong@intel.com>:
>
>
> Hi Marcello,
>
>
>
> The patch passed all checks now .
> https://github.com/tianocore/edk2/pull/1109
>
> And I just send the patch out for code review. Please comments if you have
> question.
>
>
>
> I briefly reviewed your secureboot work, both BlSMMStoreDxe.inf and
> SecureBootEnrollDefaultKeys are DXE driver, I don’t see any dependency to
> PEI.
>
> And here is my though for the overall flow for the default key enrollment:
>
> 1. Bootloader pass the NVS variable region to UEFI payload via HOB
> 1. Bootloader might provision the default keys in variable region.
> 2. UEFI payload retrieve the variable region from HOB.
> 1. This could be done via a PlatformSupportLib instance, or add to
> ParseLib.
> 3. UEFI payload BlSupportDxe modules could set variable related PCDs
> if the variable HOB found.
> 4. UEFI payload FVB driver or a new driver
> (SecureBootEnrollDefaultKeys in your case) could check if variable region
> is initialized. UEFI payload could setup the default Keys only when the
> variable region is not initialized. This should only happens once if the
> bootloader doesn’t provision default keys.
> 5. Use the EDKII variable driver should work.
>
> Feel free to contact me if you want to discuss it further.
>
>
>
> Thanks,
>
> Guo
>
>
>
> *From:* devel@edk2.groups.io <devel@edk2.groups.io> * On Behalf Of *Marcello
> Sylvester Bauer
> *Sent:* Tuesday, November 10, 2020 6:24 AM
> *To:* Dong, Guo <guo.dong@intel.com>
> *Cc:* devel@edk2.groups.io; Ma, Maurice <maurice.ma@intel.com>;
> patrick.rudolph@9elements.com; You, Benjamin <benjamin.you@intel.com>
> *Subject:* Re: [edk2-devel] [PATCH v2 0/1] UefiPayloadPkg: Set default
> PciBaseSize on Ia32
>
>
>
> Hi Guo,
>
>
>
> > Removing the PEI phase could simplify the UEFI payload, the PEI FV will
> be replaced by a single UefiPayloadEntry module which only does minimal
> work and passes control to DXE core. So we don’t need have a PEI core and
> other PEI modules in UEFI payload. It would reduce payload size and improve
> the boot performance.
>
>
>
> Okay, this makes very much sense. Is there an approximate estimate of when
> it will be finished? It would be great if we could still merge this patch
> anyway somehow.
>
>
>
> > I don’t know how your upcoming patches and your secureboot works in UEFI
> payload PEI. I could take a look and give comments if you have the change
> list.
>
> It is still WIP but could be adapted:
> https://github.com/9elements/edk2/tree/feature/secureboot
>
> Thanks,
> Marcello
>
>
>
>
>
> On Tue, Nov 10, 2020 at 5:14 AM Dong, Guo <guo.dong@intel.com> wrote:
>
>
>
> Hi Marcello,
>
>
>
> Removing the PEI phase could simplify the UEFI payload, the PEI FV will be
> replaced by a single UefiPayloadEntry module which only does minimal work
> and passes control to DXE core. So we don’t need have a PEI core and other
> PEI modules in UEFI payload. It would reduce payload size and improve the
> boot performance.
>
>
>
> I don’t know how your upcoming patches and your secureboot works in UEFI
> payload PEI. I could take a look and give comments if you have the change
> list.
>
>
>
> Thank you to point out the failure. I will update the patch and create a
> PR.
>
>
>
> Thanks,
>
> Guo
>
>
>
> *From:* Marcello Sylvester Bauer <marcello.bauer@9elements.com>
> *Sent:* Monday, November 9, 2020 3:47 AM
> *To:* Dong, Guo <guo.dong@intel.com>
> *Cc:* devel@edk2.groups.io; Ma, Maurice <maurice.ma@intel.com>;
> patrick.rudolph@9elements.com; You, Benjamin <benjamin.you@intel.com>
> *Subject:* Re: [edk2-devel] [PATCH v2 0/1] UefiPayloadPkg: Set default
> PciBaseSize on Ia32
>
>
>
> Hi Guo,
>
>
>
> Sounds good to remove the IA32 target and stick to a single DSC file.
> However, Is there an advantage to remove the PEI phase? It breaks many of
> our upcoming patches, which currently rely on the PEI phase (e.g.
> SecureBoot support).
>
> In addition to the failed PatchCheck, it does not build on Linux gcc:
> https://github.com/9elements/edk2/runs/1373473040
>
> thanks,
> Marcello
>
>
>
> On Sat, Oct 24, 2020 at 12:36 AM Dong, Guo <guo.dong@intel.com> wrote:
>
>
>
> Hi Marcello,
>
>
>
> It looks there is issue for the CI tool to complete all the checks. So I
> just closed this PR.
>
>
>
> And I just created another PR https://github.com/tianocore/edk2/pull/1046
> to remove PEI phase from UEFI payload.
>
> If the new patch is approved, we don’t need this patch to update DSC file.
>
> In the new patch, UEFI payload would use a single DSC file to support X64,
> IA32X64 and possibly IA32 build.
>
> Please have a look at that PR and let me know if you have any comments.
>
>
>
> Thanks,
>
> Guo
>
>
>
> *From:* devel@edk2.groups.io <devel@edk2.groups.io> *On Behalf Of *Guo
> Dong
> *Sent:* Thursday, October 22, 2020 7:49 PM
> *To:* Marcello Sylvester Bauer <marcello.bauer@9elements.com>; Ma,
> Maurice <maurice.ma@intel.com>
> *Cc:* devel@edk2.groups.io; patrick.rudolph@9elements.com; You, Benjamin <
> benjamin.you@intel.com>
> *Subject:* Re: [edk2-devel] [PATCH v2 0/1] UefiPayloadPkg: Set default
> PciBaseSize on Ia32
>
>
>
>
>
> Hi Marcello,
>
>
>
> Sorry for late response. I created a pull request
> https://github.com/tianocore/edk2/pull/1044 to merge this patch 2 hours
> ago.
>
> Hopefully it could be merged soon after all the checks.
>
>
>
> Thanks,
>
> Guo
>
>
>
> *From:* Marcello Sylvester Bauer <marcello.bauer@9elements.com>
> *Sent:* Thursday, October 22, 2020 1:25 AM
> *To:* Ma, Maurice <maurice.ma@intel.com>
> *Cc:* devel@edk2.groups.io; patrick.rudolph@9elements.com; Dong, Guo <
> guo.dong@intel.com>; You, Benjamin <benjamin.you@intel.com>
> *Subject:* Re: [PATCH v2 0/1] UefiPayloadPkg: Set default PciBaseSize on
> Ia32
>
>
>
> Hi,
>
> As already mentioned, this patch fixes the current master build for the
> UefiPayloadPkgIa32 platform.
> Is it possible to merge this change soon?
>
>
>
> Sorry for the circumstances.
>
>
> thanks,
> Marcello
>
> On Tue, Oct 13, 2020 at 9:02 PM Ma, Maurice <maurice.ma@intel.com> wrote:
>
> Reviewed-by:
> Maurice Ma <maurice.ma@intel.com>
>
> > -----Original Message-----
> > From: Marcello Sylvester Bauer <marcello.bauer@9elements.com>
> > Sent: Tuesday, October 13, 2020 6:34
> > To: devel@edk2.groups.io
> > Cc: Marcello Sylvester Bauer <marcello.bauer@9elements.com>;
> > patrick.rudolph@9elements.com; Ma, Maurice <maurice.ma@intel.com>; Dong,
> > Guo <guo.dong@intel.com>; You, Benjamin <benjamin.you@intel.com>
> > Subject: [PATCH v2 0/1] UefiPayloadPkg: Set default PciBaseSize on Ia32
> >
> > This commit fix UefiPayloadPkgIa32 build in master.
> >
> > In commit 8028b2907e20b21cd7d69639a36ac82a77c81dc1 I did forget to set
> > the default value for PcdPciExpressBaseSize on Ia32 Targets. This patch
> does
> > insert it afterwards. It would be great if it could be merged asap.
> >
> > PS: I added the Ia32 target to our CI to avoid this issue in future.
> Sorry for the
> > misfortune.
> >
> > v2:
> > * Remove no longer required build-time PcdPciExpressBaseAddress
> >
> > Branch: https://github.com/9elements/edk2/tree/fix/UefiPayloadPkgIa32_V2
> > PR: https://github.com/tianocore/edk2/pull/1008
> >
> > Marcello Sylvester Bauer (1):
> > UefiPayloadPkg: Set default PciBaseSize on Ia32
> >
> > UefiPayloadPkg/UefiPayloadPkgIa32.dsc | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > --
> > 2.28.0
>
>
>
>
> --
>
> *[Marcello Sylvester Bauer]*
>
>
>
> 9elements Agency GmbH, Kortumstraße 19-21, 44787 Bochum, Germany
>
> Email: [DEINE EMAIL ADDRESSE]
> <https://static.9elements.com/email_signatur.html>
>
> Phone: +49 234 68 94 188 <+492346894188>
>
> Mobile: +49 1722847618 <+491722847618>
>
>
>
> Sitz der Gesellschaft: Bochum
>
> Handelsregister: Amtsgericht Bochum, HRB 17519
>
> Geschäftsführung: Sebastian Deutsch, Eray Basar
>
>
> Datenschutzhinweise nach Art. 13 DSGVO <https://9elements.com/privacy>
>
>
>
>
> --
>
> *[Marcello Sylvester Bauer]*
>
>
>
> 9elements Agency GmbH, Kortumstraße 19-21, 44787 Bochum, Germany
>
> Email: [DEINE EMAIL ADDRESSE]
> <https://static.9elements.com/email_signatur.html>
>
> Phone: +49 234 68 94 188 <+492346894188>
>
> Mobile: +49 1722847618 <+491722847618>
>
>
>
> Sitz der Gesellschaft: Bochum
>
> Handelsregister: Amtsgericht Bochum, HRB 17519
>
> Geschäftsführung: Sebastian Deutsch, Eray Basar
>
>
> Datenschutzhinweise nach Art. 13 DSGVO <https://9elements.com/privacy>
>
>
>
>
> --
>
> *[Marcello Sylvester Bauer]*
>
>
>
> 9elements Agency GmbH, Kortumstraße 19-21, 44787 Bochum, Germany
>
> Email: [DEINE EMAIL ADDRESSE]
> <https://static.9elements.com/email_signatur.html>
>
> Phone: +49 234 68 94 188 <+492346894188>
>
> Mobile: +49 1722847618 <+491722847618>
>
>
>
> Sitz der Gesellschaft: Bochum
>
> Handelsregister: Amtsgericht Bochum, HRB 17519
>
> Geschäftsführung: Sebastian Deutsch, Eray Basar
>
>
> Datenschutzhinweise nach Art. 13 DSGVO <https://9elements.com/privacy>
>
>
>
[-- Attachment #2: Type: text/html, Size: 30550 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2020-11-11 17:51 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-10-13 13:33 [PATCH v2 0/1] UefiPayloadPkg: Set default PciBaseSize on Ia32 Marcello Sylvester Bauer
2020-10-13 13:33 ` [PATCH v2 1/1] " Marcello Sylvester Bauer
2020-10-13 19:00 ` Ma, Maurice
2020-10-13 19:02 ` [PATCH v2 0/1] " Ma, Maurice
2020-10-22 8:25 ` Marcello Sylvester Bauer
2020-10-23 2:49 ` Guo Dong
[not found] ` <16407F3C2F4AEB24.28553@groups.io>
2020-10-23 22:36 ` [edk2-devel] " Guo Dong
2020-11-09 10:47 ` Marcello Sylvester Bauer
2020-11-10 4:13 ` Guo Dong
2020-11-10 13:23 ` Marcello Sylvester Bauer
2020-11-10 19:28 ` Guo Dong
2020-11-11 17:51 ` Patrick Rudolph
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox