public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Guo Dong" <guo.dong@intel.com>
To: Laszlo Ersek <lersek@redhat.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>,
	"avinok@gmail.com" <avinok@gmail.com>
Cc: "Ma, Maurice" <maurice.ma@intel.com>,
	"You, Benjamin" <benjamin.you@intel.com>
Subject: Re: [edk2-devel] UefiPayloadPkg: Slimboot assign PCIe resource above 4GB. but not supported in UEFIPayload
Date: Mon, 17 Aug 2020 22:43:08 +0000	[thread overview]
Message-ID: <BYAPR11MB362251C16E2013582740C7749E5F0@BYAPR11MB3622.namprd11.prod.outlook.com> (raw)
In-Reply-To: <84de6b28-1a7b-ac17-2aa3-8b6a89aed821@redhat.com>


Thanks for reporting this issue in UEFI payload.
We would enhance the UEFI payload to support the PCI resource to be allocated below 4GB and above 4GB at same time.

Thanks,
Guo

> -----Original Message-----
> From: Laszlo Ersek <lersek@redhat.com>
> Sent: Wednesday, August 12, 2020 10:49 AM
> To: devel@edk2.groups.io; avinok@gmail.com
> Cc: Ma, Maurice <maurice.ma@intel.com>; Dong, Guo <guo.dong@intel.com>;
> You, Benjamin <benjamin.you@intel.com>
> Subject: Re: [edk2-devel] UefiPayloadPkg: Slimboot assign PCIe resource above
> 4GB. but not supported in UEFIPayload
> 
> CC'ing Maurice, Guo, Benjamin
> 
> Thanks
> Laszlo
> 
> On 08/12/20 16:22, Andrey V wrote:
> > Hi
> >
> > I've encountered a problem after using the patch from SBL (slimboot)
> https://github.com/slimbootloader/slimbootloader/pull/809
> > The SBL supports resource allocation above the 4GB, but it fails on ASSERT
> [PciHostBridgeDxe]
> /home/andreyv/edk2/edk2/MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciRoot
> BridgeIo.c(120): Bridge->Mem.Limit < 0x0000000100000000ULL
> >
> > The proposed workaround for this is something like in function
> AdjustRootBridgeResource()
> of  UefiPayloadPkg\Library\PciHostBridgeLib\PciHostBridgeSupport.c :
> >
> > VOID
> >
> > AdjustRootBridgeResource (
> >
> > IN  PCI_ROOT_BRIDGE_APERTURE *Io,
> >
> > IN  PCI_ROOT_BRIDGE_APERTURE *Mem,
> >
> > IN  PCI_ROOT_BRIDGE_APERTURE *MemAbove4G,
> >
> > IN  PCI_ROOT_BRIDGE_APERTURE *PMem,
> >
> > IN  PCI_ROOT_BRIDGE_APERTURE *PMemAbove4G
> >
> > )
> >
> > {
> >
> > Io->Base = 0x1000;
> >
> > Io->Limit = 0xEFFF;
> >
> > Mem ->Base = 0x80000000;
> >
> > Mem ->Limit = 0xCFFFFFFF;
> >
> > PMem ->Base = MAX_UINT64;
> >
> > PMem ->Limit = 0;
> >
> > MemAbove4G->Base = MAX_UINT64;
> >
> > MemAbove4G->Limit = 0;
> >
> > PMemAbove4G->Base = 0x400000000ULL;
> >
> > PMemAbove4G->Limit = 0x7FFFFFFFFULL;
> >
> > }
> >
> > It is working in my board using SBL, but still with a following error
> >
> > PciHostBridge driver failed to set EFI_MEMORY_UC to MMIO aperture - Out
> of Resources.
> >
> > Can someone help to resolve this issue ?
> >
> > Andrey
> >
> > 
> >
> >


  reply	other threads:[~2020-08-17 22:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-12 14:22 UefiPayloadPkg: Slimboot assign PCIe resource above 4GB. but not supported in UEFIPayload Andrey V
2020-08-12 17:48 ` [edk2-devel] " Laszlo Ersek
2020-08-17 22:43   ` Guo Dong [this message]
2020-08-20  9:47     ` Andrey V

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BYAPR11MB362251C16E2013582740C7749E5F0@BYAPR11MB3622.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox