From: "Guo Dong" <guo.dong@intel.com>
To: "Liu, Zhiguang" <zhiguang.liu@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Ma, Maurice" <maurice.ma@intel.com>,
"You, Benjamin" <benjamin.you@intel.com>,
"Ni, Ray" <ray.ni@intel.com>
Subject: Re: [Patch V2 2/2] UefiPayloadPkg: Remove code that installs APCI
Date: Tue, 23 Mar 2021 05:19:44 +0000 [thread overview]
Message-ID: <BYAPR11MB36225D260AC22C0BBE3092A59E649@BYAPR11MB3622.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20210323032438.950-2-zhiguang.liu@intel.com>
Thanks to help make this change.
Reviewed-by: Guo Dong <guo.dong@intel.com>
> -----Original Message-----
> From: Liu, Zhiguang <zhiguang.liu@intel.com>
> Sent: Monday, March 22, 2021 8:25 PM
> To: devel@edk2.groups.io
> Cc: Ma, Maurice <maurice.ma@intel.com>; Dong, Guo <guo.dong@intel.com>;
> You, Benjamin <benjamin.you@intel.com>; Ni, Ray <ray.ni@intel.com>
> Subject: [Patch V2 2/2] UefiPayloadPkg: Remove code that installs APCI
>
> MdeModulePkg\Universal\Acpi\AcpiTableDxe\AcpiTableDxe.inf is capable to
> install
> ACPI table contained in HOB. All ACPI table shoulb be managed by that module.
>
> Cc: Maurice Ma <maurice.ma@intel.com>
> Cc: Guo Dong <guo.dong@intel.com>
> Cc: Benjamin You <benjamin.you@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Signed-off-by: Zhiguang Liu <zhiguang.liu@intel.com>
> ---
> UefiPayloadPkg/BlSupportDxe/BlSupportDxe.c | 13 ++-----------
> UefiPayloadPkg/BlSupportDxe/BlSupportDxe.h | 5 +----
> UefiPayloadPkg/BlSupportDxe/BlSupportDxe.inf | 5 ++---
> 3 files changed, 5 insertions(+), 18 deletions(-)
>
> diff --git a/UefiPayloadPkg/BlSupportDxe/BlSupportDxe.c
> b/UefiPayloadPkg/BlSupportDxe/BlSupportDxe.c
> index a746d0581e..dfff8ecf0e 100644
> --- a/UefiPayloadPkg/BlSupportDxe/BlSupportDxe.c
> +++ b/UefiPayloadPkg/BlSupportDxe/BlSupportDxe.c
> @@ -1,8 +1,8 @@
> /** @file
>
> - This driver will report some MMIO/IO resources to dxe core, extract smbios
> and acpi
>
> + This driver will report some MMIO/IO resources to dxe core, extract smbios
>
> tables from bootloader.
>
>
>
> - Copyright (c) 2014 - 2020, Intel Corporation. All rights reserved.<BR>
>
> + Copyright (c) 2014 - 2021, Intel Corporation. All rights reserved.<BR>
>
> SPDX-License-Identifier: BSD-2-Clause-Patent
>
>
>
> **/
>
> @@ -120,15 +120,6 @@ BlDxeEntryPoint (
> ASSERT (GuidHob != NULL);
>
> SystemTableInfo = (SYSTEM_TABLE_INFO *)GET_GUID_HOB_DATA (GuidHob);
>
>
>
> - //
>
> - // Install Acpi Table
>
> - //
>
> - if (SystemTableInfo->AcpiTableBase != 0 && SystemTableInfo-
> >AcpiTableSize != 0) {
>
> - DEBUG ((DEBUG_ERROR, "Install Acpi Table at 0x%lx, length 0x%x\n",
> SystemTableInfo->AcpiTableBase, SystemTableInfo->AcpiTableSize));
>
> - Status = gBS->InstallConfigurationTable (&gEfiAcpiTableGuid, (VOID
> *)(UINTN)SystemTableInfo->AcpiTableBase);
>
> - ASSERT_EFI_ERROR (Status);
>
> - }
>
> -
>
> //
>
> // Install Smbios Table
>
> //
>
> diff --git a/UefiPayloadPkg/BlSupportDxe/BlSupportDxe.h
> b/UefiPayloadPkg/BlSupportDxe/BlSupportDxe.h
> index 512105fafd..3332a30eae 100644
> --- a/UefiPayloadPkg/BlSupportDxe/BlSupportDxe.h
> +++ b/UefiPayloadPkg/BlSupportDxe/BlSupportDxe.h
> @@ -1,7 +1,7 @@
> /** @file
>
> The header file of bootloader support DXE.
>
>
>
> -Copyright (c) 2014, Intel Corporation. All rights reserved.<BR>
>
> +Copyright (c) 2021, Intel Corporation. All rights reserved.<BR>
>
> SPDX-License-Identifier: BSD-2-Clause-Patent
>
>
>
> **/
>
> @@ -19,12 +19,9 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
> #include <Library/IoLib.h>
>
> #include <Library/HobLib.h>
>
>
>
> -#include <Guid/Acpi.h>
>
> #include <Guid/SmBios.h>
>
> #include <Guid/SystemTableInfoGuid.h>
>
> #include <Guid/AcpiBoardInfoGuid.h>
>
> #include <Guid/GraphicsInfoHob.h>
>
>
>
> -#include <IndustryStandard/Acpi.h>
>
> -
>
> #endif
>
> diff --git a/UefiPayloadPkg/BlSupportDxe/BlSupportDxe.inf
> b/UefiPayloadPkg/BlSupportDxe/BlSupportDxe.inf
> index cebc811355..ad4e0a57a1 100644
> --- a/UefiPayloadPkg/BlSupportDxe/BlSupportDxe.inf
> +++ b/UefiPayloadPkg/BlSupportDxe/BlSupportDxe.inf
> @@ -1,9 +1,9 @@
> ## @file
>
> # Bootloader Support DXE Module
>
> #
>
> -# Report some MMIO/IO resources to dxe core, extract smbios and acpi tables
>
> +# Report some MMIO/IO resources to dxe core, extract smbios tables
>
> #
>
> -# Copyright (c) 2014 - 2020, Intel Corporation. All rights reserved.<BR>
>
> +# Copyright (c) 2014 - 2021, Intel Corporation. All rights reserved.<BR>
>
> #
>
> # SPDX-License-Identifier: BSD-2-Clause-Patent
>
> #
>
> @@ -42,7 +42,6 @@
> HobLib
>
>
>
> [Guids]
>
> - gEfiAcpiTableGuid
>
> gEfiSmbiosTableGuid
>
> gUefiSystemTableInfoGuid
>
> gUefiAcpiBoardInfoGuid
>
> --
> 2.30.0.windows.2
next prev parent reply other threads:[~2021-03-23 5:19 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-23 3:24 [Patch V2 1/2] MdeModulePkg/ACPI: Install ACPI table from HOB Zhiguang Liu
2021-03-23 3:24 ` [Patch V2 2/2] UefiPayloadPkg: Remove code that installs APCI Zhiguang Liu
2021-03-23 3:44 ` Ni, Ray
2021-03-23 5:19 ` Guo Dong [this message]
2021-03-23 3:24 ` [Patch V2 0/2] Let AcpiTableDxe driver install Acpi table from Hob Zhiguang Liu
2021-03-23 12:40 ` [edk2-devel] " Laszlo Ersek
2021-03-23 15:45 ` Guo Dong
2021-03-23 16:12 ` Andrew Fish
2021-03-23 17:29 ` Guo Dong
2021-03-24 5:30 ` Ni, Ray
2021-03-23 16:48 ` Laszlo Ersek
2021-03-23 17:15 ` Guo Dong
2021-03-24 9:50 ` Laszlo Ersek
2021-03-24 4:09 ` Ni, Ray
2021-03-24 10:29 ` Laszlo Ersek
2021-03-23 23:52 ` Benjamin Doron
2021-03-24 9:53 ` Laszlo Ersek
2021-03-24 16:55 ` Benjamin Doron
2021-03-24 18:33 ` Laszlo Ersek
2021-03-25 1:10 ` Ni, Ray
2021-03-25 3:55 ` Andrew Fish
2021-03-25 17:35 ` Laszlo Ersek
2021-03-25 17:33 ` Laszlo Ersek
2021-03-25 1:39 ` Benjamin Doron
2021-03-23 3:44 ` [Patch V2 1/2] MdeModulePkg/ACPI: Install ACPI table from HOB Ni, Ray
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR11MB36225D260AC22C0BBE3092A59E649@BYAPR11MB3622.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox