From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mx.groups.io with SMTP id smtpd.web08.4709.1616476787510261538 for ; Mon, 22 Mar 2021 22:19:47 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=KihrHeQv; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: guo.dong@intel.com) IronPort-SDR: j9aJZfvn1WRt95U2kXxUYFF8iVkFGmoPOP5prNC9jsgAnRFHOGntNSOo0DrUirmpTK8Kowy0nZ boxPhpCckzJw== X-IronPort-AV: E=McAfee;i="6000,8403,9931"; a="190433792" X-IronPort-AV: E=Sophos;i="5.81,270,1610438400"; d="scan'208";a="190433792" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Mar 2021 22:19:46 -0700 IronPort-SDR: 3qr2q+W0R2bXovKn209Vwg7QDnKn6WfHShUM8LuL4VtRwOf9pc1QlXP3fxvYSaLW0lcNeJhtlB 404V/hmWFJJQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,270,1610438400"; d="scan'208";a="381227612" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga007.fm.intel.com with ESMTP; 22 Mar 2021 22:19:45 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Mon, 22 Mar 2021 22:19:45 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Mon, 22 Mar 2021 22:19:45 -0700 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (104.47.56.40) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Mon, 22 Mar 2021 22:19:45 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IA9dzvks4SiJDx1k9t477KP3OEwpe0bkkwXx7MtHQutqVHk4uX2sAbANwI6Jwr9BNPQREKubqMT41z50oHH2Y0mlEu1OTIEMA/k2c9Qbe5DcuLBlyUg6n22Rw9e3t6T+6wD4JKrMdqiOGNch5ScYQ3JxvE5l82yRSgfhTxzlFcEpHQEumdkdElBPJXnM2lrjXQRMn4Tr9OFQft8RvYyDL+c0bLD1OozCyFgDigUginrirOc10jzhReVSAoHx/NF9w8RAP2N8AR5ZzWbxlT526WTG/qbfCbQa/X6eveNM7E3qxZ57AujAKZRcmvcRoZp8oa9RHTwbYq3DkG8XkLCacQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=y271pdjI0MBHUmd/MBX+IUxNePHbjUK2pjqHzzmOVtE=; b=n5RtXqRe7M3jEYcQ4m68LmF55RYo8n7ay0xwE+rNjLyiNHqYZvhcAyPMp501PiGytiy2BG4KX6rLUT4h5UuFq/ls8JB1UcLAGcrbxSB7uAtEoLIKpWlwpQo66Enuz1mnLXXtSaM6XP624O+T6VfbdcxqLc0y+m7vAbFTBrjHYSLMcflV+PUtWV5rx1wB7pEknCJIl2rpiKixp/jDBqy6VPoUUwTUOCHoOXHz02/SSfRVf5xazg/G7f7hiVwndAvWdjFLYNnTgtx/G83HcHOd7xkLt6J+/fmDtG2XKbDjAi3DvnT4aw1A2uJJvtPt4KZ/fnJ7CAS9zlYakU6YCU8sRg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=y271pdjI0MBHUmd/MBX+IUxNePHbjUK2pjqHzzmOVtE=; b=KihrHeQv5+iywf3tYPtgsHScyTiUhAN9mFJPTZDmQjoT2j28pqTzwevvvEO2AIjPjHN4okkVhbgRsf++Br7ZXvGzsFb2A2Xl0Wfl5JYXjhVs6f7QtZD6A/6l7Eo2NFy+qPyWCIJfmqsS2ftfQJGkHVuTsv9//nXX6lUMrDraLhQ= Received: from BYAPR11MB3622.namprd11.prod.outlook.com (2603:10b6:a03:fe::30) by SJ0PR11MB4864.namprd11.prod.outlook.com (2603:10b6:a03:2d4::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.18; Tue, 23 Mar 2021 05:19:44 +0000 Received: from BYAPR11MB3622.namprd11.prod.outlook.com ([fe80::9d0a:3b97:a353:663d]) by BYAPR11MB3622.namprd11.prod.outlook.com ([fe80::9d0a:3b97:a353:663d%3]) with mapi id 15.20.3933.034; Tue, 23 Mar 2021 05:19:44 +0000 From: "Guo Dong" To: "Liu, Zhiguang" , "devel@edk2.groups.io" CC: "Ma, Maurice" , "You, Benjamin" , "Ni, Ray" Subject: Re: [Patch V2 2/2] UefiPayloadPkg: Remove code that installs APCI Thread-Topic: [Patch V2 2/2] UefiPayloadPkg: Remove code that installs APCI Thread-Index: AQHXH5Qk4lehupCvlEOnX/Yt/TBWKKqRCO1Q Date: Tue, 23 Mar 2021 05:19:44 +0000 Message-ID: References: <20210323032438.950-1-zhiguang.liu@intel.com> <20210323032438.950-2-zhiguang.liu@intel.com> In-Reply-To: <20210323032438.950-2-zhiguang.liu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [68.2.51.172] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 2a151171-e4c5-451e-608c-08d8edbb44db x-ms-traffictypediagnostic: SJ0PR11MB4864: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1728; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 5MDtE+dlxgvksbWEbNci4ipH4qYmx9sB+kkFjZzk6A2/dX3KBZY4M3QW6U+i10wd+eFPC6VmF3XCREQtsYjBXeB6yomBap3ZY6b8f72P3fm/97Mj+0+LVBTS3SvKXbAqtA9AVw8wPISBySp0tNdOgDju2yiQlH1Mgh7o3ZVvE8/wb7LtfXZnp09LAs7FI04bsBIcuoXRWBd7/Elp+vvRW9uGq07NRR5WpjpP13+gfCjCogyeG8pFiOgsoQToMbE9gXx0Pm3oflxGvBYUGl9aJsI+rSMwsuB21kMXfzCgUCC0fZk0wTGvmG6W4DxTgIjx/+nWEnrtYWvkAuVFFDqEdaHBGQsEdUGrFSBHandBqTkFNQ50TJ688bIOeyDnaOV5KwOJ4qHHIcnWH9vLyKhgmvOhUZKdD/8K0QJm8R4fY43f+JIKY3VsWrZESayobD4r1/XBfBs+RvldBw7cRqrYEENM8YybhZW1ww2MPCgbfWL3Vsg/3JPQjK9u1YeaJp0F7KGjtSYxLmscGOAw4pdksrXZZMIsTG/LlPj+oRGf0mNtnKdckXAHOKRknmtKuOI1+57axjQF5q7rDOIvleXT1gRmiyhE8cugB1DseCRVOX/J4VZ0dkd9gG6TK5jMRHaFZ4a/lVKE5QN5a5GDveEosGYwIrdC+tuzK7FFKo4heKY= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR11MB3622.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(396003)(39860400002)(136003)(376002)(346002)(366004)(53546011)(478600001)(71200400001)(6506007)(26005)(107886003)(52536014)(9686003)(7696005)(186003)(38100700001)(55016002)(4326008)(5660300002)(110136005)(8676002)(66476007)(66446008)(66556008)(316002)(86362001)(76116006)(66946007)(33656002)(2906002)(83380400001)(8936002)(54906003)(64756008);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?CLGhykjDGWcm/Tv5H4oUl4oDnvYDYE6X9JRdp/XvQjzzEif6pyZxE49lr0Oe?= =?us-ascii?Q?kvEkDIQIGxCNi7M4d6c6paVjx4j1ts7yRnLCUz5Qm917LBib6Z2fvzTh3dS6?= =?us-ascii?Q?H8HZF/qP9sR7LFm31UxVCZPKTBDhiYNK6pJenIStv4LW+4SA8yiWSztroA1K?= =?us-ascii?Q?zjlvlVHzAPrKZcaAGAPL+gCQZKQYvi0pcqZCml7wLU1jO1VLejvoOYvyMtQ/?= =?us-ascii?Q?lVzRJuAfKbRBhXf0ttXymwQTUrxhMBb1BTTTfdBjfujTfdQQmEaVGcmAJtb4?= =?us-ascii?Q?fK5Eu+fSwl2Jh38JI0jCeoEBJCRlbnkrC3pNQa511Q9v5u4aEfichrY05Ftc?= =?us-ascii?Q?RwjFr7EQgEepANhCv8+bYhsNgRpOVxe/IXUbd9vYYoL0cjTO43CmE8S9aPzU?= =?us-ascii?Q?PSX4vQT6PkTdtCYagtI3SUcTIrnWQI2CEvKyZZSj3inIFyz76pJTvDGWWWQh?= =?us-ascii?Q?Lxb6Gt1b48xnHH5RXV4CdZ9/rb2NeCVG/TwR/vxrJRey1gOam649wZ5WFs7Z?= =?us-ascii?Q?LfvjyVNaiWeHAW8JkF29UGIBBlcxoPNLldZmXfmjSL/AaZLNaoJkjvlblxMz?= =?us-ascii?Q?DKBKOzjga1FH+pCnHk/tS+k/nvr/9fM9bTo46srjTae4HkYY+9tmGhdBCxuu?= =?us-ascii?Q?IDhiGLUh1HrJ6x1aVmZTXX0gg9PnAS0KkqGxtrWpNz7TA0iLxE5/eKH1P85R?= =?us-ascii?Q?RJe3ym3jkDMQfVQj8+dV/tLYEzdE61lbMo7gl+ANjpfULmwGddjPa+c0ujvF?= =?us-ascii?Q?OWpHegPp4dm0P7t8gr0ETwnJu9alTTyjTUKFg/3vWntSCUG9QSdVHR7AA9+J?= =?us-ascii?Q?ik+wL9mJeOIHeA+SOeZTwxDmO4PVwSrXI426oW3+uQV/HcjQ5nc4W9Wvsi82?= =?us-ascii?Q?A9e5hn43HzPoaQXfEGpOpcZ/prcncpl7gMwB6KMij7/PVv7O3Dvryctdvd4T?= =?us-ascii?Q?R2t5cDxw8oWPu3ivhB6yQFTxFQWu8eH7YzuPpj/0BpklGRdelBu57kttgbqp?= =?us-ascii?Q?KpZD1PwARSxg2Uq4ovlbvXSpzJ6hR8uC4cO/RPt78j4z4ID1p76inOqbrJB+?= =?us-ascii?Q?XNLZTsg6S8NsdtOggS72g/Lbs1BNX2gEcwlIzSVFk8xWWjzXB6qOTRW/8Rfd?= =?us-ascii?Q?9qDiMd8pmH2ZiwHPNRPbnLMOqrNUxKt26zHwOFUThfbM4mKBctnU8CF+cauz?= =?us-ascii?Q?WjG25go3dPKaSeD0JUcQt2xnmrKeifdDsep97ZfV40B3JaQckWOFcmjTghwD?= =?us-ascii?Q?8xGFdh2xOukpNtbu9lb2fWwETuBSWjT6V0YNr1zRddN3v+y9Tc8JUhNcSV1e?= =?us-ascii?Q?9YY=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3622.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2a151171-e4c5-451e-608c-08d8edbb44db X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Mar 2021 05:19:44.1441 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: FGJOKq3ZHkFYB57FLbsfX5LmkZ4jczmskIBp2vujLDWclhC5ScAGIltyPKdAzgG/ss5h3B4llf1AiWUTPZCepQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB4864 Return-Path: guo.dong@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thanks to help make this change. Reviewed-by: Guo Dong > -----Original Message----- > From: Liu, Zhiguang > Sent: Monday, March 22, 2021 8:25 PM > To: devel@edk2.groups.io > Cc: Ma, Maurice ; Dong, Guo ; > You, Benjamin ; Ni, Ray > Subject: [Patch V2 2/2] UefiPayloadPkg: Remove code that installs APCI >=20 > MdeModulePkg\Universal\Acpi\AcpiTableDxe\AcpiTableDxe.inf is capable to > install > ACPI table contained in HOB. All ACPI table shoulb be managed by that mod= ule. >=20 > Cc: Maurice Ma > Cc: Guo Dong > Cc: Benjamin You > Cc: Ray Ni > Signed-off-by: Zhiguang Liu > --- > UefiPayloadPkg/BlSupportDxe/BlSupportDxe.c | 13 ++----------- > UefiPayloadPkg/BlSupportDxe/BlSupportDxe.h | 5 +---- > UefiPayloadPkg/BlSupportDxe/BlSupportDxe.inf | 5 ++--- > 3 files changed, 5 insertions(+), 18 deletions(-) >=20 > diff --git a/UefiPayloadPkg/BlSupportDxe/BlSupportDxe.c > b/UefiPayloadPkg/BlSupportDxe/BlSupportDxe.c > index a746d0581e..dfff8ecf0e 100644 > --- a/UefiPayloadPkg/BlSupportDxe/BlSupportDxe.c > +++ b/UefiPayloadPkg/BlSupportDxe/BlSupportDxe.c > @@ -1,8 +1,8 @@ > /** @file >=20 > - This driver will report some MMIO/IO resources to dxe core, extract sm= bios > and acpi >=20 > + This driver will report some MMIO/IO resources to dxe core, extract sm= bios >=20 > tables from bootloader. >=20 >=20 >=20 > - Copyright (c) 2014 - 2020, Intel Corporation. All rights reserved.
>=20 > + Copyright (c) 2014 - 2021, Intel Corporation. All rights reserved.
>=20 > SPDX-License-Identifier: BSD-2-Clause-Patent >=20 >=20 >=20 > **/ >=20 > @@ -120,15 +120,6 @@ BlDxeEntryPoint ( > ASSERT (GuidHob !=3D NULL); >=20 > SystemTableInfo =3D (SYSTEM_TABLE_INFO *)GET_GUID_HOB_DATA (GuidHob); >=20 >=20 >=20 > - // >=20 > - // Install Acpi Table >=20 > - // >=20 > - if (SystemTableInfo->AcpiTableBase !=3D 0 && SystemTableInfo- > >AcpiTableSize !=3D 0) { >=20 > - DEBUG ((DEBUG_ERROR, "Install Acpi Table at 0x%lx, length 0x%x\n", > SystemTableInfo->AcpiTableBase, SystemTableInfo->AcpiTableSize)); >=20 > - Status =3D gBS->InstallConfigurationTable (&gEfiAcpiTableGuid, (VOID > *)(UINTN)SystemTableInfo->AcpiTableBase); >=20 > - ASSERT_EFI_ERROR (Status); >=20 > - } >=20 > - >=20 > // >=20 > // Install Smbios Table >=20 > // >=20 > diff --git a/UefiPayloadPkg/BlSupportDxe/BlSupportDxe.h > b/UefiPayloadPkg/BlSupportDxe/BlSupportDxe.h > index 512105fafd..3332a30eae 100644 > --- a/UefiPayloadPkg/BlSupportDxe/BlSupportDxe.h > +++ b/UefiPayloadPkg/BlSupportDxe/BlSupportDxe.h > @@ -1,7 +1,7 @@ > /** @file >=20 > The header file of bootloader support DXE. >=20 >=20 >=20 > -Copyright (c) 2014, Intel Corporation. All rights reserved.
>=20 > +Copyright (c) 2021, Intel Corporation. All rights reserved.
>=20 > SPDX-License-Identifier: BSD-2-Clause-Patent >=20 >=20 >=20 > **/ >=20 > @@ -19,12 +19,9 @@ SPDX-License-Identifier: BSD-2-Clause-Patent > #include >=20 > #include >=20 >=20 >=20 > -#include >=20 > #include >=20 > #include >=20 > #include >=20 > #include >=20 >=20 >=20 > -#include >=20 > - >=20 > #endif >=20 > diff --git a/UefiPayloadPkg/BlSupportDxe/BlSupportDxe.inf > b/UefiPayloadPkg/BlSupportDxe/BlSupportDxe.inf > index cebc811355..ad4e0a57a1 100644 > --- a/UefiPayloadPkg/BlSupportDxe/BlSupportDxe.inf > +++ b/UefiPayloadPkg/BlSupportDxe/BlSupportDxe.inf > @@ -1,9 +1,9 @@ > ## @file >=20 > # Bootloader Support DXE Module >=20 > # >=20 > -# Report some MMIO/IO resources to dxe core, extract smbios and acpi tab= les >=20 > +# Report some MMIO/IO resources to dxe core, extract smbios tables >=20 > # >=20 > -# Copyright (c) 2014 - 2020, Intel Corporation. All rights reserved. >=20 > +# Copyright (c) 2014 - 2021, Intel Corporation. All rights reserved. >=20 > # >=20 > # SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > # >=20 > @@ -42,7 +42,6 @@ > HobLib >=20 >=20 >=20 > [Guids] >=20 > - gEfiAcpiTableGuid >=20 > gEfiSmbiosTableGuid >=20 > gUefiSystemTableInfoGuid >=20 > gUefiAcpiBoardInfoGuid >=20 > -- > 2.30.0.windows.2