From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mx.groups.io with SMTP id smtpd.web12.119.1609972232084703491 for ; Wed, 06 Jan 2021 14:30:32 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=eEda6tH6; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: guo.dong@intel.com) IronPort-SDR: /ADZhLKCHIZibUGYX7RgpLDCaONEvw2h3gf34FQQDO1SHTzTNKoYZIpMmBhSSDkYRZpzCV/gCg cCG46r+2H9eg== X-IronPort-AV: E=McAfee;i="6000,8403,9856"; a="177444565" X-IronPort-AV: E=Sophos;i="5.79,328,1602572400"; d="scan'208";a="177444565" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jan 2021 14:30:19 -0800 IronPort-SDR: Y+mHY04WbZM3wFPgBNCxUbuSzCUK0WIv5T/GrWZ4LC/i3QzwsKvQMg1GF2FhryBDjNTslkpMJ1 6w9a1VsrS9RA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.79,328,1602572400"; d="scan'208";a="350361856" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by orsmga006.jf.intel.com with ESMTP; 06 Jan 2021 14:30:18 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 6 Jan 2021 14:30:18 -0800 Received: from fmsmsx605.amr.corp.intel.com (10.18.126.85) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 6 Jan 2021 14:30:18 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Wed, 6 Jan 2021 14:30:18 -0800 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.176) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Wed, 6 Jan 2021 14:30:17 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XLSmNElEo2lEBOjbGyv3sd5RMlCxcYjFvL3ZAz+T4vKeEp7dmD3YGlEHLN8yJu0rgugJ4GL+Bb7it2EsTKXohijd3Be4gBPNJYpVbeRL2zOfKV8C/lJgNQAZ9Bjr0dXaw7otVyAV4OGpZbczxz5pdGh9fiYN+MhShXD+tTzzRgeFgVpqVml67k0T/7z0gNiuTh4T+eoAJS9nz4bnz1zne3jcDRY+XSoK2ehiRSIBUTx9VvkXKb8UugpYWFjK+7wtXO5Vsf5dmk6bb60d5Mc0g6j6GB+wEK2n48g6dv8waF6rkX5/M3uporpENhrF4yF2r2u6UakAceEWaDrPgaH38A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=E0NV/C3pNokrLfP6W46u//vRZsJ807RjojT3IzjQQmA=; b=kSsbrNSjNLwgKDpG3M7WYdbN0F/OLI4NQA8psYVIT6ikWUmpnWdCU4Nlej0K4CTtweG/dwsVLKlZ0UcZqNnJCrMIMBZUZQahRArS5RsCaHB02jDrWa3teDl2LR3EgOtuoyCYWTuZ6wixT/vnmZBQEA2xsjUL01wdEXzAQM2n5oTSmNrg01TLOf3p4xN8h1dAEibpVxaCDP4i1x/q7NgWi894dPcpmkqQCqVRNbGoFgxNNOeW8w46z/HZCgkU/tmyeGyFVIWUNp4kt8pgtBqpPynrjlFQXr7R3xObCWNvzxjEzMWXCCpS5musmg1ZeDL0G7wQJ6HnX6UmL/RZTXUKHA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=E0NV/C3pNokrLfP6W46u//vRZsJ807RjojT3IzjQQmA=; b=eEda6tH6WydkRXfADyB18c2jN7nHc4bfUpGkL4WHB47w3Hjb5RT9xwFLTe18zyNtL3Y/F5EafgYMz1TyHXkcqZnRw+G1ZP8n2T+ijxc0dpdybD3rVgFGCOnhK/I+1mwHTs3R8OcMU8Tm5Psg3VbzETCarlx6oy/bi4Q4ijkyR1I= Received: from BYAPR11MB3622.namprd11.prod.outlook.com (2603:10b6:a03:fe::30) by BYAPR11MB3814.namprd11.prod.outlook.com (2603:10b6:a03:fb::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3742.6; Wed, 6 Jan 2021 22:30:14 +0000 Received: from BYAPR11MB3622.namprd11.prod.outlook.com ([fe80::cc51:e99f:f09d:1268]) by BYAPR11MB3622.namprd11.prod.outlook.com ([fe80::cc51:e99f:f09d:1268%7]) with mapi id 15.20.3742.006; Wed, 6 Jan 2021 22:30:14 +0000 From: "Guo Dong" To: Patrick Rudolph , "devel@edk2.groups.io" CC: "Ma, Maurice" , "You, Benjamin" Subject: Re: [PATCH 1/2] UefiPayloadPkg: Enable boot logo Thread-Topic: [PATCH 1/2] UefiPayloadPkg: Enable boot logo Thread-Index: AQHW5D3TnLT6G/Rl/0mdoAxy4ZrOOaobLCrg Date: Wed, 6 Jan 2021 22:30:14 +0000 Message-ID: References: <20210106150830.11110-1-patrick.rudolph@9elements.com> <20210106150830.11110-2-patrick.rudolph@9elements.com> In-Reply-To: <20210106150830.11110-2-patrick.rudolph@9elements.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: 9elements.com; dkim=none (message not signed) header.d=none;9elements.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [68.2.51.172] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f2bf845c-7152-40c5-2f7d-08d8b292a303 x-ms-traffictypediagnostic: BYAPR11MB3814: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2657; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Pt1MVCGNzp56ddwf6mlNVmGGc5Nt0YDyMD+q10Nk01NgwOTfPNTDH50m84FtRBmqUhd8R7Be/VJxS5ypwfOtDlLOY1g+QD4lW/XfnemiGpXzyRkTcv9KCitHdrgyNjwKNShoqoMhFX27e9CYc/Hl+yLkyO2E0fLMNEsRZgPy6FG7lMbJME0diyAI4E/p0uxb9pDab7mbYXACI4W64jESTwh/1hRIlML72x6V10mIvQrw6xDEzU4aBA+pfAzTp2G8EujzCNWsV3bX5xkjHNJDvF/s1jm8/yC2aUfdAIdFgOZW0hhVVdf04/zvx7uqg4siClvh36tYXgf/ixmNOpLCSjYIP9uZVGsk2Eki1FLfeioKiS51DbPOD0JR0q9kehuZl9zgElvcXLtj2a6i9qN26Q== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR11MB3622.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(376002)(366004)(136003)(39860400002)(396003)(86362001)(8676002)(33656002)(4326008)(54906003)(316002)(110136005)(26005)(186003)(2906002)(9686003)(64756008)(76116006)(8936002)(66556008)(66446008)(66476007)(66946007)(5660300002)(53546011)(71200400001)(478600001)(107886003)(83380400001)(7696005)(6506007)(52536014)(55016002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?38MzWJWM35DegDVEztkJEfpuCjduLzSs9Hrhz+hxIP9zvUYMlTC+JniJzB7U?= =?us-ascii?Q?Kuo4kAa3ygysebW+8QkPpZUZ/um/Od+5+wjzHjcnzRm+TYwlXp6q6iOoX1V2?= =?us-ascii?Q?IW1eDI0TUXcO2sOrqtsWP1J7WYDgMfcGWuosigF/BoDp6yChquLlZEuty0y/?= =?us-ascii?Q?K7pChmrxlN1ReTO+DofI6nFj972DAVRthQ3l0MspjB+NTYY3STt2pWn/Almp?= =?us-ascii?Q?hyhFVPaa/PItsBA3f3/QEX0iSFzj3uCawGhOCn/MONLOp7Wq4EqB7Qwp3yaL?= =?us-ascii?Q?Prvq7SMjY/QLyjKCNwtExAUBiJn6tRpgC8R+XBguXmNbyIYT8Lh0WNVsF5rk?= =?us-ascii?Q?VAZJdy15QpUvATIDoU7NK5hVsPxiWSnaPltZzVg2WDvtS184oi7Gxo5cczE6?= =?us-ascii?Q?TMTEcwWPaHre/AgARdOc3uGiZ6LcXyIT188HLdBKOpotPxZdeQ9Vw4lkArH6?= =?us-ascii?Q?MFiud5OidLttvarCr0o7JnYSE8a1cv4TB8/aneIhgL36U+8RtUhkeNh+K65F?= =?us-ascii?Q?KzZZZXPKTZ7nKEhCXgyjvayIPNITHFew6xuClETIAudPvEKEcW/etOSrvKQH?= =?us-ascii?Q?Wmyjgx6O1qmP843g0SxuD/sUzGmZ6W+KpJSx7gSrAZ0kn/zmevNVPsb2xZAo?= =?us-ascii?Q?PKYZw/RWpEY0TCZa4NSxxoBX6hvhcPPXjNc6kkMu8Gv16xoYjYVy3RUJYuQM?= =?us-ascii?Q?0QEKJI12Pt9pkWcIBmU90FbbY7MEbcVAHTGvzAdDX3pkb46kfKcqFOCCMCfK?= =?us-ascii?Q?o0kzQuxM0mLTJcfetLPiW8y/X/NnbFLpQtFqejeQYDRLZEgfIoi0lp2xkTQn?= =?us-ascii?Q?cQMB6s+yTTjwTs6ZKbbzmNVIzTRqrD3WLNqXGL18JXFhiPQmHgvXkE0ly76p?= =?us-ascii?Q?1R2VvITAuA3yLsShtWJMKbK6Q5ffkwsv3ZZ1Ke/jjby5W1ihaNiZXrlun0mC?= =?us-ascii?Q?y61AWnPnZhVhITJLi3vBpFQqBdvSDp+YP6n7COUgtKM=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3622.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f2bf845c-7152-40c5-2f7d-08d8b292a303 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Jan 2021 22:30:14.1460 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: JMGGVTLzZHBgjzPKOHjt1o6CUc1471VwOii2tjW+BbnHoHiJ2zyVaAnVHdr2OYZ4JMZ4KpsztjPDCm66XOxgvw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3814 Return-Path: guo.dong@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Patrick, I didn't look at the impl details. If the logo is shown from the bootloader= , how it would be impacted in payload phase? I saw you have clearscreen in this patch. Does it only move the logo to cen= ter of the screen? Thanks, Guo > -----Original Message----- > From: Patrick Rudolph > Sent: Wednesday, January 6, 2021 8:08 AM > To: devel@edk2.groups.io > Cc: Ma, Maurice ; Dong, Guo ; > You, Benjamin > Subject: [PATCH 1/2] UefiPayloadPkg: Enable boot logo >=20 > From: Tim Crawford >=20 > Signed-off-by: Patrick Rudolph > --- > UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManager.c > | 3 +++ >=20 > UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf > | 1 + > UefiPayloadPkg/UefiPayloadPkg.dsc = | 2 ++ > UefiPayloadPkg/UefiPayloadPkg.fdf = | 2 ++ > 4 files changed, 8 insertions(+) >=20 > diff --git > a/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManager.c > b/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManager.c > index c5c6af0abc..2df2d5a02d 100644 > --- > a/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManager.c > +++ > b/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManager.c > @@ -216,6 +216,9 @@ PlatformBootManagerAfterConsole ( > Black.Blue =3D Black.Green =3D Black.Red =3D Black.Reserved =3D 0; >=20 > White.Blue =3D White.Green =3D White.Red =3D White.Reserved =3D 0xFF; >=20 >=20 >=20 > + gST->ConOut->ClearScreen (gST->ConOut); >=20 > + BootLogoEnableLogo (); >=20 > + >=20 > EfiBootManagerConnectAll (); >=20 > EfiBootManagerRefreshAllBootOption (); >=20 >=20 >=20 > diff --git > a/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.i > nf > b/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.i > nf > index 1f5a0bcad0..beba973a70 100644 > --- > a/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.i > nf > +++ > b/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.i > nf > @@ -39,6 +39,7 @@ > UefiRuntimeServicesTableLib >=20 > UefiLib >=20 > UefiBootManagerLib >=20 > + BootLogoLib >=20 > PcdLib >=20 > DxeServicesLib >=20 > MemoryAllocationLib >=20 > diff --git a/UefiPayloadPkg/UefiPayloadPkg.dsc > b/UefiPayloadPkg/UefiPayloadPkg.dsc > index ae62a9c4d6..1a084c479e 100644 > --- a/UefiPayloadPkg/UefiPayloadPkg.dsc > +++ b/UefiPayloadPkg/UefiPayloadPkg.dsc > @@ -169,6 +169,7 @@ > CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.in= f >=20 >=20 > SecurityManagementLib|MdeModulePkg/Library/DxeSecurityManagementLib/ > DxeSecurityManagementLib.inf >=20 >=20 > UefiBootManagerLib|MdeModulePkg/Library/UefiBootManagerLib/UefiBootM > anagerLib.inf >=20 > + BootLogoLib|MdeModulePkg/Library/BootLogoLib/BootLogoLib.inf >=20 >=20 > CustomizedDisplayLib|MdeModulePkg/Library/CustomizedDisplayLib/Customiz > edDisplayLib.inf >=20 >=20 > FrameBufferBltLib|MdeModulePkg/Library/FrameBufferBltLib/FrameBufferBlt > Lib.inf >=20 >=20 >=20 > @@ -389,6 +390,7 @@ > MdeModulePkg/Universal/SecurityStubDxe/SecurityStubDxe.inf >=20 > UefiCpuPkg/CpuDxe/CpuDxe.inf >=20 > MdeModulePkg/Universal/BdsDxe/BdsDxe.inf >=20 > + MdeModulePkg/Logo/LogoDxe.inf >=20 > MdeModulePkg/Application/UiApp/UiApp.inf { >=20 > >=20 >=20 > NULL|MdeModulePkg/Library/DeviceManagerUiLib/DeviceManagerUiLib.inf >=20 > diff --git a/UefiPayloadPkg/UefiPayloadPkg.fdf > b/UefiPayloadPkg/UefiPayloadPkg.fdf > index a97ace7395..98d3fdea4a 100644 > --- a/UefiPayloadPkg/UefiPayloadPkg.fdf > +++ b/UefiPayloadPkg/UefiPayloadPkg.fdf > @@ -112,6 +112,8 @@ INF > MdeModulePkg/Universal/DisplayEngineDxe/DisplayEngineDxe.inf > INF UefiPayloadPkg/BlSupportDxe/BlSupportDxe.inf >=20 >=20 >=20 > INF MdeModulePkg/Universal/SmbiosDxe/SmbiosDxe.inf >=20 > +INF MdeModulePkg/Logo/LogoDxe.inf >=20 > + >=20 > # >=20 > # PCI Support >=20 > # >=20 > -- > 2.26.2