public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Guo Dong" <guo.dong@intel.com>
To: "Ni, Ray" <ray.ni@intel.com>,
	Patrick Rudolph <patrick.rudolph@9elements.com>
Cc: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"Chaganty, Rangasai V" <rangasai.v.chaganty@intel.com>,
	"Bi, Dandan" <dandan.bi@intel.com>,
	"Zeng, Star" <star.zeng@intel.com>,
	"Gao, Zhichao" <zhichao.gao@intel.com>,
	"You, Benjamin" <benjamin.you@intel.com>,
	"philipp.deppenwiese@9elements.com"
	<philipp.deppenwiese@9elements.com>,
	"Ma, Maurice" <maurice.ma@intel.com>
Subject: Re: [edk2-devel] [PATCH - resend] MdeModulePkg/Universal/SmbiosDxe: Scan for existing tables
Date: Wed, 3 Mar 2021 17:53:47 +0000	[thread overview]
Message-ID: <BYAPR11MB36227E184E0D36F21B663A629E989@BYAPR11MB3622.namprd11.prod.outlook.com> (raw)
In-Reply-To: <CO1PR11MB4930D5E8AF9866A6452A690C8C989@CO1PR11MB4930.namprd11.prod.outlook.com>


hi Ray,

Just saw the discussion on this patch.
Both coreboot and SBL would build the whole SMBIOS table and report it to payloads.

For UEFI payload, I think it is not necessary to let other driver (BlSupportDxe) to split the whole SMBIOS table into records.
I would prefer SMBIOS DXE diver could support the whole SMBIOS table from PEI/bootloader.
But it is also possible to support individual records if required by checking AnchorString to know if it is whole table.

Thanks,
Guo

> -----Original Message-----
> From: Ni, Ray <ray.ni@intel.com>
> Sent: Wednesday, March 3, 2021 3:04 AM
> To: Patrick Rudolph <patrick.rudolph@9elements.com>
> Cc: devel@edk2.groups.io; Chaganty, Rangasai V
> <rangasai.v.chaganty@intel.com>; Bi, Dandan <dandan.bi@intel.com>; Zeng,
> Star <star.zeng@intel.com>; Gao, Zhichao <zhichao.gao@intel.com>; You,
> Benjamin <benjamin.you@intel.com>;
> philipp.deppenwiese@9elements.com; Ma, Maurice
> <maurice.ma@intel.com>; Dong, Guo <guo.dong@intel.com>
> Subject: RE: [edk2-devel] [PATCH - resend]
> MdeModulePkg/Universal/SmbiosDxe: Scan for existing tables
> 
> >
> > Hi Ray,
> > thanks for your feedback.
> >
> > Currently a single HOB containing all the SMBIOS table is exported by
> > coreboot.
> > As coreboot doesn't support multiple HOBs with the same ID, #2 isn't a
> > solution.
> 
> Hi Patrick,
> I checked the code in deep.
> The HOB is not created by coreboot. It's the PayloadEntry that creates the
> HOB.
> Can we update PayloadEntry to create multiple HOBs?
> 
> Guo,
> Any comments?
> 
> The reason I like this approach is it doesn't require the other bootloaders to
> write
> a SMBIOS driver that merges all SMBIOS structures together into one table.
> 
> Thanks,
> Ray

  reply	other threads:[~2021-03-03 17:54 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-01 14:32 [PATCH - resend] MdeModulePkg/Universal/SmbiosDxe: Scan for existing tables Patrick Rudolph
2021-03-03  8:13 ` [edk2-devel] " Ni, Ray
2021-03-03  8:37   ` Patrick Rudolph
2021-03-03  9:15     ` Ni, Ray
2021-04-01  4:41       ` Zhiguang Liu
2021-04-01  5:50         ` Patrick Rudolph
2021-03-03 10:03     ` Ni, Ray
2021-03-03 17:53       ` Guo Dong [this message]
2021-03-04  1:03         ` Ni, Ray
2021-03-09  9:05           ` Ni, Ray
2021-03-03 15:29 ` Guo Dong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BYAPR11MB36227E184E0D36F21B663A629E989@BYAPR11MB3622.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox