Re: [PATCH 15/18] UefiPayloadPkg/Library/PlatformBootManagerLib: Remove broken VGA detection

["Guo Dong" <guo.dong@intel.com>]

Reviewed-by: Guo Dong <guo.dong@intel.com>

-----Original Message-----
From: Sean Rhodes <sean@starlabs.systems> 
Sent: Thursday, February 10, 2022 2:28 PM
To: devel@edk2.groups.io
Cc: Dong, Guo <guo.dong@intel.com>; Patrick Rudolph <patrick.rudolph@9elements.com>
Subject: [PATCH 15/18] UefiPayloadPkg/Library/PlatformBootManagerLib: Remove broken VGA detection

From: Patrick Rudolph <patrick.rudolph@9elements.com>

This fixes an issue where the framebuffer provided by coreboot or slimbootloader will only work on the primary VGA device. If the framebuffer corresponds to a different device the screen will stay black.
In addition, the code doesn't work for multiple graphic cards, has reference to non existing functions, and is a duplication of common code.

Call EfiBootManagerConnectVideoController on every display device found, not only the legacy VGA device. This is the same as OvmfPkg does.

Allows to display output on the framebuffer set up by firmware, which might not be the VGA device.

Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>
---
 .../PlatformBootManagerLib/PlatformConsole.c   | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformConsole.c b/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformConsole.c
index c93c7c99b5..bfaf89e74c 100644
--- a/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformConsole.c
+++ b/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformConsole.c
@@ -109,7 +109,7 @@ EFI_DEVICE_PATH_PROTOCOL  *gPlatformRootBridges[] = {
   NULL }; -BOOLEAN  mDetectVgaOnly;+BOOLEAN  mDetectDisplayOnly;  /**   Add IsaKeyboard to ConIn; add IsaSerial to ConOut, ConIn, ErrOut.@@ -482,7 +482,7 @@ DetectAndPreparePlatformPciDevicePath (
                     );   ASSERT_EFI_ERROR (Status); -  if (!mDetectVgaOnly) {+  if (!mDetectDisplayOnly) {     //     // Here we decide whether it is LPC Bridge     //@@ -515,14 +515,14 @@ DetectAndPreparePlatformPciDevicePath (
   }    //-  // Here we decide which VGA device to enable in PCI bus+  // Enable all display devices   //-  if (IS_PCI_VGA (Pci)) {+  if (IS_PCI_DISPLAY (Pci)) {     //     // Add them to ConOut.     //-    DEBUG ((DEBUG_INFO, "Found PCI VGA device\n"));-    PreparePciVgaDevicePath (Handle);+    DEBUG ((DEBUG_INFO, "Found PCI Display device\n"));+    EfiBootManagerConnectVideoController (Handle);     return EFI_SUCCESS;   } @@ -532,7 +532,7 @@ DetectAndPreparePlatformPciDevicePath (
 /**   Do platform specific PCI Device check and add them to ConOut, ConIn, ErrOut -  @param[in]  DetectVgaOnly - Only detect VGA device if it's TRUE.+  @param[in]  DetectDisplayOnly - Only detect display device if it's TRUE.    @retval EFI_SUCCESS - PCI Device check and Console variable update successfully.   @retval EFI_STATUS - PCI Device check or Console variable update fail.@@ -540,10 +540,10 @@ DetectAndPreparePlatformPciDevicePath (
 **/ EFI_STATUS DetectAndPreparePlatformPciDevicePaths (-  BOOLEAN  DetectVgaOnly+  BOOLEAN  DetectDisplayOnly   ) {-  mDetectVgaOnly = DetectVgaOnly;+  mDetectDisplayOnly = DetectDisplayOnly;    EfiBootManagerUpdateConsoleVariable (     ConIn,-- 
2.32.0