From: "Guo Dong" <guo.dong@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"chengchieh@google.com" <chengchieh@google.com>
Subject: Re: [edk2-devel] [PATCH v1 4/6] UefiPayloadPkg: Reserve Payload config in runtime services data
Date: Wed, 4 Aug 2021 02:44:41 +0000 [thread overview]
Message-ID: <BYAPR11MB362293E0AF3E739676F1670D9EF19@BYAPR11MB3622.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20210721132328.1415485-5-chengchieh@google.com>
why build runtime memory allocation hob here?
The PayloadEntry should already got the information and build a new HOB list to DXE core, will anyone access these region late?
If yes, maybe you need add LINUXBOOT_PAYLOAD flag for this code, and update commit message on this.
Thanks,
Guo
-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Cheng-Chieh Huang via groups.io
Sent: Wednesday, July 21, 2021 6:23 AM
To: devel@edk2.groups.io
Cc: Cheng-Chieh Huang <chengchieh@google.com>
Subject: [edk2-devel] [PATCH v1 4/6] UefiPayloadPkg: Reserve Payload config in runtime services data
Signed-off-by: Cheng-Chieh Huang <chengchieh@google.com>
---
UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.c b/UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.c
index ae16f25c7c0e..70afbf83ed4a 100644
--- a/UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.c
+++ b/UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.c
@@ -517,6 +517,8 @@ BuildGenericHob (
// The UEFI payload FV
BuildMemoryAllocationHob (PcdGet32 (PcdPayloadFdMemBase), PcdGet32 (PcdPayloadFdMemSize), EfiBootServicesData);
+ // The UEFI payload config FV
+ BuildMemoryAllocationHob (PcdGet32 (PcdPayloadFdMemBase) - SIZE_64KB, SIZE_64KB, EfiRuntimeServicesData);
//
// Build CPU memory space and IO space hob
--
2.32.0.402.g57bb445576-goog
next prev parent reply other threads:[~2021-08-04 2:44 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-21 13:23 [PATCH 0/6] UefiPayloadPkg: LinuxBoot Support in UefiPayload Cheng-Chieh Huang
2021-07-21 13:23 ` [PATCH v1 1/6] UefiPayloadPkg: Add LINUXBOOT payload target Cheng-Chieh Huang
2021-08-04 2:41 ` [edk2-devel] " Guo Dong
2021-07-21 13:23 ` [PATCH v1 2/6] UefiPayloadPkg: Use legacy timer in Linuxboot payload Cheng-Chieh Huang
2021-08-04 2:22 ` [edk2-devel] " Guo Dong
[not found] ` <1697F93BEFA774AB.32148@groups.io>
2021-08-04 2:52 ` Guo Dong
2021-07-21 13:23 ` [PATCH v1 3/6] UefiPayloadPkg: Update maximum logic processor to 256 Cheng-Chieh Huang
2021-08-04 2:22 ` [edk2-devel] " Guo Dong
[not found] ` <1697F92B243CA725.1963@groups.io>
2021-08-04 2:51 ` Guo Dong
2021-07-21 13:23 ` [PATCH v1 4/6] UefiPayloadPkg: Reserve Payload config in runtime services data Cheng-Chieh Huang
2021-08-04 2:44 ` Guo Dong [this message]
2021-08-04 6:23 ` [edk2-devel] " Cheng-Chieh Huang
2021-08-04 13:37 ` Guo Dong
2021-07-21 13:23 ` [PATCH v1 5/6] UefiPayloadPkg: Add DISABLE_MMX_SSE to avoid generating floating points operation Cheng-Chieh Huang
2021-07-21 16:34 ` [edk2-devel] " Michael D Kinney
2021-07-21 17:42 ` Cheng-Chieh Huang
2021-07-22 1:28 ` 回复: " gaoliming
2021-07-22 2:35 ` Cheng-Chieh Huang
2021-07-23 10:28 ` 回复: " gaoliming
2021-07-23 11:16 ` Cheng-Chieh Huang
2021-07-23 16:45 ` Michael D Kinney
2021-07-23 17:17 ` Cheng-Chieh Huang
2021-07-23 18:38 ` Michael D Kinney
2021-07-21 13:23 ` [PATCH v1 6/6] UefiPayloadPkg: LinuxBoot: use a text format for the configuration block Cheng-Chieh Huang
2021-07-21 17:09 ` [edk2-devel] " Marvin Häuser
2021-07-22 13:48 ` Cheng-Chieh Huang
2021-08-04 3:00 ` Guo Dong
2021-08-07 13:53 ` Cheng-Chieh Huang
2021-07-22 1:29 ` 回复: [edk2-devel] [PATCH 0/6] UefiPayloadPkg: LinuxBoot Support in UefiPayload gaoliming
2021-07-22 3:40 ` Cheng-Chieh Huang
2021-07-22 1:44 ` Ni, Ray
2021-07-22 1:58 ` Daniel Schaefer
2021-07-22 2:48 ` Cheng-Chieh Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR11MB362293E0AF3E739676F1670D9EF19@BYAPR11MB3622.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox