From: "Guo Dong" <guo.dong@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"mjg59@srcf.ucam.org" <mjg59@srcf.ucam.org>,
Laszlo Ersek <lersek@redhat.com>
Cc: "You, Benjamin" <benjamin.you@intel.com>,
"patrick.rudolph@9elements.com" <patrick.rudolph@9elements.com>
Subject: Re: [edk2-devel] UefiPayloadPkg and over-eager PCI resource allocation?
Date: Fri, 8 Jan 2021 02:18:36 +0000 [thread overview]
Message-ID: <BYAPR11MB36229406CC0F50213127ECFB9EAE0@BYAPR11MB3622.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20210107223932.GA30464@codon.org.uk>
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Matthew
> Garrett
> Sent: Thursday, January 7, 2021 3:40 PM
> To: Laszlo Ersek <lersek@redhat.com>
> Cc: devel@edk2.groups.io; You, Benjamin <benjamin.you@intel.com>; Dong,
> Guo <guo.dong@intel.com>; patrick.rudolph@9elements.com
> Subject: Re: [edk2-devel] UefiPayloadPkg and over-eager PCI resource
> allocation?
>
> On Thu, Jan 07, 2021 at 11:28:13PM +0100, Laszlo Ersek wrote:
>
> > But then I run a git-log on
> >
> > UefiPayloadPkg/Library/PciHostBridgeLib
> >
> > and I find *one* commit, namely the *ridiculously* huge commit
> > 04af8bf262f1 ("UefiPayloadPkg: Enhance UEFI payload for coreboot and
> > Slim Bootloader", 2019-04-15).
>
> Yeah, that commit is present in my working tree. And there don't seem to
> be any recent changes to PciHostBridgeDxe. Hmm, now I'm confused.
>
I don't remember we changed PciHostBridgeDxe recently. And also don't know
how it could work if the PCI resource has a big range including PCI CFG space.
Anyway, maybe you could narrow down which commit caused this issue.
Every time we made change, we tried to make it as compatible change.
But I did remove some hardcoded values in the UEFI payload from a big
patch "UefiPayloadPkg: Remove PEI phase from Payload". But I don't know
how they could be related with your current issue.
Thanks,
Guo
>
>
prev parent reply other threads:[~2021-01-08 2:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-27 20:40 UefiPayloadPkg and over-eager PCI resource allocation? mjg59
2021-01-04 3:17 ` [edk2-devel] " Guo Dong
2021-01-04 6:34 ` Benjamin You
2021-01-06 13:56 ` Patrick Rudolph
2021-01-06 22:20 ` Guo Dong
2021-01-06 22:34 ` Matthew Garrett
2021-01-06 23:04 ` Guo Dong
2021-01-07 4:09 ` Benjamin You
2021-01-07 13:14 ` Laszlo Ersek
2021-01-07 22:04 ` Matthew Garrett
2021-01-07 22:28 ` Laszlo Ersek
2021-01-07 22:39 ` Matthew Garrett
2021-01-08 2:18 ` Guo Dong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR11MB36229406CC0F50213127ECFB9EAE0@BYAPR11MB3622.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox