From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mx.groups.io with SMTP id smtpd.web09.2608.1610072325908796109 for ; Thu, 07 Jan 2021 18:18:46 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=CW1/0agV; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: guo.dong@intel.com) IronPort-SDR: rKxOvBUrmgqi/asH2m8LBk8n9hIyT+Br5/N+7QDr3oxxKurOqro0Nx3OJ3fNU8sz0HJLaX+x8G /ZZ6RUSj+Fpg== X-IronPort-AV: E=McAfee;i="6000,8403,9857"; a="177627901" X-IronPort-AV: E=Sophos;i="5.79,330,1602572400"; d="scan'208";a="177627901" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jan 2021 18:18:39 -0800 IronPort-SDR: slnycVCCorWTBWxlFa8h2vwuOvhuLMKgf+D1mQ7sqlnrOO/FmBuAK1cv8Cqb/jeEr2g4OjizkP sHFnRZFMCrhg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.79,330,1602572400"; d="scan'208";a="463249612" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by fmsmga001.fm.intel.com with ESMTP; 07 Jan 2021 18:18:38 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 7 Jan 2021 18:18:38 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Thu, 7 Jan 2021 18:18:38 -0800 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.177) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Thu, 7 Jan 2021 18:18:37 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SJtLfFYutKtidx5g5Sq0t8bvdtxpU6bnbHZMztrYpDicpjoEQVxfuk0e1uDsYWGqgIPZEgOt0QI+FxktLkU2SnIOMUomT0XvI3G7nLiz3GDtmzh4VxVECvLWtvnbiL5isZgjKwTZ4nFjzaenzol6ZoF/2K8QDvi+KGiavj3SmmRRA5TLsewQI513ekihh25cWDf5c5FrPtCch9/VF+naZBrhWG3IfXgVuryDFv0U9dfiyX1BTnuRspjejsiG0m2XS5lfq2JEkfK+t1os25XR8YxQpXNoG/j/wlWSAFWufDe8koyyjO/HVA9h6IN/QFpWv9gWP7CUTPZ32fepMqeGwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AMzx/D1lbOptHVulKWXohLOUT4UghXZO/FqD976ViGU=; b=fSJ9s1vkgylmIs4e1CblUF3Xa59qyUcCaHeApA2AsmepeXnCbuF3wyO27jYe14IHgvB+6VVSHn5sVLJMjffeI8AOwS2OfFBTbxPKO8xCLCSz8gxSMYUoQZ+qKqnX+dlULVLJ8OkzfQk/0qxwk3PdbH9/fm+zuAs58LF2VdSvJv1StrozFw0uqTETnrhiJsvX3P2LO7LqUzrpe3iGoknKGHxIoZ1+ZV34dbDHVf6bb1YaFsmP9GXJ3u/vf20gK/cVw6BzB8TCUlWwWEb7TNCuHf/yxsOss7Zgh6qbhejcmIlkAGAJztIJsWDrUyvjwVaK2APbtQENQc/DTI03NcXUlQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AMzx/D1lbOptHVulKWXohLOUT4UghXZO/FqD976ViGU=; b=CW1/0agVKVkol4S1w9chimMH4eDJTQsX3f1pF/VvsBEWCjQoVVdSWUs9/hXHu2uLyaEpZje1G0xx7Bh2txohatfO2ZmRDNFT7edz58VZ03+0neVlXZz+tkw3HM4qK5pVd6Lv7cl73rfICqfXrZmeSl1k2D3OqbUeJLVXGsiOcBk= Received: from BYAPR11MB3622.namprd11.prod.outlook.com (20.178.239.30) by SJ0PR11MB4816.namprd11.prod.outlook.com (20.182.106.77) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3742.6; Fri, 8 Jan 2021 02:18:36 +0000 Received: from BYAPR11MB3622.namprd11.prod.outlook.com ([fe80::cc51:e99f:f09d:1268]) by BYAPR11MB3622.namprd11.prod.outlook.com ([fe80::cc51:e99f:f09d:1268%7]) with mapi id 15.20.3742.006; Fri, 8 Jan 2021 02:18:36 +0000 From: "Guo Dong" To: "devel@edk2.groups.io" , "mjg59@srcf.ucam.org" , Laszlo Ersek CC: "You, Benjamin" , "patrick.rudolph@9elements.com" Subject: Re: [edk2-devel] UefiPayloadPkg and over-eager PCI resource allocation? Thread-Topic: [edk2-devel] UefiPayloadPkg and over-eager PCI resource allocation? Thread-Index: AQHW4j0GQsuQUlThDUC4pnnMHgHBsKoWxu3ggAA76ACAA6BHAIAAi/oQgAAEm4CAAAP8AIAAWZ8AgACYLQCAAJQdgIAABrWAgAADKQCAADnFoA== Date: Fri, 8 Jan 2021 02:18:36 +0000 Message-ID: References: <20210106223425.GA3280@codon.org.uk> <26ee2dc5-e3fa-8726-eb62-2eb966cc996f@redhat.com> <20210107220413.GA28363@codon.org.uk> <8bf5849f-bb4d-f00c-bdee-d86cabb05754@redhat.com> <20210107223932.GA30464@codon.org.uk> In-Reply-To: <20210107223932.GA30464@codon.org.uk> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-originating-ip: [68.2.51.172] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 73c3dc1a-6dbb-4c8f-c722-08d8b37bb484 x-ms-traffictypediagnostic: SJ0PR11MB4816: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4303; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: b73Mk67K5Ktjwjkn3faQSY0OrH9Zn7DTIFOQS5vQqI7U49IWJ/oRb/vRFsOTYSAYRpIbgGY/f/dUBfyqukVJvccbjGVUzLRvAnQlpw+aK6Im16LiDbrUmj77GntEyZnOqtPo3RvbdT6yzHzeLx8YPw00OT3otUqYT1ptWxj6AQoqNie6DzJWx8UXwRibIXFnpZui2cIy4xNqxAMYwEwz/j3POWr35QGecCQZB8lWpDAzFcCIUKlf82kJ5K37P6Mc5XknNQazkYf1HkIwO/M14uDm4CUH9FDmKiTQfXD1g8pQIVGp8I1C2qrI8CNQZ4yEWtVwH8UaOkuA/7UlcdeiPp3WS/JvSQKCP6sfgm2mqIa1Ir0D/f1puaYYJuPJpPQd/fDbCRiu7gYE2dQBlsL41bVkxIguc8rLlwemDl8YnlN22/t7IRmMsohsUMNxUkFap1c8pI3xayyb3EzDf3lHBQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR11MB3622.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(346002)(366004)(396003)(39860400002)(136003)(53546011)(66946007)(8676002)(316002)(76116006)(33656002)(66476007)(6506007)(66446008)(110136005)(2906002)(83380400001)(8936002)(5660300002)(71200400001)(478600001)(54906003)(55016002)(52536014)(4326008)(186003)(86362001)(9686003)(26005)(966005)(64756008)(66556008)(7696005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?Vdo+8tIDyLOUxBjeAoWtRKW33eVjfsKCjc/zmJ8xvtJorB9M4JSf5TNw233a?= =?us-ascii?Q?chgDRK+bdLMROa+Y3j+kYzl8ozw38X543YUFgV9t6UP2TIaZ7OzFxo0+2wko?= =?us-ascii?Q?fjuTALyHDRGhrxP3OR+hprcW0zjNBo2CVxczaL8g3tmxGfM3iZhGomizGpGA?= =?us-ascii?Q?sNvH/6xcS3BTRK0g7UO9q2E/SJcXv+xfK2f1h4OHxIlbmL2YkkyWpkLk7YgV?= =?us-ascii?Q?QiFsz1rCpiSUb+s32mhuEaY5MvoVBXYK5gi7DofUf8YxKww2YYN1QlEksXXP?= =?us-ascii?Q?AXrirjn+Lss6xe9nvi10BBS2TH8MdeRRyxTQDahDK+KC1CGMXhGgRZglbnve?= =?us-ascii?Q?5MLSJqtwrcSirzd/PZRC6+IUfPVVvHwoOFvn2hzln6/jSXh/ycTZFKBtRPXU?= =?us-ascii?Q?+m2CHcL52bnbuWpQ71rfSral+wQt8i+ZEpxPD5zLh7QUM4HzpWjCTeTBnj2C?= =?us-ascii?Q?ghXQHoU8140TKc36lIEcOtJ0zgYjXUWXdkkBJ2N6RLyBtAg6TzQ3kT84oWEn?= =?us-ascii?Q?mjcOvQpWrZ07hKv/7RttZ8vgN5VfV2tZ0uV+mIOIvZXeJHr+Oi5TW+aNHf2Z?= =?us-ascii?Q?mn/EUHC/dnGXx0g45dLvY+1T8CJ/dlJEqJ7aYiraMOuXAxWWdkfmVfwFXZYu?= =?us-ascii?Q?esIY+6Egzc0PW0WCWYySVdWyjBYfxSBUnZANE05iRtGCZbEl2wtkabXhk/mv?= =?us-ascii?Q?akqyg8vPiKfvZ+Bcl0Clwx5Amq2xEg55sQyKwv7NN29Gthc9ipqp9ZsWaI7x?= =?us-ascii?Q?OiyLBHY9gi0a14d69/ZqVIdKpz6wNfC4EK1xJXOgpu4cUo+2M+m45nLMC4A9?= =?us-ascii?Q?h8pzJ5SZZHIsMJBXNMaMOLtQqBB0V2JB6sLeEYoFTu829psXYazjI+OpwL9w?= =?us-ascii?Q?qR7s8iLKLtrRgsGdQOUdfS/FptMUiUsmeDM3qiYwE0J7V4K8C2oW5lAv5aet?= =?us-ascii?Q?2LcwEaE1JJhmhg95gsWLZXXWUHP9oPeKOoZ4f8atnrc=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3622.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 73c3dc1a-6dbb-4c8f-c722-08d8b37bb484 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Jan 2021 02:18:36.2685 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 9m6w9eMnB2Ti6G4xdO1P0SaQBl/UJZVvlL3Jp4YtX1mpCwEOQyQ7UNeP7aLwS7pCyTXzLv++GZG/MWkMxAbr+Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB4816 Return-Path: guo.dong@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Matthew > Garrett > Sent: Thursday, January 7, 2021 3:40 PM > To: Laszlo Ersek > Cc: devel@edk2.groups.io; You, Benjamin ; Dong, > Guo ; patrick.rudolph@9elements.com > Subject: Re: [edk2-devel] UefiPayloadPkg and over-eager PCI resource > allocation? >=20 > On Thu, Jan 07, 2021 at 11:28:13PM +0100, Laszlo Ersek wrote: >=20 > > But then I run a git-log on > > > > UefiPayloadPkg/Library/PciHostBridgeLib > > > > and I find *one* commit, namely the *ridiculously* huge commit > > 04af8bf262f1 ("UefiPayloadPkg: Enhance UEFI payload for coreboot and > > Slim Bootloader", 2019-04-15). >=20 > Yeah, that commit is present in my working tree. And there don't seem to > be any recent changes to PciHostBridgeDxe. Hmm, now I'm confused. >=20 I don't remember we changed PciHostBridgeDxe recently. And also don't know how it could work if the PCI resource has a big range including PCI CFG sp= ace. Anyway, maybe you could narrow down which commit caused this issue. Every time we made change, we tried to make it as compatible change. But I did remove some hardcoded values in the UEFI payload from a big=20 patch "UefiPayloadPkg: Remove PEI phase from Payload". But I don't know how they could be related with your current issue. Thanks, Guo >=20 >=20