From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web10.479.1651007273064536845 for ; Tue, 26 Apr 2022 14:07:53 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=hDyG0+uW; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: guo.dong@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1651007273; x=1682543273; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=haBPL1b9WSfbAZ7vQcjZ2+qNroFlytsnZtbFNoaC60w=; b=hDyG0+uWn12o084neADmdk3hRtTQHyoU+E8rJq5uAvMdArzDZhjpfhFG YPzhnRiC53/i0iElKnxkxUodK7s/r6lyI+OiP1sL8TkuVB5lH3L7jY0XJ zdAIreSZAGT/PjqcnBIgHvyc6c2vR9Z6yAcTIMokQ3jA8EScZhDKw9avB E2qsdw7Lscvz6i1BbeGpHpUGiW/4NBUOVw1OL8YlPdWqBp9joYbC4hEzK ys8IeBs8Yls6vxTB1ehBUqPAZ8aBnGGgFKg6blrWDge79oFH+QVALfJkd 8AUXUGXGrw4KAxRf6MFxfeFw1AG4eLaZmQ+Jb6Up7u4hmaNa0nsdLt7Bk Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10329"; a="253099229" X-IronPort-AV: E=Sophos;i="5.90,292,1643702400"; d="scan'208";a="253099229" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Apr 2022 14:07:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,292,1643702400"; d="scan'208";a="730456488" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga005.jf.intel.com with ESMTP; 26 Apr 2022 14:07:51 -0700 Received: from fmsmsx606.amr.corp.intel.com (10.18.126.86) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Tue, 26 Apr 2022 14:07:51 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Tue, 26 Apr 2022 14:07:51 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.48) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Tue, 26 Apr 2022 14:07:50 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dJQtpk3LML6OcXasOT0EqldfigMxXuMl22lOYAgeTzKaL/5fR0RK+EB+orkBqZ9FQQ1k/ykF3vhKtvdbL+kiHLjj8hosiLOmi1lYXeBn2g9oKWABSzMIeL+lYyvuR4Dl7I/greOC0ngN5iIf9i4e7npPyE1R3HL/vPlfhRRR7ow04Miv2jq7aVWLaS6ASfDY+Q5bPs5AOIAL0ejq7Ju+M5W1KALRWI4sra3jWmhIhkvshPF+O4xWsZMjoc7x1Gu1vgDlTogsqH3Ih+DdZV1hTXQiEwIHgpav6c6tSLEL7J9xnE7b2bCO7gDIqEl3+lStTscH5RcYP8Vx8v0ZTMba0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hjZnFQN+Fxa0j/zTB8iU9aY0L9XfyYCh7IAIIHccS+c=; b=EKFqO2N6iOVHvQj/7VbWa3UECzyC4VkEvcYE97uwecetmya5IVmAeWvS+AohRR7rsc7ey6GflTfaWWL9UgD5n7J8o8QwBzAlcwdaSs1oLJmkM+HTglYCp/ZDSPgm1oRtphzPpFbfEHr7iS0qf40IruQ6LTGzQK4ig8robBZpTu0PUALzewPp7dRc/4p5kcdBPqtSiR+Q7f1bvTqLjn1quFgX2BtNBnY3KdSNxdeVlMPvz28c6ZkQBN0Wg5FP2UJ+cpmOMBYH/NX5FVq1M37v3Ode6F6LIL+7hihO8Gm/ynrBxHlFs+z7Kk75BYz4hwZPYLMekPK8A5jcMvMvcTwbqw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BYAPR11MB3622.namprd11.prod.outlook.com (2603:10b6:a03:fe::30) by CO1PR11MB5121.namprd11.prod.outlook.com (2603:10b6:303:98::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.13; Tue, 26 Apr 2022 21:07:49 +0000 Received: from BYAPR11MB3622.namprd11.prod.outlook.com ([fe80::106d:fdf2:29cf:4a30]) by BYAPR11MB3622.namprd11.prod.outlook.com ([fe80::106d:fdf2:29cf:4a30%7]) with mapi id 15.20.5186.021; Tue, 26 Apr 2022 21:07:49 +0000 From: "Guo Dong" To: "Tan, Dun" , "devel@edk2.groups.io" CC: "Ni, Ray" , "You, Benjamin" , "Rhodes, Sean" , "Liu, Zhiguang" Subject: Re: [PATCH] UefiPayloadPkg: Add definition for LinuxCommandLine HOB Thread-Topic: [PATCH] UefiPayloadPkg: Add definition for LinuxCommandLine HOB Thread-Index: AQHYVfw2tW3kRE1rc0a+/8C0x7Xjmaz7XptggAAiVACABzSJAA== Date: Tue, 26 Apr 2022 21:07:48 +0000 Message-ID: References: <20220422035047.1130-1-dun.tan@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.401.20 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 8b744f14-9807-4841-922d-08da27c8d1a4 x-ms-traffictypediagnostic: CO1PR11MB5121:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: W1Aas0p5kzs0x7PUNfT77D3QnMaVuZs9Q43QE4e5Vdf6NUHGsFAyS2zDN0GQx7sVIiTOowR1dMTZVS1HAkmXJEEw3OZqv7+7Fux4wN9UApK7A5tI1ighNikjcYtr1I/DRlrHRUj5Hw3XrWSzBT1jnGi1ZfqDKxlJigQb1/cz0HzSmFNpbqplkhgywQo0E8Mu8nXOJzwzbTq2074+U6XlNpYjBwEZu6vjGq8DpF3X/wmtxitrrfNLVykd4Tz+92AFrfsmIEiPe3cc87LDc/jGpMmd2WhD0ImNgNntQGOuYEw+IwOFtpvr5I847v+zsHDpD8Xm2PRw8EA5EeZJsxpC/2P7vpOZdJzVLWi49h2gpi6juhxgNoXYUJ4MloObHlRxvi6jG4aEop/1toRE908RiWJSdLkVSyYtw21ilD9f/Hw5gO4u+1Crb1tUpQq3QztrWztAb4jtSAwOAePuNFvHomI3Gd3kkttR9MdHt+EDeYl/AWziZNtWZAXFJA/o1Ttr/l11enwMmRo+gAJConF9+F2Wp5QAwIQ0tawSsdpfNDzay3bmYNWBF9vgMUkFwi7G+8SwSeqq5/y4KbX9+zCnr9o4itM6scEZowiEw9S7c723+kFVR/EIVs7Cw6/Ps0s2Nhbn9SvlC4+ep9G3oD6WtKj4v2GkUyItw/XqYw/wPDPCL3HRmHaRr3zjSku4N9tlpgHf8fP5q4eLpklFdUu/+g== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR11MB3622.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(9686003)(38070700005)(53546011)(38100700002)(55016003)(33656002)(5660300002)(316002)(71200400001)(66446008)(4326008)(26005)(6506007)(7696005)(107886003)(2906002)(86362001)(186003)(82960400001)(122000001)(64756008)(508600001)(8936002)(110136005)(54906003)(66946007)(8676002)(66476007)(52536014)(66556008)(76116006)(83380400001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?WD5LJY8fq0SGjNKl4Y5IhscCGo5L7oisaKJfLFyh5mbbo7NkyGv5nLwi8fiQ?= =?us-ascii?Q?j2WuMn3xyz9y2Nw3psZRwA3NchS2/MnDjOHq0ThG2r+kshY9QNE6dwiHzi/V?= =?us-ascii?Q?r1FqTgbi2340xby+OYDTRRJMgKojhLR4nUQ/Mdmc+AWsffZ1lzFlJ1nUU0lT?= =?us-ascii?Q?UzB8SnfrQMbz8SlQNWMIRIl6NzSSJMEnzU0QkXQUoXJUIc76EuBFPzWsnfCK?= =?us-ascii?Q?LazXbeimngO8pgAFXbsI5GLnEtm2NH4ibMAuSXwm6VNjQFn+zXW6siZFCb0a?= =?us-ascii?Q?r+/BlcXTfsVFLP1yi3tnDeQ9QvprRIqmFZH1Ydx7TUE3x4YHeveLi21547GF?= =?us-ascii?Q?teE+FXiasApgsNgWhPGBitMNp8a5ns+VbfQVdRVP8iyszWvOZ0YXx2HSojL/?= =?us-ascii?Q?Jy7VRCPHSytku5+UicF86vj5zh2ZNCDSCLgImVv5AWWUhUW4Nf8Pks/Y0xP6?= =?us-ascii?Q?cO+s7Pqyq3OcKnaDFhwM+og6v9m94fyFK4SwDd4LqmXcmfAZ0t0AritcC+Hc?= =?us-ascii?Q?wXIwN0EDkm/4Fsx3N0qTSZMVEFlx0S/Q4RLJ2/1zV0xqQlCzOED3u1yMzPSl?= =?us-ascii?Q?9BqIpvgSADwlcbYJebL4GGfbUVZ0+FzABU0+liTbWk8xOmx/q8jIsTDcxXuU?= =?us-ascii?Q?fUXLi8Tydr0ts+gmDMV1PSax8AfdUvyhXh/M9o7iESAJP2O6UgDlkE4Hj+PK?= =?us-ascii?Q?AN7VsrqUNw+Jt3ij2jdhsoxMCZZKSCGoOBtFyYPmYoyJwRCqaTWPI4uonU9v?= =?us-ascii?Q?QB1WNV8KKHPbhmh0EYFZrHkqHVnXTv5Jt4RLV66iNxNJV6JhZxX3HvHlfWxl?= =?us-ascii?Q?R2z0BzsuA5/nplnBqcBRtdTNVc8Iqw5wFGy9LyC74Lt0K3GVyyegwcf/MN3j?= =?us-ascii?Q?TO+tAZEDJW/OdL/eEBajgYP63LwLCsCrk6Ew2QgFMyhz76413JmGnPyJrYD/?= =?us-ascii?Q?YgZDLXO4hKsBBEDX92f+Mo8Xhocidi7BI+vWlLEyI7z+KU3t4UegBqs1D0Bh?= =?us-ascii?Q?Lpb/v9GuTkLMu32+kAXibpWI62b1ITtL/Q1EXgkk+adPO8t45Pg0+nuYd92n?= =?us-ascii?Q?DqoIV1GkBksIiDQL6+NTz+7Z5IIlLH0IF/a9jd/DyvCTD71cQAfnkKfIYP7g?= =?us-ascii?Q?nFYlwg2dbRjx4KF+hjPCu8QI69HozU8sBzEG1UfyFp8PNaGsJceEoOXjneXb?= =?us-ascii?Q?wfDPxGCGVnwBVLKkAT2T+n8faRTFs4OqdHNckVn63z9Wlw2g0wgHI7VC6dQK?= =?us-ascii?Q?cFERibMYYQSzsF4A3p2osoQLvVGwvXB8a1fbP+cZPBIOpAGGN5cpI+7sKwj6?= =?us-ascii?Q?aEefrFwbdp7fJ626RM2wd6HOMwq9kco3V+RReClZIYeuDUyilpd2zpWYet7L?= =?us-ascii?Q?ecLJAc1ryJESs25fNKO6RfTPlbaSStrX0yD0tKih85mXLb7JOjDKUTv8ksU7?= =?us-ascii?Q?LsrqYw6jDlQhl5XiUo0/XmwmKS+qZ7M8b6ETNdw9UdiRJhfOF2jYS9iDsN19?= =?us-ascii?Q?1WYz24lLCbnslbyN1EijsXTF5nWndKEzmLq+UEIndJIfc7WZRh2aF7ps/Fj7?= =?us-ascii?Q?n6DjR5bwtcGFcYNY3NH92I/MFwP1fXHiP5h3J2ZIwLNcUhDxFAu6XNxkFeHc?= =?us-ascii?Q?UilbQiXVy9+1MfLuAg9dUKkFDP8LeKz9mbpWMbLlZHRTUnnGGU4kA0qmJ3dn?= =?us-ascii?Q?jWD5JVBwE5RHj0pesbWnYoCLZULRxfcfEpaneGoo3QJxMgPzJM715o9OTUTU?= =?us-ascii?Q?eUUvaglCFQ=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3622.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8b744f14-9807-4841-922d-08da27c8d1a4 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Apr 2022 21:07:49.0043 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: D9+NS3S8JDlR6pTOJPxCf2ekNBBEQBsmfhZCSL7pHaV2gIT90Q69oo4dgiO0ZI0hwg5Tton0dV6F7RBDthi+7g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB5121 Return-Path: guo.dong@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Dun, This patch adds an interface (passing command line HOB) between bootloader = and UEFI payload. Do you mean the use case is that bootloader passes this HOB to UEFI payloa= d, then UEFI payload would launch LinuxPayload with this command line? If so, how the UEFI payload knows it is LinuxPayload so it would pass this = command line? Thanks, Guo -----Original Message----- From: Tan, Dun =20 Sent: Thursday, April 21, 2022 11:59 PM To: Dong, Guo ; devel@edk2.groups.io Cc: Ni, Ray ; You, Benjamin ; Rho= des, Sean ; Liu, Zhiguang Subject: RE: [PATCH] UefiPayloadPkg: Add definition for LinuxCommandLine HO= B Hi Guo, Thanks for the comments!=20 This Hob is used to pass Linux command line to LinuxPayload instead of OSes= . For LinuxPayload, it only needs the Linux Command Line. Thanks, Dun -----Original Message----- From: Dong, Guo =20 Sent: Friday, April 22, 2022 1:09 PM To: Tan, Dun ; devel@edk2.groups.io Cc: Ni, Ray ; You, Benjamin ; Rho= des, Sean ; Liu, Zhiguang Subject: RE: [PATCH] UefiPayloadPkg: Add definition for LinuxCommandLine HO= B Minor comments: It would be great if adding some descriptions to the fields to make its usa= ge more clear. Maybe we need give this header file and structure a more generic name by us= ing "OS" instead of "LINUX" so that bootloader could pass command line to A= ndroid and other OSes using same structure. With current definition it looks bootloader could only pass 1 command line = to payload. I am not sure if there is a case that bootloader need pass mult= iple command line so that payload could pick up one of them for OS. +typedef struct { + UNIVERSAL_PAYLOAD_GENERIC_HEADER Header; + UINT32 Count; + CHAR8 CommandLine[0]; +} UNIVERSAL_PAYLOAD_LINUX_COMMAND_LINE; Thanks, Guo -----Original Message----- From: Tan, Dun Sent: Thursday, April 21, 2022 8:51 PM To: devel@edk2.groups.io Cc: Ni, Ray ; Dong, Guo ; You, Benjam= in ; Rhodes, Sean ; Liu, Zhi= guang Subject: [PATCH] UefiPayloadPkg: Add definition for LinuxCommandLine HOB Add definition for UNIVERSAL_PAYLOAD_LINUX_COMMAND_LINE Hob. This Hob is used to pass Linux Kernel command Line to Payload Signed-off-by: Dun Tan Cc: Ray Ni Cc: Guo Dong Cc: Benjamin You Cc: Sean Rhodes Cc: Zhiguang Liu Signed-off-by: Dun Tan --- UefiPayloadPkg/Include/Guid/LinuxCommandLine.h | 28 ++++++++++++++++++++++= ++++++ UefiPayloadPkg/UefiPayloadPkg.dec | 1 + 2 files changed, 29 insertions(+) diff --git a/UefiPayloadPkg/Include/Guid/LinuxCommandLine.h b/UefiPayloadPk= g/Include/Guid/LinuxCommandLine.h new file mode 100644 index 0000000000..0bb75238e7 --- /dev/null +++ b/UefiPayloadPkg/Include/Guid/LinuxCommandLine.h @@ -0,0 +1,28 @@ +/** @file + Define the structure for the Linux command line Hob. + +Copyright (c) 2022, Intel Corporation. All rights reserved.
+SPDX-License-Identifier: BSD-2-Clause-Patent + +**/ + +#ifndef LINUX_COMMAND_LINE_GUID_H_ +#define LINUX_COMMAND_LINE_GUID_H_ + +#include +#include + +#pragma pack (1) + +typedef struct { + UNIVERSAL_PAYLOAD_GENERIC_HEADER Header; + UINT32 Count; + CHAR8 CommandLine[0]; +} UNIVERSAL_PAYLOAD_LINUX_COMMAND_LINE; + +#pragma pack() + +#define UNIVERSAL_PAYLOAD_LINUX_COMMAND_LINE_REVISION 1 + +extern GUID gEdkiiLinuxCommandLineGuid; #endif diff --git a/UefiPayloadPkg/UefiPayloadPkg.dec b/UefiPayloadPkg/UefiPayload= Pkg.dec index 5c1aeb8235..494ef94932 100644 --- a/UefiPayloadPkg/UefiPayloadPkg.dec +++ b/UefiPayloadPkg/UefiPayloadPkg.dec @@ -35,6 +35,7 @@ gUefiAcpiBoardInfoGuid =3D {0xad3d31b, 0xb3d8, 0x4506, {0xae, 0x71, 0x= 2e, 0xf1, 0x10, 0x6, 0xd9, 0xf}} gUefiSerialPortInfoGuid =3D { 0x6c6872fe, 0x56a9, 0x4403, { 0xbb, 0x98,= 0x95, 0x8d, 0x62, 0xde, 0x87, 0xf1 } } gLoaderMemoryMapInfoGuid =3D { 0xa1ff7424, 0x7a1a, 0x478e, { 0xa9, 0xe4,= 0x92, 0xf3, 0x57, 0xd1, 0x28, 0x32 } } + gEdkiiLinuxCommandLineGuid =3D {0xb5aeb34f, 0x3047, 0x4955, {0xb8,=20 + 0x80, 0xad, 0xd3, 0x6d, 0x86, 0xdc, 0x0f}} =20 # SMM variable support gNvVariableInfoGuid =3D { 0x7a345dca, 0xc26, 0x4f2a, { 0xa8, 0x9a,= 0x57, 0xc0, 0x8d, 0xdd, 0x22, 0xee } } -- 2.31.1.windows.1