From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mx.groups.io with SMTP id smtpd.web12.42247.1605563925363160671 for ; Mon, 16 Nov 2020 13:58:45 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=rwUq8F0d; spf=pass (domain: intel.com, ip: 192.55.52.88, mailfrom: guo.dong@intel.com) IronPort-SDR: g5xOSlBrCAHIUqpzo6GSnnptSJ9zrRKawyi++v5/599ssg99atcDgY8PoxqEGKLwD/NSGYT5UU e4TBfy8qYUNQ== X-IronPort-AV: E=McAfee;i="6000,8403,9807"; a="188872405" X-IronPort-AV: E=Sophos;i="5.77,483,1596524400"; d="scan'208";a="188872405" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Nov 2020 13:58:36 -0800 IronPort-SDR: wOf9vvutOYp/Kq8q3C0hnEVc+T3IfJhfB0AHb4cQeRqQu72cNSFTILkSctSrqsTEkpJKQj2FjQ FA8UU5uJnqLQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,483,1596524400"; d="scan'208";a="310522335" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by fmsmga007.fm.intel.com with ESMTP; 16 Nov 2020 13:58:33 -0800 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 16 Nov 2020 13:58:33 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Mon, 16 Nov 2020 13:58:33 -0800 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.107) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Mon, 16 Nov 2020 13:58:32 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oRAuqpex7491C5vea1TMBLQxEaKO0bKbWMBne5VfHwd1EAkwTC4WTBhZzY44mWTav+bQ5HiezkP8IrTpTBRNY6YC5vcjr3j/jop0O04Fi7Ixr9nuw/nKRIUeVnRJH68nqqMpoSHxNy1PsH6M3/CnMQu4Kf0VdT21BTeozSuYtBndCQ0kaQgT/7Uq9HAagxkHqDnutfvpwJgYSgD1d5J2u7E+MPDmDRh7M5IkTaFU4MPIHW3LjetgiCYHOZotaqDtZEA3KTUZsnROK+/T81RmQ9AwDokn5aYxmrIh8ZRM3wOJ++iDwMCxPaG6TuMe+todDK7rgED05SZNmtPAfC7BDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RjM/y3gYafBttnsSIMD5Vjbyk6/B4DQymOfYZJF71CE=; b=Wv9yVrln9MG3iMdcWHJlRi953KW58seGy1BeJW4Vp7gOw+vEAJJqU0CZNGUmjQsyyEngXUCX/bR3tuWE7wmoFrwJw08bKM/GSW2EUoqD7zO0k/RRCRYx3VIS1tXqNcQ8HW9QMGKmC44799DHoDooSyYxpPlaalddb3TSh8H4kvDQirL+HL5xIhotXB1DZ2Wi/TXzh+rD+OyrFvTEx7+qSlCMD884vFDvd8CqULAkGLZapcWWMuYa1eCGUZZKLo1Qf2S8jZz4gYl6fPf+oOQy7e9WgyPOa2EQj1puJRxQ6Wz7VRfFJ+mRNBqifd+kStgAms5bt/QlU0ynEeYgQ6+K4Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RjM/y3gYafBttnsSIMD5Vjbyk6/B4DQymOfYZJF71CE=; b=rwUq8F0dfRU5KKuy91JkNp1Bzpk+HpcCOIMIeiimeuWQbXXf0H38e96OPONY9uOX/mfqaTFDN3vYxLccLHzL7U672iC1/A5bTFOVAOav3FrL87s4b7nbFQ/pNuyeUBOAcEkzzr743MDyxKYmbjDBaKBdjPLu4wx6Tz7QSJT+j2E= Received: from BYAPR11MB3622.namprd11.prod.outlook.com (2603:10b6:a03:fe::30) by BYAPR11MB2630.namprd11.prod.outlook.com (2603:10b6:a02:c2::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3541.21; Mon, 16 Nov 2020 21:58:31 +0000 Received: from BYAPR11MB3622.namprd11.prod.outlook.com ([fe80::d192:c1f8:f66e:28bf]) by BYAPR11MB3622.namprd11.prod.outlook.com ([fe80::d192:c1f8:f66e:28bf%4]) with mapi id 15.20.3564.028; Mon, 16 Nov 2020 21:58:31 +0000 From: "Guo Dong" To: "devel@edk2.groups.io" , "Dong, Guo" , gaoliming CC: "Ma, Maurice" , "You, Benjamin" Subject: Re: [edk2-devel] [PATCH V2 0/1] UefiPayloadPkg: Remove PEI phase from Payload Thread-Topic: [edk2-devel] [PATCH V2 0/1] UefiPayloadPkg: Remove PEI phase from Payload Thread-Index: AQHWu7BqCqWVUKG7S0mnoHmdSp0QhKnLTomA Date: Mon, 16 Nov 2020 21:58:31 +0000 Message-ID: References: <1647D5DAE0E6DDAF.27572@groups.io> In-Reply-To: <1647D5DAE0E6DDAF.27572@groups.io> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-originating-ip: [68.2.51.172] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 2aa356d6-7636-4f87-9e49-08d88a7ac1b4 x-ms-traffictypediagnostic: BYAPR11MB2630: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6108; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: IH1aeluR5q1Vg5MjUTaynxEKLEvELb9AwEEp9S4o3Q7H53Rioxvu8HZKJZWjCqXGxD5X0ZgI7yY6SrNPL9CebxYUcfwdBp8sF9T1Is0XpeTLeDpMtwp97Q4nULzOK84tZHrLXTNYu5BnqewZa+lbc40hyHsAJPO3tNldtdBW0t4u0DupZSHe8dRn5eiU1XMpsyqJ+g5hqjbSOVUtlLV8AcwVASrXH/uq7lPfSoE4ZFrN9fK1k5P9bB7VopWPvunH5dnGorTo9Qco28aXCsbm0SoZ3A9ScVXLhhHOAWE/kKlcYSUEoZTYyF8odQJI9jWJ7hEvZ/m9s8SDGdZiQek+hiFY7dsFZ4VBGK3+z07toxnAv3gI8qRLFj70ucAaFhhFxISGQL3QprY1Bykm6wOZWQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR11MB3622.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(136003)(366004)(346002)(39860400002)(376002)(2906002)(83380400001)(33656002)(5660300002)(478600001)(52536014)(19627235002)(54906003)(86362001)(966005)(110136005)(4326008)(66556008)(64756008)(76116006)(8936002)(71200400001)(6506007)(316002)(186003)(7696005)(55016002)(107886003)(66946007)(26005)(53546011)(8676002)(66446008)(9686003)(66476007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: bteatuUbkbLJ1R+2057PtBPiLbngS7ju3T/bIBcgOBWskaknncj1MAV2a4cohuk9QZrl5vQTtDdlZbTZpkgebzXLuUSrRBURiR++K6/YewJiYtEAuor4cVmkLKnwU+EVANRd0SrS0l/T+VAXTcuzWdtSh+i7VdXICjqVVkFvM+8CJKBN4iMsVtW76GdK0f8QiThr8Hj+JfdEsc+M9mQXaJ9CB5G/mRiDe67jtYAtpzNFFTM8u4ZDtDQQY0c/x8HIFHRZih/Llq2XYGmI+lAjFtp42e+f1DYgIDfVxnszPnfPT0kHrBpPjy8aqt9v8VIzi1tT6RU6TTgRfVy2ZZ3DxMlLVahGifwz2zfGd6rQZXkwdtciSNwhqGUupCIwbibqnYE+sKHqdWN7p8/vuEy2t3NXHg9pLMT1fZqygFM3I+hYRH0Tan3CPWfgIlQkayZUt4aIQmS/4DgdXNkeNxcSHDmep/bacm2thxba04eHaR8Gia5sxvm8ijHJ96Cyq0Cxg90unG3dxLfqAh0j56uvob2WXprGxGkFXqcZKK+s3YlJ4oKIl36lw5PZKW+szn0I0Dt64Z74vm5IoNOhKdQ3hjFAI+t+TDy13tz8r/2sxEutECyL6765kZ5Tq4jASs+KSqRhJcJxRTlSLSEA7rPiIw== MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3622.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2aa356d6-7636-4f87-9e49-08d88a7ac1b4 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Nov 2020 21:58:31.0949 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: iDgQ7yOSahNCETXt9TWYglAw5Yt4r/XF6wDRhQTCv9jJa3+SbDXE/ztpEylKMrwiBC9T3FW8dRlOQZMqUkYobg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB2630 Return-Path: guo.dong@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Liming, =20 This patch is sent before the soft freeze and passed review. I would like to merge this patch into edk2-stable202011 tomorrow if there = is no additional feedback. And here is the PR and it passed all CI checks. https://github.com/tianocore/edk2/pull/1127 =20 Thanks, Guo > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Guo Dong > Sent: Sunday, November 15, 2020 5:35 PM > To: devel@edk2.groups.io > Cc: Ma, Maurice ; You, Benjamin > > Subject: [edk2-devel] [PATCH V2 0/1] UefiPayloadPkg: Remove PEI phase fr= om > Payload >=20 > Hi All, >=20 > This patch removed UEFI payload PEI phase to make UEFI payload simple. > It uses UefiPayloadEntry module to bridge bootloader and DXE phase. >=20 > Original DSC files UefiPayloadIa32.dsc and UefiPayloadIa32X64.dsc > are replaced by a single DSC UefiPayloadPkg.dsc. Pure IA32 support > is replaced by Pure X64 support. IA32 Entry point with X64 DXE phase > is still supported. >=20 > Changes in V2: > Addressed all the review comments from Maurice. > Fixed debug msg in UefiPayloadEntry. > Updated the Handoff HOB to DXE core to include Payload FV. > Synced the GHCB changes from DxeIpl to UefiPayloadEntry. >=20 > V1: > It is not necessary to have a PEI phase in the UEFI payload since no > specific PEI task is required. This patch adds a UefiPayloadEntry > driver to get UEFI Payload required information from the bootloaders, > convert them into a HOB list, load DXE core and transfer control to it. >=20 > Here is the change details: > 1) Removed PEI phase, including Peicore, BlSupportPei, SecCore, etc. > 2) Added UefiPayloadEntry driver. this is the only driver before DXE cor= e. > 3) Added Pure X64 support, dropped Pure IA32 (Could add later if require= d) > 64bit payload with 32bit entry point is still supported. > 4) Use one DSC file UefiPayloadPkg.dsc to support X64 and IA32X64 build. > Removed UefiPayloadIa32.dsc and UefiPayloadIa32X64.dsc >=20 > Tested with SBL and coreboot on QEMU. >=20 > Refs: https://github.com/tianocore/edk2/pull/1127 >=20 > CC: maurice.ma@intel.com > CC: benjamin.you@intel.com > Signed-off-by: Guo Dong >=20 > Guo Dong (1): > UefiPayloadPkg: Remove PEI phase from Payload >=20 > UefiPayloadPkg/BlSupportPei/BlSupportPei.h | 39 - > UefiPayloadPkg/BlSupportPei/BlSupportPei.inf | 73 -- > UefiPayloadPkg/BuildAndIntegrationInstructions.txt | 32 +- > UefiPayloadPkg/Include/Library/BlParseLib.h | 4 +- > UefiPayloadPkg/Library/HobLib/Hob.c | 706 ++++++++++++++= ++ > UefiPayloadPkg/Library/HobLib/HobLib.inf | 39 + > UefiPayloadPkg/SecCore/FindPeiCore.c | 193 ----- > UefiPayloadPkg/SecCore/Ia32/SecEntry.nasm | 78 -- > UefiPayloadPkg/SecCore/Ia32/Stack.nasm | 72 -- > UefiPayloadPkg/SecCore/SecCore.inf | 58 -- > UefiPayloadPkg/SecCore/SecMain.c | 288 ------- > UefiPayloadPkg/SecCore/SecMain.h | 131 --- > UefiPayloadPkg/UefiPayloadEntry/Ia32/DxeLoadFunc.c | 365 ++++++++ > .../UefiPayloadEntry/Ia32/IdtVectorAsm.nasm | 71 ++ > UefiPayloadPkg/UefiPayloadEntry/Ia32/SecEntry.nasm | 46 + > UefiPayloadPkg/UefiPayloadEntry/LoadDxeCore.c | 307 +++++++ > UefiPayloadPkg/UefiPayloadEntry/MemoryAllocation.c | 201 +++++ > .../UefiPayloadEntry.c} | 451 ++++------ > UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.h | 134 +++ > .../UefiPayloadEntry/UefiPayloadEntry.inf | 93 ++ > UefiPayloadPkg/UefiPayloadEntry/X64/DxeLoadFunc.c | 107 +++ > UefiPayloadPkg/UefiPayloadEntry/X64/SecEntry.nasm | 47 ++ > .../UefiPayloadEntry/X64/VirtualMemory.c | 939 > +++++++++++++++++++++ > .../UefiPayloadEntry/X64/VirtualMemory.h | 330 ++++++++ > UefiPayloadPkg/UefiPayloadPkg.dec | 5 +- > ...efiPayloadPkgIa32X64.dsc =3D> UefiPayloadPkg.dsc} | 57 +- > UefiPayloadPkg/UefiPayloadPkg.fdf | 32 +- > UefiPayloadPkg/UefiPayloadPkgIa32.dsc | 585 ------------- > 28 files changed, 3576 insertions(+), 1907 deletions(-) > delete mode 100644 UefiPayloadPkg/BlSupportPei/BlSupportPei.h > delete mode 100644 UefiPayloadPkg/BlSupportPei/BlSupportPei.inf > create mode 100644 UefiPayloadPkg/Library/HobLib/Hob.c > create mode 100644 UefiPayloadPkg/Library/HobLib/HobLib.inf > delete mode 100644 UefiPayloadPkg/SecCore/FindPeiCore.c > delete mode 100644 UefiPayloadPkg/SecCore/Ia32/SecEntry.nasm > delete mode 100644 UefiPayloadPkg/SecCore/Ia32/Stack.nasm > delete mode 100644 UefiPayloadPkg/SecCore/SecCore.inf > delete mode 100644 UefiPayloadPkg/SecCore/SecMain.c > delete mode 100644 UefiPayloadPkg/SecCore/SecMain.h > create mode 100644 UefiPayloadPkg/UefiPayloadEntry/Ia32/DxeLoadFunc.c > create mode 100644 > UefiPayloadPkg/UefiPayloadEntry/Ia32/IdtVectorAsm.nasm > create mode 100644 UefiPayloadPkg/UefiPayloadEntry/Ia32/SecEntry.nasm > create mode 100644 UefiPayloadPkg/UefiPayloadEntry/LoadDxeCore.c > create mode 100644 UefiPayloadPkg/UefiPayloadEntry/MemoryAllocation.c > rename UefiPayloadPkg/{BlSupportPei/BlSupportPei.c =3D> > UefiPayloadEntry/UefiPayloadEntry.c} (52%) > create mode 100644 UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.h > create mode 100644 UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.inf > create mode 100644 UefiPayloadPkg/UefiPayloadEntry/X64/DxeLoadFunc.c > create mode 100644 UefiPayloadPkg/UefiPayloadEntry/X64/SecEntry.nasm > create mode 100644 UefiPayloadPkg/UefiPayloadEntry/X64/VirtualMemory.c > create mode 100644 UefiPayloadPkg/UefiPayloadEntry/X64/VirtualMemory.h > rename UefiPayloadPkg/{UefiPayloadPkgIa32X64.dsc =3D> UefiPayloadPkg.ds= c} > (90%) > delete mode 100644 UefiPayloadPkg/UefiPayloadPkgIa32.dsc >=20 > -- > 2.16.2.windows.1 >=20 >=20 >=20 >=20 >=20