From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web11.825.1599604648311032844 for ; Tue, 08 Sep 2020 15:37:28 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=aoPKGHvM; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: guo.dong@intel.com) IronPort-SDR: Bsik0ICUP11mZTffJJi8U/ePa0785pFfj/F1h0+46hRfg4dAx2/g9jtRECjXA2XVoyA1gBZ5vV 4iytAwn2WXDQ== X-IronPort-AV: E=McAfee;i="6000,8403,9738"; a="155720000" X-IronPort-AV: E=Sophos;i="5.76,407,1592895600"; d="scan'208";a="155720000" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Sep 2020 15:37:27 -0700 IronPort-SDR: H4KyujA3LM6WPcIeOPMZAwj4ewOFx6hQqHzBhGJcil9HaQLZxIe3+L0yKMQKGR4ORi9wRbZRpX Z9/bJQ1bRkXQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,407,1592895600"; d="scan'208";a="341343843" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by FMSMGA003.fm.intel.com with ESMTP; 08 Sep 2020 15:37:27 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 8 Sep 2020 15:35:51 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 8 Sep 2020 15:35:51 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.169) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Tue, 8 Sep 2020 15:35:49 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NV7NbVLwmc5nntJt7XUKz11L19vxsFAmUnYIVBzDj6/Alae92/MuUXmwsCQc8nHaxSWG1tRGaoIWEx8UOgeseYIA6pS+t+3y1uVsNgHpzedPdvTQRY9R22oYHE7MCC5wQ52jNE7tDKTn+jW2uDWWG75mFaOk+QTopGJadmHW5NAMx7Bfa7Aal8QbFcbLyn1z6nOwWqR430zLSLUTDYNWCzXx8fa7OcbF+qohBamdjka+ryOqUEsbE6qEbJy8AX5jilogWyB129k1o5jXRJ+Xhok3jon6e6n7+ijzZcjsxjPYJwV1KW4bFtG5kBKnwmgwgwrr1L6+v3YoToiGrVJdWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bWAK3/YpTs5ARUI9D6o85+zjMhmL/rA6XirUabfP2Ss=; b=kQpxOWRSzPB4z6WlowLY7zfs0kdHPR0pKGp5PVANQFP51E8Zj/XSlyn2fRxKYzrpCP7JVWDHztTOtirjymfkad9rDVfeepwZJrxnkfQUjPL2/lgifIUtAJpkymEsJXmgB0ZhDG9frW7QG6Ae9Yky9uPcggZbHvHlYK8cNxCxZ6RgNiO/uZ8tCLS7effkv3Mcy8yk49pcD3I8SXh9PSIiHxH8zDdz3jMIa6vTxoHzNImr6r5qigsKLHbC0DO+eZJ43dl1yV2hAN3ZXkqAMGrQs6osUL5Ug+QvqcBU+nl4qT86QVLgyMMjFzEIP/ztsuPmffut1jRwW5LXn0WdqwQ7dQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bWAK3/YpTs5ARUI9D6o85+zjMhmL/rA6XirUabfP2Ss=; b=aoPKGHvMJcLUGdzo4ac0Sa0Ws3gQpcT8Yt2yvvdUMVLZf3yOCQb2tN9wQrkLS3paFWOvpoZ48+cBrMckvYmNxwM3QXQg1tQDlcjPzZRjO0yzgThTik4SlNMkvyzvKj0vXfCfis4EZU408niwudCwxqrF5VsoD2Vv/fCH/fVxKUA= Received: from BYAPR11MB3622.namprd11.prod.outlook.com (2603:10b6:a03:fe::30) by BYAPR11MB2727.namprd11.prod.outlook.com (2603:10b6:a02:c7::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3348.16; Tue, 8 Sep 2020 22:35:48 +0000 Received: from BYAPR11MB3622.namprd11.prod.outlook.com ([fe80::edcc:d9ab:61a6:bd13]) by BYAPR11MB3622.namprd11.prod.outlook.com ([fe80::edcc:d9ab:61a6:bd13%3]) with mapi id 15.20.3370.016; Tue, 8 Sep 2020 22:35:47 +0000 From: "Guo Dong" To: "devel@edk2.groups.io" , "marcello.bauer@9elements.com" CC: Patrick Rudolph , Christian Walter , "Ma, Maurice" , "Desimone, Nathaniel L" , "You, Benjamin" Subject: Re: [edk2-devel] [PATCH v5 3/3] UefiPayloadPkg: Support variable size MMCONF space Thread-Topic: [edk2-devel] [PATCH v5 3/3] UefiPayloadPkg: Support variable size MMCONF space Thread-Index: AQHWdTlwp9hx2X7xlkqAAmIl1VmmhKlfdjPw Date: Tue, 8 Sep 2020 22:35:47 +0000 Message-ID: References: <20200818082421.6168-1-marcello.bauer@9elements.com> <20200818082421.6168-4-marcello.bauer@9elements.com> In-Reply-To: <20200818082421.6168-4-marcello.bauer@9elements.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-originating-ip: [68.2.51.172] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b5c5ae2d-8730-4ecb-c9af-08d854478833 x-ms-traffictypediagnostic: BYAPR11MB2727: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2089; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 1pSa/jzB9yco7U028UH8P2uomXeIztSUXS5iPk+Cb1DMIfykUnwGY5BICxJ9wWbDGrwZdrKSJ6yfr609nRIvm5AtKcJw+xHiD8p5EGwr4ijQKgmuMYfRl3QaBzLhPxLs8xlmSm3c0XIg21c/VDyWZkINp2Px5kOI/l9YzLsK5zOJXEUUK3meloOHYtmKoF6vOPZ928KXGUBgzv3SjPFnOL3BnpLCzJXDRtgbU4CIR9/hO7B3JL9EZFxqpg9ztehSINmuUBYYFf7/tD+wBPnyeegbJ6jXIHRpfcIL2LWfkZKzWzRWn895CgiGSEtwsNnyHEcGfZFqzkA40VXgU+I0zpV0frOrUDwOt8vnX6ZlosV/aLhTnV1HDmBwAgX4rqi9cKX/9ujkUX0a3/+TJYGjYQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR11MB3622.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(39860400002)(376002)(346002)(396003)(136003)(366004)(33656002)(86362001)(83380400001)(966005)(26005)(9686003)(107886003)(54906003)(110136005)(478600001)(76116006)(66556008)(4326008)(66446008)(8676002)(64756008)(66946007)(7696005)(8936002)(316002)(6506007)(19627235002)(66476007)(53546011)(5660300002)(52536014)(2906002)(186003)(55016002)(71200400001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: 7R8tFeoKb+DV4fY98V8LiA3ppV/nVQVL8QNRa6QX5BvqEs0zljBwLHTl7eXV+nNQ5+Jzamh02Zci5jFAKEzH2AzV/zfaes7rwUlgYw+mm0v8dP234w4L5b7p08Pz+QLq/gzzLnINrUVtwDIMWwn3iVF/Wv5o3RLchEMYvWjCwm2uzp3U56zW+WhLhZiUd8zXVqnZTxPowNsoj0ZxZKkuOzV3aAWjZC08o+vZoqtx+r4S6HrdqpdM0+N9hOixe3mWNxOGEae/Hhbqjmw8tD0SyPpJTn17UbXMz0WfQzD776L4hrIeOw5GDM3tZdNjBQUhWuVHrfSz280WMijjZcM/Lr53TiWwoZjKA+tF+1nAM8GnrKA45+beG+TkPjL5k/rZrfkvfBIUmH6MeyfcLs84EAtmQin7MNjOw8vHVBXk/oGaR6pxBJ1IIqpKkAVMlC90b7Kb44xciyUBZ1WPg/6zn/nFWMdRghCQ6K/ly+rTDKrI/OKPzpK3N5OjS1Tdb2nflwacu5g/FnZW7tclcqQ5BJDq/Wj0FD/FK3LwH2chrS3rYsJq3QKVhLzgVrVlgS4dt77i/MMp3ZSZAJX3X5vuoS//6Zn9X5cMtJy5LFDnQViuY6DU4EJWOXOFEAq9p2mTptwU/l2kuIgsurVkkzhYNQ== MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3622.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b5c5ae2d-8730-4ecb-c9af-08d854478833 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Sep 2020 22:35:47.5612 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: G8Z8x7uUe7N2iLhtV/wcjnmCsHkJaIkOFydGjcgyLy6uVc8/0s2wWApOYita0Osky+JBK9fLC72+vxMTjWJ8Iw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB2727 Return-Path: guo.dong@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Guo Dong > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Marcello > Sylvester Bauer > Sent: Tuesday, August 18, 2020 1:24 AM > To: devel@edk2.groups.io > Cc: Patrick Rudolph ; Christian Walter > ; Ma, Maurice ; > Desimone, Nathaniel L ; You, Benjamin > > Subject: [edk2-devel] [PATCH v5 3/3] UefiPayloadPkg: Support variable siz= e > MMCONF space >=20 > The default size is still 256MiB, but will be overwritten by > UefiPayloadPkg with the real MMCONF size. >=20 > e.g.: On embedded AMD platforms the MMCONF window size is usually > only 64MiB. >=20 > Fixes crash on platforms not exposing 256 buses. > Tested on: > * AMD Stoney Ridge >=20 > Signed-off-by: Patrick Rudolph > Signed-off-by: Marcello Sylvester Bauer > Cc: Patrick Rudolph > Cc: Christian Walter > Cc: Maurice Ma > Cc: Nate DeSimone > Cc: Benjamin You > --- > UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc | 1 + > UefiPayloadPkg/BlSupportDxe/BlSupportDxe.inf | 1 + > UefiPayloadPkg/BlSupportDxe/BlSupportDxe.c | 4 +++- > 3 files changed, 5 insertions(+), 1 deletion(-) >=20 > diff --git a/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc > b/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc > index 942bc9076634..5898a474f9e9 100644 > --- a/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc > +++ b/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc > @@ -365,6 +365,7 @@ [PcdsDynamicDefault] > gEfiMdeModulePkgTokenSpaceGuid.PcdConOutRow|31 >=20 > gEfiMdeModulePkgTokenSpaceGuid.PcdConOutColumn|100 >=20 > gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress|0 >=20 > + gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseSize|0 >=20 >=20 >=20 >=20 > ################################################################ > ################ >=20 > # >=20 > diff --git a/UefiPayloadPkg/BlSupportDxe/BlSupportDxe.inf > b/UefiPayloadPkg/BlSupportDxe/BlSupportDxe.inf > index 1371d5eb7952..cebc81135565 100644 > --- a/UefiPayloadPkg/BlSupportDxe/BlSupportDxe.inf > +++ b/UefiPayloadPkg/BlSupportDxe/BlSupportDxe.inf > @@ -54,6 +54,7 @@ [Pcd] > gEfiMdeModulePkgTokenSpaceGuid.PcdSetupVideoHorizontalResolution >=20 > gEfiMdeModulePkgTokenSpaceGuid.PcdSetupVideoVerticalResolution >=20 > gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress >=20 > + gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseSize >=20 >=20 >=20 > [Depex] >=20 > TRUE >=20 > diff --git a/UefiPayloadPkg/BlSupportDxe/BlSupportDxe.c > b/UefiPayloadPkg/BlSupportDxe/BlSupportDxe.c > index a3974dcc02f8..a746d0581ee3 100644 > --- a/UefiPayloadPkg/BlSupportDxe/BlSupportDxe.c > +++ b/UefiPayloadPkg/BlSupportDxe/BlSupportDxe.c > @@ -155,13 +155,15 @@ BlDxeEntryPoint ( > } >=20 >=20 >=20 > // >=20 > - // Set PcdPciExpressBaseAddress by HOB info >=20 > + // Set PcdPciExpressBaseAddress and PcdPciExpressBaseSize by HOB info >=20 > // >=20 > GuidHob =3D GetFirstGuidHob (&gUefiAcpiBoardInfoGuid); >=20 > if (GuidHob !=3D NULL) { >=20 > AcpiBoardInfo =3D (ACPI_BOARD_INFO *)GET_GUID_HOB_DATA (GuidHob); >=20 > Status =3D PcdSet64S (PcdPciExpressBaseAddress, AcpiBoardInfo- > >PcieBaseAddress); >=20 > ASSERT_EFI_ERROR (Status); >=20 > + Status =3D PcdSet64S (PcdPciExpressBaseSize, AcpiBoardInfo->PcieBase= Size); >=20 > + ASSERT_EFI_ERROR (Status); >=20 > } >=20 >=20 >=20 > return EFI_SUCCESS; >=20 > -- > 2.28.0 >=20 >=20 > -=3D-=3D-=3D-=3D-=3D-=3D > Groups.io Links: You receive all messages sent to this group. >=20 > View/Reply Online (#64366): https://edk2.groups.io/g/devel/message/64366 > Mute This Topic: https://groups.io/mt/76261187/1781375 > Group Owner: devel+owner@edk2.groups.io > Unsubscribe: https://edk2.groups.io/g/devel/unsub [guo.dong@intel.com] > -=3D-=3D-=3D-=3D-=3D-=3D