From: "Guo Dong" <guo.dong@intel.com>
To: Cheng-Chieh Huang <chengchieh@google.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Schaefer, Daniel" <daniel.schaefer@hpe.com>,
Trammell Hudson <hudson@trmm.net>,
"Ma, Maurice" <maurice.ma@intel.com>,
"You, Benjamin" <benjamin.you@intel.com>
Subject: Re: [PATCH v2 0/4] UefiPayloadPkg: LinuxBoot Support in UefiPayload
Date: Sat, 7 Aug 2021 16:34:37 +0000 [thread overview]
Message-ID: <BYAPR11MB3622AC5F9C829B20E2A7B8E99EF49@BYAPR11MB3622.namprd11.prod.outlook.com> (raw)
In-Reply-To: <CANtkA9ZGNRg-5xQ_L3BipxVnm68vCact2FPwXRcT0-UQXegn9w@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 3144 bytes --]
Hi Cheng-chieh,
The Github comments is just for your reference to quick locate the comment place. You could update the PR with new changes and I could comment there.
But we still need follow EDII requirement to review the patches by email.
Thanks,
Guo
From: Cheng-Chieh Huang <chengchieh@google.com>
Sent: Saturday, August 7, 2021 8:06 AM
To: devel@edk2.groups.io
Cc: Schaefer, Daniel <daniel.schaefer@hpe.com>; Trammell Hudson <hudson@trmm.net>; Ma, Maurice <maurice.ma@intel.com>; Dong, Guo <guo.dong@intel.com>; You, Benjamin <benjamin.you@intel.com>
Subject: Re: [PATCH v2 0/4] UefiPayloadPkg: LinuxBoot Support in UefiPayload
Hi Guo,
I saw you left messages in https://github.com/tianocore/edk2/pull/1820. If it's also possible to upstreaming using github PR. I can just update my old branch.
--
Cheng-chieh
On Sat, Aug 7, 2021 at 10:51 PM Cheng-Chieh Huang <chengchieh@google.com<mailto:chengchieh@google.com>> wrote:
These are necessary patches to Support LinuxBoot in UefiPayload.
With these paches, we can boot to ESXi and Windows from a linux in QEMU.
This is second parse. In addition to fixing reviwer's suggestions,
I removed the following CLs.
* Add DISABLE_MMX_SSE to avoid generating floating points operation
-> will send a seperate patch to add these flags to BaseTools
* LinuxBoot: use a text format for the configuration block.
-> will work with Trammell Hudson to cover this patch to EDK2 style.
LinuxBoot README:
https://github.com/linuxboot/edk2/blob/uefipayload/UefiPayloadPkg/README.md
v2 PR to tianocore:
https://github.com/tianocore/edk2/pull/1873
Cheng-Chieh Huang (4):
UefiPayloadPkg: Add LINUXBOOT payload target
UefiPayloadPkg: Use legacy timer in Linuxboot payload
UefiPayloadPkg: Update maximum logic processor to 256
UefiPayloadPkg: Reserve Payload config in runtime services data
UefiPayloadPkg/UefiPayloadPkg.dsc | 24 ++-
UefiPayloadPkg/UefiPayloadPkg.fdf | 5 +
UefiPayloadPkg/Library/LbParseLib/LbParseLib.inf | 39 +++++
UefiPayloadPkg/Library/LbParseLib/Linuxboot.h | 47 +++++
UefiPayloadPkg/Library/LbParseLib/LbParseLib.c | 182 ++++++++++++++++++++
UefiPayloadPkg/Library/PciHostBridgeLib/PciHostBridgeSupport.c | 6 +-
UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.c | 4 +
7 files changed, 299 insertions(+), 8 deletions(-)
create mode 100644 UefiPayloadPkg/Library/LbParseLib/LbParseLib.inf
create mode 100644 UefiPayloadPkg/Library/LbParseLib/Linuxboot.h
create mode 100644 UefiPayloadPkg/Library/LbParseLib/LbParseLib.c
Cc: Cheng-Chieh Huang <chengchieh@google.com<mailto:chengchieh@google.com>>
Cc: Daniel Schaefer <daniel.schaefer@hpe.com<mailto:daniel.schaefer@hpe.com>>
Cc: Trammell Hudson <hudson@trmm.net<mailto:hudson@trmm.net>>
Cc: Maurice Ma <maurice.ma@intel.com<mailto:maurice.ma@intel.com>>
Cc: Guo Dong <guo.dong@intel.com<mailto:guo.dong@intel.com>>
Cc: Benjamin You <benjamin.you@intel.com<mailto:benjamin.you@intel.com>>
--
2.32.0.605.g8dce9f2422-goog
[-- Attachment #2: Type: text/html, Size: 7112 bytes --]
next prev parent reply other threads:[~2021-08-07 16:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-07 14:51 [PATCH v2 0/4] UefiPayloadPkg: LinuxBoot Support in UefiPayload Cheng-Chieh Huang
2021-08-07 14:51 ` [PATCH v2 1/4] UefiPayloadPkg: Add LINUXBOOT payload target Cheng-Chieh Huang
2021-08-07 14:51 ` [PATCH v2 2/4] UefiPayloadPkg: Use legacy timer in Linuxboot payload Cheng-Chieh Huang
2021-08-07 14:51 ` [PATCH v2 3/4] UefiPayloadPkg: Update maximum logic processor to 256 Cheng-Chieh Huang
2021-08-07 14:51 ` [PATCH v2 4/4] UefiPayloadPkg: Reserve Payload config in runtime services data Cheng-Chieh Huang
2021-08-07 15:05 ` [PATCH v2 0/4] UefiPayloadPkg: LinuxBoot Support in UefiPayload Cheng-Chieh Huang
2021-08-07 16:34 ` Guo Dong [this message]
2021-08-12 4:49 ` [edk2-devel] " Ni, Ray
2021-08-12 8:51 ` Cheng-Chieh Huang
2021-08-16 4:42 ` Guo Dong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR11MB3622AC5F9C829B20E2A7B8E99EF49@BYAPR11MB3622.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox