From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web12.21627.1632681143965184625 for ; Sun, 26 Sep 2021 11:32:24 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=g7jVbi5R; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: guo.dong@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10119"; a="285374405" X-IronPort-AV: E=Sophos;i="5.85,324,1624345200"; d="scan'208";a="285374405" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Sep 2021 11:32:23 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,324,1624345200"; d="scan'208";a="537169194" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga004.fm.intel.com with ESMTP; 26 Sep 2021 11:32:22 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Sun, 26 Sep 2021 11:32:22 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Sun, 26 Sep 2021 11:32:22 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Sun, 26 Sep 2021 11:32:22 -0700 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.46) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Sun, 26 Sep 2021 11:32:21 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oUlaYXjQkgFPBKzeCzPBtOBjNPsZP1coxJ6gyq/dMsQaAmvo0Nxg7LX07FP4lHECgiYYw55hJikb5o0GC/6zaTnxmX2U4cX8F0UdJYLRp+La3n27p2NhdT0I0V6WNZpWg68zIJPCqaOz8gr42SASvKLAO76X9WaT2jQQDJg3EnQXtziwFXbppQtaOuvZgXAV66DmCrIEv4cZjUmyM/M0slalbf3zxtFpgPfeye/36z+0Nf+oQfucwLBOR3KWAV7FA6n3uD74tLHs1ub38hEd1P4uMnAipr+ZNf5sNcPSRqr8GUOOqKKvMpI5kcL28bz+6RLEOFRSumCz9pqM0FwuAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=YZrmVORhxKd6Dz0HhXafofjmk0hjJ6WSUXaMJaU1ueg=; b=knTkqArhXFymfIzbWiZapcL3i+VpHsW7FSY+yGqn1Z3HrmLBLtNB3hZfUVKwHhA9kjA4UNT4yO2lo2foqqeTTops9oRgttSdLjrlA5kmbJnWs/G7/9zyX84cS3BGLhJegzBSQOZSUKVA3DD9DikgsKkdISSIBcFCfMd909kFVuKerQcFXTY0fMW5JYcUDLxbQeBr5Tgatj2D6hXUogHuZp+khr4HWXRszm6ya2vfVkrZ/8ELjhP1QFPRRfz1B2m5DBp2F7aqDgCoXlXgs6eIpmQSOTmDOc0Gonfu6TCbZwoC2zeKKIbkfwNffme1/1KnKjKvBHXiWfYrlZFt2jCC4w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YZrmVORhxKd6Dz0HhXafofjmk0hjJ6WSUXaMJaU1ueg=; b=g7jVbi5R3r7g966Rp6tKcilK6JfqJwkcMeu9RF5Fe+BhF8EgtiDa/6ReiQyfJei9iTK0Ovxzzoc18673f2ELohUVGaVXIR+KkaT+HWOyCDAV1HfdSNycVyNe9MorOfnDjL3avW/tiOB1mZXhKYMhcTomLBVRjWn0OXaJj8xZU2I= Received: from BYAPR11MB3622.namprd11.prod.outlook.com (2603:10b6:a03:fe::30) by BY5PR11MB4260.namprd11.prod.outlook.com (2603:10b6:a03:1ba::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.13; Sun, 26 Sep 2021 18:32:19 +0000 Received: from BYAPR11MB3622.namprd11.prod.outlook.com ([fe80::d40b:f4f3:3815:dd69]) by BYAPR11MB3622.namprd11.prod.outlook.com ([fe80::d40b:f4f3:3815:dd69%7]) with mapi id 15.20.4544.021; Sun, 26 Sep 2021 18:32:19 +0000 From: "Guo Dong" To: "Ni, Ray" , "devel@edk2.groups.io" CC: "Ma, Maurice" , "You, Benjamin" Subject: Re: [`edk2-devel][PATCH] UefiPayloadPkg: Build a HOB from bootloader ACPI table Thread-Topic: [`edk2-devel][PATCH] UefiPayloadPkg: Build a HOB from bootloader ACPI table Thread-Index: AQHXscG3jVQY8WbnLUea9P9uVpiw06u1njKAgAD8l0A= Date: Sun, 26 Sep 2021 18:32:19 +0000 Message-ID: References: <20210925035903.1644-1-guo.dong@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.200.16 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 3ba3d958-0eed-407f-2d78-08d9811bf94e x-ms-traffictypediagnostic: BY5PR11MB4260: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: QuzdaT05vg6BGT937Vozt0s415T9fZVq87qsflKfA7i8vq/yiv/ZI7h8cxRUeQhLT7vdfLs1597gKtg1N5ul62M2RsrzBk7RhqHtrFiC8J/TanTRmr5rcb/zwep1Ax2Cag6jcI8tXvAjg/BHv80X84MH1F53OXVQLyWmVykVdEZGYA7X0l6Id+jkGe0cmZglQV0mi409fvkXkTJNULfkb/THAljOFqmBLdhmGG8OH7EZM3tURvAYVKNE2bf6SmC1NyhWGbPP3K3fCISabwzPidm8vnHKwdnLYsrySyacLWfH4Q8mICJMCRNuKK7gO3mAFQdA56PHZh/cEmirho8XPTKWQSqJJeqAZ6x0/wLB+Ii52I3KZYzhz+6dhizDy56QbEtr80Jtu3QD7ExbnmYHUaZE/HZVNYqae3sVw63AtAc6E4FfYOrDnvEQbR/9CmkuCL6Ipj5p0NEi5fzZHba722dTD6lCoY3tIrs9pTP/Hql9DVmDcJCRdjCgHdFtzV+7gAZuLWmof/T/UDK7uqPhYAldav0OAcXpxTGwLG60oT0Ip63URgwiUU8MBfj/RjoXbO7vDtKxI6ARaxBz7fxUJebt44hua0pSB2dqku11Dd1EgI3GTyOT2JE1kIf27NXo5GNyxtdBpHTK94CGbAbm5B/tUKRiHp0xf/URuzDbYhRWmOgRUaUGdVzQpjwqTEunS5acS2CnJmaJ9bIdg8GUZxo2sxq49Lhrd3br9KN+ukY= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR11MB3622.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(38100700002)(66556008)(2906002)(9686003)(66446008)(186003)(26005)(86362001)(55016002)(8936002)(6506007)(8676002)(64756008)(5660300002)(316002)(7696005)(52536014)(33656002)(122000001)(53546011)(4326008)(76116006)(38070700005)(508600001)(54906003)(66476007)(110136005)(83380400001)(71200400001)(66946007)(107886003)(81973001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?hQxHcm9JTmHNApoYpKsFZJhjM/xhREBvj363Q8hWdUlKeXgBOYs5nZp6NUa6?= =?us-ascii?Q?uLgnlsS9VUCcIE82MqsYzKzY2KTDvOGshFSKxaEjEQ3D3jOGUHqAfJg8Cc5W?= =?us-ascii?Q?wzWUDJve2UzpGVB9bNnUoCJGWcPml37TZ71G/3asDy4Yt5eTtgXO/qH3esPk?= =?us-ascii?Q?AywvQHbOlSF6JGE0DkRSbcBrTrMr2V7GDjJ9eh0d7xrNSFf/r5sET7LQmXcC?= =?us-ascii?Q?XbjSJjscMW+WOnNzAeqaOEbamZq25vfMVnqHx2EWYS84WKS9SeJ3W8sJgxD5?= =?us-ascii?Q?thGWI1avD9lPbN2po4wcyFMT4khYgl38cJmDPIP/B+pNGX5bMONMMBq2i/fP?= =?us-ascii?Q?ZE0fFQERp1MVYGUlxT9ApmxdZ6SH7HImwOWMfNN2urh82f7XRWl4UFHMCy2j?= =?us-ascii?Q?nZtNtFV4vEa9xTdaRE00hRIsewkY1xLxIHCmWy63cCnbjbUTP3iEtPyXbk3D?= =?us-ascii?Q?LVWgK1eys5eu/Td+HzNm3oXLfV8yx+kfIJCkBKt8R6Dh6mURp7wB78Y72KxU?= =?us-ascii?Q?C1R/GWBeLoYh3sO19fHMZ/I8y7OV/SXzorp8/Ey/UkUevymSGfRRuys/P4wp?= =?us-ascii?Q?o639Xvvvwqz7vmLAx/E8vvQKiQ2pbjI/faX7Vkew0nuV8xGv1YeZTuCv8NYw?= =?us-ascii?Q?/EogM3cERkXLfjKclGs02vruQk56S4InPzpNgg3BPLTl0lhLoLqUdSfr8m4R?= =?us-ascii?Q?K9oC/rmQyNcW184gzkfGqVYqAKtCD+Yo2o2KDxpw1TXpZSuZBr8Lc7fcy2J3?= =?us-ascii?Q?OO9tSMZ4xsqADgCBk8tqFo1c4W/An0de+aDjB7lESfPKgDd9jWkE7sFjkakZ?= =?us-ascii?Q?q6lJEQH2Y/ZuErr9fvhu8DL5mbiqWg0R40wp0jmtv53iPS/RglVupKvsu/oT?= =?us-ascii?Q?O1SkdOtRN8rrve1qasd8FmmWB9aMbE6oPogJAotj9jGuUlbzi8AuvCrcyqZJ?= =?us-ascii?Q?344lJ3Qz4hwXQy/JwjO0vRMyw8zQsXRRZwaW+rkSD245+cBqr27P8YlMuYg0?= =?us-ascii?Q?TlV0d52oAFRxMq5s+8FBi/tU7NVm9qlqOBfkcbvHf927j1S/0ms9zDHrMTsX?= =?us-ascii?Q?Ygfvyhf/ZqXrAK/KFrKMYVFyi5DRj1wtURPgpW6ppa+jFijyw+ozPxu18NzT?= =?us-ascii?Q?X624gmi6QEMxRo/57EXPLKyBr2xxhTFU/5uHtY10TnXE2+BYHFycmrwMp/n6?= =?us-ascii?Q?55Tb2fOjqyzFgDWOL+cl2IQoLsc1jRg7ua52CMJMbBllYXtc0MZv3scp17+3?= =?us-ascii?Q?LgkK27I8a65bLFODJOmOYDQMkTNEJvdm5hcu2PYhTuZ4FIX+XecdsDsg6hYQ?= =?us-ascii?Q?2VBhMKOvRt9lDbSsUlM1Pmqs?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3622.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3ba3d958-0eed-407f-2d78-08d9811bf94e X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Sep 2021 18:32:19.4827 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 5aWM0cphGHKmB7IALUzjXjGBiAXEdibN0YqOy7T86byN2PwgnQmAi4tn1CZRSaajfL8ZYHyMq+TEfosXUKgwJQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR11MB4260 Return-Path: guo.dong@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Ray, In this patch, we added a shared file AcpiTable.c for both universal payloa= d and non-universal payload. The exposed API from this file is: EFI_STATUS BuildHobFromAcpi ( IN UI= NT64 AcpiTableBase); This function will build an ACPI board HOB based on the information from AC= PI table. For universal payload, it calls this function to build a hob for other modu= les. The main function is very simple and clear. For non-universal payload, ACPI board HOB is used in the ParseMemoryInfo() = callback for PCIE base info. So we could get this HOB from the caller, or get this HOB inside the callba= ck. I select to do it inside the callback. Thanks, Guo -----Original Message----- From: Ni, Ray =20 Sent: Saturday, September 25, 2021 7:48 PM To: Dong, Guo ; devel@edk2.groups.io Cc: Ma, Maurice ; You, Benjamin Subject: RE: [`edk2-devel][PATCH] UefiPayloadPkg: Build a HOB from bootload= er ACPI table - Status =3D ParseMemoryInfo (MemInfoCallbackMmio, &AcpiBoardInfo); + Status =3D ParseMemoryInfo (MemInfoCallbackMmio, NULL); Guo, I am curious why you changed this part. Without this change, MemInfoCallbackMmio() can get the AcpiBoardInfo from t= he parameter. With the change, it has to locate the Guided HOB itself. Other parts look good to me. Thanks, Ray