From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web11.1.1624402302747503745 for ; Tue, 22 Jun 2021 15:51:42 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=lHkxmNPD; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: guo.dong@intel.com) IronPort-SDR: p6dBMhHDVbv78GfW/s91bp7V83kgNSH5wVThabB5qpBXPKAn8JrUwRfsa47Qw3ubQxAIUMD0BD /r1fBP8aaD6w== X-IronPort-AV: E=McAfee;i="6200,9189,10023"; a="292782859" X-IronPort-AV: E=Sophos;i="5.83,292,1616482800"; d="scan'208";a="292782859" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jun 2021 15:51:42 -0700 IronPort-SDR: 4bDoQ6srHb2TbRYOcvFlTBE5dVkisvFQsg5CJ3cPpQbLM7GVrx74qceiDF0w+BN5B/wmWmmHO0 CHi/atNT5bqw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.83,292,1616482800"; d="scan'208";a="406116537" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga006.jf.intel.com with ESMTP; 22 Jun 2021 15:51:37 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Tue, 22 Jun 2021 15:51:36 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4 via Frontend Transport; Tue, 22 Jun 2021 15:51:36 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.176) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.4; Tue, 22 Jun 2021 15:51:36 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XqXiqA3OoAlS8ib81CdiSOXV1l3Q+dJti56PDSbeI24G6+zvbQmm6DFDcedKRRDtNk27fWYkoXf+dg1h+ed4xZ1Ew/hHl6ykfkocLk+6sygy8i9OhnCbnXY4itblrA9eYUoTH5orfTGCDS6Fxy2xaozefL+uM6a6sv3EQe4IRovvTL1+OD7ng/u1WLusJdWDANp6FVdm+WlDJTYJCifZD9ANyzBF72i1pIAFEb47KrMegznXuEkwPjtA0LKGy6f1q8XPwM3mqgXmGdXyFBDozqxxOhV0hGvMFD3IAq4OBIMz3u5B+p+N2o4vLwmZKc5YDujfHLyFLhLpHtYK+sK/cg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=m31zKb/bltotwO95xF9QMlFxUlAI99qcIijCDuwUTXM=; b=mOj2NowoXUt9GyruHVPjIlRW8CAbWUGMkxDH4VULjcClr7799/Me9SwZkcwsSoca6TwbeYtIYmAa2qlW3vzVgL3HP6I3rMn6cV8qXwfrjjvJfqNkkxBP66CKEcozFN/Abnw3k1C9AwzpLMgxOQ6MErphrqqBi7a9PZShL2w1jeUWkpVqzNbPIp4ms4GE3BNIxIeAE1DllNU+9g3T+r6yn/Xg0prWTPoYVm/X+d7/m2gFTQSCgOGNVIIaTKQlE2IZB0BCzIpqNyUeNAfgc94RFln6MQymT3TKbpS7MVrbwwu+OF2ri/0E+DEGaMc6J0LS/uSo+N3AC7XOfW6V4pB9SA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=m31zKb/bltotwO95xF9QMlFxUlAI99qcIijCDuwUTXM=; b=lHkxmNPD/iVrLWSyvrEn0qrMJ4n9pjg3Q4fi9OKJ0L02aS6igFKuGio4mS6psKT7YhMUMCN46O+5kYuZ1uXHksuJf3nuulVg377+6aAWJ6yNXUNd6DKb84aR43p0Z/hN8GdscFeAZ+IXYOhWh+PEukAbCR/mmDofHCl/cDmhNSU= Received: from BYAPR11MB3622.namprd11.prod.outlook.com (2603:10b6:a03:fe::30) by BYAPR11MB2805.namprd11.prod.outlook.com (2603:10b6:a02:c1::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4264.18; Tue, 22 Jun 2021 22:51:35 +0000 Received: from BYAPR11MB3622.namprd11.prod.outlook.com ([fe80::247b:262c:b8da:710b]) by BYAPR11MB3622.namprd11.prod.outlook.com ([fe80::247b:262c:b8da:710b%7]) with mapi id 15.20.4242.023; Tue, 22 Jun 2021 22:51:35 +0000 From: "Guo Dong" To: "Liu, Zhiguang" , "devel@edk2.groups.io" CC: "Ma, Maurice" , "You, Benjamin" Subject: Re: [PATCH 09/12] UefiPayloadPkg: Remove assert when reserve MMIO/IO resource for devices Thread-Topic: [PATCH 09/12] UefiPayloadPkg: Remove assert when reserve MMIO/IO resource for devices Thread-Index: AQHXZeuX8P0js/qLV0ONStHRJ+pnbasgpnDQ Date: Tue, 22 Jun 2021 22:51:35 +0000 Message-ID: References: <20210620154702.2681-1-zhiguang.liu@intel.com> <20210620154702.2681-10-zhiguang.liu@intel.com> In-Reply-To: <20210620154702.2681-10-zhiguang.liu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [68.104.146.79] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 125cd454-013d-4019-6409-08d935d049e6 x-ms-traffictypediagnostic: BYAPR11MB2805: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:462; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: IeXboL8KR6FjyTMM8Q6p67sB2zNjPUS79IzSejs9i/7mIigrwoVkbibDYtoct64YeLOxppwP87QhkWstlzDbFpVkH4V/MhE+6TzqLgPJyRUYwbCRpzwicK6EwagNWhm3VEG9FqVc2lm4+0LzKsX1vnIfzEpBD2P3wHuMJYnvuQXKEBaMQxSOtj1I5rOJl0mNtJGX9kxtGbWeJQwSz8BkZlt03cAGZFaEjRgbYu1NiNaiXT4wZbWSjg+uI43dQVmZVedOJDGxOhUiIXiT804g6+hijIFxs3MMArr732/IaKp3tw6T5a6E6MYVL2Tjt0ZJelJ0LMq21HxxzyGzU/C0S1sanogkzVoMW9LRFWGpR6vl6ah6FwLR1POFLeyCcdObqN6O2YtcB/7wltng7O3TyoscY/i+ITfMN64w1dip/BoHBqzKkOCT1Gk71b76H2ML1LseWPNBFwPDtRxod/yqQTQNosT5hJY+OHhjrWew2yGVnmBm/PwD7yt+t9LcDqxtr1kvJk7NxJY24RBklZgPYMH6D481M4v3wjQrUucCotrUeL5gx3EY8VLDgK600g/ukiom33rE1x6Fh6MRsTKJANMA8/8Fsv+w3WwBf+LstXQ= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR11MB3622.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(346002)(396003)(376002)(136003)(39860400002)(366004)(316002)(478600001)(83380400001)(66946007)(5660300002)(9686003)(66476007)(64756008)(66556008)(66446008)(8676002)(52536014)(8936002)(33656002)(76116006)(26005)(186003)(53546011)(86362001)(55016002)(107886003)(122000001)(38100700002)(2906002)(4326008)(6506007)(7696005)(110136005)(54906003)(71200400001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?utwiMoOS9+/DA4IdO7pQKfFb1bP6fGfNQsNbF/eDuqhX+FH/QN6ge3vALEI0?= =?us-ascii?Q?MThWlUFwefnHxB152TOZImFXN/xFFAqttnjgI1S1EebHscEEp/uZUG4Kzadg?= =?us-ascii?Q?35v23dKYwQoq0s5Zzp22WlR3ymucHFfTUWBqJT3n7hvTZwHTHbrmLXCtMuEU?= =?us-ascii?Q?b1D0WMdkYlIYz6LM+r4nturY30aIiM5qwfud1GIqLRQI/Sz6FGuXj/Dqu68s?= =?us-ascii?Q?YFYKeZTR3KUnKrcUDH5vnSh3sxLgWcQWdErf/E7JAlaT4jXzxjnotajikS/N?= =?us-ascii?Q?kY8aO/mbVty0JEddkxi5+UAhdhcNUXuM/1F8soxItwkQpLAhI7omZWX1ocPX?= =?us-ascii?Q?HaunrIaGBBbtDQ86cEycDZeAN8o1vJid3mDLDdoifoa6sBeX8joJB/D5CUOW?= =?us-ascii?Q?euvkuJLKe9I0TvuGcvA67yphzuU3wVzVNUSMahFxMooMI4+2vU57n1buyiIC?= =?us-ascii?Q?j/8Wv1USoYO39C5sPaRPN+8GFsxHQPv3JhH/Sv/fq8mdm/FoF8pUanvSsleQ?= =?us-ascii?Q?7Od/G5+G8hu/UwQvglktIyKKsh4b38uZoTa3aV7NU+EJ07fNuQfv+drINf2h?= =?us-ascii?Q?p/WH24jAZ3uFitk+t2KJnIw2Zxywk2/Mk7V3Rx5gLthb9vbpNJK4WoYTFI4q?= =?us-ascii?Q?koniHFB6dDsgAOj7nnJ9mNiYks+jm1Etz2vf2hAJ0b57iWdlVpn4qMRdJ2Pr?= =?us-ascii?Q?FG3AtOXs6K8vbmhZDr929CGtdqMTSoZZ699NQnY2Z8WEvAO3lPY2nXXTTLgx?= =?us-ascii?Q?+Ineh6FAko4lW3HlmxIKeh2xCrYKD2QVxjOL0qAwGEaKyPDKl6JFkQ06zBUP?= =?us-ascii?Q?W8SPwg4zz21TDcp+d3rV5/qZWzZx4zHImwTNuqGId79BXTtF92AnlZAkz0fQ?= =?us-ascii?Q?5CuyL5NpJ+5a0w/eCgGlekb2/+oMEIcgAQjE+Eg8pkuOBewCV8hGwmHr4r1J?= =?us-ascii?Q?PRey5fWaVmb5XBh6B5lc7wFoTpojNZCVrrNYJKHB51MbGDwkhBm+bZnxook3?= =?us-ascii?Q?aeiba49ZCVuDdeZO1lI/6y8cpijE9n85dV9SuG1J9XVgrU88tXzsh8IsgBmQ?= =?us-ascii?Q?nLYB0m63dFm3BgF5c2t3mn/hk2WOhY4tQgx0j+S5VDI03mPkVksFIDbkaLNC?= =?us-ascii?Q?fLftgF7SInTIWSm//rvOCpB6sB9kgmeonC/9nPsTS5ZCEULyLoGwhj5ZkL3v?= =?us-ascii?Q?6aVhYzf+aHUaBU5TtVeaYULJaYAA1aRonI3hGxu1yI98rz05vFQtAYaNDTer?= =?us-ascii?Q?o1zsxea9bKaVHMcUlSX+WK4B6Tbvn3iB7i/yiS/MobdlL9dwsx88qdYCzSq8?= =?us-ascii?Q?CKI2UKjmrgYoTUsaSy/eIPYN?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3622.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 125cd454-013d-4019-6409-08d935d049e6 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Jun 2021 22:51:35.8001 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: CXhxjfAxYpK8WXwgBmpGP496RuSsd4haxAglZCzPnOZNFq6AFVJgIqDbG/tEtEpu1mlITuaGtKa716Y2lkyw3A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB2805 Return-Path: guo.dong@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Guo Dong > -----Original Message----- > From: Liu, Zhiguang > Sent: Sunday, June 20, 2021 8:47 AM > To: devel@edk2.groups.io > Cc: Ma, Maurice ; Dong, Guo > ; You, Benjamin > Subject: [PATCH 09/12] UefiPayloadPkg: Remove assert when reserve > MMIO/IO resource for devices >=20 > Some boot loader may already reserve MMIO/IO resource for IOAPIC and > HPET, > so remove the assert when reserve MMIO/IO resource for IOAPIC and HPET >=20 > Cc: Maurice Ma > Cc: Guo Dong > Cc: Benjamin You > Signed-off-by: Zhiguang Liu > --- > UefiPayloadPkg/BlSupportDxe/BlSupportDxe.c | 20 +++++++++++--------- > 1 file changed, 11 insertions(+), 9 deletions(-) >=20 > diff --git a/UefiPayloadPkg/BlSupportDxe/BlSupportDxe.c > b/UefiPayloadPkg/BlSupportDxe/BlSupportDxe.c > index ffd3427fb3..04e968a232 100644 > --- a/UefiPayloadPkg/BlSupportDxe/BlSupportDxe.c > +++ b/UefiPayloadPkg/BlSupportDxe/BlSupportDxe.c > @@ -41,13 +41,12 @@ ReserveResourceInGcd ( > ); >=20 > if (EFI_ERROR (Status)) { >=20 > DEBUG (( >=20 > - DEBUG_ERROR, >=20 > + DEBUG_WARN, >=20 > "Failed to add memory space :0x%lx 0x%lx\n", >=20 > BaseAddress, >=20 > Length >=20 > )); >=20 > } >=20 > - ASSERT_EFI_ERROR (Status); >=20 > Status =3D gDS->AllocateMemorySpace ( >=20 > EfiGcdAllocateAddress, >=20 > GcdType, >=20 > @@ -57,14 +56,20 @@ ReserveResourceInGcd ( > ImageHandle, >=20 > NULL >=20 > ); >=20 > - ASSERT_EFI_ERROR (Status); >=20 > } else { >=20 > Status =3D gDS->AddIoSpace ( >=20 > GcdType, >=20 > BaseAddress, >=20 > Length >=20 > ); >=20 > - ASSERT_EFI_ERROR (Status); >=20 > + if (EFI_ERROR (Status)) { >=20 > + DEBUG (( >=20 > + DEBUG_WARN, >=20 > + "Failed to add IO space :0x%lx 0x%lx\n", >=20 > + BaseAddress, >=20 > + Length >=20 > + )); >=20 > + } >=20 > Status =3D gDS->AllocateIoSpace ( >=20 > EfiGcdAllocateAddress, >=20 > GcdType, >=20 > @@ -74,7 +79,6 @@ ReserveResourceInGcd ( > ImageHandle, >=20 > NULL >=20 > ); >=20 > - ASSERT_EFI_ERROR (Status); >=20 > } >=20 > return Status; >=20 > } >=20 > @@ -106,11 +110,9 @@ BlDxeEntryPoint ( > // >=20 > // Report MMIO/IO Resources >=20 > // >=20 > - Status =3D ReserveResourceInGcd (TRUE, > EfiGcdMemoryTypeMemoryMappedIo, 0xFEC00000, SIZE_4KB, 0, > ImageHandle); // IOAPIC >=20 > - ASSERT_EFI_ERROR (Status); >=20 > + ReserveResourceInGcd (TRUE, EfiGcdMemoryTypeMemoryMappedIo, > 0xFEC00000, SIZE_4KB, 0, ImageHandle); // IOAPIC >=20 >=20 >=20 > - Status =3D ReserveResourceInGcd (TRUE, > EfiGcdMemoryTypeMemoryMappedIo, 0xFED00000, SIZE_1KB, 0, > ImageHandle); // HPET >=20 > - ASSERT_EFI_ERROR (Status); >=20 > + ReserveResourceInGcd (TRUE, EfiGcdMemoryTypeMemoryMappedIo, > 0xFED00000, SIZE_1KB, 0, ImageHandle); // HPET >=20 >=20 >=20 > // >=20 > // Find the frame buffer information and update PCDs >=20 > -- > 2.16.2.windows.1