public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Guo Dong" <guo.dong@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"Rhodes, Sean" <sean@starlabs.systems>
Subject: Re: [edk2-devel] [PATCH] UefiPayloadPkg: Add PcdAllowHttpConnections to dec [edk2-stable202202]
Date: Mon, 7 Feb 2022 18:41:17 +0000	[thread overview]
Message-ID: <BYAPR11MB3622CB99F70EE7E156DBA3649E2C9@BYAPR11MB3622.namprd11.prod.outlook.com> (raw)
In-Reply-To: <22133.1644258710236189582@groups.io>

[-- Attachment #1: Type: text/plain, Size: 619 bytes --]


Hi Sean,

I added comments in your new patch below.
You need remove the old lines (lines 524 ~ 529) while adding new ones.

Thanks,
Guo
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Sean Rhodes
Sent: Monday, February 7, 2022 11:32 AM
To: Dong, Guo <guo.dong@intel.com>; devel@edk2.groups.io
Subject: Re: [edk2-devel] [PATCH] UefiPayloadPkg: Add PcdAllowHttpConnections to dec [edk2-stable202202]


Hi Guo

Assuming this (https://github.com/StarLabsLtd/edk2/commit/6da0b758872f5ed77a4d4f38ad2b0f06574be530) is what you meant, it does not resolve the build failure.

Thanks

Sean


[-- Attachment #2: Type: text/html, Size: 3651 bytes --]

      reply	other threads:[~2022-02-07 18:41 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-07  8:20 [PATCH] UefiPayloadPkg: Add PcdAllowHttpConnections to dec [edk2-stable202202] Sean Rhodes
2022-02-07 15:49 ` [edk2-devel] " Guo Dong
2022-02-07 18:31   ` Sean Rhodes
2022-02-07 18:41     ` Guo Dong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BYAPR11MB3622CB99F70EE7E156DBA3649E2C9@BYAPR11MB3622.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox