[PATCH] UefiPayloadPkg: Add PcdAllowHttpConnections to dec [edk2-stable202202]

[PATCH] UefiPayloadPkg: Add PcdAllowHttpConnections to dec [edk2-stable202202]

[Sean Rhodes]

This patch solves the build error of:
error F001: Pcd (gEfiNetworkPkgTokenSpaceGuid.PcdAllowHttpConnections) defined in DSC
is not declared in DEC files referenced in INF files in FDF. Arch: ['X64']

Signed-off-by: Sean Rhodes <sean@starlabs.systems>
---
 UefiPayloadPkg/UefiPayloadPkg.dec | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/UefiPayloadPkg/UefiPayloadPkg.dec b/UefiPayloadPkg/UefiPayloadPkg.dec
index 551f0a4915..21b0829d6e 100644
--- a/UefiPayloadPkg/UefiPayloadPkg.dec
+++ b/UefiPayloadPkg/UefiPayloadPkg.dec
@@ -86,3 +86,5 @@ gUefiPayloadPkgTokenSpaceGuid.PcdPcdDriverFile|{ 0x57, 0x72, 0xcf, 0x80, 0xab, 0
 ## FFS filename to find the default variable initial data file.
 # @Prompt FFS Name of variable initial data file
  gUefiPayloadPkgTokenSpaceGuid.PcdNvsDataFile |{ 0x1a, 0xf1, 0xb1, 0xae, 0x42, 0xcc, 0xcf, 0x4e, 0xac, 0x60, 0xdb, 0xab, 0xf6, 0xca, 0x69, 0xe6 }|VOID*|0x00000025
+
+gEfiNetworkPkgTokenSpaceGuid.PcdAllowHttpConnections|FALSE|BOOLEAN|0x00000026
-- 
2.32.0

Re: [edk2-devel] [PATCH] UefiPayloadPkg: Add PcdAllowHttpConnections to dec [edk2-stable202202]

[Guo Dong]

Hi Sean,

That PCD is defined in NetworkPkg\NetworkPkg.dec:  gEfiNetworkPkgTokenSpaceGuid.PcdAllowHttpConnections|FALSE|BOOLEAN|0x00000008
Could you update the UefiPayloadPkg.dsc to include network modules after "[Components.X64]" as below to have a try?

[Components.X64]
#
# UEFI network modules
#
!if $(NETWORK_DRIVER_ENABLE) == TRUE
  !include NetworkPkg/Network.dsc.inc
!endif

Thanks,
Guo

-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Sean Rhodes
Sent: Monday, February 7, 2022 1:20 AM
To: devel@edk2.groups.io
Cc: Dong, Guo <guo.dong@intel.com>; Rhodes, Sean <sean@starlabs.systems>
Subject: [edk2-devel] [PATCH] UefiPayloadPkg: Add PcdAllowHttpConnections to dec [edk2-stable202202]

This patch solves the build error of:
error F001: Pcd (gEfiNetworkPkgTokenSpaceGuid.PcdAllowHttpConnections) defined in DSC is not declared in DEC files referenced in INF files in FDF. Arch: ['X64']

Signed-off-by: Sean Rhodes <sean@starlabs.systems>
---
 UefiPayloadPkg/UefiPayloadPkg.dec | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/UefiPayloadPkg/UefiPayloadPkg.dec b/UefiPayloadPkg/UefiPayloadPkg.dec
index 551f0a4915..21b0829d6e 100644
--- a/UefiPayloadPkg/UefiPayloadPkg.dec
+++ b/UefiPayloadPkg/UefiPayloadPkg.dec
@@ -86,3 +86,5 @@ gUefiPayloadPkgTokenSpaceGuid.PcdPcdDriverFile|{ 0x57, 0x72, 0xcf, 0x80, 0xab, 0  ## FFS filename to find the default variable initial data file. # @Prompt FFS Name of variable initial data file  gUefiPayloadPkgTokenSpaceGuid.PcdNvsDataFile |{ 0x1a, 0xf1, 0xb1, 0xae, 0x42, 0xcc, 0xcf, 0x4e, 0xac, 0x60, 0xdb, 0xab, 0xf6, 0xca, 0x69, 0xe6 }|VOID*|0x00000025++gEfiNetworkPkgTokenSpaceGuid.PcdAllowHttpConnections|FALSE|BOOLEAN|0x00000026--
2.32.0



-=-=-=-=-=-=
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#86405): https://edk2.groups.io/g/devel/message/86405
Mute This Topic: https://groups.io/mt/88967566/1781375
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [guo.dong@intel.com]
-=-=-=-=-=-=

Re: [edk2-devel] [PATCH] UefiPayloadPkg: Add PcdAllowHttpConnections to dec [edk2-stable202202]

[Sean Rhodes]

[-- Attachment #1: Type: text/plain, Size: 189 bytes --]

Hi Guo

Assuming this ( https://github.com/StarLabsLtd/edk2/commit/6da0b758872f5ed77a4d4f38ad2b0f06574be530 ) is what you meant, it does not resolve the build failure.

Thanks

Sean

[-- Attachment #2: Type: text/html, Size: 356 bytes --]

Re: [edk2-devel] [PATCH] UefiPayloadPkg: Add PcdAllowHttpConnections to dec [edk2-stable202202]

[Guo Dong]

[-- Attachment #1: Type: text/plain, Size: 619 bytes --]


Hi Sean,

I added comments in your new patch below.
You need remove the old lines (lines 524 ~ 529) while adding new ones.

Thanks,
Guo
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Sean Rhodes
Sent: Monday, February 7, 2022 11:32 AM
To: Dong, Guo <guo.dong@intel.com>; devel@edk2.groups.io
Subject: Re: [edk2-devel] [PATCH] UefiPayloadPkg: Add PcdAllowHttpConnections to dec [edk2-stable202202]


Hi Guo

Assuming this (https://github.com/StarLabsLtd/edk2/commit/6da0b758872f5ed77a4d4f38ad2b0f06574be530) is what you meant, it does not resolve the build failure.

Thanks

Sean


[-- Attachment #2: Type: text/html, Size: 3651 bytes --]