From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web10.56711.1643755911355297437 for ; Tue, 01 Feb 2022 14:51:51 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=S4sFBUta; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: guo.dong@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1643755911; x=1675291911; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=ZMDK4G+qLJNZpcaG6u9Z8tXOv6XBDEPgOOGMWOoLrhs=; b=S4sFBUtatmuzSBVzOTpKBZgVHsu0R4z/BYmY6YikNSrh7CRuDp8LDuWE buKOSI8LfklNyAPRzWqY7kweLOvwF4qvwk8c4RVdtHRarJ5fAMocesxGt NaKgQ+Hneghueai1NLa2f8KrUHKoCGmgkqcz7Ny5HBGCprib/loDeqXrO EDFk4xtdyxyXNHoB7ntbDrdDoViYgpmg3ah/BIMqB+FqCPb88Gm6A1QuJ bWu3TnosOBgVbbGkyoqFPk47gmrT2sjpdp4Ws1ukYz7CWQytVPZ3JXFX4 /AJgU/AbB5fWSZZY5CAOGTY2LxtRkFOfRrF9QLO72q/stX8+/IZ/FyA+V A==; X-IronPort-AV: E=McAfee;i="6200,9189,10245"; a="235207975" X-IronPort-AV: E=Sophos;i="5.88,335,1635231600"; d="scan'208";a="235207975" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Feb 2022 14:51:50 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,335,1635231600"; d="scan'208";a="565763965" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga001.jf.intel.com with ESMTP; 01 Feb 2022 14:51:50 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 1 Feb 2022 14:51:50 -0800 Received: from fmsmsx604.amr.corp.intel.com (10.18.126.84) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 1 Feb 2022 14:51:49 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Tue, 1 Feb 2022 14:51:49 -0800 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.40) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Tue, 1 Feb 2022 14:51:49 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=i/vHA/LFu2Stx2g3dLmTMWR2O8NER1DoIldw2zyOWBN3QA1UmjA/+GI4jfM3f4jSQRcQdxgV60YaWhSJUqHHU/BojPdsAV16olfi3npGt3DtW+xqg4Cdm/Klv426etMU+czLKQwhEZpoqPEcLhSKOHRPu4MpsuDi00fjOU+AJmoewuVLiAl9VtUKW5zfrCfk8L3BgnwaWmKT2ZKVDZUmnl2I/IjUUChWcEWK60A3PVy3q28D391hXYsiM7jZkC4tZ+tLTuJv2ZxFUqo7yD0PBH3KoWAuwrvGjHejll999a++dD226uiwuYZbv9rPHsQUtUkHzqWDTXsHj0y+0Gdr/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=e0FdIjI++LEdT8fuVAXpxfjH6rSA99Uz7YuNjs37Hsw=; b=Isi4Ji+3um6BOUKZIRfmLpmmdg+wCYz0dE5BvYXiEAc39YOwmTq+pTYnZR1huQMgUdY7tKqQCFkuD4W3KsnMgIG12zfNS6VM4wd3x7DxALcoAZz7BV0ZQ4zyIdL5SRH5pXi+R1bt54MbC65keoCHXAZow0gaRBemwOOHfvxMYrzF5Z1265KsBWcnGUFAPc5C/00CPkGwlPXuKEEgu5H+nia6pNRt0NVYNQ+UK8hmfoBkTUALU8nSG+eyRSjZvVnbzyG5vve/h4HdEEvNj7+Y6SRSE6VQcFG5EO+NBccMaIWJ8osB2eai5xZSOYi8ZuTrCAMwTS0qVZkDOYL4kv47Sg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from BYAPR11MB3622.namprd11.prod.outlook.com (2603:10b6:a03:fe::30) by DM6PR11MB2826.namprd11.prod.outlook.com (2603:10b6:5:c0::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4930.20; Tue, 1 Feb 2022 22:51:46 +0000 Received: from BYAPR11MB3622.namprd11.prod.outlook.com ([fe80::c461:5de1:9cf:23cf]) by BYAPR11MB3622.namprd11.prod.outlook.com ([fe80::c461:5de1:9cf:23cf%7]) with mapi id 15.20.4930.022; Tue, 1 Feb 2022 22:51:46 +0000 From: "Guo Dong" To: "devel@edk2.groups.io" , "Rhodes, Sean" Subject: Re: [edk2-devel] [PATCH 43/43] UefiPayloadPkg: Add option to follow BGRT spec Thread-Topic: [edk2-devel] [PATCH 43/43] UefiPayloadPkg: Add option to follow BGRT spec Thread-Index: AQHYFuUFqUXeErwzJkauVHzFO32CB6x/Td+w Date: Tue, 1 Feb 2022 22:51:46 +0000 Message-ID: References: <9dd14fc91c174eae87fd122c7ac70073a363527f.1643662556.git.sean@starlabs.systems> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.200.16 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 0bc74d9d-e2a9-4d67-dad5-08d9e5d56c87 x-ms-traffictypediagnostic: DM6PR11MB2826:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: jk3sChlDE8cL3L+LrNyFdkVLFPSMis1StXzTjyWx1Sw5galu0jeP+eoiQ+Jq7EPpipOw39XALXWjVIxjpykqLRRHJuHnmrENNmM5vTmp2cS16G4u2anwwM0gZe/IP/zIQD/Gy9B7Bw8YABDv36iHWxGD7/Lmg75rjByTMQ38uWpRtmGNUxHll4xQvohEnAaZVU+jc9TK5/ftHW/irRUa/qKfQ8mOStyyUCeRJBEIlXcvnz6vPyHwPLHN3AbvMqbjjN1ZEziLd5qEKluMb72BVxyDeWy1MKAw8mR6eg1LhVZiwPspQED3bD6T8mvlIHX7rbSCyTR4bGyWc+IKa2iphXcZhXpvwHbbQG4yEjODE6jzJFT5MyK4l8PPdRim0N5hyE4m0nueMrw33yLplGlPxT/Jn+9X5IfNU/8sBhx2uKcZOSpDbGdUoqJFEqLQYZa95nHxuPA+o05c2gcxivT0cGTyRq8cDdCX/uGPvQvw1FF1x85+hJ09hhJNfm4cGxAY0+oljEm5w29dSewxw5iHUASMxQ6DyhEMnN1V3x9NA8AZrGZv11EgJigRDXc6AgsJDdeq+xr6A0l57a6gpyko+TKgwEssVGJUrEjP9P0k+fncoQoK/Ji98kJURjVHsuhczEWBckZeA+IhHe59pJkv2fTj0V1wauhqulZnIXnYOodG2NKUSKVcBbkqskLh1ozqIaW9SQF9gGys2dWiz7RLpWJoXfVYgJGv9XjQAnEb2mTiieKrOFIaFEnnrtm0WHkB444n/LUPEPqU2BfTeihlahhXP5f4+jRulh9tAx4sKzBdW4vvGjohsLLhTfQurLkOogZeiBJpNAxN8wm2fBXHqA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR11MB3622.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(5660300002)(83380400001)(9686003)(6506007)(7696005)(122000001)(52536014)(38070700005)(2906002)(186003)(26005)(71200400001)(53546011)(33656002)(66476007)(110136005)(55016003)(64756008)(316002)(38100700002)(66446008)(966005)(82960400001)(76116006)(86362001)(8676002)(66946007)(8936002)(508600001)(66556008);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?HX4Hp8KPyhMLly395OtkWhxuzoK9u2JKrVqdgSEtT10phKc1F9f6XRJVG1r2?= =?us-ascii?Q?yfSsICAfI98vJC2ReMdeyf4uwA8p/PXq0N4wYnyfxIktAd+7Em+usxa9mWyr?= =?us-ascii?Q?EjB+n5hSX0UaIKi4Qr+Q1QJqiMnUhJtr24CzFI+RBULmz2iXfyoXSO5ltIRZ?= =?us-ascii?Q?Br0ptbs7SZOL7QUbdZsWjf43Y2uJC34kWqeLblCb2whTyvih17Y2tO97lIP4?= =?us-ascii?Q?wxQBTA+YiRgFSoUyjFbaHsupWmNdwDJ8BQtsJ3x8hkVvBiYb9UlOonV0AhV1?= =?us-ascii?Q?nZNT4AUusezA1BpPrjCk2jfD4AsN4yE83nLVAkZ64v8Npdb4qupFfPyy/I2L?= =?us-ascii?Q?oa6Kc0FwmRYqub+rYiEz+PQ+PTj5KB+LKNW0ldOIqIGqwemD3J6FeUAThs49?= =?us-ascii?Q?4PhDS3rU/nzulfyXKUnl5fpoGNNAY0KJjJAdjDR4uXYNta3bAyYeFsz6/G5b?= =?us-ascii?Q?MkcOxCUNYOVwrZ5rUGRfC2R5GPtJsTt2qK/zA8M97gfzWZ8udk8io3s2fWHC?= =?us-ascii?Q?hfSPhLFfUpTQn6mDZHE9g0m2Ps1qldxdQt2wva/fije5wQ14nadtEgLpb8bt?= =?us-ascii?Q?jgLDBOxV+iiavWCuizb8ozsdMXpf9i3rOT1vjv3aWxz3kYll6ZFCSFRQy3Ln?= =?us-ascii?Q?+NxXyMDdqXxkb690exG8epqTJ9GFLBnbPsrR0PW5qtjbqmca7QzW7S8sPXeY?= =?us-ascii?Q?7uc7MDKr6jKUfY+nMzyqjWTVoT7wqwb2exb85TbCufqIZGkrr11Sde2vRCFE?= =?us-ascii?Q?guHEFTmZZPTct+F21hgb6kAcJO51mY8AGadiwoYKgRV7nJvKRZ719u18HBmG?= =?us-ascii?Q?+q7nNET1Vf3bqAxi6laJqrUlgFhMRA53UNsQy7THy4F0m0ckQRlsDuFCf+F0?= =?us-ascii?Q?sEOugcCRpf2Kwkdw7y1T3IIZ6m50YU/CwlJQcfPwiz+C3CYV5Ti9Qsk2IKCM?= =?us-ascii?Q?P1du77W7nDI320INlUxugPy7WxhcYr79pF61pLt++PKjtlIpZ+OWKcQz5WVq?= =?us-ascii?Q?yngNDAur4vwinTJdPnIfxSYJj0dM2oCpAEhub2fFLgnGxUHRBiyRhVCd4raE?= =?us-ascii?Q?7O/rMZywInqkEg5gzAlnNsMrlJjW50O7OaMo6fWLQKbht+u2qeZcmmM7DYzM?= =?us-ascii?Q?SKaNbWoCI04EH5g04pMPnQld058Bf8nfVHFG2t5xUtUx1m8R7BfBSe1JiN1v?= =?us-ascii?Q?+M6Sfj1J/0V33pWhiLJKTiV6LOY3pb6eN/lql1qs6FBrYd0zQtCKYgYZJpI0?= =?us-ascii?Q?chL9AbzWl/XrDfHcZUigDfmO64HGI6SEOHg9WS8dx9MlvfF8pnnDcwf6iYaN?= =?us-ascii?Q?WwNg24H8bT7JoA17RxksEBTPkJRQ3tJwAQWeqDDBQk5kTsYnWkRr/M0c5Mew?= =?us-ascii?Q?TdTpERlEYXIkBaPzUCJ/ST8yIxL5k3Synl64ElQ4VIbt8dZAGDHzKZ9cc47h?= =?us-ascii?Q?/3rGn6EEjIYwUKQw5Ue8qTHA7vBJ0ZEAX1WqDcVxJcIlaDUmOhuNDOcfxNyZ?= =?us-ascii?Q?LyvQ7jBxl83nF+XYE2njB0d2u4C4GDe8P3+jE1R2QrJVLTHvtgVuLG/dZIPg?= =?us-ascii?Q?L9FEb8+pOv0duxmlAIupp7u9jowQkEzgiKP4eyDgtUyYuvRv77D8AyxwKvlL?= =?us-ascii?Q?/Q=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3622.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0bc74d9d-e2a9-4d67-dad5-08d9e5d56c87 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Feb 2022 22:51:46.0492 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: xx5o3MPnGLRHd/17oBeD4KVE88t8K5tKbPfisV1efwUBUcdAsxUUDHFm2KfEdy6vsWCwPo8Kec9B77N1b389lA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB2826 Return-Path: guo.dong@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable This patch has changes for MdeModulePkg which need review from MdeModulePkg= maintainers. Pease separate this patch into different patches for different package. And please CC the package maintainers when you send patches to edk2 devel l= ist follow EDK2 process. Else the patch might be not reviewed in time. Thanks, Guo -----Original Message----- From: devel@edk2.groups.io On Behalf Of Sean Rhodes Sent: Monday, January 31, 2022 1:56 PM To: devel@edk2.groups.io Cc: Rhodes, Sean Subject: [edk2-devel] [PATCH 43/43] UefiPayloadPkg: Add option to follow BG= RT spec Add option to centre the Boot Logo 38.2% from the top of screen, following = the BGRT specification. Signed-off-by: Sean Rhodes --- MdeModulePkg/Library/BootLogoLib/BootLogoLib.c | 6 +++++- MdeModulePkg/Library/BootLogoLib/BootLogoLib.inf | 3 +++ MdeModulePkg/MdeModulePkg.dec | 3 +++ UefiPayloadPkg/UefiPayloadPkg.dsc | 2 ++ 4 files changed, 13 insertions(+), 1 deletion(-) diff --git a/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c b/MdeModulePkg/= Library/BootLogoLib/BootLogoLib.c index 478ec2d40e..f6d052eea2 100644 --- a/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c +++ b/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c @@ -176,7 +176,11 @@ BootLogoEnableLogo ( break; case EdkiiPlatformLogoDisplayAttributeCenter: = DestX =3D (SizeOfX - Image.Width) / 2;- DestY =3D (SizeOfY - Image.= Height) / 2;+ if (FixedPcdGetBool (PcdFollowBGRTSpec) =3D=3D TRUE) {= + DestY =3D (SizeOfY * 382) / 1000 - Image.Height / 2;+ } e= lse {+ DestY =3D (SizeOfY - Image.Height) / 2;+ } b= reak; case EdkiiPlatformLogoDisplayAttributeCenterRight: Dest= X =3D SizeOfX - Image.Width;diff --git a/MdeModulePkg/Library/BootLogoLib/B= ootLogoLib.inf b/MdeModulePkg/Library/BootLogoLib/BootLogoLib.inf index 7d50f2dfa3..03ff038f47 100644 --- a/MdeModulePkg/Library/BootLogoLib/BootLogoLib.inf +++ b/MdeModulePkg/Library/BootLogoLib/BootLogoLib.inf @@ -48,5 +48,8 @@ gEfiUserManagerProtocolGuid ## CONSUMES gEdkiiPlatfo= rmLogoProtocolGuid ## CONSUMES +[Pcd]+ gEfiMdeModulePkgToke= nSpaceGuid.PcdFollowBGRTSpec+ [FeaturePcd] gEfiMdePkgTokenSpaceGuid.PcdUg= aConsumeSupport ## CONSUMESdiff --git a/MdeModulePkg/MdeModulePkg.dec b/Mde= ModulePkg/MdeModulePkg.dec index 463e889e9a..fb3eb7ab7f 100644 --- a/MdeModulePkg/MdeModulePkg.dec +++ b/MdeModulePkg/MdeModulePkg.dec @@ -2079,6 +2079,9 @@ # @Prompt Enable PCIe Resizable BAR Capability support. gEfiMdeModuleP= kgTokenSpaceGuid.PcdPcieResizableBarSupport|FALSE|BOOLEAN|0x10000024 + # F= ollow BGRT Specifcation+ gEfiMdeModulePkgTokenSpaceGuid.PcdFollowBGRTSpec|= TRUE|BOOLEAN|0x00000025+ [PcdsPatchableInModule] ## Specify memory size w= ith page number for PEI code when # Loading Module at Fixed Address feat= ure is enabled.diff --git a/UefiPayloadPkg/UefiPayloadPkg.dsc b/UefiPayload= Pkg/UefiPayloadPkg.dsc index 1ce96a51c1..115111c037 100644 --- a/UefiPayloadPkg/UefiPayloadPkg.dsc +++ b/UefiPayloadPkg/UefiPayloadPkg.dsc @@ -33,6 +33,7 @@ DEFINE UNIVERSAL_PAYLOAD =3D FALSE DEFINE SECURITY_STUB_ENA= BLE =3D TRUE DEFINE SMM_SUPPORT =3D FALSE+ DEFI= NE FOLLOW_BGRT_SPEC =3D TRUE # # SBL: UEFI payload for= Slim Bootloader # COREBOOT: UEFI payload for coreboot@@ -398,6 +399,7 @@ !if $(PERFORMANCE_MEASUREMENT_ENABLE) gEfiMdePkgTokenSpaceGuid.PcdPerfor= manceLibraryPropertyMask | 0x1 !endif+ gEfiMdeModulePkgTokenSpaceGui= d.PcdFollowBGRTSpec|$(FOLLOW_BGRT_SPEC) [PcdsPatchableInModule.X64] gPcA= tChipsetPkgTokenSpaceGuid.PcdRtcIndexRegister|$(RTC_INDEX_REGISTER)--=20 2.32.0 -=3D-=3D-=3D-=3D-=3D-=3D Groups.io Links: You receive all messages sent to this group. View/Reply Online (#86263): https://edk2.groups.io/g/devel/message/86263 Mute This Topic: https://groups.io/mt/88818048/1781375 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [guo.dong@intel.com] -=3D= -=3D-=3D-=3D-=3D-=3D