* [UefiPayloadPkg: Make TerminalDxe build time configurable 0/1] ***
@ 2020-06-23 15:02 Marcello Sylvester Bauer
2020-06-23 15:02 ` [UefiPayloadPkg: Make TerminalDxe build time configurable 1/1] UefiPayloadPkg: Make TerminalDxe build time configurable Marcello Sylvester Bauer
0 siblings, 1 reply; 3+ messages in thread
From: Marcello Sylvester Bauer @ 2020-06-23 15:02 UTC (permalink / raw)
To: devel
As the TerminalDxe significantly slows down the boot menu rendering.
Disable it by default and add the option SERIAL_TERMINAL to enabled
it for headless platforms.
Changes at:
https://github.com/9elements/edk2-1/tree/UefiPayloadPkg-TerminalDxe
Pull Request:
https://github.com/tianocore/edk2/pull/701
Patrick Rudolph (1):
UefiPayloadPkg: Make TerminalDxe build time configurable
UefiPayloadPkg/UefiPayloadPkgIa32.dsc | 5 +++++
UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc | 5 +++++
UefiPayloadPkg/UefiPayloadPkg.fdf | 2 ++
3 files changed, 12 insertions(+)
--
2.25.4
^ permalink raw reply [flat|nested] 3+ messages in thread
* [UefiPayloadPkg: Make TerminalDxe build time configurable 1/1] UefiPayloadPkg: Make TerminalDxe build time configurable
2020-06-23 15:02 [UefiPayloadPkg: Make TerminalDxe build time configurable 0/1] *** Marcello Sylvester Bauer
@ 2020-06-23 15:02 ` Marcello Sylvester Bauer
2020-06-23 17:13 ` Guo Dong
0 siblings, 1 reply; 3+ messages in thread
From: Marcello Sylvester Bauer @ 2020-06-23 15:02 UTC (permalink / raw)
To: devel; +Cc: Maurice Ma, Guo Dong, Benjamin You
From: Patrick Rudolph <patrick.rudolph@9elements.com>
As the TerminalDxe significantly slows down the boot menu rendering.
Disable it by default and add the option SERIAL_TERMINAL to enabled
it for headless platforms.
Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>
Signed-off-by: Marcello Sylvester Bauer <marcello.bauer@9elements.com>
Cc: Maurice Ma <maurice.ma@intel.com>
Cc: Guo Dong <guo.dong@intel.com>
Cc: Benjamin You <benjamin.you@intel.com>
---
UefiPayloadPkg/UefiPayloadPkgIa32.dsc | 5 +++++
UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc | 5 +++++
UefiPayloadPkg/UefiPayloadPkg.fdf | 2 ++
3 files changed, 12 insertions(+)
diff --git a/UefiPayloadPkg/UefiPayloadPkgIa32.dsc b/UefiPayloadPkg/UefiPayloadPkgIa32.dsc
index c6c47833871b..2ea475a4cee4 100644
--- a/UefiPayloadPkg/UefiPayloadPkgIa32.dsc
+++ b/UefiPayloadPkg/UefiPayloadPkgIa32.dsc
@@ -58,6 +58,9 @@ [Defines]
DEFINE UART_DEFAULT_STOP_BITS = 1
DEFINE DEFAULT_TERMINAL_TYPE = 0
+ # Enabling the serial terminal will slow down the boot menu rendering!
+ DEFINE SERIAL_TERMINAL = FALSE
+
#
# typedef struct {
# UINT16 VendorId; ///< Vendor ID to match the PCI device. The value 0xFFFF terminates the list of entries.
@@ -502,7 +505,9 @@ [Components.IA32]
MdeModulePkg/Universal/Console/ConPlatformDxe/ConPlatformDxe.inf
MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitterDxe.inf
MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsoleDxe.inf
+!if $(SERIAL_TERMINAL) == TRUE
MdeModulePkg/Universal/Console/TerminalDxe/TerminalDxe.inf
+!endif
UefiPayloadPkg/GraphicsOutputDxe/GraphicsOutputDxe.inf
#------------------------------
diff --git a/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc b/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc
index 5559b1258521..62539ad56031 100644
--- a/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc
+++ b/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc
@@ -59,6 +59,9 @@ [Defines]
DEFINE UART_DEFAULT_STOP_BITS = 1
DEFINE DEFAULT_TERMINAL_TYPE = 0
+ # Enabling the serial terminal will slow down the boot menu redering!
+ DEFINE SERIAL_TERMINAL = FALSE
+
#
# typedef struct {
# UINT16 VendorId; ///< Vendor ID to match the PCI device. The value 0xFFFF terminates the list of entries.
@@ -504,7 +507,9 @@ [Components.X64]
MdeModulePkg/Universal/Console/ConPlatformDxe/ConPlatformDxe.inf
MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitterDxe.inf
MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsoleDxe.inf
+!if $(SERIAL_TERMINAL) == TRUE
MdeModulePkg/Universal/Console/TerminalDxe/TerminalDxe.inf
+!endif
UefiPayloadPkg/GraphicsOutputDxe/GraphicsOutputDxe.inf
#------------------------------
diff --git a/UefiPayloadPkg/UefiPayloadPkg.fdf b/UefiPayloadPkg/UefiPayloadPkg.fdf
index dfbcde566849..bda831d77c9b 100644
--- a/UefiPayloadPkg/UefiPayloadPkg.fdf
+++ b/UefiPayloadPkg/UefiPayloadPkg.fdf
@@ -131,7 +131,9 @@ [FV.DXEFV]
INF MdeModulePkg/Universal/Console/ConPlatformDxe/ConPlatformDxe.inf
INF MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitterDxe.inf
INF MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsoleDxe.inf
+!if $(SERIAL_TERMINAL) == TRUE
INF MdeModulePkg/Universal/Console/TerminalDxe/TerminalDxe.inf
+!endif
INF UefiPayloadPkg/GraphicsOutputDxe/GraphicsOutputDxe.inf
#
--
2.25.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [UefiPayloadPkg: Make TerminalDxe build time configurable 1/1] UefiPayloadPkg: Make TerminalDxe build time configurable
2020-06-23 15:02 ` [UefiPayloadPkg: Make TerminalDxe build time configurable 1/1] UefiPayloadPkg: Make TerminalDxe build time configurable Marcello Sylvester Bauer
@ 2020-06-23 17:13 ` Guo Dong
0 siblings, 0 replies; 3+ messages in thread
From: Guo Dong @ 2020-06-23 17:13 UTC (permalink / raw)
To: Marcello Sylvester Bauer, devel@edk2.groups.io; +Cc: Ma, Maurice, You, Benjamin
Serial terminal is used for remote debug beside headless. To avoid change current behavior,
How about enabling serial terminal by default and using a build flag (e.g. DISABLE_SERIAL_TERMINAL) to disable it?
Thanks,
Guo
> -----Original Message-----
> From: Marcello Sylvester Bauer <marcello.bauer@9elements.com>
> Sent: Tuesday, June 23, 2020 8:03 AM
> To: devel@edk2.groups.io
> Cc: Ma, Maurice <maurice.ma@intel.com>; Dong, Guo
> <guo.dong@intel.com>; You, Benjamin <benjamin.you@intel.com>
> Subject: [UefiPayloadPkg: Make TerminalDxe build time configurable 1/1]
> UefiPayloadPkg: Make TerminalDxe build time configurable
>
> From: Patrick Rudolph <patrick.rudolph@9elements.com>
>
> As the TerminalDxe significantly slows down the boot menu rendering.
> Disable it by default and add the option SERIAL_TERMINAL to enabled
> it for headless platforms.
>
> Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>
> Signed-off-by: Marcello Sylvester Bauer <marcello.bauer@9elements.com>
> Cc: Maurice Ma <maurice.ma@intel.com>
> Cc: Guo Dong <guo.dong@intel.com>
> Cc: Benjamin You <benjamin.you@intel.com>
> ---
> UefiPayloadPkg/UefiPayloadPkgIa32.dsc | 5 +++++
> UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc | 5 +++++
> UefiPayloadPkg/UefiPayloadPkg.fdf | 2 ++
> 3 files changed, 12 insertions(+)
>
> diff --git a/UefiPayloadPkg/UefiPayloadPkgIa32.dsc
> b/UefiPayloadPkg/UefiPayloadPkgIa32.dsc
> index c6c47833871b..2ea475a4cee4 100644
> --- a/UefiPayloadPkg/UefiPayloadPkgIa32.dsc
> +++ b/UefiPayloadPkg/UefiPayloadPkgIa32.dsc
> @@ -58,6 +58,9 @@ [Defines]
> DEFINE UART_DEFAULT_STOP_BITS = 1
>
> DEFINE DEFAULT_TERMINAL_TYPE = 0
>
>
>
> + # Enabling the serial terminal will slow down the boot menu rendering!
>
> + DEFINE SERIAL_TERMINAL = FALSE
>
> +
>
> #
>
> # typedef struct {
>
> # UINT16 VendorId; ///< Vendor ID to match the PCI device. The
> value 0xFFFF terminates the list of entries.
>
> @@ -502,7 +505,9 @@ [Components.IA32]
> MdeModulePkg/Universal/Console/ConPlatformDxe/ConPlatformDxe.inf
>
> MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitterDxe.inf
>
>
> MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsoleD
> xe.inf
>
> +!if $(SERIAL_TERMINAL) == TRUE
>
> MdeModulePkg/Universal/Console/TerminalDxe/TerminalDxe.inf
>
> +!endif
>
> UefiPayloadPkg/GraphicsOutputDxe/GraphicsOutputDxe.inf
>
>
>
> #------------------------------
>
> diff --git a/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc
> b/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc
> index 5559b1258521..62539ad56031 100644
> --- a/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc
> +++ b/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc
> @@ -59,6 +59,9 @@ [Defines]
> DEFINE UART_DEFAULT_STOP_BITS = 1
>
> DEFINE DEFAULT_TERMINAL_TYPE = 0
>
>
>
> + # Enabling the serial terminal will slow down the boot menu redering!
>
> + DEFINE SERIAL_TERMINAL = FALSE
>
> +
>
> #
>
> # typedef struct {
>
> # UINT16 VendorId; ///< Vendor ID to match the PCI device. The
> value 0xFFFF terminates the list of entries.
>
> @@ -504,7 +507,9 @@ [Components.X64]
> MdeModulePkg/Universal/Console/ConPlatformDxe/ConPlatformDxe.inf
>
> MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitterDxe.inf
>
>
> MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsoleD
> xe.inf
>
> +!if $(SERIAL_TERMINAL) == TRUE
>
> MdeModulePkg/Universal/Console/TerminalDxe/TerminalDxe.inf
>
> +!endif
>
> UefiPayloadPkg/GraphicsOutputDxe/GraphicsOutputDxe.inf
>
>
>
> #------------------------------
>
> diff --git a/UefiPayloadPkg/UefiPayloadPkg.fdf
> b/UefiPayloadPkg/UefiPayloadPkg.fdf
> index dfbcde566849..bda831d77c9b 100644
> --- a/UefiPayloadPkg/UefiPayloadPkg.fdf
> +++ b/UefiPayloadPkg/UefiPayloadPkg.fdf
> @@ -131,7 +131,9 @@ [FV.DXEFV]
> INF
> MdeModulePkg/Universal/Console/ConPlatformDxe/ConPlatformDxe.inf
>
> INF MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitterDxe.inf
>
> INF
> MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsoleD
> xe.inf
>
> +!if $(SERIAL_TERMINAL) == TRUE
>
> INF MdeModulePkg/Universal/Console/TerminalDxe/TerminalDxe.inf
>
> +!endif
>
> INF UefiPayloadPkg/GraphicsOutputDxe/GraphicsOutputDxe.inf
>
>
>
> #
>
> --
> 2.25.4
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-06-23 17:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-06-23 15:02 [UefiPayloadPkg: Make TerminalDxe build time configurable 0/1] *** Marcello Sylvester Bauer
2020-06-23 15:02 ` [UefiPayloadPkg: Make TerminalDxe build time configurable 1/1] UefiPayloadPkg: Make TerminalDxe build time configurable Marcello Sylvester Bauer
2020-06-23 17:13 ` Guo Dong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox