From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web10.12005.1592932401553822957 for ; Tue, 23 Jun 2020 10:13:21 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=L4pc+cZx; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: guo.dong@intel.com) IronPort-SDR: mmoX6qCf5VtPeUE/+yMlSykgdnJZwDVUkmRrHDbAntk/GQnScA2owfGIKYN41Fly+Gwn6n1AXv pbo8mhJN13Dw== X-IronPort-AV: E=McAfee;i="6000,8403,9661"; a="123828119" X-IronPort-AV: E=Sophos;i="5.75,272,1589266800"; d="scan'208";a="123828119" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jun 2020 10:13:19 -0700 IronPort-SDR: VbHi8XCPundIPtT6M71WI17F69g5JbRdnO/hiJAPBjd7+dxuuBCT/Dlo+C273iNwYJzEsBG5OL 6TI643Y6O+ww== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,272,1589266800"; d="scan'208";a="263383949" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga007.fm.intel.com with ESMTP; 23 Jun 2020 10:13:19 -0700 Received: from fmsmsx604.amr.corp.intel.com (10.18.126.84) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 23 Jun 2020 10:13:19 -0700 Received: from fmsmsx604.amr.corp.intel.com (10.18.126.84) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 23 Jun 2020 10:13:18 -0700 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 23 Jun 2020 10:13:17 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.40) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 23 Jun 2020 10:13:12 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fJ/T5h6QWfpnTV1z01QV6caqwI6h6pHuJcWdMQPKPIbbCgR6LCtEtqsGgrwaf+eN5KV+xzd8xJPMaOGPgxkDV2fhdGZZun0y9ho4VZG8WQvPTvQ6N09glcFZPZY4l5lyLLKUrj/3cDBUYy4qtw5CBYSv22zaZOwl+OijzJvnunieOCDiRw3+YdMVxgOSTr0fxL2KIMz+StHFQWAglo/uMuAkAzCBsS0OF43pa5sjppAf9EpOIOTTCsO+e8/X7FhTRYjx9HZ68jQNLt5clWrJrLntZIpZGOGgM8qWRMLusOeyiY7bKeE5ZJeZ/3mY1ZaIYkKHO0+fi28AbqqmJXfhPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=t6Yv368pOaWkuEXmW6v8Cq2zzbD9l3X1ucK37zbfin4=; b=ORHh6un4FqWFTxMP2HM51D4w/QkP+5MZJQRj97h3sUrUb0ZasRzzpxyjRzJn4JOoDLfr9KHFfdEhRfu3X12CTtkXRTrnqCz+BdS6D0zJMUDecL2gfFKbcVHHOKcAPVsIZwR0glozvvIHq+lc5JmjRiyQOADjNhucxuLUldkmGhXvUs88jrL4qEmN6mKYjpih9F8ABW4aiNRF6K/1MCe98R1ory6B10H9Q/UEGnnNq/gBpPQBN7O5SDzyiuJmhwWffLdsgITxNym0Ov/stJnc1q9vawzu4rgLdO6hdlyoQn9PlWnTCcgGk2oiojsqr0ArLrGMdrZ7l994ZZILwWBpeA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=t6Yv368pOaWkuEXmW6v8Cq2zzbD9l3X1ucK37zbfin4=; b=L4pc+cZxLoR+zqYKyTDJW59657pR0qFMn4x2DdyvqrAOS+ikrerr+lCY84y6lCW60pX2FExQeelGNJtS6q5TffxzD5bA5tX6weEbk7HyDZvrLzLVXoWlDeULQBIZDKZazYYEReXSL8TUvfIrTGq9dE+jWyIqN20WKbWC/i9NgFE= Received: from BYAPR11MB3653.namprd11.prod.outlook.com (2603:10b6:a03:f7::14) by BYAPR11MB2983.namprd11.prod.outlook.com (2603:10b6:a03:88::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3109.23; Tue, 23 Jun 2020 17:13:10 +0000 Received: from BYAPR11MB3653.namprd11.prod.outlook.com ([fe80::6c0c:f784:6060:76de]) by BYAPR11MB3653.namprd11.prod.outlook.com ([fe80::6c0c:f784:6060:76de%7]) with mapi id 15.20.3109.027; Tue, 23 Jun 2020 17:13:10 +0000 From: "Guo Dong" To: Marcello Sylvester Bauer , "devel@edk2.groups.io" CC: "Ma, Maurice" , "You, Benjamin" Subject: Re: [UefiPayloadPkg: Make TerminalDxe build time configurable 1/1] UefiPayloadPkg: Make TerminalDxe build time configurable Thread-Topic: [UefiPayloadPkg: Make TerminalDxe build time configurable 1/1] UefiPayloadPkg: Make TerminalDxe build time configurable Thread-Index: AQHWSW/H8dwlk5tdK0+fAEkRopdbjqjmbiLA Date: Tue, 23 Jun 2020 17:13:10 +0000 Message-ID: References: <20200623150248.16206-1-marcello.bauer@9elements.com> <20200623150248.16206-2-marcello.bauer@9elements.com> In-Reply-To: <20200623150248.16206-2-marcello.bauer@9elements.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: 9elements.com; dkim=none (message not signed) header.d=none;9elements.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [68.2.51.172] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 07bb6e9b-16eb-4835-5491-08d81798b4d8 x-ms-traffictypediagnostic: BYAPR11MB2983: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:660; x-forefront-prvs: 04433051BF x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: QNW9FiV40VEemtNg7zc46oyBTo3reqtzxY66sfGTABMzsw5bv/gW8qUjvrJFuICgRZtk80POnlkob8TpC/dFUaDDOm/dLdmr73to74mlfX8oCSNsTJPY9vzjRTxxq2fuvWfSvgA5nIcV9YhAB/5UvYPI/fE3vRLNM1zqDcIXEvr5jWTCPdmHtLE9N/mq05hgZktuzNxoaBd2l5KazMR7YIY/1+wzpniclVxl3+87P0fNfQJwXRdyqfj2LldTwJEyIgUz1oFQ0+/xr8guKIFgoYkmzXT3LnEZaqeDNyg9qzKo/4T0/zmgoh1iO883RUU7W5D/sr+W+p61vWYmh4Kugw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR11MB3653.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(366004)(86362001)(8936002)(33656002)(4326008)(498600001)(107886003)(66556008)(66476007)(76116006)(83380400001)(64756008)(66446008)(66946007)(55016002)(9686003)(19627235002)(2906002)(5660300002)(52536014)(26005)(186003)(53546011)(7696005)(54906003)(6506007)(8676002)(71200400001)(110136005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: rQWaJ+rY+DIZ440V4IqnfPsmeZ4THFdwg4Uz6iP1hrH8OXus4cEaC0HkmLtiDYC6GfAN4RCmgEe9eYL458VMXg1Y9007iR9CkWzEmpw7F0mObo3KAXsqW82u64aYorHIYpAYgP0immmddNDheY87zM/bHld4SGYW7+E6i+xxXkx7Q3seqZkq3pwt7gBF7fJlvjw5rRRDIEfp6w3WH17ZVzAbJjTZ4pUcThSbHLr4sinU+tEorz07NSioYXGYhfXIIkoqto9fzH/0GQoc5vYWWUZ3bO2GrVjjlaPe5iCvm/zNgMEuMhdERVg4D7PMHpgIHkXXowjl7RoNVIaHTodIvGZuz9fYVNR5lnvu2xrzii8vCKt+OXxEdDDaM8texv8m8a7L+9RnGpJ7K50BKYVu1kbw0e2LjA5u//7cvBK2RSwG9TvOO3H9kJd/hQz5TPmrQUKq0YJt5e5NM5nY43Ldn1PPe/s6baODjvZYcbldxjY= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 07bb6e9b-16eb-4835-5491-08d81798b4d8 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Jun 2020 17:13:10.7280 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Wf3mjnTFvdycTvCTwlIcYhMu4pgPQgVF0z00DdwoIn7jem8VQB4DqnZZf+d7g+IcEfPQQ47ZAUJsTEICZqn0Hw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB2983 Return-Path: guo.dong@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Serial terminal is used for remote debug beside headless. To avoid change c= urrent behavior,=20 How about enabling serial terminal by default and using a build flag (e.g. = DISABLE_SERIAL_TERMINAL) to disable it? Thanks, Guo > -----Original Message----- > From: Marcello Sylvester Bauer > Sent: Tuesday, June 23, 2020 8:03 AM > To: devel@edk2.groups.io > Cc: Ma, Maurice ; Dong, Guo > ; You, Benjamin > Subject: [UefiPayloadPkg: Make TerminalDxe build time configurable 1/1] > UefiPayloadPkg: Make TerminalDxe build time configurable >=20 > From: Patrick Rudolph >=20 > As the TerminalDxe significantly slows down the boot menu rendering. > Disable it by default and add the option SERIAL_TERMINAL to enabled > it for headless platforms. >=20 > Signed-off-by: Patrick Rudolph > Signed-off-by: Marcello Sylvester Bauer > Cc: Maurice Ma > Cc: Guo Dong > Cc: Benjamin You > --- > UefiPayloadPkg/UefiPayloadPkgIa32.dsc | 5 +++++ > UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc | 5 +++++ > UefiPayloadPkg/UefiPayloadPkg.fdf | 2 ++ > 3 files changed, 12 insertions(+) >=20 > diff --git a/UefiPayloadPkg/UefiPayloadPkgIa32.dsc > b/UefiPayloadPkg/UefiPayloadPkgIa32.dsc > index c6c47833871b..2ea475a4cee4 100644 > --- a/UefiPayloadPkg/UefiPayloadPkgIa32.dsc > +++ b/UefiPayloadPkg/UefiPayloadPkgIa32.dsc > @@ -58,6 +58,9 @@ [Defines] > DEFINE UART_DEFAULT_STOP_BITS =3D 1 >=20 > DEFINE DEFAULT_TERMINAL_TYPE =3D 0 >=20 >=20 >=20 > + # Enabling the serial terminal will slow down the boot menu rendering! >=20 > + DEFINE SERIAL_TERMINAL =3D FALSE >=20 > + >=20 > # >=20 > # typedef struct { >=20 > # UINT16 VendorId; ///< Vendor ID to match the PCI device= . The > value 0xFFFF terminates the list of entries. >=20 > @@ -502,7 +505,9 @@ [Components.IA32] > MdeModulePkg/Universal/Console/ConPlatformDxe/ConPlatformDxe.inf >=20 > MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitterDxe.inf >=20 >=20 > MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsoleD > xe.inf >=20 > +!if $(SERIAL_TERMINAL) =3D=3D TRUE >=20 > MdeModulePkg/Universal/Console/TerminalDxe/TerminalDxe.inf >=20 > +!endif >=20 > UefiPayloadPkg/GraphicsOutputDxe/GraphicsOutputDxe.inf >=20 >=20 >=20 > #------------------------------ >=20 > diff --git a/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc > b/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc > index 5559b1258521..62539ad56031 100644 > --- a/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc > +++ b/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc > @@ -59,6 +59,9 @@ [Defines] > DEFINE UART_DEFAULT_STOP_BITS =3D 1 >=20 > DEFINE DEFAULT_TERMINAL_TYPE =3D 0 >=20 >=20 >=20 > + # Enabling the serial terminal will slow down the boot menu redering! >=20 > + DEFINE SERIAL_TERMINAL =3D FALSE >=20 > + >=20 > # >=20 > # typedef struct { >=20 > # UINT16 VendorId; ///< Vendor ID to match the PCI device= . The > value 0xFFFF terminates the list of entries. >=20 > @@ -504,7 +507,9 @@ [Components.X64] > MdeModulePkg/Universal/Console/ConPlatformDxe/ConPlatformDxe.inf >=20 > MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitterDxe.inf >=20 >=20 > MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsoleD > xe.inf >=20 > +!if $(SERIAL_TERMINAL) =3D=3D TRUE >=20 > MdeModulePkg/Universal/Console/TerminalDxe/TerminalDxe.inf >=20 > +!endif >=20 > UefiPayloadPkg/GraphicsOutputDxe/GraphicsOutputDxe.inf >=20 >=20 >=20 > #------------------------------ >=20 > diff --git a/UefiPayloadPkg/UefiPayloadPkg.fdf > b/UefiPayloadPkg/UefiPayloadPkg.fdf > index dfbcde566849..bda831d77c9b 100644 > --- a/UefiPayloadPkg/UefiPayloadPkg.fdf > +++ b/UefiPayloadPkg/UefiPayloadPkg.fdf > @@ -131,7 +131,9 @@ [FV.DXEFV] > INF > MdeModulePkg/Universal/Console/ConPlatformDxe/ConPlatformDxe.inf >=20 > INF MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitterDxe.inf >=20 > INF > MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsoleD > xe.inf >=20 > +!if $(SERIAL_TERMINAL) =3D=3D TRUE >=20 > INF MdeModulePkg/Universal/Console/TerminalDxe/TerminalDxe.inf >=20 > +!endif >=20 > INF UefiPayloadPkg/GraphicsOutputDxe/GraphicsOutputDxe.inf >=20 >=20 >=20 > # >=20 > -- > 2.25.4