From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web11.10364.1591922506217871718 for ; Thu, 11 Jun 2020 17:41:46 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=uQqfCJ0E; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: guo.dong@intel.com) IronPort-SDR: Ejgw9Z0PeOgwCpaWQmIw3OxGilBQSXtc8BOvaP/zeF374kHY3uhvNpSkyQMBKJ+/EIblgXwRex ctkoWRYARwIA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jun 2020 17:41:41 -0700 IronPort-SDR: M4yRAbXgcWQFLg68XK9J4n1A4FU8U3T3l2mtNUO5iC5ueg1GbRI1HxAxjIRTcSfJV94kc1tqwY ZgyeOBLP3bFA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,501,1583222400"; d="scan'208";a="473886116" Received: from orsmsx103.amr.corp.intel.com ([10.22.225.130]) by fmsmga006.fm.intel.com with ESMTP; 11 Jun 2020 17:41:40 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX103.amr.corp.intel.com (10.22.225.130) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 11 Jun 2020 17:41:40 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 11 Jun 2020 17:41:40 -0700 Received: from ORSEDG001.ED.cps.intel.com (10.7.248.4) by orsmsx608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Thu, 11 Jun 2020 17:41:40 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.171) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 11 Jun 2020 17:41:38 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fHQ6e3pA2gSeYKmlGnPWg/xFvSCVe9kKkG9YSrRNDKuwDmfvXFW61lJHG1x38NMEEywsCzStJMNW6FkVhy3oJysumd4E1pi+AnHu+T7FcogOdHGzHFovOtMPre1KAsYyVD0ue9mxWTwTnuHe2eX1x6sJheHdKegL6upDQ1BlaPJBNW5N1+cKNV9y/tUu2Pp3rqE4Xsn5uKBnw89x4uN36bS73a9J4Ed5PPYvJxEJFGnjW6Qn75ev1AO7Gx7W2FdQ9EGgyPgFbJzkWqG/+I+EGI1puEkFHuOKfn9NB5jnDjZZWX+VQqgg6dMw/2C2l9/Wre+Pz1HiRdqvA+MbQQPfeQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vaj6RdqAT9UeyPIaO8tOupwsjZSORb06qu92/bA1KRg=; b=ZscXGIeoaHv7NtK/yn+ertGe40AbDDWsQQnHbMPIzbc5htqcWBOf6FwNQkIEwqHkQ6Uv35fivFDKQnmctfH6VT4oiUwZtCnZNig6g93Y+105Ig8t03mUMwkobhWm/owztaD1uJPewZlTUr/pfbER3FLkjazKjW+pyF9x9eDLPgaViFNdQt7mOBKOUSLBXl2Yf9YmSDQQQk8GETcd5xVgVvhoxwNdA9PLp3dtfaeLvHgOSeuhUzwaMJ1oscPdCbk2N0iYOsM2VUJxUCQBht4RdUmp0qM592oXa5s6dndG8GibVuex7yD5JFGdJuOahYkrWla2AgEGAX0U/E46N5DGMQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vaj6RdqAT9UeyPIaO8tOupwsjZSORb06qu92/bA1KRg=; b=uQqfCJ0EgPc3b12ltAdkqwEpsP0drF9bbN4pb2HCfcsny500tVX3oMpQWoSv7PZOAN9b3f8JreYsGJxjZqonZ91ES3RDDf3rSxJhC/ZgTagMHj45SJemjnM7AalaE9dyFB1O14oLsx6Il1RjTgGJsoP3I6Oz3y4n4/eK4iBdhrQ= Received: from BYAPR11MB3653.namprd11.prod.outlook.com (2603:10b6:a03:f7::14) by BYAPR11MB3269.namprd11.prod.outlook.com (2603:10b6:a03:75::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3066.22; Fri, 12 Jun 2020 00:41:36 +0000 Received: from BYAPR11MB3653.namprd11.prod.outlook.com ([fe80::d1b:deae:aabb:ef77]) by BYAPR11MB3653.namprd11.prod.outlook.com ([fe80::d1b:deae:aabb:ef77%5]) with mapi id 15.20.3066.023; Fri, 12 Jun 2020 00:41:36 +0000 From: "Guo Dong" To: "Tan, Ming" , "devel@edk2.groups.io" CC: "Ma, Maurice" , "You, Benjamin" Subject: Re: [PATCH v4 3/4] UefiPayloadPkg/UefiPayloadPkgIa*.dsc: Change some PCDs type Thread-Topic: [PATCH v4 3/4] UefiPayloadPkg/UefiPayloadPkgIa*.dsc: Change some PCDs type Thread-Index: AQHWPtLc6TKV9G4yD0iYIYxRdtLaVajUJptg Date: Fri, 12 Jun 2020 00:41:36 +0000 Message-ID: References: <20200610025634.21833-1-ming.tan@intel.com> <20200610025634.21833-3-ming.tan@intel.com> In-Reply-To: <20200610025634.21833-3-ming.tan@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [68.2.51.172] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 08f3a520-ec94-4a82-c57b-08d80e695cfd x-ms-traffictypediagnostic: BYAPR11MB3269: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3513; x-forefront-prvs: 0432A04947 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: w/Us9s6kYNnbQ1V65Jfg2cssoHx8sId8yp6hWD6kNUo/u+94NOy9wDHul/J/cElmyUziG8WJrfArdJ4px8OKbBwONo7YjR/g7plEgtMNaBPjZBU2fGwmoL19LCZSeXMmvb9zL+X9KjSDilgKbzUdx7iN3POBkh7yn6PA8C1a4cywslbOxPWdCS6zNt9i0YSs6wILiUyP527GA0Y3iCSXYFMAkm8LAtB0Vs21vxvtHOb2pwnkLcsmTo/+HQ3Z7f10VIuIyNtB4PoVaeCYo44uQNnlti149FtzlM45TivmVQvGRKctChC+d9Toe63WXQAH18Zwef5681i09rdbPUYos2MfqorqIzvfOS1onxyj0/RZDbFyjyp9m9jfXfRgjHqwEGqXU3tnFQdFNB41taD3IQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR11MB3653.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(136003)(39860400002)(396003)(346002)(376002)(366004)(9686003)(107886003)(19627235002)(66476007)(6506007)(64756008)(8676002)(66946007)(26005)(52536014)(66446008)(71200400001)(186003)(55016002)(478600001)(66556008)(110136005)(86362001)(76116006)(5660300002)(53546011)(2906002)(7696005)(54906003)(316002)(4326008)(33656002)(8936002)(966005)(83380400001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: nobvX5s65DLbOKJPkSVh0UOOabBEzWnQR21HhRijaBFRUPvzC8YUZicFdd8QqM+NilcWGJg0F+rvHhCJ/8IoROr7k/RVeoN3DFfyOj17zay1npKOu2wJgrEvI1ezoXVmZjRCiETngQ0I5h4sKHXesBuGgKUFddQlIPfMf09kOwUF0veaVw1je17ahKqvHPd7wxVQIlhY55XFboNkdyPV2c7rc+grXM/wC9TH2kxa0WzqQ8ZBXXGUDz+3XbS9I/3A1rfgMWkqe7WzgxeW4RZMqXdsT5xu9G8zH0FHXF1L/PqVrDU5NdI4dO8Y7e2UGPVZcVB9NbKvtUpSBJcC5lDnm/PZ9ssvsG5M7BcFBflgqS3+wwX9CSIu77Oc53WXZ/cVEmvLd/BUbnZ+rXbwHrmd0MgpaWu/DLnUjgxqxkUtLUcUOwE0E1EerX0LZYHY9DAJ7GvnzrkacFf955A1+4kJbNps5EZztI7ts1eYvc2WZ8I= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 08f3a520-ec94-4a82-c57b-08d80e695cfd X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Jun 2020 00:41:36.6425 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Vt4F8jXOu1/7TtEzfAfDZGHm1UvuIWQw+hfP4SXKlmPoLakroU6vNzAVjXE0/0/5gkPsxBDyALlGiQ8JtxiEfw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3269 Return-Path: guo.dong@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Dong, Guo Thanks, Guo > -----Original Message----- > From: Tan, Ming > Sent: Tuesday, June 9, 2020 7:57 PM > To: devel@edk2.groups.io > Cc: Ma, Maurice ; Dong, Guo > ; You, Benjamin > Subject: [PATCH v4 3/4] UefiPayloadPkg/UefiPayloadPkgIa*.dsc: Change > some PCDs type >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2786 >=20 > Since the type of PcdStatusCodeUseSerial and PcdStatusCodeUseMemory > in MdeModulePkg.dec are changed, so change them from > PcdsFeatureFlag to PcdsFixedAtBuild in dsc files. >=20 > Cc: Maurice Ma > Cc: Guo Dong > Cc: Benjamin You > Signed-off-by: Ming Tan > --- > V4: Adjust the location of PCDs, put them after PcdVpdBaseAddress, > and make PCDs together with same TokenSpaceGuid > instead of put them in the last of section. > V3: Split one patch to several patchs, each Pkg has one patch. > UefiPayloadPkg/UefiPayloadPkgIa32.dsc | 14 +++++++------- > UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc | 14 +++++++------- > 2 files changed, 14 insertions(+), 14 deletions(-) >=20 > diff --git a/UefiPayloadPkg/UefiPayloadPkgIa32.dsc > b/UefiPayloadPkg/UefiPayloadPkgIa32.dsc > index d52945442e0e..c6c47833871b 100644 > --- a/UefiPayloadPkg/UefiPayloadPkgIa32.dsc > +++ b/UefiPayloadPkg/UefiPayloadPkgIa32.dsc > @@ -3,7 +3,7 @@ > # > # Provides drivers and definitions to create uefi payload for bootloader= s. > # > -# Copyright (c) 2014 - 2019, Intel Corporation. All rights reserved.
> +# Copyright (c) 2014 - 2020, Intel Corporation. All rights reserved.
> # SPDX-License-Identifier: BSD-2-Clause-Patent > # > ## > @@ -264,12 +264,6 @@ > [LibraryClasses.common.UEFI_DRIVER,LibraryClasses.common.UEFI_APPLIC > ATION] > # >=20 > ########################################################## > ###################### > [PcdsFeatureFlag] > -!if $(TARGET) =3D=3D DEBUG > - gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|TRUE > -!else > - gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|FALSE > -!endif > - gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseMemory|FALSE > gEfiMdeModulePkgTokenSpaceGuid.PcdDxeIplSwitchToLongMode|FALSE > gEfiMdeModulePkgTokenSpaceGuid.PcdConOutGopSupport|TRUE > gEfiMdeModulePkgTokenSpaceGuid.PcdConOutUgaSupport|FALSE > @@ -284,6 +278,12 @@ [PcdsFixedAtBuild] > gEfiMdeModulePkgTokenSpaceGuid.PcdEmuVariableNvModeEnable|TRUE >=20 > gEfiMdeModulePkgTokenSpaceGuid.PcdVpdBaseAddress|0x0 > +!if $(TARGET) =3D=3D DEBUG > + gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|TRUE > +!else > + gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|FALSE > +!endif > + gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseMemory|FALSE > gEfiMdeModulePkgTokenSpaceGuid.PcdBootManagerMenuFile|{ 0x21, > 0xaa, 0x2c, 0x46, 0x14, 0x76, 0x03, 0x45, 0x83, 0x6e, 0x8a, 0xb6, 0xf4, 0= x66, > 0x23, 0x31 } >=20 > gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress|$(PCIE_BASE) > diff --git a/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc > b/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc > index 0736cd995476..5559b1258521 100644 > --- a/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc > +++ b/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc > @@ -3,7 +3,7 @@ > # > # Provides drivers and definitions to create uefi payload for bootloader= s. > # > -# Copyright (c) 2014 - 2019, Intel Corporation. All rights reserved.
> +# Copyright (c) 2014 - 2020, Intel Corporation. All rights reserved.
> # SPDX-License-Identifier: BSD-2-Clause-Patent > # > ## > @@ -265,12 +265,6 @@ > [LibraryClasses.common.UEFI_DRIVER,LibraryClasses.common.UEFI_APPLIC > ATION] > # >=20 > ########################################################## > ###################### > [PcdsFeatureFlag] > -!if $(TARGET) =3D=3D DEBUG > - gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|TRUE > -!else > - gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|FALSE > -!endif > - gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseMemory|FALSE > gEfiMdeModulePkgTokenSpaceGuid.PcdDxeIplSwitchToLongMode|TRUE > gEfiMdeModulePkgTokenSpaceGuid.PcdConOutGopSupport|TRUE > gEfiMdeModulePkgTokenSpaceGuid.PcdConOutUgaSupport|FALSE > @@ -285,6 +279,12 @@ [PcdsFixedAtBuild] > gEfiMdeModulePkgTokenSpaceGuid.PcdEmuVariableNvModeEnable|TRUE >=20 > gEfiMdeModulePkgTokenSpaceGuid.PcdVpdBaseAddress|0x0 > +!if $(TARGET) =3D=3D DEBUG > + gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|TRUE > +!else > + gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|FALSE > +!endif > + gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseMemory|FALSE > gEfiMdeModulePkgTokenSpaceGuid.PcdUse1GPageTable|TRUE > gEfiMdeModulePkgTokenSpaceGuid.PcdBootManagerMenuFile|{ 0x21, > 0xaa, 0x2c, 0x46, 0x14, 0x76, 0x03, 0x45, 0x83, 0x6e, 0x8a, 0xb6, 0xf4, 0= x66, > 0x23, 0x31 } >=20 > -- > 2.24.0.windows.2