Re: [PATCH v3 3/4] UefiPayloadPkg/UefiPayloadPkgIa*.dsc: Change some PCDs type

["Guo Dong" <guo.dong@intel.com>]

Reviewed-by: Dong, Guo <guo.dong@intel.com>

Thanks,
Guo

> -----Original Message-----
> From: Tan, Ming <ming.tan@intel.com>
> Sent: Tuesday, June 9, 2020 4:24 AM
> To: devel@edk2.groups.io
> Cc: Ma, Maurice <maurice.ma@intel.com>; Dong, Guo
> <guo.dong@intel.com>; You, Benjamin <benjamin.you@intel.com>
> Subject: [PATCH v3 3/4] UefiPayloadPkg/UefiPayloadPkgIa*.dsc: Change
> some PCDs type
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2786
> 
> Since the type of PcdStatusCodeUseSerial and PcdStatusCodeUseMemory
> in MdeModulePkg.dec are changed, so change them from
> PcdsFeatureFlag to PcdsFixedAtBuild in dsc files.
> 
> Cc: Maurice Ma <maurice.ma@intel.com>
> Cc: Guo Dong <guo.dong@intel.com>
> Cc: Benjamin You <benjamin.you@intel.com>
> Signed-off-by: Ming Tan <ming.tan@intel.com>
> ---
> V3: Split one patch to several patchs, each Pkg has one patch.
> 
>  UefiPayloadPkg/UefiPayloadPkgIa32.dsc    | 16 +++++++++-------
>  UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc | 16 +++++++++-------
>  2 files changed, 18 insertions(+), 14 deletions(-)
> 
> diff --git a/UefiPayloadPkg/UefiPayloadPkgIa32.dsc
> b/UefiPayloadPkg/UefiPayloadPkgIa32.dsc
> index d52945442e..b0708cf01f 100644
> --- a/UefiPayloadPkg/UefiPayloadPkgIa32.dsc
> +++ b/UefiPayloadPkg/UefiPayloadPkgIa32.dsc
> @@ -3,7 +3,7 @@
>  #
> 
>  # Provides drivers and definitions to create uefi payload for bootloaders.
> 
>  #
> 
> -# Copyright (c) 2014 - 2019, Intel Corporation. All rights reserved.<BR>
> 
> +# Copyright (c) 2014 - 2020, Intel Corporation. All rights reserved.<BR>
> 
>  # SPDX-License-Identifier: BSD-2-Clause-Patent
> 
>  #
> 
>  ##
> 
> @@ -264,12 +264,6 @@
>  #
> 
> 
> ##########################################################
> ######################
> 
>  [PcdsFeatureFlag]
> 
> -!if $(TARGET) == DEBUG
> 
> -  gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|TRUE
> 
> -!else
> 
> -  gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|FALSE
> 
> -!endif
> 
> -  gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseMemory|FALSE
> 
>    gEfiMdeModulePkgTokenSpaceGuid.PcdDxeIplSwitchToLongMode|FALSE
> 
>    gEfiMdeModulePkgTokenSpaceGuid.PcdConOutGopSupport|TRUE
> 
>    gEfiMdeModulePkgTokenSpaceGuid.PcdConOutUgaSupport|FALSE
> 
> @@ -292,6 +286,14 @@
> 
> gEfiSourceLevelDebugPkgTokenSpaceGuid.PcdDebugLoadImageMethod|0x
> 2
> 
>  !endif
> 
> 
> 
> +  # Status Code support.
> 
> +!if $(TARGET) == DEBUG
> 
> +  gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|TRUE
> 
> +!else
> 
> +  gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|FALSE
> 
> +!endif
> 
> +  gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseMemory|FALSE
> 
> +
> 
>  [PcdsPatchableInModule.common]
> 
>    gEfiMdePkgTokenSpaceGuid.PcdReportStatusCodePropertyMask|0x7
> 
>    gEfiMdePkgTokenSpaceGuid.PcdDebugPrintErrorLevel|0x8000004F
> 
> diff --git a/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc
> b/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc
> index 0736cd9954..3ca0f2fd93 100644
> --- a/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc
> +++ b/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc
> @@ -3,7 +3,7 @@
>  #
> 
>  # Provides drivers and definitions to create uefi payload for bootloaders.
> 
>  #
> 
> -# Copyright (c) 2014 - 2019, Intel Corporation. All rights reserved.<BR>
> 
> +# Copyright (c) 2014 - 2020, Intel Corporation. All rights reserved.<BR>
> 
>  # SPDX-License-Identifier: BSD-2-Clause-Patent
> 
>  #
> 
>  ##
> 
> @@ -265,12 +265,6 @@
>  #
> 
> 
> ##########################################################
> ######################
> 
>  [PcdsFeatureFlag]
> 
> -!if $(TARGET) == DEBUG
> 
> -  gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|TRUE
> 
> -!else
> 
> -  gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|FALSE
> 
> -!endif
> 
> -  gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseMemory|FALSE
> 
>    gEfiMdeModulePkgTokenSpaceGuid.PcdDxeIplSwitchToLongMode|TRUE
> 
>    gEfiMdeModulePkgTokenSpaceGuid.PcdConOutGopSupport|TRUE
> 
>    gEfiMdeModulePkgTokenSpaceGuid.PcdConOutUgaSupport|FALSE
> 
> @@ -294,6 +288,14 @@
> 
> gEfiSourceLevelDebugPkgTokenSpaceGuid.PcdDebugLoadImageMethod|0x
> 2
> 
>  !endif
> 
> 
> 
> +  # Status Code support.
> 
> +!if $(TARGET) == DEBUG
> 
> +  gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|TRUE
> 
> +!else
> 
> +  gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|FALSE
> 
> +!endif
> 
> +  gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseMemory|FALSE
> 
> +
> 
>  [PcdsPatchableInModule.common]
> 
>    gEfiMdePkgTokenSpaceGuid.PcdReportStatusCodePropertyMask|0x7
> 
>    gEfiMdePkgTokenSpaceGuid.PcdDebugPrintErrorLevel|0x8000004F
> 
> --
> 2.24.0.windows.2