From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mx.groups.io with SMTP id smtpd.web10.112.1591728890239048680 for ; Tue, 09 Jun 2020 11:54:50 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=pT3eckZG; spf=pass (domain: intel.com, ip: 192.55.52.88, mailfrom: guo.dong@intel.com) IronPort-SDR: 6kVrQV4jlzy+3OeCPr6pWJBTacNinM/iSzj9Ib97CeY0XVDmGqoaz3RcTpXCVt2za8YxDYyzQB ax0Aywr2dw3Q== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jun 2020 11:54:49 -0700 IronPort-SDR: iOrdFCvomG6aH+3zw+B+iKdLJ31tllpatKa7kT6/yAE+clJsg8pQ1Se8t2EzQ+1QrGqgPxDJYn gu9o+8lkUDMQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,493,1583222400"; d="scan'208";a="295929193" Received: from orsmsx104.amr.corp.intel.com ([10.22.225.131]) by fmsmga004.fm.intel.com with ESMTP; 09 Jun 2020 11:54:49 -0700 Received: from orsmsx111.amr.corp.intel.com (10.22.240.12) by ORSMSX104.amr.corp.intel.com (10.22.225.131) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 9 Jun 2020 11:54:43 -0700 Received: from ORSEDG002.ED.cps.intel.com (10.7.248.5) by ORSMSX111.amr.corp.intel.com (10.22.240.12) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 9 Jun 2020 11:54:43 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.107) by edgegateway.intel.com (134.134.137.101) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 9 Jun 2020 11:54:40 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FJXGKB0s6LZz9X5Qvn1z7s9v91A8nSbUFR98gUXMGFkDkhZQ/8pHJz1E7tDpla0ROkdtSuI2aBNCR/s/wW3Tl3JdNP8K8elaK31VZD+wKIJjfWg0izNuywmRnA4XgLNlNE1OnKNE+Zt68sg4E0+EMs/l6KMT7BApij5G2aCthMInEgo+s8KeKGn6ZG3ZZ/WKmLfgEXUow9hlMimXU1urzuKp2DSRZQda0elspqphrNAbJYyz8b8/4qcIg8F2IEo6VlyjdUq3HkollLrXvTIcnDlOmz7Tl5UILV7q5optuA9cEBgc5A/oX85eK4gKQUntWcamvBNG07P6zJ/WMAms5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yAM45qUcdU0c6AnTBzBHMpnsjHmM5cHDZmBt1t/LPRM=; b=FKEzEkuRtAbgdWMuoE4bs6qcLmOMw3uQYtLVqwNJYl2xoAUtrOOKr7+7EnVx6VZPchu3/aRr+UNr2ArTUbTWNYZy4NGFv65rNjYiT/Gm/NhPlp0X7YA/PxSAqcAnkUQTjGMAq9seAqZE+QZAN6uU0feJvvMb+OOx3DDk6+vPDpP+UVi4eZLHHvsj0/483A9VA4MX/Bl7ZANo1RtPQlYJ2icXnv0H6/fnseW6Z1xXlD3gaSI9H8lfiB0kMywEAx6MUZVkUuhxkbcq5IfxKrwuyD2AnNmXbErXTiS+zQGxvW8ZR2r8rn13zfDKa+XiwNGe9OSgZXWvKMb5djn9JcC/iw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yAM45qUcdU0c6AnTBzBHMpnsjHmM5cHDZmBt1t/LPRM=; b=pT3eckZGYwACjtwA/uXyP1KV91rJ41g+TvQBqfEvgQArr8Ix/3ly7QF85vwNVrehAUKYYNDZZa1MaMBp8Qn9TDV8huanalCKAOvmnzizv1TDFCPrvB9svaUH/eWl9RQIhS9mulvg+Q99I/i6XawIvTBJeRlnKlYnwWwpOpQiELQ= Received: from BYAPR11MB3653.namprd11.prod.outlook.com (2603:10b6:a03:f7::14) by BYAPR11MB3525.namprd11.prod.outlook.com (2603:10b6:a03:8e::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3066.18; Tue, 9 Jun 2020 18:54:39 +0000 Received: from BYAPR11MB3653.namprd11.prod.outlook.com ([fe80::d1b:deae:aabb:ef77]) by BYAPR11MB3653.namprd11.prod.outlook.com ([fe80::d1b:deae:aabb:ef77%5]) with mapi id 15.20.3066.023; Tue, 9 Jun 2020 18:54:39 +0000 From: "Guo Dong" To: "Tan, Ming" , "devel@edk2.groups.io" CC: "Ma, Maurice" , "You, Benjamin" Subject: Re: [PATCH v3 3/4] UefiPayloadPkg/UefiPayloadPkgIa*.dsc: Change some PCDs type Thread-Topic: [PATCH v3 3/4] UefiPayloadPkg/UefiPayloadPkgIa*.dsc: Change some PCDs type Thread-Index: AQHWPlCNTD8lSgKyuESQ+23Gti1uFqjQocOg Date: Tue, 9 Jun 2020 18:54:39 +0000 Message-ID: References: <20200609112353.20824-1-ming.tan@intel.com> <20200609112353.20824-3-ming.tan@intel.com> In-Reply-To: <20200609112353.20824-3-ming.tan@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [68.2.51.172] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 02f86a1c-67cb-418e-eb45-08d80ca69010 x-ms-traffictypediagnostic: BYAPR11MB3525: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:446; x-forefront-prvs: 042957ACD7 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Y/B8AQG9p6uIqf3mttlFQ3n1nsc/TyRFWxP7o7BA/V1IdDUPupUUaC9zjWhg9lHElvUD1SWqQUKWQKSMgdEJ1NIYHNV9Fk39HJsX5V704qJCy3j7eS3HzSk1+RE+u59LNN/wt3XfRM5RDlNtujOD/jZ//D60XwSksMCzx9oFP5FadS+YNmbS5i7kvebFVsQ0o9I+35iIIf2uRz4EFQfXUtnqYV8Bxo9G9EFHLZ3dhDIYpeZw7ZM1wIjXu/7SSNK7ahCY2jtLdJxmsPymMLzdHh3tfUlWBQuef9Ftbz9bjJ0z2ttgv+Ivi76FMziFQulgGYlQlGwkfwWLCCCUOdCdSH+tBC7PDc6GmaUn4AfLJzlDGQrHG/Xm9Z23fj/1/YqaBvYtMO9KLEC1MDm3qR8F8g== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR11MB3653.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(366004)(39860400002)(136003)(346002)(396003)(376002)(64756008)(5660300002)(9686003)(53546011)(8936002)(8676002)(86362001)(66446008)(66476007)(186003)(6506007)(55016002)(66556008)(66946007)(76116006)(26005)(54906003)(2906002)(83380400001)(966005)(110136005)(316002)(478600001)(4326008)(52536014)(71200400001)(19627235002)(107886003)(33656002)(7696005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: uI6qJkjGr0Esqb7JceBU4tH2pz0U7KIGhKZO6U5dPv5K7UF/BEoq+YqW1/xP6thFMUom8yYCXcXWJJ56dQ2QnmFkEicR6uMeVX/lPXMZ25nqvlbCxo46SBPyjh97tnCcjqbQCwP/44tV/Uh0ejIu79l7R+Uo/xJKL0ps7S38KAYCg7XQGtEUzHN8yzK71dtxjheNi7yxna6/ANYoSu+FCu+9mX/MrykckCqQwzV7ac1JU9vHao51X4VsciW4DZrCaoe9aHWBAGCOH0UDkER3stQ3OsAlWv+pjegcHx/a4AOP45FLrb0IS+93wJ9/JS+6CgrZScdGjH6v39lEVs5E7Mva5Nu0Fk0hYH0aeYYT4Z/8uR5kHMmMbHW4RA7dKh9268eohDUjZxAvJCBzdFuATxYeSmy2TutN7qCO/9vCLPjwjnMCzGDlA2wnEajW1qkhWD765+AQfYFGuZr1FWJhb+LqYZZH+tvYyio6wAQi29E= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 02f86a1c-67cb-418e-eb45-08d80ca69010 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Jun 2020 18:54:39.2668 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: cNQ8T3KyvuIIuJIAvn6Xw5kRQZLzXCKXJwHJciTdv8/lez3o+37AZ+ugnDZRLFx1+C7KJGj+GivDIIAllYXB5Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3525 Return-Path: guo.dong@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Dong, Guo Thanks, Guo > -----Original Message----- > From: Tan, Ming > Sent: Tuesday, June 9, 2020 4:24 AM > To: devel@edk2.groups.io > Cc: Ma, Maurice ; Dong, Guo > ; You, Benjamin > Subject: [PATCH v3 3/4] UefiPayloadPkg/UefiPayloadPkgIa*.dsc: Change > some PCDs type >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2786 >=20 > Since the type of PcdStatusCodeUseSerial and PcdStatusCodeUseMemory > in MdeModulePkg.dec are changed, so change them from > PcdsFeatureFlag to PcdsFixedAtBuild in dsc files. >=20 > Cc: Maurice Ma > Cc: Guo Dong > Cc: Benjamin You > Signed-off-by: Ming Tan > --- > V3: Split one patch to several patchs, each Pkg has one patch. >=20 > UefiPayloadPkg/UefiPayloadPkgIa32.dsc | 16 +++++++++------- > UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc | 16 +++++++++------- > 2 files changed, 18 insertions(+), 14 deletions(-) >=20 > diff --git a/UefiPayloadPkg/UefiPayloadPkgIa32.dsc > b/UefiPayloadPkg/UefiPayloadPkgIa32.dsc > index d52945442e..b0708cf01f 100644 > --- a/UefiPayloadPkg/UefiPayloadPkgIa32.dsc > +++ b/UefiPayloadPkg/UefiPayloadPkgIa32.dsc > @@ -3,7 +3,7 @@ > # >=20 > # Provides drivers and definitions to create uefi payload for bootloader= s. >=20 > # >=20 > -# Copyright (c) 2014 - 2019, Intel Corporation. All rights reserved.
>=20 > +# Copyright (c) 2014 - 2020, Intel Corporation. All rights reserved.
>=20 > # SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > # >=20 > ## >=20 > @@ -264,12 +264,6 @@ > # >=20 >=20 > ########################################################## > ###################### >=20 > [PcdsFeatureFlag] >=20 > -!if $(TARGET) =3D=3D DEBUG >=20 > - gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|TRUE >=20 > -!else >=20 > - gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|FALSE >=20 > -!endif >=20 > - gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseMemory|FALSE >=20 > gEfiMdeModulePkgTokenSpaceGuid.PcdDxeIplSwitchToLongMode|FALSE >=20 > gEfiMdeModulePkgTokenSpaceGuid.PcdConOutGopSupport|TRUE >=20 > gEfiMdeModulePkgTokenSpaceGuid.PcdConOutUgaSupport|FALSE >=20 > @@ -292,6 +286,14 @@ >=20 > gEfiSourceLevelDebugPkgTokenSpaceGuid.PcdDebugLoadImageMethod|0x > 2 >=20 > !endif >=20 >=20 >=20 > + # Status Code support. >=20 > +!if $(TARGET) =3D=3D DEBUG >=20 > + gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|TRUE >=20 > +!else >=20 > + gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|FALSE >=20 > +!endif >=20 > + gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseMemory|FALSE >=20 > + >=20 > [PcdsPatchableInModule.common] >=20 > gEfiMdePkgTokenSpaceGuid.PcdReportStatusCodePropertyMask|0x7 >=20 > gEfiMdePkgTokenSpaceGuid.PcdDebugPrintErrorLevel|0x8000004F >=20 > diff --git a/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc > b/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc > index 0736cd9954..3ca0f2fd93 100644 > --- a/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc > +++ b/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc > @@ -3,7 +3,7 @@ > # >=20 > # Provides drivers and definitions to create uefi payload for bootloader= s. >=20 > # >=20 > -# Copyright (c) 2014 - 2019, Intel Corporation. All rights reserved.
>=20 > +# Copyright (c) 2014 - 2020, Intel Corporation. All rights reserved.
>=20 > # SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > # >=20 > ## >=20 > @@ -265,12 +265,6 @@ > # >=20 >=20 > ########################################################## > ###################### >=20 > [PcdsFeatureFlag] >=20 > -!if $(TARGET) =3D=3D DEBUG >=20 > - gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|TRUE >=20 > -!else >=20 > - gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|FALSE >=20 > -!endif >=20 > - gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseMemory|FALSE >=20 > gEfiMdeModulePkgTokenSpaceGuid.PcdDxeIplSwitchToLongMode|TRUE >=20 > gEfiMdeModulePkgTokenSpaceGuid.PcdConOutGopSupport|TRUE >=20 > gEfiMdeModulePkgTokenSpaceGuid.PcdConOutUgaSupport|FALSE >=20 > @@ -294,6 +288,14 @@ >=20 > gEfiSourceLevelDebugPkgTokenSpaceGuid.PcdDebugLoadImageMethod|0x > 2 >=20 > !endif >=20 >=20 >=20 > + # Status Code support. >=20 > +!if $(TARGET) =3D=3D DEBUG >=20 > + gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|TRUE >=20 > +!else >=20 > + gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|FALSE >=20 > +!endif >=20 > + gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseMemory|FALSE >=20 > + >=20 > [PcdsPatchableInModule.common] >=20 > gEfiMdePkgTokenSpaceGuid.PcdReportStatusCodePropertyMask|0x7 >=20 > gEfiMdePkgTokenSpaceGuid.PcdDebugPrintErrorLevel|0x8000004F >=20 > -- > 2.24.0.windows.2