From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web11.14860.1593009150135732454 for ; Wed, 24 Jun 2020 07:32:30 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=OYUVtlr6; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: guo.dong@intel.com) IronPort-SDR: amZd5YowXoFHssl4R+vWufxVhBFEeE7TRrZd5oXVlQ6rtn6cOBH6xelaWJU704IuQljyyBRbrF esTUvhstzMwQ== X-IronPort-AV: E=McAfee;i="6000,8403,9662"; a="229165843" X-IronPort-AV: E=Sophos;i="5.75,275,1589266800"; d="scan'208";a="229165843" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Jun 2020 07:32:29 -0700 IronPort-SDR: tmt08sHFnrhz/nBnwtF4M8iCorWajarIzj5EcEPnU+hzK7I/w3Tff3WnrpkuGVtPw9AxnaDqI7 9xdLresYSTzw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,275,1589266800"; d="scan'208";a="265090180" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga008.fm.intel.com with ESMTP; 24 Jun 2020 07:32:29 -0700 Received: from fmsmsx162.amr.corp.intel.com (10.18.125.71) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 24 Jun 2020 07:32:29 -0700 Received: from FMSEDG001.ED.cps.intel.com (10.1.192.133) by fmsmsx162.amr.corp.intel.com (10.18.125.71) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 24 Jun 2020 07:32:29 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.175) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 24 Jun 2020 07:32:29 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oax3NBcmHX7MLbrz4Jij2Cggk9OGoDhqaiS1S0XEemADZrovahyGsT18lFCu3GWTJ0rhG1rBA35OmD5/GkyTp+oH9S/vT4RT+zxDSw49mlRmaS/31fZ08e1KMMtdqcP+q7T+0B3INvwLPmNXCvuo4KxqRjH5hnsnm22lcerp+YgvGoxBHASr0ptbEZYB7SBBugojV7/cKz8jTHO4gvZMbE7JIn7P4HUzJq5GfWUbyqsJY7xRFl7mpzpaDntEUJeMN7ZQY4S/gTzTYVOjy/5hczy658u+3PPkCQxayE/NK2HOOPvcNq8OF3VSr/KxR2N2p09aa9ukiC7p+Kb2qnLJOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BFk4JxS+buMEO4iSdfSdYDKonB8wzUdr959aAYe91KI=; b=J7tcputa/5CjObXiW0D3sA8WnZgA4QJHBacELDZclOTSJMFr/ET4yTO8GRp99uc39USNDk+CIB0v2+Eh2fW2yCfI04JYKmx4unH530HmU4/HxtLx2e6bZTnUedWd4bHlyr/6HBvtAsFf0AQZMpHsUZ2F4ZhyXsS4bzVkhoNvIhGvz31OUuTXy8EEo1nzp4D7dOzu3Ff9iwTVaCxvzYUH6VbxxAOGMTLSEkTWewgUuwLFQ5IeszrHGiFBWvbRCqU/XJE0KVK0ixgtHoY24BfFuAtOs34Cehqj71nIMP+Jljaw2yaulwHnetevgIVXPa15oVX5RGF0oTHEDFlCmtZB3Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BFk4JxS+buMEO4iSdfSdYDKonB8wzUdr959aAYe91KI=; b=OYUVtlr6tvK7KNCflSzhrGv7uOkZTB8Ucg6cxHQdGSCMyYLUAlTcj4gyTL06bB7byrUb1SElTt9IRDUzmZl2HYmTE0oArifFxWIAclheaDcTC7tTJfuFSUz9WL88yvh50W+Cc+LdDie+i4ZU+s5HRC2G4OnGPhVvjRCiXvxGGEI= Received: from BYAPR11MB3653.namprd11.prod.outlook.com (2603:10b6:a03:f7::14) by BY5PR11MB4433.namprd11.prod.outlook.com (2603:10b6:a03:1cb::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3131.21; Wed, 24 Jun 2020 14:32:27 +0000 Received: from BYAPR11MB3653.namprd11.prod.outlook.com ([fe80::6c0c:f784:6060:76de]) by BYAPR11MB3653.namprd11.prod.outlook.com ([fe80::6c0c:f784:6060:76de%7]) with mapi id 15.20.3109.027; Wed, 24 Jun 2020 14:32:27 +0000 From: "Guo Dong" To: Marcello Sylvester Bauer , "devel@edk2.groups.io" CC: Patrick Rudolph , Christian Walter , "Ma, Maurice" , "You, Benjamin" Subject: Re: [PATCH v2 1/1] UefiPayloadPkg: Make TerminalDxe build time configurable Thread-Topic: [PATCH v2 1/1] UefiPayloadPkg: Make TerminalDxe build time configurable Thread-Index: AQHWSg4CffnaOH3FAEWoTyf3Cqqqkajn1Gkw Date: Wed, 24 Jun 2020 14:32:27 +0000 Message-ID: References: <20200624095755.27057-1-marcello.bauer@9elements.com> <20200624095755.27057-2-marcello.bauer@9elements.com> In-Reply-To: <20200624095755.27057-2-marcello.bauer@9elements.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: 9elements.com; dkim=none (message not signed) header.d=none;9elements.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [68.2.51.172] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e59b8585-6db0-4b03-bfa9-08d8184b6b6d x-ms-traffictypediagnostic: BY5PR11MB4433: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:489; x-forefront-prvs: 0444EB1997 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 1MVvfQk2ntbJPhLfz2IWmAkgf8dvw6vd4aXjkrRqrDeR1Te4me0bk81OjVl3DbP1V5h8R6fJ+211qQpUEC4uXnejgsnB7dbtNwnhFRdZ4jIYKFksGBAz08FdWDkXmmDz+XDqiZa37bfa7tmAylVbTnUKmC34C0gQGcwjA9Xjq1OMeARU17ZOt0Yws9ut0RnqArCCM6/ZIlCu88oErV//a08Ve8P+OVzYzpBu6Xns0jGmv/HPniFgEvu8V2jbhH7sPyay/45i3OLojP45Zuwn24FwStgqiU++Tc/z/sybwbBpMEeBEpa2BdlGiT5NjrTCPUxtvjS2HpODjO3CR2uyNA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR11MB3653.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(136003)(39860400002)(366004)(346002)(376002)(396003)(52536014)(55016002)(6506007)(316002)(8936002)(66476007)(76116006)(9686003)(83380400001)(53546011)(33656002)(66946007)(107886003)(4326008)(71200400001)(26005)(2906002)(186003)(19627235002)(66556008)(110136005)(86362001)(54906003)(66446008)(64756008)(5660300002)(7696005)(478600001)(8676002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: SQYvjXnNh0QJ5jKtgQ7woEMo9h8f774IdyQjt3pQXI74q3/y6q+4NVnyseNXup5Wg0pkAt1SnEUl1FMGV7GcFXccCGS+RByCLWYOj4dHDFmGww8+toqyk3mnZY6HQ3Z2hkOswqcwi94SLX7ZIgC9nD7mKTQZ7KtSd9X/O/mDdUKnA2XWa8MQo65FD9BchLpJyj0nEQT18CZDUVFEejioEu8d99t55HKs8MEFk/JzUySXaKe1i+FvMvcT4ImL4fgkGv7+4ZrM20OpeFKkYo9tUweGbYxQ9k0CHj2zEBs/BdIC5wkcjefLi6InB/rpEhtlozBRGp4isce1z8SFlN0ztxworH8I4mGjT+XxGj7vWT7SKvCvE6u0N81MOn1SWKjrQkQJ/7atwsNRHSCJ17CllwI5AenZCYXI4x3mtUHQvjHU1ifBw1SOt4QK+k/YcPuG1b+yJ4RcS4ggRg75gOOixY5m/tllmeiP9oP6wU+BaLA= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3653.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e59b8585-6db0-4b03-bfa9-08d8184b6b6d X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Jun 2020 14:32:27.5704 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: KT182x6WTyZG8yGCZMuaR+y2OEnwCQo8Lx+rPXAJe+Vo+ntEirCkBVP9WNBGRXsXV04nu9IHP9AKbEgF3GNdQg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR11MB4433 Return-Path: guo.dong@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Dong, Guo Thanks, Guo > -----Original Message----- > From: Marcello Sylvester Bauer > Sent: Wednesday, June 24, 2020 2:58 AM > To: devel@edk2.groups.io > Cc: Patrick Rudolph ; Christian Walter > ; Ma, Maurice ; > Dong, Guo ; You, Benjamin > > Subject: [PATCH v2 1/1] UefiPayloadPkg: Make TerminalDxe build time > configurable >=20 > From: Patrick Rudolph >=20 > As the TerminalDxe significantly slows down the boot menu rendering, > add the DISABLE_SERIAL_TERMINAL option to disable it at build time. >=20 > Signed-off-by: Patrick Rudolph > Signed-off-by: Marcello Sylvester Bauer > Cc: Patrick Rudolph > Cc: Christian Walter > Cc: Maurice Ma > Cc: Guo Dong > Cc: Benjamin You > --- > UefiPayloadPkg/UefiPayloadPkgIa32.dsc | 5 +++++ > UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc | 5 +++++ > UefiPayloadPkg/UefiPayloadPkg.fdf | 2 ++ > 3 files changed, 12 insertions(+) >=20 > diff --git a/UefiPayloadPkg/UefiPayloadPkgIa32.dsc > b/UefiPayloadPkg/UefiPayloadPkgIa32.dsc > index c6c47833871b..49f42285882d 100644 > --- a/UefiPayloadPkg/UefiPayloadPkgIa32.dsc > +++ b/UefiPayloadPkg/UefiPayloadPkgIa32.dsc > @@ -58,6 +58,9 @@ [Defines] > DEFINE UART_DEFAULT_STOP_BITS =3D 1 >=20 > DEFINE DEFAULT_TERMINAL_TYPE =3D 0 >=20 >=20 >=20 > + # Enabling the serial terminal will slow down the boot menu rendering! >=20 > + DEFINE DISABLE_SERIAL_TERMINAL =3D FALSE >=20 > + >=20 > # >=20 > # typedef struct { >=20 > # UINT16 VendorId; ///< Vendor ID to match the PCI device= . The > value 0xFFFF terminates the list of entries. >=20 > @@ -502,7 +505,9 @@ [Components.IA32] > MdeModulePkg/Universal/Console/ConPlatformDxe/ConPlatformDxe.inf >=20 > MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitterDxe.inf >=20 >=20 > MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsoleD > xe.inf >=20 > +!if $(DISABLE_SERIAL_TERMINAL) =3D=3D FALSE >=20 > MdeModulePkg/Universal/Console/TerminalDxe/TerminalDxe.inf >=20 > +!endif >=20 > UefiPayloadPkg/GraphicsOutputDxe/GraphicsOutputDxe.inf >=20 >=20 >=20 > #------------------------------ >=20 > diff --git a/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc > b/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc > index 5559b1258521..33805902f705 100644 > --- a/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc > +++ b/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc > @@ -59,6 +59,9 @@ [Defines] > DEFINE UART_DEFAULT_STOP_BITS =3D 1 >=20 > DEFINE DEFAULT_TERMINAL_TYPE =3D 0 >=20 >=20 >=20 > + # Enabling the serial terminal will slow down the boot menu redering! >=20 > + DEFINE DISABLE_SERIAL_TERMINAL =3D FALSE >=20 > + >=20 > # >=20 > # typedef struct { >=20 > # UINT16 VendorId; ///< Vendor ID to match the PCI device= . The > value 0xFFFF terminates the list of entries. >=20 > @@ -504,7 +507,9 @@ [Components.X64] > MdeModulePkg/Universal/Console/ConPlatformDxe/ConPlatformDxe.inf >=20 > MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitterDxe.inf >=20 >=20 > MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsoleD > xe.inf >=20 > +!if $(DISABLE_SERIAL_TERMINAL) =3D=3D FALSE >=20 > MdeModulePkg/Universal/Console/TerminalDxe/TerminalDxe.inf >=20 > +!endif >=20 > UefiPayloadPkg/GraphicsOutputDxe/GraphicsOutputDxe.inf >=20 >=20 >=20 > #------------------------------ >=20 > diff --git a/UefiPayloadPkg/UefiPayloadPkg.fdf > b/UefiPayloadPkg/UefiPayloadPkg.fdf > index dfbcde566849..03ff6a9595d1 100644 > --- a/UefiPayloadPkg/UefiPayloadPkg.fdf > +++ b/UefiPayloadPkg/UefiPayloadPkg.fdf > @@ -131,7 +131,9 @@ [FV.DXEFV] > INF > MdeModulePkg/Universal/Console/ConPlatformDxe/ConPlatformDxe.inf >=20 > INF MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitterDxe.inf >=20 > INF > MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsoleD > xe.inf >=20 > +!if $(DISABLE_SERIAL_TERMINAL) =3D=3D FALSE >=20 > INF MdeModulePkg/Universal/Console/TerminalDxe/TerminalDxe.inf >=20 > +!endif >=20 > INF UefiPayloadPkg/GraphicsOutputDxe/GraphicsOutputDxe.inf >=20 >=20 >=20 > # >=20 > -- > 2.25.4