From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mx.groups.io with SMTP id smtpd.web12.4013.1600134482385252925 for ; Mon, 14 Sep 2020 18:48:02 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=y6qv2YQ/; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: hao.a.wu@intel.com) IronPort-SDR: /oBOdRbOOdNbI+tazJ6MPza/dKieAA8Y3J792tBiXmbpMubuKqjNFDGXM5s5WuSU272767dUjO Ec7AgVpyZylw== X-IronPort-AV: E=McAfee;i="6000,8403,9744"; a="146926848" X-IronPort-AV: E=Sophos;i="5.76,427,1592895600"; d="scan'208";a="146926848" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Sep 2020 18:48:00 -0700 IronPort-SDR: DRKTl43oH08S3AqE6A0X85ES1KFj9aqk+wjurINDTh1kHE0Cx96MK5gGymzS8/ofsIwpdGmRPh 9JXC5CygPKcA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,427,1592895600"; d="scan'208";a="330976042" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by fmsmga004.fm.intel.com with ESMTP; 14 Sep 2020 18:48:00 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 14 Sep 2020 18:48:00 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Mon, 14 Sep 2020 18:48:00 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.168) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Mon, 14 Sep 2020 18:47:58 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=a5ZZGZaISedH7DfPWmzFmkAk85zwW+l86MafOWmhRJhOS5nfbDn8hJLTccBQfOazjCbXCrgJEw6iXXEDbOCql5ya0dIpDe4cZBEX/T7QkjAlcGICCuGB695YXJ2Djgn3VVMAyS+JiFniO1l4IC21aUah5bsv6Iz3pGwUAED2xQsxjKx9E7ZrABfKyvPXVWSF1pJGkATK0K9UC3C37ahNlI10qWR61tlS03vsNPOBasiD3HJsa//Mg/WkrPNh4NPRZkDkgDTg9IEt4u360d7QnyT+5kDcqumF44x6lPJ9+3ubbigbWnHZpKgmHadKAUeqaEiDa8JcjkNKgHKL/lkImg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Epkd1MnXJ8CSWzpr86RjxFdqTn/uLdcqqd/oA+nN+wA=; b=GStr72ghrkvnGHBOUTRPf0LkHfQABP+YaHiggdKWmIJeNm3FlOm8LT/so5AA2VTsFRb1kDyVTbZMdyfq+ihWvK3OLlwAGRD0DOauLe5ucsHUDLSIf9SAq28OudrTYEtY4GZGhTU0TLn8QUqdF/pW9A9yZtuX7MEqzIdELPUhUNSCs4je+is5jZ1BFrVBGATcfKwSHeRvBHGFZJbb8GjeUwEiugwhx9u0GhCiYxJmXriwhmwoKJMp5lXBRt/jYnQBHv2H/7hr6O0vSl9TBLvkdDSuW8rj/6DRwgsbWyrDqUKb1T/DzKD1mAyf1rwW634zsxqKQSJz7W1WL9VxnlmD0w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Epkd1MnXJ8CSWzpr86RjxFdqTn/uLdcqqd/oA+nN+wA=; b=y6qv2YQ/XvM5MZxOObKTb1NLDXIbpo3YIEQVm9xZX0siUKl8toIsQl7p9DsLjrOfnrZveaefDz6Q3xOF/My/zz3Irq3uPmx0QLzliUJ00/1yurgnkbYqo+rz8LsKVtH0HVPZFNee4urvD+vuVxT7cKzhjIKyPKDFVNT8oNrRYNs= Received: from BYAPR11MB3670.namprd11.prod.outlook.com (2603:10b6:a03:f8::11) by BYAPR11MB2600.namprd11.prod.outlook.com (2603:10b6:a02:c8::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3370.16; Tue, 15 Sep 2020 01:47:55 +0000 Received: from BYAPR11MB3670.namprd11.prod.outlook.com ([fe80::2129:60f2:c049:c024]) by BYAPR11MB3670.namprd11.prod.outlook.com ([fe80::2129:60f2:c049:c024%7]) with mapi id 15.20.3370.019; Tue, 15 Sep 2020 01:47:54 +0000 From: "Wu, Hao A" To: Jeff Brasen , "devel@edk2.groups.io" CC: "Ni, Ray" Subject: Re: [PATCH] MdeModulePkg/NonDiscoverablePciDeviceDxe: Add NULL pointer check Thread-Topic: [PATCH] MdeModulePkg/NonDiscoverablePciDeviceDxe: Add NULL pointer check Thread-Index: AQHWiF9VOUUZ9A13wUaAUBbxQ9Wsqqlo86Fw Date: Tue, 15 Sep 2020 01:47:54 +0000 Message-ID: References: <3e6a774a62a4ef92fcdfb5e156e2abc4c440d35e.1599844505.git.jbrasen@nvidia.com> In-Reply-To: <3e6a774a62a4ef92fcdfb5e156e2abc4c440d35e.1599844505.git.jbrasen@nvidia.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.218] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 7a804e2b-c376-4112-167f-08d859195d74 x-ms-traffictypediagnostic: BYAPR11MB2600: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:265; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 4Y8nwO4br2Oli65+A2zZX5bXRADelovawZOv7D1wAblQ/4HFnh+X0Itc2r55ZbnQ63940D36iEyxFouQRschE02qrad2txRQNqgt6alCpR24j8PF7OaMKuXfRfg9HRIWyRGAe3cufmfMn1vJVvXIh/Z/vT40QWwjBHI+LPYrC9S+ppOCqVhitAhToNKFRRtUCaELk8EZoYHYpP5XGF46JVimg46zgV7CF7pnm01mh7+Yo3oSxt/iISnyaXOfY6da7r138PSbpmRoCwgsjFwhur7EDP41Ho816/JCVeRZ1u1zZQ2RqYy1CejZNkgMWxn/4lllyk5rUlVU9xJi2e0Vn680XDBMYhe+X7GwzS1TjWUTS9JkKTyvwSSJSTgRRPaL x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR11MB3670.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(346002)(396003)(39860400002)(366004)(136003)(8936002)(7696005)(110136005)(83380400001)(66946007)(66476007)(4326008)(66556008)(478600001)(8676002)(64756008)(66446008)(55016002)(107886003)(9686003)(86362001)(52536014)(76116006)(316002)(6506007)(71200400001)(5660300002)(26005)(53546011)(2906002)(186003)(33656002)(213903007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: NW55BJhK4xwL7z3IO5eM4t8PEhW4Fmy8sWM7bXKD0ggqUdqZr6uwPxtPq8fR4ZNVbIG6WYMaZaSPtNwPbTdU4c3+sO2H/yl855q1OR/bKUXBG+GdsV+HOFJcn2FWBXzPQEgsqIoh6PvWcXPTth1ABIHCwghuZp4yykDiIR5bVftQ7iDr4qlnWxrMk5Rh0MxyfIseDmwC8SICEWfTnYm9v/6+hNT/+cCQYAT042KICOe69sxSsLMi1W2qb7M1AOr2O6GiXS2XRPKJphEaqlR1Sg2L6ljzT0o/tlwAMjq8P9NwMr4BewDgeE/1wGYx5WWOTysNEkvcZzQTkowIbW8lr1rd0Wp4oj/QlVeE2XD2ImwtyM7q6zxRm7/RXWLW2kEZPz1ozkhi7weCmNI3X9FMbrTT79Xui0CpIKuEKtqRUAQ6elT/EoW7hP7qPGyKx/YhkcZUIgAnsWmwMLpEqzdGrlpgGxBUFJrvSbvlwfHoXXiJJyeBuJ2dSHwOY9n9/XOwtkTpnpdfPGEUK6KB78fjl1Ff5BCYJpX/p+lBcnAFy2Gjdn4d/u6b7+Fxj/vkiVfZGkOBVKp7KGfZ6sL7z/edqbQDoxyxZs5Fs7eNcHuBuR4TPLHDnFRat/cm9gQlHmWhvu7cuP7UNTlwYb1pPk1eCg== MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3670.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7a804e2b-c376-4112-167f-08d859195d74 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Sep 2020 01:47:54.7659 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: RJXHabfH4IpAMUYs8XG/qLLCxIxlchdSBUqrSKGOwX0m/uZVdtq7eNX9RDehzgEc/8MJE4uqy9YJ2EmcPiUD1Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB2600 Return-Path: hao.a.wu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Hao A Wu Best Regards, Hao Wu > -----Original Message----- > From: Jeff Brasen > Sent: Saturday, September 12, 2020 1:17 AM > To: devel@edk2.groups.io > Cc: Wu, Hao A ; Ni, Ray ; Jeff > Brasen > Subject: [PATCH] MdeModulePkg/NonDiscoverablePciDeviceDxe: Add NULL > pointer check >=20 > Add check for NULL HostAddress in AllocateBuffer as required by UEFI > specification. >=20 > Signed-off-by: Jeff Brasen > --- > .../NonDiscoverablePciDeviceDxe/NonDiscoverablePciDeviceIo.c | 4 ++++ > 1 file changed, 4 insertions(+) >=20 > diff --git > a/MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverable > PciDeviceIo.c > b/MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverable > PciDeviceIo.c > index a40c1a9593..363c4a765b 100644 > --- > a/MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverable > PciDeviceIo.c > +++ > b/MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverable > Pc > +++ iDeviceIo.c > @@ -856,6 +856,10 @@ CoherentPciIoAllocateBuffer ( > return EFI_UNSUPPORTED; } + if (HostAddress =3D=3D NULL) {+ re= turn > EFI_INVALID_PARAMETER;+ }+ if ((MemoryType !=3D EfiBootServicesData) > && (MemoryType !=3D EfiRuntimeServicesData)) { return > EFI_INVALID_PARAMETER;-- > 2.25.1