From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web11.11228.1595299909617948173 for ; Mon, 20 Jul 2020 19:51:49 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=KZqIEee0; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: ianx.kuo@intel.com) IronPort-SDR: +iV6GDjfhcyGGw3XTsdjtPXXu5Ixw/I6zhsmgpTTmd/CGwO+8x+jfxxhDi8kg/1hpzD/Bi/cFW utVI5PGUD5qA== X-IronPort-AV: E=McAfee;i="6000,8403,9688"; a="147991468" X-IronPort-AV: E=Sophos;i="5.75,377,1589266800"; d="scan'208,217";a="147991468" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jul 2020 19:51:48 -0700 IronPort-SDR: PBYHXxm9rgCXde+4YEM6B6n03GXNegALwXWso/3urfBx5Vd/5S+TSMiZX6k4iA3Niy+Et331jF C5Y6QNdK/XPQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,377,1589266800"; d="scan'208,217";a="283719200" Received: from orsmsx106.amr.corp.intel.com ([10.22.225.133]) by orsmga003.jf.intel.com with ESMTP; 20 Jul 2020 19:51:47 -0700 Received: from ORSEDG002.ED.cps.intel.com (10.7.248.5) by ORSMSX106.amr.corp.intel.com (10.22.225.133) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 20 Jul 2020 19:51:47 -0700 Received: from NAM04-BN3-obe.outbound.protection.outlook.com (104.47.46.50) by edgegateway.intel.com (134.134.137.101) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 20 Jul 2020 19:51:47 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=R73hg4VZ+4xPxJl+aH2DcdR/grJCGHAQ80tARcrJYRoi5MacAGt7oZbIF3QJdd/Po3flilehvWARqCgcdHm9MaNx1qqwVcq4h4ACIa2MUPASQyH268+ZyF1YJIb2KCmntwbUzqSsO1JXa6Bmv0pkYwLK/I4YoabnV6SwN08hvhUx7K8wWpuJPdBQYckuVqvIZ8CpLqVWx1pVZf7zJnVPUSZ0VgAUvADFA+4Nt0p7HGNjHclhNp3snePTTs2XfIR+AIqBWXMoctjMGKktLWsn60tGRzyNe1Rky5F3qlY3EOCs0JkhyTv9WjcwXknyqusrAZXh/SAm2xUITli2dYLwyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QQsOJWveu5c22wufIeD57bfuLLA2lJWz0rECwybPZqA=; b=EGGYSoemZO7mi1x95KcrfG9p5tSzyoWc8lYlEiPZhytLYCYJoRCWMKj+RJ4nwZcLABCPIiuAaE9Xf6gItn8PbAZTbQYN6oSSErnFq9HdoR/T54riigZe3U1WdL2XqRwXoWlHbP4NQt5LehohOZ3Mdkd9PmSDz2nwAec5ixc4yZy5eL3DO0Cfqf8+ZPuSkE60xLikKzsifEnevQF2Q2dncyOPk6Wnu+C5gk7a2ctia+QO88MYi57hoq3HGkotg/P1ojUO7RTu6KCjfjhYNG0Ua/CXFHez0w/Eq+3fapy6OdL2OrOLLYYTctebn5L6C4UME3VgrdS0Fn1AdPQp3Mk4gw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QQsOJWveu5c22wufIeD57bfuLLA2lJWz0rECwybPZqA=; b=KZqIEee0/nzUlIeJuWEZ7o7LuBsAtR1/HnNVRUMrWp6Wru4IvO8sGx5WPqZvKW9kxgM2Dzbe1djWOmRWihSOjJOecvntElkWxtsI8ub63m7Otny/9nla4JskvJJodFvpnNJAHq0FiFQFSDUxyV8cdxAwnop1CfvTKlZLG/tFZJk= Received: from BYAPR11MB3765.namprd11.prod.outlook.com (2603:10b6:a03:f6::25) by BYAPR11MB2536.namprd11.prod.outlook.com (2603:10b6:a02:c4::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3195.23; Tue, 21 Jul 2020 02:51:45 +0000 Received: from BYAPR11MB3765.namprd11.prod.outlook.com ([fe80::a0bf:5090:a53f:77e]) by BYAPR11MB3765.namprd11.prod.outlook.com ([fe80::a0bf:5090:a53f:77e%4]) with mapi id 15.20.3195.026; Tue, 21 Jul 2020 02:51:45 +0000 From: "IanX Kuo" To: "Gao, Liming" , "devel@edk2.groups.io" , "Chiu, Chasel" CC: "Lu, James" , "Kumar, Chandana C" , "Prabhala, Varalakshmi A" , "Chaganty, Rangasai V" Subject: =?UTF-8?B?5Zue6KaGOiBbZWRrMi1kZXZlbF0gW2VkazItcGxhdGZvcm1zXSBbUEFUQ0ggdjYgMS82XSBQbGF0Zm9ybS9JbnRlbC9NaW5QbGF0Zm9ybVBrZzogRml4IGJ1aWxkIGVycm9y?= Thread-Topic: [edk2-devel] [edk2-platforms] [PATCH v6 1/6] Platform/Intel/MinPlatformPkg: Fix build error Thread-Index: AQHWXvbVH4JFE4emb0Gu4BLwz7kevqkRNiYAgAAUloCAAArKmA== Date: Tue, 21 Jul 2020 02:51:45 +0000 Message-ID: References: <82e226162a72f62a6a46e3a4733d1752908bcabc.1595291556.git.ianx.kuo@intel.com> , In-Reply-To: Accept-Language: zh-TW, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.52.214] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 9ad3a372-5179-4586-5c02-08d82d21019a x-ms-traffictypediagnostic: BYAPR11MB2536: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:514; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: pdwT/DatzHpzckKQ/MoQn8r4EEa2T2mENujhc+odfmrOkVWD7W2coCk12TntVw1HND/rmTZuPxkfc7QwFe3FeSsGa8Gzd/uPOQMSV5o9ok7P0/9U2VV6RCvDI+p/5eBLd6RVYzZV5+F5iZ7SovsxHccn9BovaCmMr3HjU7UfpTb7BUNqSnPX++e/EbhAnFf/pjIz0Hfi97UCqNHFevzWZbz4Fa0N/9PfXlhBOLdddwFVeoK+9BEw6S5PCGXw+LJGnwJZBLMl58HkXtSnG9LfyGVd1iK4GRgcSE1Yizlhay0yeuVUA32TDQBKOtZUDBbQYKixxUEChfiuqecB4YIyIh7Gr3V1q0ZCKCHw+kwj4Afm4BdwM/AbxPX2n2M2T2UW/FaEllwjmUALmEtgBf4BVw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR11MB3765.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(396003)(366004)(39860400002)(136003)(346002)(376002)(2906002)(166002)(4326008)(186003)(107886003)(8936002)(224303003)(54906003)(110136005)(33656002)(6636002)(83380400001)(316002)(55016002)(19627405001)(9686003)(7696005)(53546011)(91956017)(478600001)(86362001)(71200400001)(26005)(6506007)(966005)(76116006)(66556008)(66446008)(64756008)(66476007)(52536014)(5660300002)(66946007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: I72m7uNsyqThK4wL325YUK3+wEK/LoMS/P3JuN+/ShPQLcv3lgfjt0aB63tefeyr8pp+ZRN1hPbD0aBRs3egS3xQxzAA/tBG/AjsjEOqOs7vhP/aWEwNFeIyMimU22Fh87wIvY2haDnEcvb/hATJtGJ9UPnKSlW3dMSadvgdFUpWwVJ/ny7Z86fhao5cGFN/x2XfCatbfyY5zghTtt9oOe4QQYGdzzm0zLqbkSM03IYoxQJf4pEGuAVj4/CTlKEvPhN5Ec9FpCDgoulJJ+qc/FCA/AoA6e1dyoZMxJ5CHQn1kqvy2UEaknwBS690OLrfLva6oe+pqHZk5IWTGCu5yOxx2eQhzPUjlyl7nu7rjoAoTKsun5zIeMMa4RjHq3O0ccjdNoJny5ny2Traujwr77G0+5qUuR8I5LeXZkMXYP/RnlGfOv/1NqC3QuMA235kdlDbs9Bzjfvo0g3rLS8R4RPFbB3JUUW9W22k2/Et0bI= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3765.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9ad3a372-5179-4586-5c02-08d82d21019a X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Jul 2020 02:51:45.5719 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: N5oG4ujrsZtKnMHtnvpODZvANQcKzFpLAsWphBjc/Vs8mzqajdJ+VqJwIfFXwWI6hgJ6diLrZjOhOx7Jdd19Dg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB2536 Return-Path: ianx.kuo@intel.com X-OriginatorOrg: intel.com Content-Language: zh-TW Content-Type: multipart/alternative; boundary="_000_BYAPR11MB3765C244E3A14BB2C1277BCB8E780BYAPR11MB3765namp_" --_000_BYAPR11MB3765C244E3A14BB2C1277BCB8E780BYAPR11MB3765namp_ Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable Hi Liming Ok, I will have PATCH v7 to specific it to PEIM. Thanks, Ian Kuo ________________________________ =1B$B4s7o =1B$B4s7oF|4|=1B(B: 2020=1B$BG/=1B(B7=1B$B7n=1B(B21=1B$BF|=1B(B =1B$B>e8a= =1B(B 10:12 =1B$BZ@7o; Chiu, Chase= l ; Kuo, IanX =1B$BI{K\=1B(B: Lu, James ; Kumar, Chandana C ; Prabhala, Varalakshmi A ; Chaganty, Rangasai V =1B$B instead of . If so, other Pi defini= tions are not required to be included. ReportCpuHobLib module type should be PEIM. Hob can be produced only in PE= I phase. Thanks Liming -----Original Message----- From: devel@edk2.groups.io On Behalf Of Chiu, Chase= l Sent: 2020=1B$BG/=1B(B7=1B$B7n=1B(B21=1B$BF|=1B(B 8:58 To: Kuo, IanX ; devel@edk2.groups.io Cc: Lu, James ; Kumar, Chandana C ; Prabhala, Varalakshmi A ; Chaga= nty, Rangasai V Subject: Re: [edk2-devel] [edk2-platforms] [PATCH v6 1/6] Platform/Intel/M= inPlatformPkg: Fix build error Reviewed-by: Chasel Chiu > -----Original Message----- > From: Kuo, IanX > Sent: Tuesday, July 21, 2020 8:35 AM > To: devel@edk2.groups.io > Cc: Lu, James ; Kumar, Chandana C > ; Prabhala, Varalakshmi A > ; Kuo, IanX ; > Chaganty, Rangasai V ; Chiu, Chasel > > Subject: [edk2-platforms] [PATCH v6 1/6] > Platform/Intel/MinPlatformPkg: Fix build error > > Fix ReportCpuHobLib build error > > Create a Library instance of ReportCpuHobLib from PlatformInitPei driver= . > PA bits reported can be overridden by Library instance in Platform. > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2674 > > Change-Id: I0cd6ba4eb7231a3a84f080fdce85bbe74eb29eeb > Signed-off-by: IanX Kuo > Cc: Sai Chaganty > Cc: Chasel Chiu > --- > .../PlatformInit/Library/ReportCpuHobLib/ReportCpuHobLib.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git > a/Platform/Intel/MinPlatformPkg/PlatformInit/Library/ReportCpuHobLib/R > e > portCpuHobLib.c > b/Platform/Intel/MinPlatformPkg/PlatformInit/Library/ReportCpuHobLib/R > e > portCpuHobLib.c > index aa256534..83fc5249 100644 > --- > a/Platform/Intel/MinPlatformPkg/PlatformInit/Library/ReportCpuHobLib/R > e > portCpuHobLib.c > +++ > b/Platform/Intel/MinPlatformPkg/PlatformInit/Library/ReportCpuHobLib/R > e > portCpuHobLib.c > @@ -6,7 +6,10 @@ SPDX-License-Identifier: BSD-2-Clause-Patent > > > **/ > > > > -#include > > +#include > > +#include > > +#include > > +#include > > #include > > > > VOID > > -- > 2.26.2.windows.1 --_000_BYAPR11MB3765C244E3A14BB2C1277BCB8E780BYAPR11MB3765namp_ Content-Type: text/html; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable
Hi Liming

Ok, I will have PATCH v7 to specific it to PEIM.

Thanks,
Ian Kuo
=1B$B4s7o Gao, Lim= ing <liming.gao@intel.com>
=1B$B4s7oF|4|=1B(B: 2020=1B$BG/=1B(B7=1B$B7n=1B(B21=1B$BF|=1B(B =1B= $B>e8a=1B(B 10:12
=1B$BZ@7o devel@edk2.groups.io <devel@edk2.groups.io>= ; Chiu, Chasel <chasel.chiu@intel.com>; Kuo, IanX <ianx.kuo@intel.= com>
=1B$BI{K\=1B(B: Lu, James <james.lu@intel.com>; Kumar, Chanda= na C <chandana.c.kumar@intel.com>; Prabhala, Varalakshmi A <varala= kshmi.a.prabhala@intel.com>; Chaganty, Rangasai V <rangasai.v.chagant= y@intel.com>
=1B$B RE: [edk2-devel] [edk2-platforms] [PATCH v6 1/6] Pl= atform/Intel/MinPlatformPkg: Fix build error
 
I suggest to include <PiPei.h> instead of &= lt;Uefi.h>. If so, other Pi definitions are not required to be included.

ReportCpuHobLib module type should be PEIM. Hob can be produced only in PE= I phase.

Thanks
Liming
-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Chiu,= Chasel
Sent: 2020=1B$BG/=1B(B7=1B$B7n=1B(B21=1B$BF|=1B(B 8:58
To: Kuo, IanX <ianx.kuo@intel.com>; devel@edk2.groups.io
Cc: Lu, James <james.lu@intel.com>; Kumar, Chandana C <chandana.c= .kumar@intel.com>; Prabhala, Varalakshmi A <varalakshmi.a.prabhala@in= tel.com>; Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>
Subject: Re: [edk2-devel] [edk2-platforms] [PATCH v6 1/6] Platform/Intel/M= inPlatformPkg: Fix build error


Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>

> -----Original Message-----
> From: Kuo, IanX <ianx.kuo@intel.com>
> Sent: Tuesday, July 21, 2020 8:35 AM
> To: devel@edk2.groups.io
> Cc: Lu, James <james.lu@intel.com>; Kumar, Chandana C
> <chandana.c.kumar@intel.com>; Prabhala, Varalakshmi A
> <varalakshmi.a.prabhala@intel.com>; Kuo, IanX <ianx.kuo@inte= l.com>;
> Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>; Chiu, Cha= sel
> <chasel.chiu@intel.com>
> Subject: [edk2-platforms] [PATCH v6 1/6]
> Platform/Intel/MinPlatformPkg: Fix build error
>
> Fix ReportCpuHobLib build error
>
> Create a Library instance of ReportCpuHobLib from PlatformInitPei dri= ver.
> PA bits reported can be overridden by Library instance in Platform. >
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2674
>
> Change-Id: I0cd6ba4eb7231a3a84f080fdce85bbe74eb29eeb
> Signed-off-by: IanX Kuo <ianx.kuo@intel.com>
> Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> ---
>  .../PlatformInit/Library/ReportCpuHobLib/ReportCpuHobLib.c = ;  | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git
> a/Platform/Intel/MinPlatformPkg/PlatformInit/Library/ReportCpuHobLib/= R
> e
> portCpuHobLib.c
> b/Platform/Intel/MinPlatformPkg/PlatformInit/Library/ReportCpuHobLib/= R
> e
> portCpuHobLib.c
> index aa256534..83fc5249 100644
> ---
> a/Platform/Intel/MinPlatformPkg/PlatformInit/Library/ReportCpuHobLib/= R
> e
> portCpuHobLib.c
> +++
> b/Platform/Intel/MinPlatformPkg/PlatformInit/Library/ReportCpuHobLib/= R
> e
> portCpuHobLib.c
> @@ -6,7 +6,10 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
>
>
>  **/
>
>
>
> -#include <Base.h>
>
> +#include <Uefi.h>
>
> +#include <Pi/PiBootMode.h>
>
> +#include <Pi/PiHob.h>
>
> +#include <Library/BaseLib.h>
>
>  #include <Library/HobLib.h>
>
>
>
>  VOID
>
> --
> 2.26.2.windows.1




--_000_BYAPR11MB3765C244E3A14BB2C1277BCB8E780BYAPR11MB3765namp_--