From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail03.groups.io (mail03.groups.io [45.79.227.220]) by spool.mail.gandi.net (Postfix) with ESMTPS id E8365D80127 for ; Thu, 11 Apr 2024 22:27:46 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=lUuvmdSjP1EzhAaomchdqbmsfq954ZFdTFzzu4AyHAA=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type; s=20240206; t=1712874465; v=1; b=qaTOwXdWGBo5EbY68np22NmijpXkSjW3RUps1+g6GMoDrfDLmOoyWWQga5z0AQG4vcCRoS3f BeK/ayycO+/Cnp4PMXkmTwvV2NkvbtfMoKDY5pVM8gmKul0GmX5/mocIcR8y+68uewEpZJgEcih RGiS1Z8KS6HYaF78Uvm8qOqN1bCm8i6251Ze3rl+7ifNRhWiyvASrnYa4Wrq9VgnbJEDvW3oNFu ZS6Czw1r4O9auhGJjapUuCF7tzMJ/5e64Sr1BdWEzS2iJ2Ro5rqXpimWciCzFNUwWjTu9OQ0zPd 2r6mNFlBsvQX8hul7x4uPKJA8UdI6x/Yfig26pXJK9DXQ== X-Received: by 127.0.0.2 with SMTP id GWJSYY7687511xPl2qN4Vehn; Thu, 11 Apr 2024 15:27:45 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.9]) by mx.groups.io with SMTP id smtpd.web10.18410.1712843094509795892 for ; Thu, 11 Apr 2024 06:44:54 -0700 X-CSE-ConnectionGUID: 2vxXDhMOQJyDVEmk0vSAWA== X-CSE-MsgGUID: 5eeZTARfRuyeKBEImhKFRg== X-IronPort-AV: E=McAfee;i="6600,9927,11041"; a="18960582" X-IronPort-AV: E=Sophos;i="6.07,193,1708416000"; d="scan'208,217";a="18960582" X-Received: from fmviesa009.fm.intel.com ([10.60.135.149]) by fmvoesa103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Apr 2024 06:44:54 -0700 X-CSE-ConnectionGUID: zTwCNThmSUOWzXVLUR/TiQ== X-CSE-MsgGUID: 55mSO0SHQKCw0E0aaG0mXQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,193,1708416000"; d="scan'208,217";a="20953216" X-Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmviesa009.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 11 Apr 2024 06:44:54 -0700 X-Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 11 Apr 2024 06:44:53 -0700 X-Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 11 Apr 2024 06:44:52 -0700 X-Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Thu, 11 Apr 2024 06:44:52 -0700 X-Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.169) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Thu, 11 Apr 2024 06:44:52 -0700 X-Received: from BYAPR11MB3767.namprd11.prod.outlook.com (2603:10b6:a03:fd::13) by DS0PR11MB7632.namprd11.prod.outlook.com (2603:10b6:8:14f::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7452.24; Thu, 11 Apr 2024 13:44:50 +0000 X-Received: from BYAPR11MB3767.namprd11.prod.outlook.com ([fe80::def8:13bf:1c58:3a88]) by BYAPR11MB3767.namprd11.prod.outlook.com ([fe80::def8:13bf:1c58:3a88%3]) with mapi id 15.20.7452.019; Thu, 11 Apr 2024 13:44:49 +0000 From: "Lewandowski, Krzysztof" To: "devel@edk2.groups.io" CC: "Ni, Ray" , Liming Gao , "Huang, Jenny" , "Shih, More" , "Cai, Xianglei" Subject: Re: [edk2-devel] [PATCH 1/1] MdeModulePkg/XhciDxe: Reset endpoint while USB Transaction error Thread-Topic: [PATCH 1/1] MdeModulePkg/XhciDxe: Reset endpoint while USB Transaction error Thread-Index: AQHaixUpRZjwblcV5Uqw+FZWbQ87crFjFoYx Date: Thu, 11 Apr 2024 13:44:49 +0000 Message-ID: References: <2ef49d5cd3593dc573f3fac9db533b4a93ef04b5.1710220024.git.xianglei.cai@intel.com> In-Reply-To: <2ef49d5cd3593dc573f3fac9db533b4a93ef04b5.1710220024.git.xianglei.cai@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR11MB3767:EE_|DS0PR11MB7632:EE_ x-ms-office365-filtering-correlation-id: bf78f2de-4d0b-4916-6363-08dc5a2d8f06 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: 1kZBltj8GioiE7pKSYw7pLhFHuvXR5MLGLId4da1if7b5baqAtRrWi617JE8Pphzev0+rHccBqZeUQJg5RMmel0PMdSjpX0xGDF0Kk86dEQl0Ev+h5GxFM3KMAcKvOb69YB7za2/40jcvCluP/jdv+hohqmzvLoYuMjuR/CumEKy3ykjjwPUdsk/zUuHRIFwGb7o1ESGC7DcZJjosxCf78PccwP9VM2RBP4z7leq9hGEK20RrmiRbT0ZsHntJDIqP16RFpsekn6UOaEuRya/38bg5QO10Rk5uzm37ImpRtEf6HnHZHftHDmI16TIC0991fhQwnRd30VmzUEJKSZIJvVNw2CtYaYq2u9nDoICvU2AFDy/XcQdq9TwkqRSTnn+C+iRSqZb5ON/kYOuIh2nVFjVYLV/ctXEtepSd8SSZFpHtTYSmDyFwbwr/QjG/GDq4QwuYfiR9bxYucLfCGBZBtSFF+TJHqz81mhzS9pnngWkLmxZNES4494PaRVz6mPOwmADUZJnGtAK+c3O5cIm02XfSxOwA7stpmaPCC909GzqFSOlTZUuZfwDNIm5a2RXottqxDbFlHCSQby9NbgsUkHjr7gFPrPBT7UmhhCjnWXE23kQWtKZpmTYksSylCoaVPSgssIa/cBeSn0IvBcZoVT64yGg6Ch4G0LAWtsFY+s= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Ykn8DhiQTlKaRGR2ontc+5jAU84KXxNDLF2jCSRVE2x6chjODx9EzW6aEUPI?= =?us-ascii?Q?dAo5sWivVwAAApv8SDYKkj2UJJReGwGnZTQX8Z+mcqiujwcb82rXKpnLv/Py?= =?us-ascii?Q?lpiclm1yuSbSfGiURp8QDjfpfRZBwetOjeWCMAsqwJINORWp612F4r56rB5U?= =?us-ascii?Q?Nb+hSdPIAPJ01L3WCwIMatJhnFzAXDR8JLaVUL6jNvcr2yyB3ZIl3AFzEQre?= =?us-ascii?Q?ujMtURaJWXp4P3FdnF+vEhjIFAyMeggo3O3Reg2HVxiLyxNoST3RmZfrF0k1?= =?us-ascii?Q?uFdceLnP6mchS7XKYmFpwoy4pPem8pAbUSFZVcTfhSGCWsaL0A6nJzFiC3ik?= =?us-ascii?Q?E/NFGMYA9mX0XGd36bapaeVsPH1KB6WRkZ4Xq5EG3j1Uz8UqQYpHp895WIx9?= =?us-ascii?Q?efQ2G0GOmy4rbsodhHwhvIrM06IHTcSxMpvyEMKBYerJX7j4Vfh7+fIamtcN?= =?us-ascii?Q?FnDrSwYVALfnzyR+8y4rhb+RzuAsjyMgq0hwTlLdCfGq1vlO+qSatjSlGOot?= =?us-ascii?Q?HrNh29g0DkVc01hiRGn27fY/qFAOZ2l8rx9PGbGTwWBZqs6SirICOvT9F/Pb?= =?us-ascii?Q?o54BmLN7fHYazX/HmxJAzexBYquB4zM9YQaTxiBqeT2K1Sm+LephZFJEOcvA?= =?us-ascii?Q?vtBUnNJHfoXMIfXPe0+cxO5ObUJY5vDZ2A5T/5Q/twmPcvYUhywzOKc29ynx?= =?us-ascii?Q?4WjZzEHnfeyHkdg4iNqf89GpKRIXDA27JleXO/Porrrr1mZBfVR4HFL93kSK?= =?us-ascii?Q?SEYhBySpMV42X/18bKbHdrKsVd6bn7bD/7DxOWLu7k79zHTP+AG25gOmRJCf?= =?us-ascii?Q?isOHVuJ/UE1pBvw0ldlHjyhvXtb9zTR9bP+DCPZbFgPzHJxOrr21Qu6ql+aM?= =?us-ascii?Q?LxNs+9Q0dw/lTNxqrOqnXKHxr/YCDS2lVdw0FlRQV77I5sywqXhOKjPDHoI5?= =?us-ascii?Q?6l6VG49sHi/whNd4iWlruySFxR6o7lDQkVGiR87flLy2MxAgho7EAY785fvV?= =?us-ascii?Q?Zws1uWoVpCcf2R5/sE7LRnjKtBOXDQ0v7zxOPAalmutCPzp0QBZCnulb3nDV?= =?us-ascii?Q?Wo+3EkT0oA/VYnzR+YJ1jxJ9twm1cgdh8JmevpQBRJVO2gJt50VN0J0XZW3m?= =?us-ascii?Q?tQ85K/3ZaG/v94LAKkj7yuZiLX4ADWudawkU9ib0ALsFQInhgbFUizf8wXhP?= =?us-ascii?Q?KDlU0taT7TBvA+JIZnKD6AHQCOyPZL0X+dzAYcn64KCpCSYrYoNpDxk+RKyL?= =?us-ascii?Q?oZ3DECcf9GyWFcuPpAba+x9wjGpDPzhHAphQqYE8GbcNAEM/gXrxxnGcUZpv?= =?us-ascii?Q?y14cUEsJJtIG42EPGPV3kPn/xv5I1/adSx6jLtHqWHjX85LphpxoSY2GGbI1?= =?us-ascii?Q?8gYVSox7BC/JOW71nMtcYyLwqjpZtJcNXfTvsvAQOMWkVeQ7a8lJF2fomsTD?= =?us-ascii?Q?kdpuRf7209MmwEBIs5Z+qUKS9IZ4hrVfy0h0SIM1hWMcpw/c9x5pFOdAWtC2?= =?us-ascii?Q?UWAXhx1fbD2nw+EY9oQC5QM0l1hO5auVhv0/UiW0HPaHjmymxjCsLFML63lo?= =?us-ascii?Q?WCFZ0HhQapqUsMJTC2mrHQHwtAJEMGkiaoYxmBEGA+1XVqUHB2E123T5gq+3?= =?us-ascii?Q?vA=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3767.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: bf78f2de-4d0b-4916-6363-08dc5a2d8f06 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Apr 2024 13:44:49.9037 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 0BSh2dkifTvrTPccG9XJnsKjWJQa8TFJhIhtR7xQ2IRfAjlL0GA53XU9fFQFAlkT100opGoGu8nhw3bSSvZ5bJZf5g9ekqkMPNgwfnioY20= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7632 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Thu, 11 Apr 2024 15:27:40 -0700 Resent-From: krzysztof.lewandowski@intel.com Reply-To: devel@edk2.groups.io,krzysztof.lewandowski@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 74yT5is1LmdWnTjtonEc9qLtx7686176AA= Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_BYAPR11MB3767ECD8BE18508122D77490F3052BYAPR11MB3767namp_" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=qaTOwXdW; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.227.220 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none) --_000_BYAPR11MB3767ECD8BE18508122D77490F3052BYAPR11MB3767namp_ Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Looks good to me. Reviewed-by: Krzysztof Lewandowski ________________________________ From: Cai, Xianglei Sent: Wednesday, April 10, 2024 09:02 To: devel@edk2.groups.io Cc: Cai, Xianglei ; Ni, Ray ; Lim= ing Gao ; Lewandowski, Krzysztof ; Huang, Jenny ; Shih, More Subject: [PATCH 1/1] MdeModulePkg/XhciDxe: Reset endpoint while USB Transac= tion error https://bugzilla.tianocore.org/show_bug.cgi?id=3D4556 Based on XHCI spec 4.8.3, software should do the reset endpoint while USB Transaction occur. Also add the error code for USB Transaction error since UEFI spec don't have the related definition. Cc: Ray Ni Cc: Liming Gao Cc: Krzysztof Lewandowski Cc: Jenny Huang Cc: More Shih Signed-off-by: Xianglei Cai --- MdeModulePkg/Bus/Pci/XhciDxe/Xhci.c | 2 +- MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c | 2 +- MdePkg/Include/Protocol/UsbIo.h | 21 +++++++++++---------- 3 files changed, 13 insertions(+), 12 deletions(-) diff --git a/MdeModulePkg/Bus/Pci/XhciDxe/Xhci.c b/MdeModulePkg/Bus/Pci/Xhc= iDxe/Xhci.c index f4e61d223c1b..63cc29b26536 100644 --- a/MdeModulePkg/Bus/Pci/XhciDxe/Xhci.c +++ b/MdeModulePkg/Bus/Pci/XhciDxe/Xhci.c @@ -825,7 +825,7 @@ XhcTransfer ( *TransferResult =3D Urb->Result; *DataLength =3D Urb->Completed; - if ((*TransferResult =3D=3D EFI_USB_ERR_STALL) || (*TransferResult =3D= =3D EFI_USB_ERR_BABBLE)) { + if ((*TransferResult =3D=3D EFI_USB_ERR_STALL) || (*TransferResult =3D= =3D EFI_USB_ERR_BABBLE) || (*TransferResult =3D=3D EFI_USB_ERR_TRANSACTION)= ) { ASSERT (Status =3D=3D EFI_DEVICE_ERROR); RecoveryStatus =3D XhcRecoverHaltedEndpoint (Xhc, Urb); if (EFI_ERROR (RecoveryStatus)) { diff --git a/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c b/MdeModulePkg/Bus/Pc= i/XhciDxe/XhciSched.c index 05528a478baf..e77852f62f10 100644 --- a/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c +++ b/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c @@ -1193,7 +1193,7 @@ XhcCheckUrbResult ( goto EXIT; case TRB_COMPLETION_USB_TRANSACTION_ERROR: - CheckedUrb->Result |=3D EFI_USB_ERR_TIMEOUT; + CheckedUrb->Result |=3D EFI_USB_ERR_TRANSACTION; CheckedUrb->Finished =3D TRUE; DEBUG ((DEBUG_ERROR, "XhcCheckUrbResult: TRANSACTION_ERROR! Comple= tecode =3D %x\n", EvtTrb->Completecode)); goto EXIT; diff --git a/MdePkg/Include/Protocol/UsbIo.h b/MdePkg/Include/Protocol/UsbI= o.h index a780b4e07b44..211ef0c94156 100644 --- a/MdePkg/Include/Protocol/UsbIo.h +++ b/MdePkg/Include/Protocol/UsbIo.h @@ -50,16 +50,17 @@ typedef enum { // // USB Transfer Results // -#define EFI_USB_NOERROR 0x00 -#define EFI_USB_ERR_NOTEXECUTE 0x01 -#define EFI_USB_ERR_STALL 0x02 -#define EFI_USB_ERR_BUFFER 0x04 -#define EFI_USB_ERR_BABBLE 0x08 -#define EFI_USB_ERR_NAK 0x10 -#define EFI_USB_ERR_CRC 0x20 -#define EFI_USB_ERR_TIMEOUT 0x40 -#define EFI_USB_ERR_BITSTUFF 0x80 -#define EFI_USB_ERR_SYSTEM 0x100 +#define EFI_USB_NOERROR 0x00 +#define EFI_USB_ERR_NOTEXECUTE 0x01 +#define EFI_USB_ERR_STALL 0x02 +#define EFI_USB_ERR_BUFFER 0x04 +#define EFI_USB_ERR_BABBLE 0x08 +#define EFI_USB_ERR_NAK 0x10 +#define EFI_USB_ERR_CRC 0x20 +#define EFI_USB_ERR_TIMEOUT 0x40 +#define EFI_USB_ERR_BITSTUFF 0x80 +#define EFI_USB_ERR_SYSTEM 0x100 +#define EFI_USB_ERR_TRANSACTION 0x200 /** Async USB transfer callback routine. -- 2.42.0.windows.2 --------------------------------------------------------------------- Intel Technology Poland sp. z o.o. ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc | VII Wydz= ial Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 | NIP 957-07-52-31= 6 | Kapital zakladowy 200.000 PLN. Spolka oswiadcza, ze posiada status duzego przedsiebiorcy w rozumieniu usta= wy z dnia 8 marca 2013 r. o przeciwdzialaniu nadmiernym opoznieniom w trans= akcjach handlowych. Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego adresata= i moze zawierac informacje poufne. W razie przypadkowego otrzymania tej wi= adomosci, prosimy o powiadomienie nadawcy oraz trwale jej usuniecie; jakiek= olwiek przegladanie lub rozpowszechnianie jest zabronione. This e-mail and any attachments may contain confidential material for the s= ole use of the intended recipient(s). If you are not the intended recipient= , please contact the sender and delete all copies; any review or distributi= on by others is strictly prohibited. -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117635): https://edk2.groups.io/g/devel/message/117635 Mute This Topic: https://groups.io/mt/104879589/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --_000_BYAPR11MB3767ECD8BE18508122D77490F3052BYAPR11MB3767namp_ Content-Type: text/html; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
Looks good to me.

Reviewed-by: Krzysztof Lewandowski <krzysztof.lewandowski@intel.com><= /div>
From: Cai, Xianglei <xia= nglei.cai@intel.com>
Sent: Wednesday, April 10, 2024 09:02
To: devel@edk2.groups.io <devel@edk2.groups.io>
Cc: Cai, Xianglei <xianglei.cai@intel.com>; Ni, Ray <ray.ni= @intel.com>; Liming Gao <gaoliming@byosoft.com.cn>; Lewandowski, K= rzysztof <krzysztof.lewandowski@intel.com>; Huang, Jenny <jenny.hu= ang@intel.com>; Shih, More <more.shih@intel.com>
Subject: [PATCH 1/1] MdeModulePkg/XhciDxe: Reset endpoint while USB = Transaction error
 
https://bugzilla.tianocore.org/show_bug.cgi?id=3D4556
Based on XHCI spec 4.8.3, software should do the
reset endpoint while USB Transaction occur.
Also add the error code for USB Transaction error
since UEFI spec don't have the related definition.

Cc: Ray Ni           = ;            &n= bsp;        <ray.ni@intel.com>
Cc: Liming Gao          &= nbsp;           &nbs= p;     <gaoliming@byosoft.com.cn>
Cc: Krzysztof Lewandowski    <krzysztof.lewandowski@intel= .com>
Cc: Jenny Huang          =             &nb= sp;    <jenny.huang@intel.com>
Cc: More Shih          &n= bsp;            = ;      <more.shih@intel.com>

Signed-off-by: Xianglei Cai <xianglei.cai@intel.com>
---
 MdeModulePkg/Bus/Pci/XhciDxe/Xhci.c      |&n= bsp; 2 +-
 MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c |  2 +-
 MdePkg/Include/Protocol/UsbIo.h      &n= bsp;   | 21 +++++++++++----------
 3 files changed, 13 insertions(+), 12 deletions(-)

diff --git a/MdeModulePkg/Bus/Pci/XhciDxe/Xhci.c b/MdeModulePkg/Bus/Pci/Xhc= iDxe/Xhci.c
index f4e61d223c1b..63cc29b26536 100644
--- a/MdeModulePkg/Bus/Pci/XhciDxe/Xhci.c
+++ b/MdeModulePkg/Bus/Pci/XhciDxe/Xhci.c
@@ -825,7 +825,7 @@ XhcTransfer (
   *TransferResult =3D Urb->Result;
   *DataLength     =3D Urb->Completed;
 
-  if ((*TransferResult =3D=3D EFI_USB_ERR_STALL) || (*TransferResult = =3D=3D EFI_USB_ERR_BABBLE)) {
+  if ((*TransferResult =3D=3D EFI_USB_ERR_STALL) || (*TransferResult = =3D=3D EFI_USB_ERR_BABBLE) || (*TransferResult =3D=3D EFI_USB_ERR_TRANSACTI= ON)) {
     ASSERT (Status =3D=3D EFI_DEVICE_ERROR);
     RecoveryStatus =3D XhcRecoverHaltedEndpoint (Xhc, = Urb);
     if (EFI_ERROR (RecoveryStatus)) {
diff --git a/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c b/MdeModulePkg/Bus/Pc= i/XhciDxe/XhciSched.c
index 05528a478baf..e77852f62f10 100644
--- a/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c
+++ b/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c
@@ -1193,7 +1193,7 @@ XhcCheckUrbResult (
         goto EXIT;
 
       case TRB_COMPLETION_USB_TRANSACTION_ER= ROR:
-        CheckedUrb->Result  |= =3D EFI_USB_ERR_TIMEOUT;
+        CheckedUrb->Result  |= =3D EFI_USB_ERR_TRANSACTION;
         CheckedUrb->Finished = =3D TRUE;
         DEBUG ((DEBUG_ERROR, "= ;XhcCheckUrbResult: TRANSACTION_ERROR! Completecode =3D %x\n", EvtTrb-= >Completecode));
         goto EXIT;
diff --git a/MdePkg/Include/Protocol/UsbIo.h b/MdePkg/Include/Protocol/UsbI= o.h
index a780b4e07b44..211ef0c94156 100644
--- a/MdePkg/Include/Protocol/UsbIo.h
+++ b/MdePkg/Include/Protocol/UsbIo.h
@@ -50,16 +50,17 @@ typedef enum {
 //
 // USB Transfer Results
 //
-#define EFI_USB_NOERROR         0x= 00
-#define EFI_USB_ERR_NOTEXECUTE  0x01
-#define EFI_USB_ERR_STALL       0x02
-#define EFI_USB_ERR_BUFFER      0x04
-#define EFI_USB_ERR_BABBLE      0x08
-#define EFI_USB_ERR_NAK         0x= 10
-#define EFI_USB_ERR_CRC         0x= 20
-#define EFI_USB_ERR_TIMEOUT     0x40
-#define EFI_USB_ERR_BITSTUFF    0x80
-#define EFI_USB_ERR_SYSTEM      0x100
+#define EFI_USB_NOERROR        &nb= sp; 0x00
+#define EFI_USB_ERR_NOTEXECUTE   0x01
+#define EFI_USB_ERR_STALL        0x02 +#define EFI_USB_ERR_BUFFER       0x04
+#define EFI_USB_ERR_BABBLE       0x08
+#define EFI_USB_ERR_NAK        &nb= sp; 0x10
+#define EFI_USB_ERR_CRC        &nb= sp; 0x20
+#define EFI_USB_ERR_TIMEOUT      0x40
+#define EFI_USB_ERR_BITSTUFF     0x80
+#define EFI_USB_ERR_SYSTEM       0x100
+#define EFI_USB_ERR_TRANSACTION  0x200
 
 /**
   Async USB transfer callback routine.
--
2.42.0.windows.2

Intel = Technology Poland sp. z o.o.
 ul. Słowackiego 173 | 80-298 Gdańsk | Sąd Rejonowy G= dańsk Północ | VII Wydział Gospodarczy Krajowego Rejest= ru Sądowego - KRS 101882 | NIP 957-07-52-316 | Kapitał zakła= dowy 200.000 PLN.
Spółka oświadcza, że posiada status du= 80;ego przedsiębiorcy w rozumieniu ustawy z dnia 8 marca 2013 r. o prz= eciwdziałaniu nadmiernym opóźnieniom w transakcjach handlowy= ch.

Ta wiadomość wraz z załącznikami jest przeznacz= ona dla określonego adresata i może zawierać informacje pouf= ne. W razie przypadkowego otrzymania tej wiadomości, prosimy o powiado= mienie nadawcy oraz trwałe jej usunięcie; jakiekolwiek przegl= 1;danie lub rozpowszechnianie jest zabronione.
This e-mail and any attachments may contain confidential material f= or the sole use of the intended recipient(s). If you are not the intended r= ecipient, please contact the sender and delete all copies; any review or di= stribution by others is strictly prohibited.

_._,_._,_
Groups.io Links:

=20 You receive all messages sent to this group. =20 =20

View/Reply Online (#117635) | =20 | Mute= This Topic | New Topic
Your Subscriptio= n | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--_000_BYAPR11MB3767ECD8BE18508122D77490F3052BYAPR11MB3767namp_--