From: "Kubacki, Michael A" <michael.a.kubacki@intel.com>
To: "Chiu, Chasel" <chasel.chiu@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Desimone, Nathaniel L" <nathaniel.l.desimone@intel.com>,
"Gao, Liming" <liming.gao@intel.com>,
Jeremy Soller <jeremy@system76.com>,
"Lu, Shifei A" <shifei.a.lu@intel.com>,
"Zhou, Bowen" <bowen.zhou@intel.com>,
"Oram, Isaac W" <isaac.w.oram@intel.com>,
"Wei, David Y" <david.y.wei@intel.com>,
"Agyeman, Prince" <prince.agyeman@intel.com>
Subject: Re: [edk2-platforms: PATCH v2 0/6] Add SetCacheLib library class.
Date: Thu, 31 Oct 2019 05:49:50 +0000 [thread overview]
Message-ID: <BYAPR11MB38312976DC14EB0B32096FFDB5630@BYAPR11MB3831.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20191031002952.3860-1-chasel.chiu@intel.com>
Hi Chasel,
I don't think SetCacheLib is quite precise enough. Can you please
consider an alternative such as SetMtrrLib?
Thanks,
Michael
> -----Original Message-----
> From: Chiu, Chasel <chasel.chiu@intel.com>
> Sent: Wednesday, October 30, 2019 5:30 PM
> To: devel@edk2.groups.io
> Cc: Kubacki, Michael A <michael.a.kubacki@intel.com>; Desimone, Nathaniel
> L <nathaniel.l.desimone@intel.com>; Gao, Liming <liming.gao@intel.com>;
> Jeremy Soller <jeremy@system76.com>; Lu, Shifei A
> <shifei.a.lu@intel.com>; Zhou, Bowen <bowen.zhou@intel.com>; Oram,
> Isaac W <isaac.w.oram@intel.com>; Wei, David Y <david.y.wei@intel.com>;
> Agyeman, Prince <prince.agyeman@intel.com>
> Subject: [edk2-platforms: PATCH v2 0/6] Add SetCacheLib library class.
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2314
>
> The MTRRs may be redundantly or incorrectly configured.
> It is recommended to move this functionality to a library class that with a
> NULL library by default. The board package may provide its own library
> implementation.
> MinPlatformPkg should contain the library class header (API) and the NULL
> library class instance.
>
> Cc: Michael Kubacki <michael.a.kubacki@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Jeremy Soller <jeremy@system76.com>
> Cc: Shifei A Lu <shifei.a.lu@intel.com>
> Cc: Xiaohu Zhou <bowen.zhou@intel.com>
> Cc: Isaac W Oram <isaac.w.oram@intel.com>
> Cc: Wei David Y <david.y.wei@intel.com>
> Cc: Agyeman Prince <prince.agyeman@intel.com>
> Signed-off-by: Chasel Chiu <chasel.chiu@intel.com>
>
> Chasel Chiu (6):
> MinPlatformPkg: Add SetCacheLib library class.
> MinPlatformPkg: Add SetCacheLib library class.
> KabylakeOpenBoardPkg: Add SetCacheLib library class.
> WhiskeylakeOpenBoardPkg: Add SetCacheLib library class.
> PurleyOpenBoardPkg/BoardMtOlympus: Add SetCacheLib library class.
> SimicsOpenBoardPkg/BoardX58Ich10: Add SetCacheLib library class.
>
>
> Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Override/Platform/Intel
> /MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreMem.c | 640
> ----------------------------------------------------------------------------------------------
> ----------------------------------------------------------------------------------------------
> ----------------------------------------------------------------------------------------------
> ----------------------------------------------------------------------------------------------
> ----------------------------------------------------------------------------------------------
> ----------------------------------------------------------------------------------------------
> ----------------------------------------------------------------------------
> Platform/Intel/MinPlatformPkg/Library/SetCacheLib/SetCacheLib.c
> | 325
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> +++++++++++++++++++++++++++++++++++
> Platform/Intel/MinPlatformPkg/Library/SetCacheLib/SetCacheLibNull.c
> | 37 +++++++++++++++++++++++++++++++++++++
>
> Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPos
> tMem.c | 149 +-----------------------------------------
> ----------------------------------------------------------------------------------------------
> -------------
>
> Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPre
> Mem.c | 164 ++----------------------------------------
> ----------------------------------------------------------------------------------------------
> ----------------------------
> Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc
> | 3 ++-
> Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.fdf
> | 2 +-
>
> Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Override/Platform/Intel
> /MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreMem.inf | 67
> -------------------------------------------------------------------
> Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc
> | 1 +
> Platform/Intel/MinPlatformPkg/Include/Library/SetCacheLib.h
> | 34 ++++++++++++++++++++++++++++++++++
> Platform/Intel/MinPlatformPkg/Library/SetCacheLib/SetCacheLib.inf
> | 44 ++++++++++++++++++++++++++++++++++++++++++++
> Platform/Intel/MinPlatformPkg/Library/SetCacheLib/SetCacheLibNull.inf
> | 30 ++++++++++++++++++++++++++++++
>
> Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPos
> tMem.inf | 11 +----------
>
> Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPre
> Mem.inf | 7 ++-----
> Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/PlatformPkg.dsc
> | 3 ++-
> Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc
> | 1 +
>
> Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPk
> g.dsc | 1 +
> 17 files changed, 484 insertions(+), 1035 deletions(-) delete mode 100644
> Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Override/Platform/Intel
> /MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreMem.c
> create mode 100644
> Platform/Intel/MinPlatformPkg/Library/SetCacheLib/SetCacheLib.c
> create mode 100644
> Platform/Intel/MinPlatformPkg/Library/SetCacheLib/SetCacheLibNull.c
> delete mode 100644
> Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Override/Platform/Intel
> /MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreMem.inf
> create mode 100644
> Platform/Intel/MinPlatformPkg/Include/Library/SetCacheLib.h
> create mode 100644
> Platform/Intel/MinPlatformPkg/Library/SetCacheLib/SetCacheLib.inf
> create mode 100644
> Platform/Intel/MinPlatformPkg/Library/SetCacheLib/SetCacheLibNull.inf
>
> --
> 2.13.3.windows.1
next prev parent reply other threads:[~2019-10-31 5:49 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-31 0:29 [edk2-platforms: PATCH v2 0/6] Add SetCacheLib library class Chiu, Chasel
2019-10-31 0:29 ` [edk2-platforms: PATCH v2 1/6] MinPlatformPkg: " Chiu, Chasel
2019-10-31 1:38 ` Nate DeSimone
2019-10-31 6:00 ` Kubacki, Michael A
2019-10-31 10:22 ` Chiu, Chasel
2019-10-31 0:29 ` [edk2-platforms: PATCH v2 2/6] " Chiu, Chasel
2019-10-31 1:38 ` Nate DeSimone
2019-10-31 6:07 ` Kubacki, Michael A
2019-10-31 0:29 ` [edk2-platforms: PATCH v2 3/6] KabylakeOpenBoardPkg: " Chiu, Chasel
2019-10-31 1:39 ` Nate DeSimone
2019-10-31 6:11 ` Kubacki, Michael A
2019-10-31 0:29 ` [edk2-platforms: PATCH v2 4/6] WhiskeylakeOpenBoardPkg: " Chiu, Chasel
2019-10-31 1:39 ` Nate DeSimone
2019-10-31 6:11 ` Kubacki, Michael A
2019-10-31 0:29 ` [edk2-platforms: PATCH v2 5/6] PurleyOpenBoardPkg/BoardMtOlympus: " Chiu, Chasel
2019-10-31 1:39 ` [edk2-devel] " Nate DeSimone
2019-10-31 1:54 ` Zhou, Bowen
2019-10-31 1:58 ` FW: " Lu, Shifei A
2019-10-31 6:12 ` [edk2-devel] " Kubacki, Michael A
2019-10-31 0:29 ` [edk2-platforms: PATCH v2 6/6] SimicsOpenBoardPkg/BoardX58Ich10: " Chiu, Chasel
2019-10-31 1:39 ` [edk2-devel] " Nate DeSimone
2019-10-31 6:12 ` Kubacki, Michael A
2019-10-31 5:49 ` Kubacki, Michael A [this message]
2019-10-31 10:22 ` [edk2-platforms: PATCH v2 0/6] " Chiu, Chasel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR11MB38312976DC14EB0B32096FFDB5630@BYAPR11MB3831.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox