From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mx.groups.io with SMTP id smtpd.web10.2280.1572500995331429466 for ; Wed, 30 Oct 2019 22:49:55 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=dSrOuI2M; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: michael.a.kubacki@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Oct 2019 22:49:54 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,250,1569308400"; d="scan'208";a="225578802" Received: from orsmsx107.amr.corp.intel.com ([10.22.240.5]) by fmsmga004.fm.intel.com with ESMTP; 30 Oct 2019 22:49:54 -0700 Received: from orsmsx116.amr.corp.intel.com (10.22.240.14) by ORSMSX107.amr.corp.intel.com (10.22.240.5) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 30 Oct 2019 22:49:53 -0700 Received: from ORSEDG001.ED.cps.intel.com (10.7.248.4) by ORSMSX116.amr.corp.intel.com (10.22.240.14) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 30 Oct 2019 22:49:53 -0700 Received: from NAM05-DM3-obe.outbound.protection.outlook.com (104.47.49.55) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 30 Oct 2019 22:49:53 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lEt1TDHcbQZhz/U32h4oQe/iNmTMx+e+nBC1riHwfmK1+vCe7i5/nqYJXzgkntepQmwPYTz4xe+diWUJEGipeQWYbc0Ac6kEIJmWZSkrnHbP0lnpT9emBHoiu/6wOQ6ylC3fHlboZYvnGvzElDUUZpO9B+TQJAqsm4024CqTqMASlY7J6VBvKcPnIhccdExXa2iiKaBF/2Ur0J2Zx2grHL7jd6LQPyXd2cCr64GEfxtWxECcnLm9OmHQXF+e8x3sVRJNSKabLkc11i0UuQPDOv2s6UTRazTsnyVjgGMuopIf67Xg6pM8HIFwt3mYnbdZNVsakwuPuIr512gY4Lnlrw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Jg8Jg84FwUAx6Bh5kvyHWiC7BbQJjSqzNZd9rZA4XL8=; b=A+JzvcQlytEIYiMTuzrn0n0tiIlg2gXOD0+TJUtAN1aUc6A67WbZLQHnU33noo6hN1fnz12IxvfwCaJ2JBiPB4qmRWxweZ7DjC1/LKNspVA/ktqoqHjsj+PSo32+OdS/QNdj7komR0b6D0IEF47X3zVF31thhKto5VNxh5SF31C7vI6FjJ5x8KZxp5xtB4jYMneQTyTRtGseEWygYe3KcUn4bOuRgcUOBBy8+gpqu/vI/0hXYS8JDHJG+82n3g1pLLIHfEZb05ksfDVeqdEVlGohwvV3ylpvYP1EadXbkTkKpdylpwKqPjcoXc1GA0Aghpe+yv4emb2QdNpne1dc9A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Jg8Jg84FwUAx6Bh5kvyHWiC7BbQJjSqzNZd9rZA4XL8=; b=dSrOuI2MFfydj6x/MeHR6TT41DABHCsOh5hMEvkxvw11UTua4h9Lx0byIPp98eCxc54Lf3GNhlSdvERx/gh43SI9YvrXrBbJb6ZIOahMpfJne0YAu/xAOTU3WjsM7bjpOpgy5yRPaN05N//fOmlSyv5v0H7p/ZDrLoAQcRBG68o= Received: from BYAPR11MB3831.namprd11.prod.outlook.com (20.178.239.150) by BYAPR11MB3815.namprd11.prod.outlook.com (20.178.238.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2387.24; Thu, 31 Oct 2019 05:49:51 +0000 Received: from BYAPR11MB3831.namprd11.prod.outlook.com ([fe80::1d66:1307:6b66:a78f]) by BYAPR11MB3831.namprd11.prod.outlook.com ([fe80::1d66:1307:6b66:a78f%5]) with mapi id 15.20.2387.028; Thu, 31 Oct 2019 05:49:51 +0000 From: "Kubacki, Michael A" To: "Chiu, Chasel" , "devel@edk2.groups.io" CC: "Desimone, Nathaniel L" , "Gao, Liming" , Jeremy Soller , "Lu, Shifei A" , "Zhou, Bowen" , "Oram, Isaac W" , "Wei, David Y" , "Agyeman, Prince" Subject: Re: [edk2-platforms: PATCH v2 0/6] Add SetCacheLib library class. Thread-Topic: [edk2-platforms: PATCH v2 0/6] Add SetCacheLib library class. Thread-Index: AQHVj4J4JN0hj/jg10myDjoIdBi2q6d0Pdgg Date: Thu, 31 Oct 2019 05:49:50 +0000 Message-ID: References: <20191031002952.3860-1-chasel.chiu@intel.com> In-Reply-To: <20191031002952.3860-1-chasel.chiu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiY2FiY2Q1MDgtOTBiMy00NWI2LWFjYjgtMGFmM2MxMmNiMmMwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoibEJLNDVrdHRkQ1ljU0lXWEkyTVhRMWFiaXhXNGg2Y3krcHpwbjErUEl4TlBuMWJlUjhONkpGR0dQNWozMEhmSSJ9 dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: spf=none (sender IP is ) smtp.mailfrom=michael.a.kubacki@intel.com; x-originating-ip: [134.134.136.217] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 61dd7ee9-e551-48be-fe7d-08d75dc6259a x-ms-traffictypediagnostic: BYAPR11MB3815: x-ms-exchange-purlcount: 1 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5516; x-forefront-prvs: 02070414A1 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(39860400002)(366004)(136003)(396003)(376002)(346002)(13464003)(189003)(199004)(55016002)(4326008)(966005)(110136005)(9686003)(66066001)(2501003)(6436002)(54906003)(316002)(8676002)(2906002)(99286004)(52536014)(33656002)(25786009)(81166006)(81156014)(478600001)(14454004)(86362001)(6306002)(8936002)(256004)(14444005)(6116002)(305945005)(3846002)(102836004)(66556008)(66946007)(76116006)(71190400001)(6246003)(7696005)(64756008)(53546011)(76176011)(66476007)(74316002)(6506007)(71200400001)(11346002)(486006)(5660300002)(446003)(476003)(186003)(7736002)(66446008)(107886003)(26005)(229853002);DIR:OUT;SFP:1102;SCL:1;SRVR:BYAPR11MB3815;H:BYAPR11MB3831.namprd11.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ENbS2hKoQQ8bxvGVHnk/zOHEYaKzQjCoqRSmx8XRHkbO4omgizV160DP97xIqQfK6/wG2btDnBp1I5eU7EZNNFCxG757xPbd936zLfirGFRE/qz9JXuxkpwgSt5LHcW5bg4HZw3vReh+t80WGpxhhaPJbsU4c6SlfGfIngcQYBgBXVUM2tGWIUxhoH7NETVqToq4JIRobqwjl5r+FEo4ru6sZMdFU+HNoB32T0xP+GZwZuuk+J/mplDHjN/F6545y6S+UdnezypHzFJ5SG/E8WAm4aHxi54mFYBwniaoU2m7jBtlscH8U8fm0ORppUZLxrmDBXkYrVGQUDlr/Tf3QK8vdNFeNxGUjVnPvHACPhyHU2UlYyKyb5G4ArPhK9Xk+TxUM3k3+Tuz5hfncAxjUfESNvGLmB05GstiDuuSLKQ3F99h4zQfcyGGTUex6PytGFy/qUHIwEBlxcVWEQcL41CiuQFyQbIQWHb5bcIZaZk= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 61dd7ee9-e551-48be-fe7d-08d75dc6259a X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Oct 2019 05:49:50.9668 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: AQ2JFR8H/UNWoQC1xaOOkp5++QVrIL3AFQBd4yF0wE7gOaojJwOXDTG34a5mFjGKaisFIHyX+04DhBPsH9VXSSatDb+2ajaFcVp3Opf/eas= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3815 Return-Path: michael.a.kubacki@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Chasel, I don't think SetCacheLib is quite precise enough. Can you please consider an alternative such as SetMtrrLib? Thanks, Michael > -----Original Message----- > From: Chiu, Chasel > Sent: Wednesday, October 30, 2019 5:30 PM > To: devel@edk2.groups.io > Cc: Kubacki, Michael A ; Desimone, Nathaniel > L ; Gao, Liming ; > Jeremy Soller ; Lu, Shifei A > ; Zhou, Bowen ; Oram, > Isaac W ; Wei, David Y ; > Agyeman, Prince > Subject: [edk2-platforms: PATCH v2 0/6] Add SetCacheLib library class. >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2314 >=20 > The MTRRs may be redundantly or incorrectly configured. > It is recommended to move this functionality to a library class that with= a > NULL library by default. The board package may provide its own library > implementation. > MinPlatformPkg should contain the library class header (API) and the NULL > library class instance. >=20 > Cc: Michael Kubacki > Cc: Nate DeSimone > Cc: Liming Gao > Cc: Jeremy Soller > Cc: Shifei A Lu > Cc: Xiaohu Zhou > Cc: Isaac W Oram > Cc: Wei David Y > Cc: Agyeman Prince > Signed-off-by: Chasel Chiu >=20 > Chasel Chiu (6): > MinPlatformPkg: Add SetCacheLib library class. > MinPlatformPkg: Add SetCacheLib library class. > KabylakeOpenBoardPkg: Add SetCacheLib library class. > WhiskeylakeOpenBoardPkg: Add SetCacheLib library class. > PurleyOpenBoardPkg/BoardMtOlympus: Add SetCacheLib library class. > SimicsOpenBoardPkg/BoardX58Ich10: Add SetCacheLib library class. >=20 >=20 > Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Override/Platform/Intel > /MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreMem.c | 640 > -------------------------------------------------------------------------= --------------------- > -------------------------------------------------------------------------= --------------------- > -------------------------------------------------------------------------= --------------------- > -------------------------------------------------------------------------= --------------------- > -------------------------------------------------------------------------= --------------------- > -------------------------------------------------------------------------= --------------------- > -------------------------------------------------------------------------= --- > Platform/Intel/MinPlatformPkg/Library/SetCacheLib/SetCacheLib.c > | 325 > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > +++++++++++++++++++++++++++++++++++ > Platform/Intel/MinPlatformPkg/Library/SetCacheLib/SetCacheLibNull.c > | 37 +++++++++++++++++++++++++++++++++++++ >=20 > Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPo= s > tMem.c | 149 +--= --------------------------------------- > -------------------------------------------------------------------------= --------------------- > ------------- >=20 > Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPr= e > Mem.c | 164 ++-= --------------------------------------- > -------------------------------------------------------------------------= --------------------- > ---------------------------- > Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc > | 3 ++- > Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.fdf > | 2 +- >=20 > Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Override/Platform/Intel > /MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreMem.inf | 67 > ------------------------------------------------------------------- > Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc > | 1 + > Platform/Intel/MinPlatformPkg/Include/Library/SetCacheLib.h > | 34 ++++++++++++++++++++++++++++++++++ > Platform/Intel/MinPlatformPkg/Library/SetCacheLib/SetCacheLib.inf > | 44 ++++++++++++++++++++++++++++++++++++++++++++ > Platform/Intel/MinPlatformPkg/Library/SetCacheLib/SetCacheLibNull.inf > | 30 ++++++++++++++++++++++++++++++ >=20 > Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPo= s > tMem.inf | 11 +--= -------- >=20 > Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPr= e > Mem.inf | 7 ++-= ---- > Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/PlatformPkg.dsc > | 3 ++- > Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc > | 1 + >=20 > Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPk > g.dsc |= 1 + > 17 files changed, 484 insertions(+), 1035 deletions(-) delete mode 1006= 44 > Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Override/Platform/Intel > /MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreMem.c > create mode 100644 > Platform/Intel/MinPlatformPkg/Library/SetCacheLib/SetCacheLib.c > create mode 100644 > Platform/Intel/MinPlatformPkg/Library/SetCacheLib/SetCacheLibNull.c > delete mode 100644 > Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Override/Platform/Intel > /MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreMem.inf > create mode 100644 > Platform/Intel/MinPlatformPkg/Include/Library/SetCacheLib.h > create mode 100644 > Platform/Intel/MinPlatformPkg/Library/SetCacheLib/SetCacheLib.inf > create mode 100644 > Platform/Intel/MinPlatformPkg/Library/SetCacheLib/SetCacheLibNull.inf >=20 > -- > 2.13.3.windows.1