From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mx.groups.io with SMTP id smtpd.web11.2751.1572505851480727493 for ; Thu, 31 Oct 2019 00:10:51 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=b0Wlovtn; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: michael.a.kubacki@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 31 Oct 2019 00:10:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,250,1569308400"; d="scan'208";a="190532584" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga007.jf.intel.com with ESMTP; 31 Oct 2019 00:10:50 -0700 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 31 Oct 2019 00:10:50 -0700 Received: from NAM05-CO1-obe.outbound.protection.outlook.com (104.47.48.50) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 31 Oct 2019 00:10:50 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=N7X8crYTjOJgHBWEAlmOSI01mlFrEI0wcTk6TipSVV1OCqhGx3PqxwGkO5B7I64ZmEwhK5llAKJrsMkmktebqebvhXPzpuWqM0T6aE8OBBuk9dnPaxWODh1c50oNig+5Iw1H13PhiMjIpd/6xWBxenPXMBIATdsIrTlLzB4tm5HeL4YUsdqG5pTRhbZ41a8het8692fgTCdvJtK2yXY5L2KN1JeOvWLuWjR0oQ3vCIeSA8IOFWU/QF/U/uzyWNa7PRNLqXq1KZ23u6Mtc1lrKiOUmt5C+gw4tXApQ7I0C9WyL/BtsymhVRzrgVSl9vvNGpKSj/0ALo7A+PX+3x913A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=x6xlqG1W0ukFkL6UbZbwlbqIQ9rLyNsdIgYGNkZMEro=; b=PmHzPAE1GvbWUGwFx848bNARM5O07LU5P+QvR5sv+2iHA0c71/vWjjuYpbRZXbmy98uN9j738ZMTRCcYgFXeOXRn+nSfW0qmamc/19PmxNtR4IeWUadPZFdRt+uFNVfbOpxB2TpOPJx60oNilJe4nxNuY5Aeeqjt9REXmbXzqvonuH/fNRDa3RcrPx0kei2xMqezEx8i5fs0/fOswCep2hppA0RZDtnputU++Dh5KR7fiFfycQxKP3IPw0jUTWhCUqKP6WfnoQC+Cnvs1I1Bl/c9cPBNTsRBvxXZh+cOPlylul7TITQzYEvMRvZRoVPQ0gB7N/N/H61N4YUXFaY6MA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=x6xlqG1W0ukFkL6UbZbwlbqIQ9rLyNsdIgYGNkZMEro=; b=b0WlovtnQE6BHOcjbhB/4jfWRuXSYd8uPgdbFGTnROvg/IUti6RnnzLheO+uIz6majdDdLg/ikp65uC794JDSUuRxvE/CYBt+A9Tsejx2HBJb+efjJFRHfxUvxWkfpn7nKggbzHJrv/238p2yyYuF9TGs4zXdpeMeTEI0xlRY/c= Received: from BYAPR11MB3831.namprd11.prod.outlook.com (20.178.239.150) by BYAPR11MB2886.namprd11.prod.outlook.com (20.177.227.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2408.17; Thu, 31 Oct 2019 07:10:32 +0000 Received: from BYAPR11MB3831.namprd11.prod.outlook.com ([fe80::1d66:1307:6b66:a78f]) by BYAPR11MB3831.namprd11.prod.outlook.com ([fe80::1d66:1307:6b66:a78f%5]) with mapi id 15.20.2387.028; Thu, 31 Oct 2019 07:10:32 +0000 From: "Kubacki, Michael A" To: "Agyeman, Prince" , "devel@edk2.groups.io" CC: "Sinha, Ankit" , "Desimone, Nathaniel L" Subject: Re: [edk2-platforms] [PATCH] SimicsOpenBoardPkg: Fix gcc build failure Thread-Topic: [edk2-platforms] [PATCH] SimicsOpenBoardPkg: Fix gcc build failure Thread-Index: AQHVj0QsS8YkexvhEEGKkVzbHY55Kad0VV2Q Date: Thu, 31 Oct 2019 07:10:32 +0000 Message-ID: References: <20191030170436.16708-1-prince.agyeman@intel.com> In-Reply-To: <20191030170436.16708-1-prince.agyeman@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOTFjMmQ1NzYtNTQwNi00OWU0LTljMDAtYzgxMTM0MjAxMWVkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiTjVoRGtwbjhiMm5ReUFoY0FreXFBWnlsQmQxdzhDUGtUQk9kNnRTcUhLUm5DQ2ZiTDArSXBCcVRmSmpacEYrTCJ9 dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: spf=none (sender IP is ) smtp.mailfrom=michael.a.kubacki@intel.com; x-originating-ip: [134.134.136.217] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 820c4195-6aa4-40b5-ef11-08d75dd16b30 x-ms-traffictypediagnostic: BYAPR11MB2886: x-ms-exchange-purlcount: 1 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6108; x-forefront-prvs: 02070414A1 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(396003)(136003)(376002)(39860400002)(366004)(346002)(189003)(199004)(13464003)(14454004)(6506007)(33656002)(2501003)(11346002)(229853002)(6436002)(3846002)(8676002)(6246003)(7696005)(4326008)(76176011)(81166006)(99286004)(81156014)(9686003)(6116002)(26005)(186003)(102836004)(6306002)(55016002)(2906002)(486006)(476003)(446003)(107886003)(25786009)(8936002)(966005)(53546011)(74316002)(478600001)(71200400001)(316002)(305945005)(66556008)(54906003)(14444005)(66066001)(86362001)(256004)(110136005)(52536014)(66476007)(66446008)(66946007)(5660300002)(76116006)(7736002)(64756008)(71190400001);DIR:OUT;SFP:1102;SCL:1;SRVR:BYAPR11MB2886;H:BYAPR11MB3831.namprd11.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:3;A:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: /wzO/SZfEegctmcB9GUELvUUr4OCjJ47nELBOhWXjmJxuI7ZUYsqwkxXVf3L7uL/EAU4dbYVORI/xLMn8jcz+58BaADoTS+Il4dgG0CgBFovmvVgWpR7htryO8WNevutPHqLwURE5WLDx3ugdw2ONh2VoLPoBEOSRqmcNhHI0N8V0IdMujhtqQIiGQoLE0l0gyW5+FFk1B43+OwNPnFHj9YgyXdZ6g0KhTtnDuSzZRHS6Fd5N4eFyiiTeekTYBQEIPf7y0i6sl5h8Ln12oBFnLn8GXEa9xZt778ChonhNpUzOzPhC9lyfuvhGxzmP4e8Pww3miUla46imnNJ8XWTEayPO41Lp+fPm6Vz+SF0bAxFyu7zUJWs/KRFnWgUyly9OTfbuLPTqkH4rH89ZKkjN4rTyBWU1lojH8eu5L8jqdU7WErOsIW9uRRUqaYrabK+X0cOu/NMgoY4QfR8WkVGL6i1J4oZN5v684NUnC8IeFs= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 820c4195-6aa4-40b5-ef11-08d75dd16b30 X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Oct 2019 07:10:32.2122 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: jHQmEtyugr+4I31VcrFCVhe9Fzv4TccF8PWZtqvFRWhW75CyF73+MJOJlOXhbJZLYjBEstOfP6ou+1fGtMdkfOpFv6zJyjRPbaIulY0WdsE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB2886 Return-Path: michael.a.kubacki@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Please check whitespace and formatting in the future. I agree with Nate that it can be fixed when pushed but there's quite a few errors here. Reviewed-by: Michael Kubacki > -----Original Message----- > From: Agyeman, Prince > Sent: Wednesday, October 30, 2019 10:05 AM > To: devel@edk2.groups.io > Cc: Sinha, Ankit ; Desimone, Nathaniel L > ; Kubacki, Michael A > > Subject: [edk2-platforms] [PATCH] SimicsOpenBoardPkg: Fix gcc build failu= re >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2225 >=20 > Currently, gcc 5 encounters an error "unused-but-set-variable" in > BdsPlatform.c as a result of a Status variable not being used after it's= set. >=20 > This was fixed by printing the Status variable when > EfiBootManagerDeleteLoadOptionVariable function encounters an error >=20 > Cc: Ankit Sinha > Cc: Nate DeSimone > Cc: Kubacki Michael A >=20 > Signed-off-by: Prince Agyeman > --- > .../Library/PlatformBootManagerLib/BdsPlatform.c | 4 ++++ > 1 file changed, 4 insertions(+) >=20 > diff --git > a/Platform/Intel/SimicsOpenBoardPkg/Library/PlatformBootManagerLib/Bds > Platform.c > b/Platform/Intel/SimicsOpenBoardPkg/Library/PlatformBootManagerLib/Bd > sPlatform.c > index 7aa3860f75..a4b010be63 100644 > --- > a/Platform/Intel/SimicsOpenBoardPkg/Library/PlatformBootManagerLib/Bds > Platform.c > +++ > b/Platform/Intel/SimicsOpenBoardPkg/Library/PlatformBootManagerLib/B > +++ dsPlatform.c > @@ -348,6 +348,10 @@ PlatformBootManagerBeforeConsole ( > NvBootOptions =3D EfiBootManagerGetLoadOptions (&NvBootOptionCount, > LoadOptionTypeBoot); > for (Index =3D 0; Index < NvBootOptionCount; Index++) { > Status =3D EfiBootManagerDeleteLoadOptionVariable > (NvBootOptions[Index].OptionNumber, LoadOptionTypeBoot); > + if(EFI_ERROR (Status)){ > + DEBUG ((DEBUG_ERROR, > + "%a: removing Boot#%04x %r\n", __FUNCTION__, > (UINT32)NvBootOptions[Index].OptionNumber, Status)); > + } > } >=20 > InstallDevicePathCallback (); > -- > 2.19.1.windows.1