Subject: Re: [edk2-devel] Conditionally Include FDF File External email: Use caution opening links or attachments I saw this issue too. The included file is always included no matter the condition is TRUE or F= ALSE. ``` !if FALSE =20 !include abc.fdf !endif ``` -------------------------------------------------------------------------= ---------- This email message is for the sole use of the intended recipient(s) and m= ay contain confidential information. Any unauthorized review, use, disclosure or di= stribution is prohibited. If you are not the intended recipient, please contact the= =20sender by reply email and destroy all copies of the original message. -------------------------------------------------------------------------= ---------- --_000_BYAPR12MB272627241ED20FC05BDFB9BEBAD40BYAPR12MB2726namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

It seems like this is happening because in FdfParser.py, include files ar= e processed before processing the conditional statements. I think this is= =20being done so that all defines (even from the included files) can be a= ccounted for before processing any conditionals. =20This seems to be a valid flow from pre-processing perspective, althoug= h this leaves out the use case where a file may be conditionally included= .

Bob/Liming,

For now, I have fixed the issue by changing my conditional include to be = the following:

In top-level FDF:

!ifdef $(

In top-level DSC:

!ifdef $(BUILD_PLATFORM_= XYZ)

INCLUDE_XYZ_FDF =3D !include Platform/NVIDIA/XYZ.fdf.inc

!endif

Please suggest me if there is a batter way of working around this issue.<= /div>

Thanks

Ashish

From: Lin, Derek (HPS S= W) <derek.lin2@hpe.com>
Sent: Monday, April 20, 2020 12:16 AM
To: Ashish Singhal <ashishsingha@nvidia.com>; devel@edk2.gro= ups.io <devel@edk2.groups.io>
Subject: Re: [edk2-devel] Conditionally Include FDF File

External email: = Use caution opening links or attachments

I saw this issue too.

The included file is always included no matter the condition is TRUE or F= ALSE.
```
!if FALSE

!include abc.fdf

!endif
```

This email message is for the sole use of the intended recipient(s) = and may=20 contain confidential information. Any unauthorized review, use, dis= closure=20 or distribution is prohibited. If you are not the intended recipien= t,=20 please contact the sender by reply email and destroy all copies of the or= iginal=20 message.

--_000_BYAPR12MB272627241ED20FC05BDFB9BEBAD40BYAPR12MB2726namp_--