public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ashish Singhal" <ashishsingha@nvidia.com>
To: Laszlo Ersek <lersek@redhat.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>,
	Bob Feng <bob.c.feng@intel.com>,
	"Gao, Liming" <liming.gao@intel.com>
Subject: Re: [edk2-devel] Conditionally Include FDF File
Date: Mon, 20 Apr 2020 16:33:53 +0000	[thread overview]
Message-ID: <BYAPR12MB27268481B6EAB086BA5E6943BAD40@BYAPR12MB2726.namprd12.prod.outlook.com> (raw)
In-Reply-To: <6f7df46f-1595-a81a-001f-27e002ba9a9f@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 1726 bytes --]

That is not the same use case. You are always including NetworkPkg/Network.fdf.inc and then inside of it you are using NETWORK_ENABLE flag to include the associated drivers or not include anything at all but the file exists. My use case differs where the file may not exist and that is why I have a conditional flag outside the include directive.

Thanks
Ashish
________________________________
From: Laszlo Ersek <lersek@redhat.com>
Sent: Monday, April 20, 2020 6:05 AM
To: devel@edk2.groups.io <devel@edk2.groups.io>; Ashish Singhal <ashishsingha@nvidia.com>; Bob Feng <bob.c.feng@intel.com>; Gao, Liming <liming.gao@intel.com>
Subject: Re: [edk2-devel] Conditionally Include FDF File

External email: Use caution opening links or attachments


On 04/20/20 07:25, Ashish Singhal wrote:

> I am trying to change my top-level FDF file layout by conditionally including an FDF depending on a build time define being passed or not.

> Any help getting around this

Try including unconditionally, and pushing down the !if into the includee.

This is known to work; see for example "NetworkPkg/Network.fdf.inc".

(The outermost "NETWORK_ENABLE" flag in "Network.fdf.inc" parallels your
use case.)

Thanks
Laszlo


-----------------------------------------------------------------------------------
This email message is for the sole use of the intended recipient(s) and may contain
confidential information.  Any unauthorized review, use, disclosure or distribution
is prohibited.  If you are not the intended recipient, please contact the sender by
reply email and destroy all copies of the original message.
-----------------------------------------------------------------------------------

[-- Attachment #2: Type: text/html, Size: 5046 bytes --]

      reply	other threads:[~2020-04-20 16:34 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-20  5:25 Conditionally Include FDF File Ashish Singhal
2020-04-20  6:16 ` [edk2-devel] " Lin, Derek (HPS SW)
2020-04-20  7:07   ` Ashish Singhal
2020-04-20  7:42     ` Ashish Singhal
2020-04-20 12:05 ` Laszlo Ersek
2020-04-20 16:33   ` Ashish Singhal [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BYAPR12MB27268481B6EAB086BA5E6943BAD40@BYAPR12MB2726.namprd12.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox