From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from nat-hk.nvidia.com (nat-hk.nvidia.com [203.18.50.4])
 by mx.groups.io with SMTP id smtpd.web10.5857.1587400439760455702
 for <devel@edk2.groups.io>;
 Mon, 20 Apr 2020 09:34:00 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@nvidia.com header.s=n1 header.b=ASCe/Uno;
 spf=pass (domain: nvidia.com, ip: 203.18.50.4, mailfrom: ashishsingha@nvidia.com)
Received: from hkpgpgate101.nvidia.com (Not Verified[10.18.92.100]) by nat-hk.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA)
	id <B5e9dcef50000>; Tue, 21 Apr 2020 00:33:57 +0800
Received: from HKMAIL102.nvidia.com ([10.18.16.11])
  by hkpgpgate101.nvidia.com (PGP Universal service);
  Mon, 20 Apr 2020 09:33:57 -0700
X-PGP-Universal: processed;
	by hkpgpgate101.nvidia.com on Mon, 20 Apr 2020 09:33:57 -0700
Received: from HKMAIL102.nvidia.com (10.18.16.11) by HKMAIL102.nvidia.com
 (10.18.16.11) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 20 Apr
 2020 16:33:56 +0000
Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.102)
 by HKMAIL102.nvidia.com (10.18.16.11) with Microsoft SMTP Server (TLS) id
 15.0.1473.3 via Frontend Transport; Mon, 20 Apr 2020 16:33:56 +0000
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=A6UnuIOKXcYyWzRzceaE+go3fhA/1E8l/od2w0uSYtp2eSTMzG0lkgV7IadO2hu5mcPOp2iUgcMunX3Q2y69bsSXmAijBVVBpnqnCOm3IhttZZN8s2zFOdS1rP69pxFtX8RX5qcTkf96jTCrRN9mJ5peKQq2k02V7DJxQTWMb009j1nhqAmf4r+kUIWdwn9aSSTKt7X59Q0rrohOVjBuf+pYu6pCKC3dE74PDxgmEDg/xobfMT9hxdEF2kpZPplP5y7a2gBKRtxhSXD2DiqrkDZ9qNFWNb/cKYCI20uuZ8bCHUUcA8EfTKqnYi2yyPSdbtcCuA2I+eylxi7VQ9YYvA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Y9wCMMvlmDAc/pHgI/bIwSI0wW2SV98FzFBatxaURzw=;
 b=Fympdttwmdy4k4Gkbrbn5Tvc4QkHicX6EYljUPQ2IYR4jUVtKTKQMoLjcnH7rZJ+jZaDDm13f2AadfUCBmHJ+bpgNnPhDusqa7hiceCUb9d/dGLs75VKNWrNMS0d4CfSDmAesKAY5mQSM42n+muKjjBi/hYwShesDPvIWTmsXOyGJEWi+TzLJElKrN0vlKemFw80j21kMJdeuztZ2e9d66mRuAjgl8SsT4v0W0gkDC/PriqJAVRoY8frBUmrjw6K9FK2k4BwRrfKU/kVkf3BQR4oXWgOX8bsuqZyl5QbvYj5NwjL7erj//y1Wwnd2axwldPcrj16ieqU9gD/DP0tRg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com;
 dkim=pass header.d=nvidia.com; arc=none
Received: from BYAPR12MB2726.namprd12.prod.outlook.com (2603:10b6:a03:66::17)
 by BYAPR12MB2903.namprd12.prod.outlook.com (2603:10b6:a03:139::22) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2921.25; Mon, 20 Apr
 2020 16:33:54 +0000
Received: from BYAPR12MB2726.namprd12.prod.outlook.com
 ([fe80::61e1:6a43:d8b:f7a4]) by BYAPR12MB2726.namprd12.prod.outlook.com
 ([fe80::61e1:6a43:d8b:f7a4%6]) with mapi id 15.20.2921.027; Mon, 20 Apr 2020
 16:33:54 +0000
From: "Ashish Singhal" <ashishsingha@nvidia.com>
To: Laszlo Ersek <lersek@redhat.com>, "devel@edk2.groups.io"
	<devel@edk2.groups.io>, Bob Feng <bob.c.feng@intel.com>, "Gao, Liming"
	<liming.gao@intel.com>
Subject: Re: [edk2-devel] Conditionally Include FDF File
Thread-Topic: [edk2-devel] Conditionally Include FDF File
Thread-Index: AQHWFtKZxMAU2rFjGkuX7RWe3+BlnKiB6nIAgABKUgE=
Date: Mon, 20 Apr 2020 16:33:53 +0000
Message-ID: <BYAPR12MB27268481B6EAB086BA5E6943BAD40@BYAPR12MB2726.namprd12.prod.outlook.com>
References: <BYAPR12MB2726D3CF9D89A277FBF8EDF9BAD40@BYAPR12MB2726.namprd12.prod.outlook.com>,<6f7df46f-1595-a81a-001f-27e002ba9a9f@redhat.com>
In-Reply-To: <6f7df46f-1595-a81a-001f-27e002ba9a9f@redhat.com>
Accept-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
authentication-results: spf=none (sender IP is )
 smtp.mailfrom=ashishsingha@nvidia.com; 
x-originating-ip: [216.228.112.22]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 9f5f23ac-7d6a-4248-8d66-08d7e5489d94
x-ms-traffictypediagnostic: BYAPR12MB2903:
x-microsoft-antispam-prvs: <BYAPR12MB29035598B8808B4F49318525BAD40@BYAPR12MB2903.namprd12.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:6790;
x-forefront-prvs: 03793408BA
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR12MB2726.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(10009020)(39860400002)(346002)(136003)(366004)(396003)(376002)(19627405001)(76116006)(7696005)(186003)(55016002)(9686003)(478600001)(33656002)(5660300002)(86362001)(52536014)(8936002)(2906002)(53546011)(6506007)(66946007)(64756008)(66556008)(8676002)(71200400001)(66446008)(110136005)(26005)(316002)(81156014)(66476007);DIR:OUT;SFP:1101;
received-spf: None (protection.outlook.com: nvidia.com does not designate
 permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: EI2IQdXAVi0VbCSQnW1/Q22okazLTZUEn8MoNx8X/7A7hdI/id0eL5e4kBkKtk9euNYXLZAdGzGJPJ94ntStWNjXeUnPAiBixP+nMziUsMy3pZyOTwzYslUsfvGEOWdRMP8bYBItZQlDwKf+8cc+zrstqA2WZkPCR+xE274AHdEyYhKRLw8IubiU9eMDhOdvVn7kcc+UoQGP3xtE79/tKvr4Je/B6WTfy63m/wWeHJx7vakZhrWNXSbrh9+S6lZN/2HO8IgGjMpNWXkoWyEhuiXTpjvhgVvVFrPUAGBbHwG7a3BbkS/SAySZN7BnO4bVfxWobSXrF3eUZuEd1To51yY5Sd9U7YZ7WPH0JGNGaRPyji6it9+ARjtHcl8qMpVBOzQr52AURg+WUTxwjUGIItzo7aRkbYATbnmxugQw+LtBELdneRNcxX6lQRawI4eE
x-ms-exchange-antispam-messagedata: f1QEnYpDDVKVQYFaZZX2IIdCbP03xG6MCaa5Ojd3Eb6tYUVyAfkSEmdIdPwxfKMn0R+dRKyMyGS/tYrdZ7NriCuK5pCIVzuQv9nTIREAcXwIbRgJhjgPFrufKHn4IU9r5Fo4DiOoaxnJYvIDdBp6gw==
x-ms-exchange-transport-forked: True
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 9f5f23ac-7d6a-4248-8d66-08d7e5489d94
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Apr 2020 16:33:53.9769
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: xzCzZbWV6dvWP2VlIMOHo7M3JVSZ8hWbXUDiuudp1Y0/PhxyTr3D0Kmhw3WSSm+qst9SixEULM2K33u8eb9Nkw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR12MB2903
Return-Path: ashishsingha@nvidia.com
X-OriginatorOrg: Nvidia.com
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1;
	t=1587400437; bh=8LmBKeFkDjp51HJJVklXCc8korW5m6zbrjifNdhxjdU=;
	h=X-PGP-Universal:ARC-Seal:ARC-Message-Signature:
	 ARC-Authentication-Results:From:To:Subject:Thread-Topic:
	 Thread-Index:Date:Message-ID:References:In-Reply-To:
	 Accept-Language:X-MS-Has-Attach:X-MS-TNEF-Correlator:
	 authentication-results:x-originating-ip:x-ms-publictraffictype:
	 x-ms-office365-filtering-correlation-id:x-ms-traffictypediagnostic:
	 x-microsoft-antispam-prvs:x-ms-oob-tlc-oobclassifiers:
	 x-forefront-prvs:x-forefront-antispam-report:received-spf:
	 x-ms-exchange-senderadcheck:x-microsoft-antispam:
	 x-microsoft-antispam-message-info:
	 x-ms-exchange-antispam-messagedata:x-ms-exchange-transport-forked:
	 MIME-Version:X-MS-Exchange-CrossTenant-Network-Message-Id:
	 X-MS-Exchange-CrossTenant-originalarrivaltime:
	 X-MS-Exchange-CrossTenant-fromentityheader:
	 X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype:
	 X-MS-Exchange-CrossTenant-userprincipalname:
	 X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg:
	 Content-Language:Content-Type;
	b=ASCe/UnoGGAS1mFHgj4HlvUsrHmy/Vd7uSh3OXsZUDoyER8BQcs/ZbCDPPSS+V2Tm
	 Obn9zwZKRqfBHkQnbhNPM4H0zZQ+WccdnuyhqXS8NgQrQNKfDFlr/txtUFaPHS3ar4
	 P7MInv794v5WgnuFra/F7QiKS2jd47H6q72RSDt7M8WcaGhOC1hHj7+0C+V44BiF+k
	 BZcWlLyO3m/Z+fx25DmjZ83tgS+j12arLiRbK4VGReiTwhkwgLRk+wC/NR5PNF8BV5
	 AgSSfyn+FANbmEqVogrpuGjCKlLLd8aTqWOtsgemKnQCWs1g53kJ63tm6rIVtMGBLs
	 WqGvde9l+W9uA==
Content-Language: en-US
Content-Type: multipart/alternative;
	boundary="_000_BYAPR12MB27268481B6EAB086BA5E6943BAD40BYAPR12MB2726namp_"

--_000_BYAPR12MB27268481B6EAB086BA5E6943BAD40BYAPR12MB2726namp_
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

That is not the same use case. You are always including NetworkPkg/Networ=
k.fdf.inc and then inside of it you are using NETWORK_ENABLE flag to incl=
ude the associated drivers or not include anything at all but the file ex=
ists. My use case differs where the file may not exist and that is why I =
have a conditional flag outside the include directive.

Thanks
Ashish
________________________________
From: Laszlo Ersek <lersek@redhat.com>
Sent: Monday, April 20, 2020 6:05 AM
To: devel@edk2.groups.io <devel@edk2.groups.io>; Ashish Singhal <ashishsi=
ngha@nvidia.com>; Bob Feng <bob.c.feng@intel.com>; Gao, Liming <liming.ga=
o@intel.com>
Subject: Re: [edk2-devel] Conditionally Include FDF File

External email: Use caution opening links or attachments


On 04/20/20 07:25, Ashish Singhal wrote:

> I am trying to change my top-level FDF file layout by conditionally inc=
luding an FDF depending on a build time define being passed or not.

> Any help getting around this

Try including unconditionally, and pushing down the !if into the includee=
.

This is known to work; see for example "NetworkPkg/Network.fdf.inc".

(The outermost "NETWORK_ENABLE" flag in "Network.fdf.inc" parallels your
use case.)

Thanks
Laszlo


-------------------------------------------------------------------------=
----------
This email message is for the sole use of the intended recipient(s) and m=
ay contain
confidential information.  Any unauthorized review, use, disclosure or di=
stribution
is prohibited.  If you are not the intended recipient, please contact the=
=20sender by
reply email and destroy all copies of the original message.
-------------------------------------------------------------------------=
----------

--_000_BYAPR12MB27268481B6EAB086BA5E6943BAD40BYAPR12MB2726namp_
Content-Type: text/html; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

<html>
<head>
<meta http-equiv=3D"Content-Type" content=3D"text/html; charset=3Dus-asci=
i">
<style type=3D"text/css" style=3D"display:none;"> P {margin-top:0;margin-=
bottom:0;} </style>
</head>
<body dir=3D"ltr">
<div style=3D"font-family: Calibri, Arial, Helvetica, sans-serif; font-si=
ze: 12pt; color: rgb(0, 0, 0);">
That is not the same use case. You are always including&nbsp;<span style=3D=
"font-family: &quot;Segoe UI&quot;, &quot;Segoe UI Web (West European)&qu=
ot;, &quot;Segoe UI&quot;, -apple-system, BlinkMacSystemFont, Roboto, &qu=
ot;Helvetica Neue&quot;, sans-serif; font-size: 14.6667px; background-col=
or: rgb(255, 255, 255); display: inline !important">NetworkPkg/Network.fd=
f.inc
=20and then inside of it you are using&nbsp;<span style=3D"font-family: &=
quot;Segoe UI&quot;, &quot;Segoe UI Web (West European)&quot;, &quot;Sego=
e UI&quot;, -apple-system, BlinkMacSystemFont, Roboto, &quot;Helvetica Ne=
ue&quot;, sans-serif; background-color: rgb(255, 255, 255); display: inli=
ne !important">NETWORK_ENABLE
=20flag to include the associated drivers or not include anything at all =
but the file exists. My use case differs where the file may not exist and=
=20that is why I have a conditional flag outside the include directive.</=
span></span></div>
<div style=3D"font-family: Calibri, Arial, Helvetica, sans-serif; font-si=
ze: 12pt; color: rgb(0, 0, 0);">
<span style=3D"font-family: &quot;Segoe UI&quot;, &quot;Segoe UI Web (Wes=
t European)&quot;, &quot;Segoe UI&quot;, -apple-system, BlinkMacSystemFon=
t, Roboto, &quot;Helvetica Neue&quot;, sans-serif; font-size: 14.6667px; =
background-color: rgb(255, 255, 255); display: inline !important"><span s=
tyle=3D"font-family: &quot;Segoe UI&quot;, &quot;Segoe UI Web (West Europ=
ean)&quot;, &quot;Segoe UI&quot;, -apple-system, BlinkMacSystemFont, Robo=
to, &quot;Helvetica Neue&quot;, sans-serif; background-color: rgb(255, 25=
5, 255); display: inline !important"><br>
</span></span></div>
<div style=3D"font-family: Calibri, Arial, Helvetica, sans-serif; font-si=
ze: 12pt; color: rgb(0, 0, 0);">
<span style=3D"font-family: &quot;Segoe UI&quot;, &quot;Segoe UI Web (Wes=
t European)&quot;, &quot;Segoe UI&quot;, -apple-system, BlinkMacSystemFon=
t, Roboto, &quot;Helvetica Neue&quot;, sans-serif; font-size: 14.6667px; =
background-color: rgb(255, 255, 255); display: inline !important"><span s=
tyle=3D"font-family: &quot;Segoe UI&quot;, &quot;Segoe UI Web (West Europ=
ean)&quot;, &quot;Segoe UI&quot;, -apple-system, BlinkMacSystemFont, Robo=
to, &quot;Helvetica Neue&quot;, sans-serif; background-color: rgb(255, 25=
5, 255); display: inline !important">Thanks</span></span></div>
<div style=3D"font-family: Calibri, Arial, Helvetica, sans-serif; font-si=
ze: 12pt; color: rgb(0, 0, 0);">
<span style=3D"font-family: &quot;Segoe UI&quot;, &quot;Segoe UI Web (Wes=
t European)&quot;, &quot;Segoe UI&quot;, -apple-system, BlinkMacSystemFon=
t, Roboto, &quot;Helvetica Neue&quot;, sans-serif; font-size: 14.6667px; =
background-color: rgb(255, 255, 255); display: inline !important"><span s=
tyle=3D"font-family: &quot;Segoe UI&quot;, &quot;Segoe UI Web (West Europ=
ean)&quot;, &quot;Segoe UI&quot;, -apple-system, BlinkMacSystemFont, Robo=
to, &quot;Helvetica Neue&quot;, sans-serif; background-color: rgb(255, 25=
5, 255); display: inline !important">Ashish</span></span></div>
<div id=3D"appendonsend"></div>
<hr style=3D"display:inline-block;width:98%" tabindex=3D"-1">
<div id=3D"divRplyFwdMsg" dir=3D"ltr"><font face=3D"Calibri, sans-serif" =
style=3D"font-size:11pt" color=3D"#000000"><b>From:</b> Laszlo Ersek &lt;=
lersek@redhat.com&gt;<br>
<b>Sent:</b> Monday, April 20, 2020 6:05 AM<br>
<b>To:</b> devel@edk2.groups.io &lt;devel@edk2.groups.io&gt;; Ashish Sing=
hal &lt;ashishsingha@nvidia.com&gt;; Bob Feng &lt;bob.c.feng@intel.com&gt=
;; Gao, Liming &lt;liming.gao@intel.com&gt;<br>
<b>Subject:</b> Re: [edk2-devel] Conditionally Include FDF File</font>
<div>&nbsp;</div>
</div>
<div class=3D"BodyFragment"><font size=3D"2"><span style=3D"font-size:11p=
t;">
<div class=3D"PlainText">External email: Use caution opening links or att=
achments<br>
<br>
<br>
On 04/20/20 07:25, Ashish Singhal wrote:<br>
<br>
&gt; I am trying to change my top-level FDF file layout by conditionally =
including an FDF depending on a build time define being passed or not.<br=
>
<br>
&gt; Any help getting around this<br>
<br>
Try including unconditionally, and pushing down the !if into the includee=
.<br>
<br>
This is known to work; see for example &quot;NetworkPkg/Network.fdf.inc&q=
uot;.<br>
<br>
(The outermost &quot;NETWORK_ENABLE&quot; flag in &quot;Network.fdf.inc&q=
uot; parallels your<br>
use case.)<br>
<br>
Thanks<br>
Laszlo<br>
<br>
</div>
</span></font></div>

<DIV>
<HR>
</DIV>
<DIV>This email message is for the sole use of the intended recipient(s) =
and may=20
contain confidential information.&nbsp; Any unauthorized review, use, dis=
closure=20
or distribution is prohibited.&nbsp; If you are not the intended recipien=
t,=20
please contact the sender by reply email and destroy all copies of the or=
iginal=20
message. </DIV>
<DIV>
<HR>
</DIV>
</body>
</html>

--_000_BYAPR12MB27268481B6EAB086BA5E6943BAD40BYAPR12MB2726namp_--