From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=203.18.50.4; helo=nat-hk.nvidia.com; envelope-from=ashishsingha@nvidia.com; receiver=edk2-devel@lists.01.org Received: from nat-hk.nvidia.com (nat-hk.nvidia.com [203.18.50.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id A356E211ADA58 for ; Mon, 7 Jan 2019 06:02:00 -0800 (PST) Received: from hkpgpgate102.nvidia.com (Not Verified[10.18.92.9]) by nat-hk.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Mon, 07 Jan 2019 22:01:56 +0800 Received: from HKMAIL103.nvidia.com ([10.18.16.12]) by hkpgpgate102.nvidia.com (PGP Universal service); Mon, 07 Jan 2019 06:01:56 -0800 X-PGP-Universal: processed; by hkpgpgate102.nvidia.com on Mon, 07 Jan 2019 06:01:56 -0800 Received: from HKMAIL101.nvidia.com (10.18.16.10) by HKMAIL103.nvidia.com (10.18.16.12) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Mon, 7 Jan 2019 14:01:55 +0000 Received: from NAM05-BY2-obe.outbound.protection.outlook.com (104.47.50.59) by HKMAIL101.nvidia.com (10.18.16.10) with Microsoft SMTP Server (TLS) id 15.0.1395.4 via Frontend Transport; Mon, 7 Jan 2019 14:01:54 +0000 Received: from BYAPR12MB2743.namprd12.prod.outlook.com (20.177.125.220) by BYAPR12MB2885.namprd12.prod.outlook.com (20.179.91.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1495.9; Mon, 7 Jan 2019 14:01:48 +0000 Received: from BYAPR12MB2743.namprd12.prod.outlook.com ([fe80::d51a:3dbb:3b90:178b]) by BYAPR12MB2743.namprd12.prod.outlook.com ([fe80::d51a:3dbb:3b90:178b%5]) with mapi id 15.20.1495.011; Mon, 7 Jan 2019 14:01:48 +0000 From: Ashish Singhal To: "edk2-devel@lists.01.org" , Michael D Kinney , Liming Gao , Siyuan Fu , Jiaxin Wu Thread-Topic: [PATCH v3 0/2] Provide UEFILib functions for protocol uninstallation. Thread-Index: AQHUpkKMUsqRLfZf6EqMNFFJsf+EAKWj1iqQ Date: Mon, 7 Jan 2019 14:01:47 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_Enabled=True; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_SiteId=43083d15-7273-40c1-b7db-39efd9ccc17a; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_Owner=ashishsingha@nvidia.com; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_SetDate=2019-01-07T14:01:47.1157771Z; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_Name=Unrestricted; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_Application=Microsoft Azure Information Protection; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_Extended_MSFT_Method=Automatic; Sensitivity=Unrestricted authentication-results: spf=none (sender IP is ) smtp.mailfrom=ashishsingha@nvidia.com; x-originating-ip: [8.46.90.104] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; BYAPR12MB2885; 6:l05CgB5YdDol5VwVDR/XC+W2jHa/A3hJPyPhQObdf9PqjPqsQgZnMHu6+/2yTlToLGZH/8l2/ESM6WDRzXoLbpAys7BUqKywcmiDn5DhKtWysVt/GTti1QjdmoiGGLdhryoqMQCESNKGcgmAdYFdTQHq2rMiENb/9dk0GV1jno1YTTktz7LntajrYJ/SKwixwug9J4xvNEAB7U/qAG2zPfmPMX4LwV3Gj1gSbAjlmeGogifM1voXubfxd18jvQZBR34WGpFM/8Qzvs72fhJi1RTRO3uebyXyaLfQIDDLsc/CeE4fcjMImHqwKHXvJOlxRNZWkxSQJgZf3OIOE+ay6ss7XvDclmPqiv9bhf6x5uqx1FaRr9rVzpgoC/pxOCiuLNiPzwzdyWv+REs194VvGykrnA/vhYhI3O1YNX8WsPCr+amAKYOx9OlzeYRZ3TaobCbR8vGWZG/Z4V6gGhIwXQ==; 5:dRx+0r8Cer4PQD/mUl8tk6jUYMHjNj7h76OsMX9fBJqovlBPnpJSFeueOQh2y34MqBnh3QILPTTfMJHwrqnbAavKE93iZ/UiDK0HXEaup4Ye5oECf8ZW+VvOQk+dWcGgZb8OChLVViFCn5oupWD2OjvtSBTnmYWF29NWASnRk8wbEyW2hITJV82p4pvCwjEKOJGU3JERG6MNTroRIX3EBQ==; 7:+7IGrjZRmxCI96zl13+B+64i47Y5zm0MJRnyXrTzZzU8pqGOUd1nlN4ItRuclTRkcZI4nykuoWz//lEfG4Ek1cUPwF1vwK7hi2frU7cA6aEQYItAejUcjc0LiviwrAH40V9bLKNiZjwqp5LMYutt2A== x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: aadc4aef-7988-4273-34c5-08d674a8aa73 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600109)(711020)(2017052603328)(7153060)(7193020); SRVR:BYAPR12MB2885; x-ms-traffictypediagnostic: BYAPR12MB2885: x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(3230021)(908002)(999002)(5005026)(6040522)(8220060)(2401047)(8121501046)(10201501046)(3231475)(944501520)(52105112)(3002001)(93006095)(93001095)(6041310)(20161123564045)(20161123562045)(20161123560045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(201708071742011)(7699051)(76991095); SRVR:BYAPR12MB2885; BCL:0; PCL:0; RULEID:; SRVR:BYAPR12MB2885; x-forefront-prvs: 0910AAF391 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(366004)(396003)(346002)(376002)(136003)(39850400004)(43544003)(199004)(189003)(13464003)(2906002)(305945005)(486006)(68736007)(7736002)(25786009)(97736004)(53936002)(9686003)(81156014)(446003)(11346002)(76176011)(186003)(26005)(8936002)(55016002)(6436002)(8676002)(476003)(81166006)(6506007)(102836004)(53546011)(7696005)(110136005)(316002)(86362001)(99286004)(71190400001)(106356001)(14454004)(478600001)(105586002)(33656002)(3846002)(6116002)(71200400001)(14444005)(229853002)(256004)(66066001)(6246003)(2501003)(74316002)(5660300001); DIR:OUT; SFP:1101; SCL:1; SRVR:BYAPR12MB2885; H:BYAPR12MB2743.namprd12.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: nvidia.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: 0QNKinMAgrsoBmLXbwg1IaaroUEHCmeMxgD1I2nBzEuUmNS6T9RVTILMmfaHVfvogqKyfAjSaiYcd6VgNmNOSbzc6AeOE2adFvonhdjOoRH4Ccb0+5n7hrKMJEFh/kPgxGkqNGUr9ViVrVJEEq6iVv+2yrhJ39InoFQQE1ndjg9PQtng+3OrSt358tmwCjG73XcvvZmzJgan24FI4qjOuVm6cV3aC4vaiPRRYQ9oA7JuPYV2jB1raF6i3+em5RYJeyxTMhHIDRq5WudDoH7+4wgJAI53g0B0bqiRKUNE8sSw0yobsSoeKIkXQsiMAf3t spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: aadc4aef-7988-4273-34c5-08d674a8aa73 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Jan 2019 14:01:48.0787 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR12MB2885 X-OriginatorOrg: Nvidia.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1546869716; bh=JstgR3KufipqmLiQyiDDHp2Fl+OWUfrMv5ucH1hJg4A=; h=X-PGP-Universal:From:To:Subject:Thread-Topic:Thread-Index:Date: Message-ID:References:In-Reply-To:Accept-Language:X-MS-Has-Attach: X-MS-TNEF-Correlator:msip_labels:authentication-results: x-originating-ip:x-ms-publictraffictype: x-microsoft-exchange-diagnostics: x-ms-exchange-antispam-srfa-diagnostics: x-ms-office365-filtering-correlation-id:x-microsoft-antispam: x-ms-traffictypediagnostic:x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test:x-forefront-prvs: x-forefront-antispam-report:received-spf: x-ms-exchange-senderadcheck:x-microsoft-antispam-message-info: spamdiagnosticoutput:spamdiagnosticmetadata:MIME-Version: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-originalarrivaltime: X-MS-Exchange-CrossTenant-fromentityheader: X-MS-Exchange-CrossTenant-id: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg: Content-Language:Content-Type:Content-Transfer-Encoding; b=FMi+z0pyPlcIHr2sa+B+kirtwu6cu7YmMxV4qLAYrSkC/TsxWqWk+yaUMobmPWeU3 dukFnzVc6JOvULX/XE03kh4kAK2nh00o9ONm02dlXLYvPobS4tsIXIyEKJS49gHsp9 gwGcRu6A6/TMwXGiQtmhoRm1SNdYJs/fOMOyTg6BnLP4ncxubcwvQBgO1bxoDlKNOy v0uv+IJvYmJgWExJxbxcFXtag1pVNY5oflq1ckPoJv10VA7HymvrE7T/8LwywcbVlc yzKGKRmmvOplGV/9crV6UXR+xuK5RIxinJPuQIejp0ZsWaSFbFuFto77QC7acQpDx0 sdPOxJ7M5YI1Q== Subject: Re: [PATCH v3 0/2] Provide UEFILib functions for protocol uninstallation. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jan 2019 14:02:01 -0000 X-List-Received-Date: Mon, 07 Jan 2019 14:02:01 -0000 X-List-Received-Date: Mon, 07 Jan 2019 14:02:01 -0000 X-List-Received-Date: Mon, 07 Jan 2019 14:02:01 -0000 X-List-Received-Date: Mon, 07 Jan 2019 14:02:01 -0000 X-List-Received-Date: Mon, 07 Jan 2019 14:02:01 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable + Maintainers -----Original Message----- From: Ashish Singhal =20 Sent: Sunday, January 6, 2019 9:38 PM To: edk2-devel@lists.01.org Cc: Ashish Singhal Subject: [PATCH v3 0/2] Provide UEFILib functions for protocol uninstalla= tion. An issue was seen in IScsiDxe in NetworkPkg where driver cleanup after in= itialization failure was not done right. Bug 1428 was filed in this regar= d. As per discussions with Mike, it was also discussed that having UEFILib p= rovide protocol uninstallation abstraction would help to avoid these issu= es in the future. Bug 1429 was found to track this. The first 2 patches t= ake care of this. Patch number 1 also simplifies the UEFILib protocol installation and unin= stallation abstraction by adding a helper function doing operations inste= ad of every public function. Ashish Singhal (2): =20 MdePkg/UefiLib: Abstract driver model protocol uninstallation =20 NetworkPkg/IScsiDxe: Use UEFILib APIs to uninstall protocols. =20MdePkg/Include/Library/UefiLib.h | 103 +++ =20MdePkg/Library/UefiLib/UefiDriverModel.c | 1186 ++++++++--------------= -------- =20NetworkPkg/IScsiDxe/IScsiDriver.c | 31 +- =203 files changed, 435 insertions(+), 885 deletions(-) -- 2.7.4 -------------------------------------------------------------------------= ---------- This email message is for the sole use of the intended recipient(s) and m= ay contain confidential information. Any unauthorized review, use, disclosure or di= stribution is prohibited. If you are not the intended recipient, please contact the= =20sender by reply email and destroy all copies of the original message. -------------------------------------------------------------------------= ----------